gerritbot added a comment.
Change 572664 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make sure WikibaseServices services
getters don't access the DB
https://gerrit.wikimedia.org/r/572664
TASK DETAIL
https://phabricator.wikimedia.org/T243729
EMAIL PREFERENCES
gerritbot added a comment.
Change 572664 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Make sure WikibaseServices services
getters don't access the DB
https://gerrit.wikimedia.org/r/572664
TASK DETAIL
hoo added a comment.
We now have fairly conclusive test coverage of this (covers all
from-global-state-factory methods I could find), so I think we can consider
this done.
TASK DETAIL
https://phabricator.wikimedia.org/T243729
EMAIL PREFERENCES
gerritbot added a comment.
Change 571474 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Test that factory methods don't access
the DB/ do http requests
https://gerrit.wikimedia.org/r/571474
TASK DETAIL
https://phabricator.wikimedia.org/T243729
EMAIL PREFERENCES
gerritbot added a comment.
Change 571474 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Test that factory methods don't access
the DB/ do http requests
https://gerrit.wikimedia.org/r/571474
TASK DETAIL
gerritbot added a comment.
Change 571318 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Assert service getters never access
the DB/ do http requests
https://gerrit.wikimedia.org/r/571318
TASK DETAIL
https://phabricator.wikimedia.org/T243729
EMAIL PREFERENCES
gerritbot added a comment.
Change 571318 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Assert service getters never access
the DB/ do http requests
https://gerrit.wikimedia.org/r/571318
TASK DETAIL
Addshore added a comment.
So this taks still needs to look for the same pattern of service construction
where one of the things injected into the service ends up doing dB calls or API
calls (what was happening with the language fallback chain issue).
Less of a profiling thing and more of a