gerritbot added a comment.
Change 569023 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms: tests for not deleting used
terms rows
https://gerrit.wikimedia.org/r/569023
TASK DETAIL
https://phabricator.wikimedia.org/T243944
EMAIL PREFERENCES
Addshore added a comment.
I manually went and poked the few items on test that needed poking, so no
need to rebuild everything there..
mysql:research@dbstore1004.eqiad.wmnet [testwikidatawiki]> SELECT
-> wbpt_property_id as id,
-> wby_name as type,
->
Ladsgroup added a comment.
Testing it in testwikidata says this is resolved,
https://test.wikidata.org/w/index.php?title=Q562=525377=525376 keeps
it for https://test.wikidata.org/wiki/Q1262?uselang=hu
TASK DETAIL
https://phabricator.wikimedia.org/T243944
EMAIL PREFERENCES
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2020-01-30T17:51:23Z]
Synchronized
php-1.35.0-wmf.16/extensions/Wikibase/lib/includes/Store/Sql/Terms/FingerprintableEntityTermStoreTrait.php:
wbterms: Fix incorrect deletion of rows in findActuallyUnusedTermIds (T243944
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2020-01-30T17:49:44Z]
Synchronized
php-1.35.0-wmf.16/extensions/Wikibase/repo/maintenance/rebuildItemTerms.php:
wbterms: Write only to the new term store in rebuildItemTerms (T243944
gerritbot added a comment.
Change 568976 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] wbterms: Write only to the
new term store in rebuildItemTerms
https://gerrit.wikimedia.org/r/568976
TASK DETAIL
https://phabricator.wikimedia.org/T243944
EMAIL
gerritbot added a comment.
Change 568975 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] wbterms: Fix incorrect
deletion of rows in findActuallyUnusedTermIds
https://gerrit.wikimedia.org/r/568975
TASK DETAIL
https://phabricator.wikimedia.org/T243944
gerritbot added a comment.
Change 569023 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] wbterms: tests for not deleting used
terms rows
https://gerrit.wikimedia.org/r/569023
TASK DETAIL
https://phabricator.wikimedia.org/T243944
gerritbot added a comment.
Change 568968 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms: Fix incorrect deletion of
rows in findActuallyUnusedTermIds
https://gerrit.wikimedia.org/r/568968
TASK DETAIL
https://phabricator.wikimedia.org/T243944
EMAIL
gerritbot added a comment.
Change 568955 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms: Write only to the new term
store in rebuildItemTerms
https://gerrit.wikimedia.org/r/568955
TASK DETAIL
https://phabricator.wikimedia.org/T243944
EMAIL PREFERENCES
gerritbot added a comment.
Change 568976 had a related patch set uploaded (by Ladsgroup; owner:
Ladsgroup):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] wbterms: Write only to the
new term store in rebuildItemTerms
https://gerrit.wikimedia.org/r/568976
TASK DETAIL
gerritbot added a comment.
Change 568975 had a related patch set uploaded (by Ladsgroup; owner:
Addshore):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] wbterms: Fix incorrect
deletion of rows in findActuallyUnusedTermIds
https://gerrit.wikimedia.org/r/568975
TASK DETAIL
gerritbot added a comment.
Change 568968 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Fix incorrect deletion of rows in
findActuallyUnusedTermIds
https://gerrit.wikimedia.org/r/568968
TASK DETAIL
Addshore added a comment.
Investigation lead to these tests and conclusions:
EVIL: Removing "English" en label as well as setting a new english en label
and removing other terms (de label, de description) (restores / undos)
https://test.wikidata.org/w/index.php?title=Q562=525291=525290
gerritbot added a comment.
Change 568955 had a related patch set uploaded (by Ladsgroup; owner:
Ladsgroup):
[mediawiki/extensions/Wikibase@master] wbterms: Write only to the new term
store in rebuildItemTerms
https://gerrit.wikimedia.org/r/568955
TASK DETAIL
15 matches
Mail list logo