[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

gerritbot added a comment. Change 571769 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove (Item|Property)TermStore::getTerms implementations https://gerrit.wikimedia.org/r/571769 TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

Addshore added a comment. > abandoning https://github.com/wmde/wikibase-term-store for good. Yes, lets get rid of this lib. In T244916#5877042 , @hoo wrote: > For creating the new narrow interfaces in WikibaseDataModelServices:

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

gerritbot added a comment. Change 572207 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Rename (Property|Item)TermStoreWriter to more specific name https://gerrit.wikimedia.org/r/572207 TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

gerritbot added a comment. Change 572207 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Rename (Property|Item)TermStoreWriter to more specific name https://gerrit.wikimedia.org/r/572207 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

hoo added a comment. PR for new datamodel services release (which will feature our new interfaces): https://github.com/wmde/WikibaseDataModelServices/pull/235 TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

gerritbot added a comment. Change 571769 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Remove ItemTermStore/PropertyTermStore::getTerms https://gerrit.wikimedia.org/r/571769 TASK DETAIL https://phabricator.wikimedia.org/T244916

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

hoo added a comment. In T244916#5876959 , @Tarrow wrote: > I'm also probably adding un thought through ideas to this but... > If TermStores can't read is having them in lib the right place? Wouldn't we be smarter to lock them up in

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

Tarrow added a comment. I'm also probably adding un thought through ideas to this but... If TermStores can't read is having them in lib the right place? Wouldn't we be smarter to lock them up in repo? TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

hoo added a comment. In T244916#5876096 , @Lucas_Werkmeister_WMDE wrote: > If this is done, I’d say the interface(s) should be renamed, because having a “store” that’s write-only and doesn’t support reads doesn’t make sense to me.

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

Lucas_Werkmeister_WMDE added a comment. If this is done, I’d say the interface(s) should be renamed, because having a “store” that’s write-only and doesn’t support reads doesn’t make sense to me. TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES