[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

gerritbot added a comment. Change 580155 abandoned by Ppchelko: Fix error: undefined constant Reason: I4f151f88ece56cf718749b9de11fc8e204ccf29d https://gerrit.wikimedia.org/r/580155 TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

gerritbot added a comment. Change 580076 **merged** by jenkins-bot: [mediawiki/core@master] ExtensionRegistry: Avoid losing 'defines' when loading lazy-loaded attributes https://gerrit.wikimedia.org/r/580076 TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Art-Baltai added a comment. Case with problem: TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Art-Baltai Cc: nnikkhoui, Peter.ovchyn, Umherirrender, thiemowmde, Jdforrester-WMF, Legoktm,

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

gerritbot added a comment. Change 580076 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui): [mediawiki/core@master] Fix for T245629 . https://gerrit.wikimedia.org/r/580076 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

gerritbot added a comment. Change 580155 had a related patch set uploaded (by Art-Baltai; owner: BAGArt): [mediawiki/core@master] Bug with CACHE: undefined constant https://gerrit.wikimedia.org/r/580155 TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

gerritbot added a comment. Change 580076 restored by Nikki Nikkhoui: Experimental fix for T245629 . Do not merge. https://gerrit.wikimedia.org/r/580076 TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

gerritbot added a comment. Change 580076 abandoned by Nikki Nikkhoui: Experimental fix for T245629 . Do not merge. https://gerrit.wikimedia.org/r/580076 TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

gerritbot added a comment. Change 580076 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui): [mediawiki/core@master] Experimental fix for T245629 . Do not merge. https://gerrit.wikimedia.org/r/580076 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

nnikkhoui added a comment. @Peter.ovchyn ok :) I spent half of yesterday trying to re-produce locally so i could test some fixes and was unable to, even on the correct branches everything was passing. The only thing I did notice was that was another extension is reporting the same error

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

thiemowmde added a comment. When someone is able and willing to identify the original issue, we can undo code changes that are not needed any more then. As long as this is not the case let us please, please unblock people from working on these codebases. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. Well, the point of this task, as far as I understand, is that such changes to extensions shouldn’t be necessary… TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

nnikkhoui added a comment. Nice, ok lets see re-check these tests once that gets a +2 ? TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: nnikkhoui Cc: Peter.ovchyn, Umherirrender, thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. Looks like it, yes. TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: nnikkhoui, Lucas_Werkmeister_WMDE Cc: Peter.ovchyn, Umherirrender, thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Peter.ovchyn added a comment. Isn't this the same issue as has been addressing here? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlogPage/+/578876 TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. For my part, I’m waiting for “someone from MediaWiki core” (Core Platform Team? not sure tbh) to clarify how the `constant` field of a namespace in `extension.json` is supposed to work, and whether this bug is due to EntitySchema having relied on

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Krinkle added a comment. There are no (obvious) team tags associated with this task. Who is waiting for what/whom? TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender,

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. (EntitySchema is also WMF-deployed.) TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Umherirrender, thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

thiemowmde added a comment. I dug into the code and indeed found the place that creates constants based on what's said in extension.json: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/registration/ExtensionRegistry.php$512. But this appears to be more like a

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. In T245629#5922514 , @thiemowmde wrote: > I would like to ask another question: How is it a good idea do define a **PHP** constant in a .json file? How is my IDE supposed to find it there? I

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

thiemowmde added a comment. I would like to ask another question: How is it a good idea do define a **PHP** constant in a .json file? How is my IDE supposed to find it there? In other words: As far as I'm concerned the duplication is a **must**. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. > Code should not assume that the "namespaces" section from extension.json was executed, and the PHP constants been made available. Then what is the point of that section anyways? What use is it if it defines constants, but only under some obscure

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

thiemowmde added a comment. Even if it's true that this started failing when a specific change in core was made. I still believe it is the extension that must be fixed. I might get this wrong, but my idea is: Code should not assume that the "namespaces" section from extension.json was

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. Is there some MediaWiki Core tag / project we can add to this task? Because I don’t think the bug is on our end, to me it looks like a bug in extension registration. TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. Strange, that constant is supposed to be defined by MediaWiki via `extension.json`. TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Daimona added a comment. That change is not responsible, but the extension is broken: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/47112/artifact/log/mw-error.log TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

Lucas_Werkmeister_WMDE added a comment. Doesn’t seem to affect other extensions – the other recent build failures in quibble-vendor-mysql-php72-docker look unrelated, and there are plenty of successful builds too. TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES