[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

daniel added a comment. > The original core test still throws errors that seem related to Wikibase You mean this one? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/475065 As I noted there: > The "dangerous" methods on DatabaseUpdater are no longer public, see

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

Michael added a comment. In T249598#6074491 , @daniel wrote: > So, can we close this? The original core test still throws errors that seem related to Wikibase, but, OTOH, it is currently 1555 commits behind master. Could you verify

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 507898 abandoned by Aaron Schulz: Register schema update callbacks rather than running them on DatabaseUpdater construction Reason: obsolete https://gerrit.wikimedia.org/r/507898 TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

daniel added a comment. In T249598#6073487 , @daniel wrote: > Oh wait, this patch also belongs here, right? > https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/507898 Actually, I think that patch is wrong. So,

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 507898 had a related patch set uploaded (by Daniel Kinzler; owner: Aaron Schulz): [mediawiki/extensions/Wikibase@master] Register schema update callbacks rather than running them on DatabaseUpdater construction https://gerrit.wikimedia.org/r/507898

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

daniel added a comment. Oh wait, this patch also belongs here, right? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/507898 TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

daniel added a comment. Looks like this is done, can the ticket be closed? TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Jdforrester-WMF, Aklapper, Krinkle, kchapman, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 587402 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove the last use of dropTable in schema updater https://gerrit.wikimedia.org/r/587402 TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 587402 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Remove the last big of dropTable in schema updater https://gerrit.wikimedia.org/r/587402 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 587248 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use dropExtensionTable instead of dropTable in the updater https://gerrit.wikimedia.org/r/587248 TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 587248 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Use dropExtensionTable instead of dropTable in the updater https://gerrit.wikimedia.org/r/587248 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 587223 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] DatabaseUpdater: don't call hook in constructor https://gerrit.wikimedia.org/r/587223 TASK DETAIL https://phabricator.wikimedia.org/T249598

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

daniel added a comment. No patch yet, one one above was tagged with this ticket erronously. TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Krinkle, kchapman, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

gerritbot added a comment. Change 587223 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] DatabaseUpdater: don't call hook in constructor https://gerrit.wikimedia.org/r/587223 TASK DETAIL https://phabricator.wikimedia.org/T249598