[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

gerritbot added a comment. Change 596522 abandoned by Jdlrobson: BaseTemplate: language_urls property should always reflect true emptiness Reason: Okay, I'm going to move this decision into the skins themselves. It seems like the path of least resistance right now.

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Jdforrester-WMF added a comment. In T252800#6175054 , @Huji wrote: > In T252800#6174656 , @Jdforrester-WMF wrote: > >> In T252800#6174604

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Huji added a comment. In T252800#6174656 , @Jdforrester-WMF wrote: > In T252800#6174604 , @Huji wrote: > >> And finally, if that is correct, would it be fair to say that the next

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Jdforrester-WMF added a comment. In T252800#6174604 , @Huji wrote: > @Jdforrester-WMF can I use this opportunity to learn the deployment process better? Of course. > Do I understand correctly that the patches associated with

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Jdforrester-WMF added a comment. Yes, this was broken by the wmf.32 release which reached Wikipedias a few hours ago (and all other wikis a week ago); the next release, wmf.34, is being branched now, and should fix that for all, but won't be on Wikipedias for another 50 hours. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

NickK added a comment. Looks like this is getting works. Multiple reports from users today on ukwiki who can no longer add articles, while it work for them as late as yesterday. TASK DETAIL https://phabricator.wikimedia.org/T252800 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

ovasileva added a comment. In T252800#6152293 , @hashar wrote: > ContentTranslation and UniversalLanguageSelector are affected as well. > > I am aiming at pushing 1.35.0-wmf.32 on the remaining wiki on Monday 25th during European

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

hashar added a comment. ContentTranslation and UniversalLanguageSelector are affected as well. I am aiming at pushing 1.35.0-wmf.32 on the remaining wiki on Monday 25th during European afternoon. We will thus have those features hidden/disabled until the next version reaches all wikis

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

ovasileva added a comment. Discussed with @Lydia_Pintscher @Pginer-WMF and we decided that, given the risks, it would be okay to wait until next week's train, so long as we don't see this affecting articles that already have language links. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Nikerabbit added a comment. It seems this affects: - No Wikidata link to add interlanguage links - No Content Translation grey links to start a translation - No UniversalLanguageSelector cog for easy access to language settings. TASK DETAIL https://phabricator.wikimedia.org/T252800

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Jdlrobson added a comment. I talked to @ovasileva earlier today and my understand is she felt it was not a train blocker per a conversation with @Pginer-WMF . She said she'd reach out to Lydia. The risk here from a development perspective is that such a fix will be bespoke for this

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Jdforrester-WMF added a comment. Isn't this still a train blocker, per Lydia? TASK DETAIL https://phabricator.wikimedia.org/T252800 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ovasileva, Jdforrester-WMF Cc: Jdforrester-WMF, polishdeveloper,

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Lydia_Pintscher added a comment. I can't judge the risk but I'd say from the product side it's pretty bad and I'd rather not leave it broken for another week. TASK DETAIL https://phabricator.wikimedia.org/T252800 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

hashar added a comment. What Lucas Said, the fix would only land next week May 27/28. So I guess we can backport the Vector patch and swat it for the wikis that are currently using 1.35.0-wmf.32 (group1 right now). And when the rest of wikis are promoted next Monday they will have the

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Lucas_Werkmeister_WMDE added a comment. Note that there’s no train this week (releng offsite, apparently), so this would remain unfixed until //next// Wednesday/Thursday. TASK DETAIL https://phabricator.wikimedia.org/T252800 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

Jdlrobson added a comment. I can but given it doesn't swat cleanly my preference would be to let this ride the train then to deploy an untested bespoke patch? The languages box does display - it just doesn't display on pages without any languages. I agree that's not ideal, but it can be

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

gerritbot added a comment. Change 596522 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/core@master] BaseTemplate: language_urls property should always reflect emptiness https://gerrit.wikimedia.org/r/596522 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

gerritbot added a comment. Change 596516 **merged** by jenkins-bot: [mediawiki/skins/Vector@master] Show empty language portal if HTML has been added after portal https://gerrit.wikimedia.org/r/596516 TASK DETAIL https://phabricator.wikimedia.org/T252800 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

gerritbot added a comment. Change 596516 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/skins/Vector@master] Show empty language portal if HTML has been added after portal https://gerrit.wikimedia.org/r/596516 TASK DETAIL