[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-19 Thread gerritbot
gerritbot added a comment. Change 247241 merged by jenkins-bot: Clean up statementview https://gerrit.wikimedia.org/r/247241 TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine, gerritbot

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-19 Thread gerritbot
gerritbot added a comment. Change 247241 had a related patch set uploaded (by Jonas Kress (WMDE)): Clean up statementview https://gerrit.wikimedia.org/r/247241 TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-15 Thread adrianheine
adrianheine added a comment. With https://gerrit.wikimedia.org/r/#/c/246769/, I consider this done. There are still more views that could be constructed in the view factory, but there are few if any options passed through these. TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PRE

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-08 Thread Jonas
Jonas added a comment. I also think that in most cases a separate ticket is the best, but didn't want you to force to do so. Feel free to create them if you like... TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/email

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-07 Thread adrianheine
adrianheine added a comment. I don't like these task lists in descriptions, but I added them anyway. I think creating subtasks would have been a better way, though. TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/email

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-07 Thread gerritbot
gerritbot added a comment. Change 243494 merged by jenkins-bot: Use ViewFactory for constructing statementlistviews in statementgroupview https://gerrit.wikimedia.org/r/243494 TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-07 Thread gerritbot
gerritbot added a comment. Change 243496 merged by jenkins-bot: Use ViewFactory for building statementviews in statementlistview https://gerrit.wikimedia.org/r/243496 TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/ema

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Story] Introduce factory for JS views

2015-10-07 Thread Jonas
Jonas added a subscriber: Jonas. Jonas added a comment. Could you please update the list of widgets in the description, so the focus of this story is clear. TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen