elukey added a comment.
I found another occurrence of timeouts in mcrouter with SETs for this key, it
might be due to TTL expiring or similar. Reducing the traffic volume to
memcached is surely a good thing.
TASK DETAIL
https://phabricator.wikimedia.org/T97368
EMAIL PREFERENCES
elukey added a comment.
Correction: the last bursts of mcrouter's timeouts seems to match a high set
rate for slab 140 on mc1022, that is exactly where the key is:
elukey added a comment.
Quick comment: I noticed while checking some memcached metrics that
`wikibase_shared/1_33_0-wmf_20-wikidatawiki-hhvm:CacheAwarePropertyInfoStore`
generates 30~60MB/s of GET traffic since the last deployment of mediawiki:
gerritbot added a comment.
Change 480731 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add docs/adr/0002-CacheAwarePropertyInfoStore-caching.md
https://gerrit.wikimedia.org/r/480731TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
gerritbot added a comment.
Change 480731 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Add docs/adr/0002-CacheAwarePropertyInfoStore-caching.md
https://gerrit.wikimedia.org/r/480731TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
Addshore added a comment.
Picked back up by the campsite to write an ADR for what was done and why & how we might need to change this in the future.TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc:
Lydia_Pintscher added a comment.
@Addshore can you close this?TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Lydia_PintscherCc: Lydia_Pintscher, Jonas, Stashbot, gerritbot, Jdforrester-WMF, Joe,
gerritbot added a comment.
Change 470567 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] CachingPropertyInfoLookup local server cache 10s -> 15s
https://gerrit.wikimedia.org/r/470567TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
gerritbot added a comment.
Change 470567 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] CachingPropertyInfoLookup local server cache 10s -> 15s
https://gerrit.wikimedia.org/r/470567TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
Addshore added a comment.
The 10 second on server cache of the data resulted in a pretty significant drop in traffic:
F26296567: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Jonas,
Addshore added a comment.
This patch should go live on wikidata.org with the train on Wednesday 3rd OctTASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Jonas, Stashbot, gerritbot, Jdforrester-WMF,
gerritbot added a comment.
Change 461371 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] SqlStore wrap PropertyInfo classes in an APC cache too
https://gerrit.wikimedia.org/r/461371TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
gerritbot added a comment.
Change 461371 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] SqlStore wrap PropertyInfo classes in an APC cache too
https://gerrit.wikimedia.org/r/461371TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
Addshore added a comment.
In T97368#4576510, @daniel wrote:
Another option would be to force this to go into APC instead of memcached.
Even with just a short life this would probably massively reduce the traffic hitting this one key.TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
daniel added a comment.
Another option would be to force this to go into APC instead of memcached.TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Stashbot, gerritbot, Jdforrester-WMF, Joe, mark,
Addshore added a comment.
So the logging I added only ran for 7 minutes, but already gives us some idea of the usage of this thing:
getPropertyInfoForDataType was not called at all. After a quick look through the code the only place this seems to be called is on
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-09-12T07:45:39Z] Synchronized php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Store/: REVERT: Debug logging for T97368 [[gerrit:459905]] (duration: 00m 51s)TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-09-12T07:38:06Z] Synchronized php-1.32.0-wmf.20/extensions/Wikibase/lib/includes/Store/: Debug logging for T97368 [[gerrit:459905]] (duration: 00m 53s)TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
gerritbot added a comment.
Change 459905 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.20] PropertyInfoStore cache usage debug logging for wmf.20
https://gerrit.wikimedia.org/r/459905TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
gerritbot added a comment.
Change 459906 abandoned by Addshore:
Debug logging for T97368
Reason:
using AdHocDebug instead
https://gerrit.wikimedia.org/r/459906TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 459906 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Debug logging for T97368
https://gerrit.wikimedia.org/r/459906TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL
gerritbot added a comment.
Change 459905 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@wmf/1.32.0-wmf.20] PropertyInfoStore cache usage debug logging for wmf.20
https://gerrit.wikimedia.org/r/459905TASK
Addshore added a comment.
In T97368#1241094, @daniel wrote:
One thin we can do is to split the cache by "type" of info, i.e. have the data types cached separate from the cache fore base URIs, etc. We can further shard the cache, so base URIs would be cached in one of n random shards. This should
23 matches
Mail list logo
