[Wikidata-bugs] [Maniphest] [Commented On] T97706: Remove EntityDeserializer

2015-05-01 Thread JeroenDeDauw
JeroenDeDauw added a comment. You are correct - since we have DispatchableSerializer, we do not need to have an EntityDeserializer class to be able to have an "entity deserializer". TASK DETAIL https://phabricator.wikimedia.org/T97706 REPLY HANDLER ACTIONS Reply to comment or attach files,

[Wikidata-bugs] [Maniphest] [Commented On] T97706: Remove EntityDeserializer

2015-05-01 Thread Bene
Bene added a comment. We already have the `DispatchableDeserializer` and `DispatchableSerializer` which do exactly that: You can pass an Entity object and it detects the requried Serializers/Deserializers for that type. We can thus just drop the `EntityDeserializer` imo completely as it isn't e

[Wikidata-bugs] [Maniphest] [Commented On] T97706: Remove EntityDeserializer

2015-05-01 Thread JeroenDeDauw
JeroenDeDauw added a subscriber: JeroenDeDauw. JeroenDeDauw added a comment. You are right about there being OCP violations that need fixing. Currently there is this EntityDeserializer, with ItemDeserializer and PropertyDeserializer derivatives. That is very similar to what we had in DataModel