[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

gerritbot added a comment. Change 500838 abandoned by Jdlrobson: Revert "Fix to be present even if title is "0"" Reason: This doesn't seem to be wanted. https://gerrit.wikimedia.org/r/500838 TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Krinkle added a comment. I think it would be best suited as a skinStyle that WikidataPageBanner adds for specific skins it knows how to handle. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Krinkle added a comment. In T97891#5083116 , @Jdlrobson wrote: > > t's been visible on Minerva/MobileFrontend for years without issue, > > @krinkle that's not true. Your patch

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Jdlrobson added a comment. > t's been visible on Minerva/MobileFrontend for years without issue, @krinkle that's not true. Your patch https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/500814/1/includes/skins/SkinMinerva.php is why the h1 is present on Minerva. TASK

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Krinkle added a comment. In T97891#5082509 , @Jdlrobson wrote: > It's still on Russian Wikivoyage https://ru.wikivoyage.org/wiki/%D0%A3%D0%BF%D0%BF%D1%81%D0%B0%D0%BB%D0%B0 I was still going through them :) Found floating

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Jdlrobson added a comment. In T97891#5082445 , @Krinkle wrote: > In T97891#5082437 , @Jdlrobson wrote: > > > > OK. Looks like it's still Varnish cached for most pages. But I see when

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Johan added a comment. OK, thanks, I've rewritten it to something //very// generic (so editors who've seen it knows it has been fixed) and linked to this discussion for those who want the details. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Jdlrobson added a comment. > OK. Looks like it's still Varnish cached for most pages. But I see when logged-in now. I've hot-fixed for now by hiding it with CSS. What about all the other Wikivoyage projects? Are we confident this is not having a negative impact on SEO for Wikivoyage?

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Krinkle added a comment. OK. Looks like it's still Varnish cached for most pages. But I see when logged-in now. I've hot-fixed for now by hiding it with CSS . It's been visible on Minerva/MobileFrontend for years without issue, but

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Jdlrobson added a comment. This has been flagged on the travellers pub now - https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Something_I've_never_seen_before - the problem is there are now 2 h1s on every page on Vector, the first one is empty. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Krinkle added a comment. In T97891#5080051 , @Jdlrobson wrote: > @krinkle I think the broken "0" page is much less of a concern than the current situation we find ourselves in. What exactly is the problem at

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Johan added a comment. Yes, I'd say it is. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Johan Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, adrianheine, thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Jdlrobson added a comment. @Johan not 100% sure whether this is user notice worthy, but I consider this a big UI regression for the wikivoyage community that is likely to be flagged on the Wikivoyage pubs (village pumps). The user notice would be, that we are aware of this problem and

[Wikidata-bugs] [Maniphest] [Commented On] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

Johan added a comment. @Jdlrobson: Is the #user-notice tag mainly because of the production issues on Wiktionary? If so, is this a "there was a problem but it was [hopefully] fixed" when this goes out on Monday? Or will it, five days from