[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages

2018-02-13 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [`ViolationMessageRenderer` improvements](https://gerrit.wikimedia.org/r/408544) Left to do: - {T185999} - //after that//, use `ViolationMessage` in `ConstraintParameterException`. Requires s11n

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 6)

2018-02-13 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] `ViolationMessageRenderer` refactorings [1](https://gerrit.wikimedia.org/r/407654), [2](https://gerrit.wikimedia.org/r/407655) - [ - [x] [multilingual text arguments](https://gerrit.wikimedia.org

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-07 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [ ] [messages with such arguments](https://gerrit.wikimedia.org/r/407657) - [ - [x] [constraint scope arguments](https://gerrit.wikimedia.org/r/407708) - [ - [x] prior [refactoring](https://gerri

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [language arguments](https://gerrit.wikimedia.org/r/407710) - to be continued…- [ ] [`ViolationMessageRenderer` improvements](https://gerrit.wikimedia.org/r/408544) Left to do:...TASK DETAILhttp

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [extra test](https://gerrit.wikimedia.org/r/407044) - [ - [x] [inline code arguments](https://gerrit.wikimedia.org/r/407653) - [ - [x] `ViolationMessageRenderer` refactorings [1](https://gerrit.w

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- to be continued… Left to do:[ ] [constraint scope arguments](https://gerrit.wikimedia.org/r/407708) - [ ] prior [refactoring](https://gerrit.wikimedia.org/r/407707) - [ ] [constraint scope list ar

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- add argument type “constraint scope” (incl. list) - add argument type “language”, probably (corresponds to one param for autonym and one param for language code)...TASK DETAILhttps://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- remove most of `ConstraintParameterRenderer` - remove injected `ConstraintParameterRenderer` from checkers and helpers (at this point, it might be interesting to check the `git diff --stat 407387c sr

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- to be continued… Left to do: - add argument type “constraint scope” - add argument type “language”, probably (corresponds to one param for autonym and one param for language code) - {T185999} - //af

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [extra test](https://gerrit.wikimedia.org/r/407044) - [ ] [inline code arguments](https://gerrit.wikimedia.org/r/407653) - [ ] `ViolationMessageRenderer` refactorings [1](https://gerrit.wikimedia

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [x] [messages with such arguments](https://gerrit.wikimedia.org/r/407009) - [ - [x] [data value type arguments](https://gerrit.wikimedia.org/r/407012)...TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [ - [x] [messages with such arguments](https://gerrit.wikimedia.org/r/407013) - [ - [x] me being stupid: [1](https://gerrit.wikimedia.org/r/407033), [2](https://gerrit.wikimedia.org/r/407037) - [ -

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [ ] [messages with such arguments](https://gerrit.wikimedia.org/r/407036) - [ ] [extra test](https://gerrit.wikimedia.org/r/407044) - to be continued…TASK DETAILhttps://phabricator.wikimedia.org/T1

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [x] [messages with such arguments](https://gerrit.wikimedia.org/r/407000) - [ - [x] [minor: remove unused parameters](https://gerrit.wikimedia.org/r/407001) - [ - [x] [`ItemIdSnakValue` list argume

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [ ] [messages with such arguments](https://gerrit.wikimedia.org/r/407009) - [ ] [data value type arguments](https://gerrit.wikimedia.org/r/407012) - [ ] [messages with such arguments](https://ger

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] minor test changes [1](https://gerrit.wikimedia.org/r/406991), [2](https://gerrit.wikimedia.org/r/406992), [3](https://gerrit.wikimedia.org/r/406993) - [ - [x] [`ItemIdSnakValue` arguments](https

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [minor: remove unused parameters](https://gerrit.wikimedia.org/r/407001) - [ ] [`ItemIdSnakValue` list arguments](https://gerrit.wikimedia.org/r/407008) - [ ] prior [refactoring](https://gerrit

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [x] [messages with such arguments](https://gerrit.wikimedia.org/r/406835) - [ - [x] minor test changes [1](https://gerrit.wikimedia.org/r/406991), [2](https://gerrit.wikimedia.org/r/406992), [3](ht

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [`ItemIdSnakValue` arguments](https://gerrit.wikimedia.org/r/406994) - [ ] [messages with such arguments](https://gerrit.wikimedia.org/r/407000) - [ ] [minor: remove unused parameters](https://

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [x] [messages with such arguments](https://gerrit.wikimedia.org/r/406835) - [ ] minor test changes [1](https://gerrit.wikimedia.org/r/406991), [2](https://gerrit.wikimedia.org/r/406992), [3](https:

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [messages without arguments](https://gerrit.wikimedia.org/r/406298) - [ - [x] [entity ID arguments](https://gerrit.wikimedia.org/r/406568) - [ - [x] [messages with such arguments](https://gerri

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [`ViolationMessage`x] [`ViolationMessage`](https://gerrit.wikimedia.org/r/406294) - [x] [`ViolationMessageRenderer`](https://gerrit.wikimedia.org/r/406295) - [x] [`ViolationMessage` in `CheckResu

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages

2018-01-26 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...This also means one less object to inject into all checkers: the checkers will instantiate such a message, which is a pure value object, and the task of rendering it is then delayed until the `CheckCon