| Lucas_Werkmeister_WMDE renamed this task from "(De)serialize CheckResults in CachingResultsBuilder" to "Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults". Lucas_Werkmeister_WMDE updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
~~We don’t need any hybrid phase for {T185709}, so we can probably just exchange the `CachingResultsBuilder` implementation for one that reads and writes `CheckResult` serializations instead (with a separate cache key format… `v2.2` I guess).~~
The transition is complicated enough that it’s split up across several patches. Essentially, were replacing `ResultsBuilder` with `ResultsSource` plus `CheckResultsRenderer`.
#patch-for-review:
- [add `CachedCheckResults`](https://gerrit.wikimedia.org/r/420706) (simple wrapper object)
- [`ResultsSource`, `CheckingResultsSource`](https://gerrit.wikimedia.org/r/420707) (half of `CheckingResultsBuilder`)
- [`CheckResultsRenderer`](https://gerrit.wikimedia.org/r/420708) (other half of `CheckingResultsBuilder`)
- make the `"v2.1"` part of the cache key in `ResultsCache` configurable – we need `"v2.1"` for `CachingResultsBuilder` but `"v2.2"` for `CachingResultsSource`
- `CachingResultsSource`
- change `CheckConstraints` API to use `ResultsSource`+`CheckResultsRenderer` instead of `ResultsBuilder`
- remove `ResultsBuilder` and implementations
The transition is complicated enough that it’s split up across several patches. Essentially, were replacing `ResultsBuilder` with `ResultsSource` plus `CheckResultsRenderer`.
#patch-for-review:
- [add `CachedCheckResults`](https://gerrit.wikimedia.org/r/420706) (simple wrapper object)
- [`ResultsSource`, `CheckingResultsSource`](https://gerrit.wikimedia.org/r/420707) (half of `CheckingResultsBuilder`)
- [`CheckResultsRenderer`](https://gerrit.wikimedia.org/r/420708) (other half of `CheckingResultsBuilder`)
- make the `"v2.1"` part of the cache key in `ResultsCache` configurable – we need `"v2.1"` for `CachingResultsBuilder` but `"v2.2"` for `CachingResultsSource`
- `CachingResultsSource`
- change `CheckConstraints` API to use `ResultsSource`+`CheckResultsRenderer` instead of `ResultsBuilder`
- remove `ResultsBuilder` and implementations
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
Cc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Tamgue, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
