[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-02-08 Thread daniel
daniel added a comment. @aude: if we check the changeop against the latest revision for validation, there should be no need to validate the result of the merge. Because of the way ChangeOps (the plural version) does validation, we then already do validate against what we would get after

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-02-08 Thread daniel
daniel added a comment. Suspicion (2) seems to be the problem, especially since our own UI //always// hits this edge case when editing the label and description for a given language at the same time: - User 1 is viewing revision B of Q5 in their browser - User 1 enters a German label and

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-02-01 Thread Tobi_WMDE_SW
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-02-02. TASK DETAIL https://phabricator.wikimedia.org/T121395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: thiemowmde, gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-01-18 Thread Tobi_WMDE_SW
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-01-19. TASK DETAIL https://phabricator.wikimedia.org/T121395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, Jonas,

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2015-12-22 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T121395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, Jonas, StudiesWorld,

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2015-12-18 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. A related issue seems to be going on in https://phabricator.wikimedia.org/T121851. TASK DETAIL https://phabricator.wikimedia.org/T121395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Bene,

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2015-12-14 Thread daniel
daniel added a comment. *sigh* not, again... I strongly recommend we implement T74430: Re-implement uniqueness constraint in a consistent and efficient way instead of trying to fix this based on the terms table. TASK DETAIL