[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-06-19 Thread Aklapper
Aklapper removed a project: Security. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, AklapperCc: Aklapper, Lydia_Pintscher, Bawolff, greg, Ladsgroup, jcrespo, Marostegui, TerraCodes,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-03-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Ministry-Of-Magic-Kanban-Board. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Bawolff, greg, Ladsgroup, jcrespo,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Okay… is there anything I can do to help move that task forward? The reason I want to get caching into place soon is that we’ll roll out constraint checks to more users in the next weeks (starting on March 1st to all usernames beginning with “Z”, see

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-28 Thread jcrespo
jcrespo added a comment. Can you wait on T188505 ? I don't think there is a reason why we should rush a deployment after it failed without a proper investigation. CC @gregTASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-27 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint-2018-02-28. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, WMDE-leszekCc: Bawolff, greg, Ladsgroup, jcrespo, Marostegui, TerraCodes,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-26 Thread Ladsgroup
Ladsgroup removed a project: Security.Ladsgroup changed the visibility from "Custom Policy" to "Public (No Login Required)".Herald added a project: Security. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-26 Thread jcrespo
jcrespo removed a project: Security.jcrespo added a comment. ok, sorry, for a second I thought you were executing that- on that code is guaranteed to be sanitized.TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-26 Thread jcrespo
jcrespo added a project: Security.jcrespo added a comment. SELECT $startOpts $vars $from $useIndex $ignoreIndex " . "WHERE $conds $preLimitTail"; That looks like a recipe for an sql injection, how did this pass security review?TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-26 Thread greg
greg added a project: Wikimedia-Incident. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gregCc: greg, Ladsgroup, jcrespo, Marostegui, TerraCodes, Stashbot, Liuxinyu970226, Jonas,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I think we can proceed with this – all the blockers should be addressed, though sometimes temporarily: T185688: Constraint check results are cached independent of language is fixed for now by T185689: Add language to cache key for check results, even

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-23 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Liuxinyu970226, Jonas, Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-02-13 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint-2018-02-14. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Liuxinyu970226, Jonas, Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-01-30 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint-2018-01-31. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Jonas, Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-01-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subtask: T185688: Constraint check results are cached independent of language. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-01-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-17. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

2018-01-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subtask: T183927: Add parameter to only get violations from wbcheckconstraints. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Jonas, Aklapper,