[Wikidata-bugs] [Maniphest] [Updated] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-05-02 Thread Jdlrobson
Jdlrobson removed a project: Patch-For-Review. Jdlrobson added a comment. So do we want WikidataPageBanner to apply the CSS rule to hide this additional heading or would it be better to add to Vector/Minerva? h1:empty { display: none; } TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector

2019-04-03 Thread Krinkle
Krinkle added a comment. In T97891#5082437 , @Jdlrobson wrote: > > OK. Looks like it's still Varnish cached for most pages. But I see when logged-in now. I've hot-fixed for now by hiding it with CSS. > > What about all the other

[Wikidata-bugs] [Maniphest] [Updated] T97891: setPageTitle to empty string or false should prevent rendering of H1 on page

2019-04-02 Thread matmarex
matmarex added a comment. This has been effectively reverted in Vector in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/500805 as a result of T219864 . TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES