Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.
I can find no trace of this deadlock in Logstash nor
`mwlog1002:/srv/mw-log/archive/rdbms.log-2023*`, so let’s close this. (For the
deadlock in
Lucas_Werkmeister_WMDE added a comment.
Actually, it looks like this deadlock is no longer happening at all:
lucaswerkmeister-wmde@mwlog1002:~$ zgrep -c 'Deadlock.*SiteLinkTable'
/srv/mw-log/archive/DBQuery.log-2021*
/srv/mw-log/archive/DBQuery.log-20210622.gz:0
Lucas_Werkmeister_WMDE added a comment.
(Or we could just speculate that `deleteLinksOfItem()` deletes in index
order, and if we sort the other two queries by site ID then it works out on its
own?)
TASK DETAIL
https://phabricator.wikimedia.org/T147981
EMAIL PREFERENCES
Lucas_Werkmeister_WMDE added a comment.
It might help if we make sure to insert and delete rows in a consistent order
(ordered by site ID)… should be easy enough for `insertLinks()` and
`deleteLinks()`, but `deleteLinksOfItem()` is going to be slightly trickier.
name=SiteLinkTable.php
Addshore added a project: wdwb-tech.
TASK DETAIL
https://phabricator.wikimedia.org/T147981
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: aude, daniel, hoo, Aklapper, Matanya, Base, Invadibot, maantietaja,
Akuckartz, darthmon_wmde,
