[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 511309 **abandoned** by Addshore: [wikidata/query/gui@master] Rename separate grunt task from 'browser_test' to 'test_all' Reason: Task is now resolved https://gerrit.wikimedia.org/r/511309 TASK DETAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 665124 **abandoned** by Addshore: [wikidata/query/gui@master] WIP: Run wdio without selenium-standalone Reason: Task is now resolved https://gerrit.wikimedia.org/r/665124 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Addshore closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Tonina_Zhelyazkova_WMDE, Lucas_Werkmeister_WMDE, Addshore, awight, Smalyshev, hashar,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 666368 **merged** by jenkins-bot: [wikidata/query/gui@master] Run browser tests in npm test, but don't run webdriver https://gerrit.wikimedia.org/r/666368 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Addshore claimed this task. Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Addshore added a comment. Restricted Application added a project: User-Addshore. https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/666368 is the

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 666368 had a related patch set uploaded (by Addshore; owner: Awight): [wikidata/query/gui@master] [WIP] experiment with browser testing https://gerrit.wikimedia.org/r/666368 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 667623 **merged** by jenkins-bot: [integration/config@master] Use {name}-node10-browser-webdriver-docker for wikidata/query/gui https://gerrit.wikimedia.org/r/667623 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 668040 **merged** by jenkins-bot: [integration/config@master] Add {name}-node10-browser-webdriver-docker https://gerrit.wikimedia.org/r/668040 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 668040 had a related patch set uploaded (by Addshore; owner: Addshore): [integration/config@master] Add {name}-node10-browser-webdriver-docker https://gerrit.wikimedia.org/r/668040 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 511308 **abandoned** by Addshore: [integration/config@master] Change Dockerfile and wikidata.yml to support running browser tests for the query service gui Reason: https://gerrit.wikimedia.org/r/511308 TASK DETAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 667623 had a related patch set uploaded (by Addshore; owner: Addshore): [integration/config@master] Add {name}-node10-browser-webdriver-docker https://gerrit.wikimedia.org/r/667623 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 666138 **abandoned** by Tonina Zhelyazkova: [wikidata/query/gui@master] Make browser tests run in CI Reason: https://gerrit.wikimedia.org/r/666138 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

awight added a comment. The latest patchset drops selenium-standalone. TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: awight Cc: Tonina_Zhelyazkova_WMDE, Lucas_Werkmeister_WMDE, Addshore,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

awight added a comment. In T00#6853286 , @zeljkofilipin wrote: > - Is there a reason this repository uses `selenium-standalone` instead of `chromedriver`? I think we can remove that dependency if we merge my patch using

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

zeljkofilipin added a comment. Looks like @awight's latest patch makes the wdio tests run in CI. I find some of my comments from 2019 still stand (T00#5172117 ). I'll quote relevant parts: In T00#5172117

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

awight added a comment. Notes: - The `wdio-chromedriver-service` seems better from a distance, but the antagonist seems to be in the details. See this commit for some notes about why the approach was abandoned in mw-core. -

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Tonina_Zhelyazkova_WMDE removed Tonina_Zhelyazkova_WMDE as the assignee of this task. Tonina_Zhelyazkova_WMDE added a comment. Moving to Review, so people can take a look at Adam W's patch. Thanks @awight TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

awight added a comment. I mashed together some bits laying around and got the above patch to pass. The only big issue is the grunt-merge-i18n package coming from github, which breaks due to missing `ssh`. Otherwise, I think this is usable. TASK DETAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 666368 had a related patch set uploaded (by Awight; owner: Awight): [wikidata/query/gui@master] [WIP] experiment with browser testing https://gerrit.wikimedia.org/r/666368 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Addshore added a comment. We could also look at just running chromedriver in a docker container as part of the CI job that is defined for query-gui. So the job would be 1) run chromedrive 2) run tests 3) stop chromedriver? Would need to see how possible @hashar thinks this would be but I

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 666138 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova): [wikidata/query/gui@master] Make browser tests run in CI https://gerrit.wikimedia.org/r/666138 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

awight added a comment. Quibble runs some services in the background, which you would also need in order to run browser tests. Specifically I think you're missing: - xvfb in order to run headless, like `xvfb :94 -screen 0 1280x1024x24 -nolisten tcp -nolisten unix` - chromedriver,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 666094 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova): [wikidata/query/gui@master] Make browser tests run in CI https://gerrit.wikimedia.org/r/666094 TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Tonina_Zhelyazkova_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Lucas_Werkmeister_WMDE, Addshore, awight, Smalyshev, hashar, zeljkofilipin,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. Lucas_Werkmeister_WMDE moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. I’m at a

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Lucas_Werkmeister_WMDE added a comment. Wait, nevermind, the job already runs on `node10-test-browser`. Not sure why wdio fails with an ECONNREFUSED error against a random port, then… TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Lucas_Werkmeister_WMDE added a comment. In T00#6818652 , @noarave wrote: > Task inspection note: we probably want to start with adding the browser_test to the `test` script in `package.json`and see what happens Tried it,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

gerritbot added a comment. Change 665124 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [wikidata/query/gui@master] Add wdio to grunt test task https://gerrit.wikimedia.org/r/665124 TASK DETAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T00 WORKBOARD

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

noarave added a comment. Task inspection note: we probably want to start with adding the browser_test to the `test` script in `package.json`and see what happens TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

darthmon_wmde moved this task from Prioritized Tech (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

darthmon_wmde updated the task description. darthmon_wmde set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthmon_wmde Cc: Addshore, awight, Smalyshev,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, awight, Smalyshev, hashar, zeljkofilipin, noarave, WMDE-leszek, Aklapper,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, awight, Smalyshev, hashar, zeljkofilipin, noarave, WMDE-leszek, Aklapper,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, awight, Smalyshev, hashar, zeljkofilipin, noarave, WMDE-leszek, Aklapper,

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI

Addshore renamed this task from "Run browser tests as part of "npm test" of wikidata/query/gui in CI" to "Run browser tests as part of "npm test" for wikidata/query/gui in CI". Addshore removed a subscriber: alaa_wmde. Addshore updated the task description. TASK DETAIL

[Wikidata-bugs] [Maniphest] T222200: Run browser tests as part of "npm test" of wikidata/query/gui in CI

Addshore renamed this task from "Run browser tests as part of "npm test" of wikidata/query/gui" to "Run browser tests as part of "npm test" of wikidata/query/gui in CI". TASK DETAIL https://phabricator.wikimedia.org/T00 EMAIL PREFERENCES