Addshore closed this task as "Resolved".
Addshore added a comment.
{
"error": {
"code": "wikibase-api-invalid-entity-id",
"info": "Invalid entity ID.",
"*": "See https://www.wikidata.org/w/api.php for API usage. Subscribe to
the mediawiki-api-announce mailing list at
toan added a comment.
I think this is all done now.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, toan
Cc: toan, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper,
Maintenance_bot removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper,
gerritbot added a comment.
Change 703746 **merged** by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Use Status for error handling
https://gerrit.wikimedia.org/r/703746
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Ladsgroup,
gerritbot added a comment.
Change 703745 **merged** by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Declare `continue` as integer
parameter
https://gerrit.wikimedia.org/r/703745
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
gerritbot added a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot,
gerritbot added a comment.
Change 703746 had a related patch set uploaded (by Lucas Werkmeister (WMDE);
author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/PropertySuggester@master] Use Status for error handling
https://gerrit.wikimedia.org/r/703746
TASK DETAIL
gerritbot added a comment.
Change 703745 had a related patch set uploaded (by Lucas Werkmeister (WMDE);
author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/PropertySuggester@master] Declare `continue` as integer
parameter
https://gerrit.wikimedia.org/r/703745
TASK DETAIL
Ladsgroup added a comment.
Using `Status` seems most sensible thing here IMHO. It decouples the
SuggesterParamsParser and the API module and gives them a shared language to
speak.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
Lucas_Werkmeister_WMDE added a comment.
So we somehow have to pass the error “properly” into the API module, because
throwing an arbitrary exception and then using `dieWithException` produces
these ugly internal errors. (Even if we throw a `LocalizedException`, the error
`"code"` still
Lucas_Werkmeister_WMDE added a comment.
Hm, apparently it’s not exactly an uncaught error:
name=GetSuggestions::execute()
try {
$params = $this->paramsParser->parseAndValidate(
$extracted );
} catch ( InvalidArgumentException $ex )
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to
bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
WORKBOARD
Addshore moved this task from Prioritized Tech (prioritised from top to bottom)
to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAIL
Addshore updated the task description.
Addshore set the point value for this task to "5".
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot,
Lucas_Werkmeister_WMDE added a comment.
Also https://www.wikidata.org/w/api.php?action=wbsgetsuggestions=a
(invalid properties instead of entity)
{
"error": {
"code": "internal_api_error_InvalidArgumentException",
"info":
Addshore triaged this task as "Medium" priority.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz,
Nandana, Lahi,
Addshore updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz,
Nandana, Lahi, Gq86,
Addshore updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz,
Nandana, Lahi, Gq86,
Addshore edited projects, added Wikidata-Campsite; removed Wikidata-Campsite
(Wikidata-Campsite-Iteration-∞).
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Lucas_Werkmeister_WMDE,
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja,
Addshore added a project: wdwb-tech.
TASK DETAIL
https://phabricator.wikimedia.org/T229319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz,
Nandana, Lahi, Gq86,
Lucas_Werkmeister_WMDE added a comment.
This also happens if you simply omit the `entity` parameter entirely.
> https://www.wikidata.org/w/api.php?action=wbsgetsuggestions
{
"error": {
"code": "internal_api_error_InvalidArgumentException",
23 matches
Mail list logo
