[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Addshore closed subtask T251286: Investigate restricting the ability to create sql queries with bad patterns in mediawiki as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup,

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Ladsgroup added a comment. I know it's not 100% related but I think Wikibase\Repo\Store\Sql\Terms\DatabaseTermsCollisionDetector::findEntityIdsWithTermInLang has done a similar thing. This is failing in Postgres: `SELECT wbpt_property_id FROM ("wbt_property_terms" "term" JOIN

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. The query looks like this in Tendril now: SELECT /*

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Lucas_Werkmeister_WMDE closed subtask T258693: Discourage “traditional” / ANSI-89 JOINs (in WHERE instead of JOIN) in IDatabase documentation as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Ladsgroup added a comment. For now, you can check tendril.wikimedia.org where it has list of slow queries: https://tendril.wikimedia.org/report/slow_queries?host=%5Edb=wikiuser=wikidatawiki=eq==1 It doesn't have all queries but it has enough to see if the change is applied or not.

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

jcrespo added a comment. There is this procedure: https://wikitech.wikimedia.org/wiki/MariaDB/query_performance which could be done for Wikidata by people with root database privileges, however it is quite involved. I will ask if maybe Manuel wants to perform soon such a thing for other

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Michael added a comment. I'm looking at this ticket in order to verify that it is done. Is there a way to see the actual queries run against the database? Or maybe dump an hour or a day's worth of Wikibase's SQL queries into a file so that it can be searched with regexes to find joins that

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, Marostegui,

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28). TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE, Addshore,

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

gerritbot added a comment. Change 615588 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Rework query format of DatabaseTermInLangIdsResolver::selectTermsViaJoin https://gerrit.wikimedia.org/r/615588 TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Lucas_Werkmeister_WMDE added a comment. Alright, I created T258693: Discourage “traditional” / ANSI-89 JOINs (in WHERE instead of JOIN) in IDatabase documentation and uploaded a patch for it. TASK DETAIL https://phabricator.wikimedia.org/T246232

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

jcrespo added a comment. > based on that sentence, I would even today vote against the change Amir just uploaded if it wasn’t for this ticket, because it seems to fly directly in the face of this documentation: why use $join_conds if the documentation says it’s unnecessary except for a LEFT

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Lucas_Werkmeister_WMDE added a comment. > - This issue would have been caught immediately by DBAs or other developers on review and asked to be changed immediately. This leads to the more important issue that **review process may be broken** because not even the most obvious formatting

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, Aklapper, Marostegui, Ladsgroup,

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Ladsgroup moved this task from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. With this change the query changes to something like this: SELECT wbtl_id,wbtl_type_id,wbxl_language,wbx_text,wbpt_property_id FROM

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

gerritbot added a comment. Change 615588 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Rework query format of DatabaseTermInLangIdsResolver::selectTermsViaJoin https://gerrit.wikimedia.org/r/615588 TASK DETAIL

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Addshore, Aklapper, Marostegui, Ladsgroup, jcrespo, Alter-paule, Beast1978, Un1tY,

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Addshore, Aklapper, Marostegui, Ladsgroup, jcrespo, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde,

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T246232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Aklapper, Marostegui, Ladsgroup, jcrespo, Akuckartz, Iflorez, darthmon_wmde,

[Wikidata-bugs] [Maniphest] T246232: Bad Wikidata query format in DatabaseTermInLangIdsResolver::selectTermsViaJoin

darthmon_wmde moved this task from Prioritized Tech to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T246232