[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Addshore closed this task as "Resolved". Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Addshore claimed this task. Restricted Application added a project: User-Addshore. TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

nnikkhoui added a comment. Apologies everyone for being the one to merge that in and block CI. It was a big miss on my end. I had needed the fake timestamp (still should definitely not have been in the data provider to begin with). But around the same time another patch was merged that

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618742 **abandoned** by Tobias Andersson: [mediawiki/core@master] Clean up test static fake time to fix Wikibase tests Reason: Solution was to just remove the faketime. already solved. https://gerrit.wikimedia.org/r/618742 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618774 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Reenable ArticleRevisionVisibilitySetHookHandlerTest https://gerrit.wikimedia.org/r/618774 TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618949 **merged** by jenkins-bot: [mediawiki/core@master] Remove stray fake time side effect in data provider https://gerrit.wikimedia.org/r/618949 TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618925 **abandoned** by Pablo Grass (WMDE): [mediawiki/core@master] UserDefTest: prevent (time) sideeffect from dataProvider Reason: I0df26d6af56ed18eac836929fd469b4a637d4902 was merged instead, which goes one step further.

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618949 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/core@master] Remove stray fake time side effect in data provider https://gerrit.wikimedia.org/r/618949 TASK DETAIL https://phabricator.wikimedia.org/T259785

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Pablo-WMDE added a subscriber: nnikkhoui. Pablo-WMDE added a comment. There are two competing patches to be able to re-enable our test, https://gerrit.wikimedia.org/r/618925 & https://gerrit.wikimedia.org/r/618949 - the original author, @nnikkhoui, is pinged on the patches to kindly advise.

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618925 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/core@master] UserDefTest: prevent (time) sideeffect from dataProvider https://gerrit.wikimedia.org/r/618925 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618740 **abandoned** by Tobias Andersson: [mediawiki/extensions/Wikibase@master] Test if this fixes CI Reason: Work happening in https://gerrit.wikimedia.org/r/c/618774 https://gerrit.wikimedia.org/r/618740 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618785 **abandoned** by Michael Große: [mediawiki/core@master] Clean up test fake time singleton to fix Wikibase tests Reason: I5430f4dee02216b5d5f48c3b2810f111362f3c4e is the original patch and the one that should be merged.

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618742 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/core@master] Clean up test static fake time to fix Wikibase tests https://gerrit.wikimedia.org/r/618742 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11). TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE, Tarrow, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Pablo-WMDE added a comment. >> Error: Call to undefined method Wikibase\Lib\Changes\ItemChange::setMetadataFromRC() > > Tracked as T259814 . Thank you! TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Lucas_Werkmeister_WMDE added a comment. > Observation: > >> The data provider specified for Wikibase\Lib\Tests\Store\Sql\SqlChangeStoreTest::testSaveChange_insert is invalid. >> Error: Call to undefined method Wikibase\Lib\Changes\ItemChange::setMetadataFromRC() >>

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618785 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/core@master] Clean up test fake time singleton to fix Wikibase tests https://gerrit.wikimedia.org/r/618785 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618774 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] Reenable ArticleRevisionVisibilitySetHookHandlerTest https://gerrit.wikimedia.org/r/618774 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Pablo-WMDE lowered the priority of this task from "Unbreak Now!" to "High". Pablo-WMDE added a comment. Patch with disabled test is merged. TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618772 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] temporarily disable ArticleRevisionVisibilitySetHookHandlerTest https://gerrit.wikimedia.org/r/618772 TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Pablo-WMDE added a comment. https://gerrit.wikimedia.org/r/618772 temporarily disables the tests to unblock unrelated work. We will keep full focus on the topic tomorrow. Observation: > The data provider specified for

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618772 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] temporarily disable ArticleRevisionVisibilitySetHookHandlerTest https://gerrit.wikimedia.org/r/618772 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Pablo-WMDE added a comment. Had a quick chat with @toan - we are looking into this for a little longer (around 30mins) and will consider alternative steps to unblock CI should we not find a solution. TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Tarrow added subscribers: Pablo-WMDE, Tarrow. Tarrow added a comment. Adding @Pablo-WMDE as this week's Incident Manager TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow,

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Addshore, guergana.tzatchkova, Michael, toan, Aklapper, Alter-paule, Beast1978, Un1tY,

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

gerritbot added a comment. Change 618740 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson): [mediawiki/extensions/Wikibase@master] Test if this fixes CI https://gerrit.wikimedia.org/r/618740 TASK DETAIL https://phabricator.wikimedia.org/T259785 EMAIL

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

Michael triaged this task as "Unbreak Now!" priority. Michael added a comment. This seems to be blocking the merging of the patch 618703 for the current UBN T259744 and maybe

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

toan created this task. toan added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Steps to Reproduce: - upload a new patch