[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Maintenance_bot Cc: Lydia_Pintscher, Ladsgroup, Jakob_WMDE, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lydia_Pintscher added a comment. \o/ TASK DETAIL https://phabricator.wikimedia.org/T260869 WORKBOARD

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15). TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

gerritbot added a comment. Change 627428 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] EntitySavingHelper: make array key check safe https://gerrit.wikimedia.org/r/627428 TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Jakob_WMDE added a comment. In T260869#6460356 , @Ladsgroup wrote: > [...] > Maybe we can use the localized version of "The save has failed" but that can be done in another patch I assume? The part that I find confusing is that

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, gerritbot Cc: Ladsgroup, Jakob_WMDE, Lucas_Werkmeister_WMDE, HakanIST, Aklapper,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

gerritbot added a comment. Change 627428 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] EntitySavingHelper: make array key check safe https://gerrit.wikimedia.org/r/627428 TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Maintenance_bot Cc: Ladsgroup, Jakob_WMDE, Lucas_Werkmeister_WMDE, HakanIST,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15). TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, ReleaseTaggerBot Cc: Ladsgroup, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

gerritbot added a comment. Change 625897 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] EntitySavingHelper: allow ArrayAccess object status values https://gerrit.wikimedia.org/r/625897 TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Ladsgroup added a comment. I can locally reproduce it too: F32350877: image.png With the Jakob's patch it becomes this: F32350883: image.png Maybe we can use the localized version of "The

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

gerritbot added a comment. Change 625897 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] EntitySavingHelper: allow ArrayAccess object status values https://gerrit.wikimedia.org/r/625897 TASK DETAIL

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, gerritbot Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, HakanIST, Aklapper, Alter-paule,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Jakob_WMDE claimed this task. Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T260869 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Jakob_WMDE removed Jakob_WMDE as the assignee of this task. Jakob_WMDE moved this task from Doing to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T260869 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Jakob_WMDE added a comment. I can reproduce this locally and found similarly broken cases while trying to figure out what the response is actually supposed to look like. It seems that `ApiErrorReporter::dieStatus` is expected to always add an English error message on top of the localized

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Jakob_WMDE claimed this task. Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T260869 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Addshore moved this task from Prioritized Product to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T260869 WORKBOARD

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lucas_Werkmeister_WMDE, HakanIST, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Lucas_Werkmeister_WMDE added a comment. On Test Wikidata (add testwikidatawiki:Wikidata:Main Page to Q148747 ), uselang=qqx: F32194446: Screenshot_2020-08-25 VqVycLSs.png TASK DETAIL

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T260869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: HakanIST, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

Lydia_Pintscher renamed this task from "Wikidata item save, shows error message twice." to "Wikidata sitelink save, shows error message twice.". Lydia_Pintscher triaged this task as "Medium" priority. Lydia_Pintscher updated the task description. TASK DETAIL