[Wikidata-bugs] [Maniphest] T266697: eslint should fail on warnings

2021-04-29 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T266697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T266697: eslint should fail on warnings

2021-01-05 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE added a comment. Warnings: https://github.com/wmde/wikit/pull/343 Duplicate rule: https://github.com/wmde/wikit/pull/345 TASK DETAIL https://phabricator.wikimedia.org/T266697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T266697: eslint should fail on warnings

2021-01-05 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T266697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] T266697: eslint should fail on warnings

2020-10-29 Thread Michael
Michael added a comment. On the topic of eslint, there also seems to be a duplicate linting rule for indent enabled: F32418707: image.png TASK DETAIL https://phabricator.wikimedia.org/T266697 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T266697: eslint should fail on warnings

2020-10-28 Thread Michael
Michael created this task. Michael added a project: Wikidata Design System. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION We should treat eslint warnings as errors and have CI fail to ensure a high quality of code and