[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-07-20 Thread Addshore
Addshore moved this task from To Prioritize to Triaged Low (0-50) on the wdwb-tech board. Addshore triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T277737 WORKBOARD https://phabricator.wikimedia.org/project/board/3532/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread ItamarWMDE
ItamarWMDE added a comment. Cool, thanks for the reply, yeah the "fix" shouldn't be too much trouble, I just wasn't sure if this was intentional, or even worth spending time on, since, as you say, the resulting lookup would act exactly the same either way. I can take care of it after

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread Addshore
Addshore added a comment. So the top level of dispatching happens in https://github.com/wikimedia/Wikibase/blob/4eefb25d289d928f81230f306570a1a575a7ceba/data-access/src/MultipleEntitySourceServices.php#L95-L108 This currently gets a PrefetchingTermLookup for the whole entity source, rather

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread ItamarWMDE
ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T277737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Addshore, Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread Addshore
Addshore added a comment. Possibly related T253754: Make Wikibase type dispatching services more uniform TASK DETAIL https://phabricator.wikimedia.org/T277737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread ItamarWMDE
ItamarWMDE added projects: Wikidata, wdwb-tech-focus. TASK DETAIL https://phabricator.wikimedia.org/T277737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86,