[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Addshore closed this task as "Resolved". Addshore added a comment. I didnt actually check this, but the changes look good and im sure this will be reopened if it doesnt work TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. Nevermind, apparently the browser tests are just flaky sometimes. Now they’re

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Lucas_Werkmeister_WMDE added a comment. Hm, but in https://github.com/wmde/wikit/runs/3020051173?check_suite_focus=true a totally different set of tests failed? sauceChrome Results for: emits first and last index on scroll change sauceChrome ✖ Timed out while waiting for

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Lucas_Werkmeister_WMDE added a comment. Example run: https://github.com/wmde/wikit/runs/3020043314?check_suite_focus=true sauceIE [Button] Test Suite sauceIE === sauceIE - Connecting to ondemand.saucelabs.com on port 80... sauceIE ℹ Connected to

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. It turns out #439 was slightly faulty, and some CI didn’t run. I fixed that in

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Michael added a comment. This recently added Setting on GitHub seems relevant here: https://github.blog/changelog/2021-07-01-github-actions-new-settings-for-maintainers/ TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. https://github.com/wmde/wikit/pull/439 TASK DETAIL https://phabricator.wikimedia.org/T283911 WORKBOARD

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T283911 WORKBOARD

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Tonina_Zhelyazkova_WMDE added a comment. In T283911#7166299 , @Lucas_Werkmeister_WMDE wrote: > To understand the requirements better: how much functionality do we need to have? From looking at the workflow, it seems like it should be

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

Addshore renamed this task from "Run GitHub actions on PRs opened from a fork" to "Run GitHub actions on PRs opened from a fork in Wikit". Addshore added a project: wikidata-campsite-a-b-split. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Lucas_Werkmeister_WMDE added a comment. > Yes, and I think this is as good as we can (safely) do in this regard. Well, I assume we should be able to run (some?) browser tests directly in GitHub actions instead of via a third-party service. The question is how important that is to us

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Michael added a comment. In T283911#7169942 , @Lucas_Werkmeister_WMDE wrote: > I’m not sure about the first-time contributors things, but as I understand it, the main problem is that pull requests from forks won’t have access to

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Lucas_Werkmeister_WMDE added a comment. I’m not sure about the first-time contributors things, but as I understand it, the main problem is that pull requests from forks won’t have access to secrets, so they’ll be missing various API keys. TASK DETAIL

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Michael added a comment. Mh, reading up on it, it seems to be a bit more complex. The above works not for first-time contributors. In those cases there is apparently a way for manually Approving workflow runs from public forks

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Michael added a comment. In T283911#7166299 , @Lucas_Werkmeister_WMDE wrote: > To understand the requirements better: how much functionality do we need to have? From looking at the workflow, it seems like it should be fairly easy to

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Lucas_Werkmeister_WMDE added a comment. To understand the requirements better: how much functionality do we need to have? From looking at the workflow, it seems like it should be fairly easy to get basic CI working, but without Chromatic, Saucelabs, and Netlify. Would that be useful? TASK

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, bete,

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Addshore set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Addshore added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Addshore triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Tonina_Zhelyazkova_WMDE added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE,

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Tonina_Zhelyazkova_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE,

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Tonina_Zhelyazkova_WMDE added a comment. The below is chat history from a conversation with @Addshore > We have the same problem on gerrit CI with jenkins: there is an allow list of contributors that have real CI run, otherwise they just have "checks" like linting run and the solution

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T283911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja,