[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.11; 2021-11-30); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26). TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732355 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Rename ParserOutput and OutputPage variables to disambiguate https://gerrit.wikimedia.org/r/732355 TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 2021-10-26); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19). TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732272 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Update deprecated calls in ShortDescHandler https://gerrit.wikimedia.org/r/732272 TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

hashar closed this task as "Resolved". hashar added a comment. There was just a few of those happening in production (once per hour or so). I have deployed the change to production. Thank you for the quick fix! TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2021-10-20T17:00:47Z] Synchronized php-1.38.0-wmf.5/extensions/Wikibase/client: Update deprecated calls to ParserOutput in ShortDescHandler - T293860 (duration: 01m 03s) TASK

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19). TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: cscott,

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732332 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Update deprecated calls in ShortDescHandler https://gerrit.wikimedia.org/r/732332 TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732332 had a related patch set uploaded (by C. Scott Ananian; author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Update deprecated calls in ShortDescHandler https://gerrit.wikimedia.org/r/732332 TASK DETAIL

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732354 **abandoned** by C. Scott Ananian: [mediawiki/extensions/Wikibase@master] Rename usages of deprecated ParserOutput::{get,set}Property() (take 2) Reason: Abandon in favor of I70706415ae657f6783b7ae78e2dbe1b96ca31dbe

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

Lucas_Werkmeister_WMDE added a comment. It is covered by tests, the tests just happen to mock the parser output instead of using the real implementation. TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732355 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian): [mediawiki/extensions/Wikibase@master] Rename ParserOutput and OutputPage variables to disambiguate https://gerrit.wikimedia.org/r/732355 TASK DETAIL

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

cscott added a comment. (Also, just sayin': this would have been caught by CI if `ShortDescHandler::doHandle()` were covered by any tests...) TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732354 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian): [mediawiki/extensions/Wikibase@master] Rename usages of deprecated ParserOutput::{get,set}Property() (take 2) https://gerrit.wikimedia.org/r/732354 TASK

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

Lucas_Werkmeister_WMDE added a comment. Yeah, I didn’t realize the two classes were so confusingly similar, sorry for being a bit too harsh there. (I did a quick git grep and just assumed most of them would be other ParserOutput calls, since they were on variables like `$out`.) TASK DETAIL

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

cscott added a comment. In T293860#7443715 , @Lucas_Werkmeister_WMDE wrote: > Okay, maybe not “easily”, given that `OutputPage` has similar methods that weren’t renamed, and in the codesearch context it’s not immediately obvious if an

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

hashar added a parent task: T287216: ParserOutput should implement ContentMetadataCollector. TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, hashar Cc:

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

hashar added a comment. That has been deprecated as part of T287216: ParserOutput should implement ContentMetadataCollector specially by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/727402 . A code search has definitely been done and the

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. Okay, maybe not “easily”, given that `OutputPage` has similar methods that weren’t renamed, and in the codesearch context it’s not immediately obvious if an `$out` variable is a `ParserOutput` or an

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, Biggs657, Invadibot,

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

gerritbot added a comment. Change 732272 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Update deprecated calls in ShortDescHandler https://gerrit.wikimedia.org/r/732272 TASK DETAIL

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

Lucas_Werkmeister_WMDE added a comment. Why were `getProperty()` and `setProperty()` hard-deprecated when there are still callers in production-deployed extensions that can easily be found with codesearch? TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

Maintenance_bot added a project: Wikidata. Restricted Application added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, hashar, Invadibot,

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

hashar created this task. hashar added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - - mwversion: `1.38.0-wmf.5` - reqId: