[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Doing to Our work done on the Wikidata-Campsite (Team A Hearth ) board. Lucas_Werkmeister_WMDE added a comment. I think we can close this task; MediaWiki core has been shipping the migration

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE closed subtask T296202: Migrate Termbox to Vue 3 as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: karapayneWMDE, Michael,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.20; 2022-01-31); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06). TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740231 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Migrate to Vue 3 and Vuex 4 https://gerrit.wikimedia.org/r/740231 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Michael closed subtask T295894: Remove vue-class-componets from Data Bridge as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Michael Cc: karapayneWMDE,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Michael added a comment. In T294465#7576504 , @Catrope wrote: > Note that there is still one `new Vue()` call remaining in Wikibase, in ErrorPermission.vue in data bridge

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Catrope added a comment. Note that there is still one `new Vue()` call remaining in Wikibase, in ErrorPermission.vue in data bridge

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a subtask: T297381: WikibaseLexeme CI broken: test:mwlibs can’t find MediaWiki core Vue version. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740654 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Use MwCreateApp https://gerrit.wikimedia.org/r/740654 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 742165 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Use emitter as prop instead of using repeater https://gerrit.wikimedia.org/r/742165 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 742165 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Use emitter as prop instead of using repeater https://gerrit.wikimedia.org/r/742165 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740654 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Use MwCreateApp https://gerrit.wikimedia.org/r/740654 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739587 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/extensions/Wikibase@master] TR: WIP: Migrate to Vue 3 and Vuex 4 Reason: replaced by I229f5b5c0b (which also has the proper commit message) https://gerrit.wikimedia.org/r/739587

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739536 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/extensions/Wikibase@master] TR: Include Vue in build and move plugin registration Reason: we made it work with MediaWiki’s Vue 3 after all, see If818f32ae0

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740201 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Move plugin registration to app https://gerrit.wikimedia.org/r/740201 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740230 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Remove vuex-class https://gerrit.wikimedia.org/r/740230 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740231 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Migrate to Vue 3 and Vuex 4 https://gerrit.wikimedia.org/r/740231 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740230 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Remove vuex-class https://gerrit.wikimedia.org/r/740230 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 740201 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Move plugin registration to app https://gerrit.wikimedia.org/r/740201 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739328 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Use Vue.createMwApp() https://gerrit.wikimedia.org/r/739328 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739327 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Change App id from data to prop https://gerrit.wikimedia.org/r/739327 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739273 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Migrate from vue-class-component to options API https://gerrit.wikimedia.org/r/739273 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a comment. Got it, the store needs to be on the outer app (obviously, in hindsight ^^): Vue.createMwApp( { store, render( h ) { return

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a comment. Hm, the `render` workaround seems to work well in Vue 2 (and it’s nicer than `extendOptions`, so thanks!), but I haven’t managed to get it working in Vue 3 yet. Rendering `App` produces an error about `$store` being undefined; rendering `$.extend( {

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Catrope added a comment. That confuses me, because WVUI uses `export default Vue.extend( { ... } )` too (example ), and using the Vue 2 build of WVUI with the Vue 3 compat runtime works fine. Maybe the

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a comment. > I thought this would be a problem with WVUI, but from my testing, the Vue 2-compiled WVUI bundle works just fine under the Vue 3 migration build. The compatibility that the migration build provides for the render function API is good enough that

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Catrope added a comment. > since we compile templates in our build step, we can’t produce a bundle that’s compatible with Vue 2 and 3 at runtime I thought this would be a problem with WVUI, but from my testing, the Vue 2-compiled WVUI bundle works just fine under the Vue 3 migration

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a comment. To summarize all the Gerrit stuff up there, our current general plan for Tainted Refs is: - Migrate from vue-class-component to the options API. Can be merged at any time. - Temporarily include Vue 2 in the build, making it independent of the

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739587 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: WIP: Migrate to Vue 3 and Vuex 4 https://gerrit.wikimedia.org/r/739587 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739536 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Include Vue in build and move plugin registration https://gerrit.wikimedia.org/r/739536 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739328 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Use Vue.createMwApp() https://gerrit.wikimedia.org/r/739328 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739327 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Change App id from data to prop https://gerrit.wikimedia.org/r/739327 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.11; 2021-11-30). TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: karapayneWMDE, Michael,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 737747 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Use createMwApp() instead of new Vue() https://gerrit.wikimedia.org/r/737747 TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 739273 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Migrate from vue-class-component to options API https://gerrit.wikimedia.org/r/739273 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a comment. @Michael and I looked at Tainted References, and it’s not really clear how to migrate it. Tainted References (and Data Bridge) uses vue-class-component, which doesn’t seem to have a version compatible with Vue 3 yet, and we don’t know if a Vue 3

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a comment. For WikibaseLexeme, as far as I can tell the old code works with Vue 2 (obviously), the old code works with the Vue 3 migration build (i.e. `git review -d 666434` in MW core), the new code (see change above) works with Vue 2 (though it requires a

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a subscriber: karapayneWMDE. Lucas_Werkmeister_WMDE moved this task from Prioritized Backlog to Doing on the Wikidata-Campsite (Team A Hearth ) board. Lucas_Werkmeister_WMDE added a comment. I started working on this in

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE, gerritbot Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, Catrope, 786, Suran38,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

gerritbot added a comment. Change 737747 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Use createMwApp() instead of new Vue() https://gerrit.wikimedia.org/r/737747 TASK DETAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Michael added a comment. In T294465#7492648 , @Lucas_Werkmeister_WMDE wrote: > I’m aware of four Wikibase codebases that use Vue: > > - termbox > - data bridge > - lexemes > - tainted references Yes, those are the only

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added a project: Wikidata Tainted References. Lucas_Werkmeister_WMDE added a comment. I’m aware of four Wikibase codebases that use Vue: - termbox - data bridge - lexemes - tainted references TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Lucas_Werkmeister_WMDE added projects: Wikidata-Bridge, Wikidata Lexicographical data. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE, Lucas_Werkmeister_WMDE Cc: Aklapper, Catrope,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Manuel triaged this task as "High" priority. Manuel edited projects, added Wikidata-Campsite (Team A Hearth ); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Michael added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE, Michael Cc: Aklapper, Catrope, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Michael added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE, Michael Cc: Aklapper, Catrope, Invadibot, maantietaja, Akuckartz, darthmon_wmde,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

egardner assigned this task to karapayneWMDE. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE, egardner Cc: Aklapper, Catrope, Invadibot, maantietaja, Akuckartz, darthmon_wmde,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, Catrope, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Catrope updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Aklapper, Catrope, Akuckartz, darthmon_wmde, lucamauri, Wikidata-bugs, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build

Catrope created this task. Catrope added projects: MediaWiki-extensions-WikibaseClient, Wikidata-Termbox. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION One of the first steps in our migration to Vue 3 will be to upgrade the version of Vue in MediaWiki from Vue 2.6 to