[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the Wikidata-Campsite (Team A Hearth ) board. Lucas_Werkmeister_WMDE added a comment. Wikibase CI is looking much better as far as I can tell;

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.19; 2022-01-24); removed MW-1.38-notes (1.38.0-wmf.18; 2022-01-17). TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh,

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Lucas_Werkmeister_WMDE added a comment. Alright, let’s see if these errors happen less often now. TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

gerritbot added a comment. Change 754495 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Support idGenerator=auto and use it in CI https://gerrit.wikimedia.org/r/754495 TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Team A Hearth ). TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper,

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17). TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

gerritbot added a comment. Change 754500 **merged** by jenkins-bot: [mediawiki/core@master] Add ConnectionManager::getLazyWriteConnectionRef() https://gerrit.wikimedia.org/r/754500 TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

gerritbot added a comment. Change 754500 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] Add ConnectionManager::getLazyWriteConnectionRef() https://gerrit.wikimedia.org/r/754500 TASK DETAIL

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. I went with a compromise between the two suggestions, introducing an `auto` type but only configuring it in CI and not yet making it the default. TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, Biggs657,

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

gerritbot added a comment. Change 754495 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Support idGenerator=auto and use it in CI https://gerrit.wikimedia.org/r/754495 TASK DETAIL

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Lucas_Werkmeister_WMDE added a comment. It looks like this is now sometimes happening even with non-parallel builds (unless you changed something so they’re parallel by default?), e.g. in #96773

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Lucas_Werkmeister_WMDE added a comment. Or maybe the default config should be that Wikibase autodetects whether MySQL is used or not? (In production I think we’d still want to explicitly configure this particular implementation.) The `UpsertSqlIdGenerator` is well tested in production by

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

Lucas_Werkmeister_WMDE added a comment. In T298682#7601346 , @hashar wrote: > I am guessing the CI config would require a similar adjustment? Yes, we might want to set $wgWBRepoSettings['idGenerator'] = 'mysql-upsert';

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

aaron added a comment. \Wikibase\Repo\Store\Sql\SqlIdGenerator definitely looks prone to deadlocks. It should probably work more like TableNameStore (named locks + auto-commit trx). TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

kostajh added projects: MediaWiki-extensions-WikibaseRepository, Browser-Tests. TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Aklapper, kostajh, hashar, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

hashar added a comment. Maybe related is T194299 , there are mentions of `$wgWBRepoSettings['idGenerator'] = 'mysql-upsert'`, I don't know what the default is or what is set on the CI job. The comment T194299#4840260

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

hashar added a parent task: T226869: Run browser tests in parallel. TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Aklapper, kostajh, hashar, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

hashar created this task. hashar added projects: Wikidata, ci-test-error. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: wdwb-tech. TASK DESCRIPTION The webdriver.io Selenium tests are run serially. As part of T226869