[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Michael changed the status of subtask T328552: Remove deprecated wikibase.common ResourceLoader module from Stalled to Open. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. Arian_Bozorg added a comment. This looks all good to me! Thanks so much :) TASK DETAIL

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30). TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE changed the status of subtask T328552: Remove deprecated wikibase.common ResourceLoader module from Open to Stalled. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. Should be ready to verify with next week’s train; I’ll make a separate subtask for removing the deprecated `wikibase.common`

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883968 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] SpecialAvailableBadges: add wikibase.alltargets module https://gerrit.wikimedia.org/r/883968 TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883970 **merged** by jenkins-bot: [mediawiki/extensions/Wikidata.org@master] Add badge styles on mobile as well https://gerrit.wikimedia.org/r/883970 TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883969 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Replace wikibase.common with wikibase.alltargets + wikibase.desktop https://gerrit.wikimedia.org/r/883969 TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883967 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Replace wikibase.common with wikibase.alltargets + wikibase.desktop https://gerrit.wikimedia.org/r/883967 TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30). TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Jdlrobson,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 881891 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Split wikibase.common into wikibase.alltargets + wikibase.desktop https://gerrit.wikimedia.org/r/881891 TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE added a comment. In T325084#8556512 , @Lucas_Werkmeister_WMDE wrote: > - We want to make sure the scope of this task stays limited – the split of RL modules needs to happen, but we limit the amount of styles that

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE added a comment. Okay, that sounds alright to me – the impact of the module being loaded on mobile prematurely should be limited. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Jdlrobson added a subscriber: LucasWerkmeister. Jdlrobson added a comment. Hey @LucasWerkmeister we're planning to push ahead with modules defaulting to desktop and mobile next week after the branch cut as every week we delay this, we're risking more migration work and breakage. Evaluating

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883970 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikidata.org@master] Add badge styles on mobile as well https://gerrit.wikimedia.org/r/883970 TASK DETAIL

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883969 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Replace wikibase.common with wikibase.alltargets + wikibase.desktop

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883968 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] SpecialAvailableBadges: add wikibase.alltargets module https://gerrit.wikimedia.org/r/883968 TASK

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 883967 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Replace wikibase.common with wikibase.alltargets + wikibase.desktop

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T325084 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. Task breakdown notes: - The overall approach above seems to be okay so far. - We want to make sure the scope of this task stays

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Michael moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. Michael edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T325084 WORKBOARD

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team; removed Wikidata Dev Team (Sprint-∞). Lucas_Werkmeister_WMDE added a comment. In T325084#8543704

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

gerritbot added a comment. Change 881891 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] WIP: Split wikibase.common into wikibase.alltargets + wikibase.desktop

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE added a comment. > This task requires enabling the following extensions in your local dev environment: > > - Wikibase > - WikimediaBadges > - Wikidata.org WikimediaBadges is responsible for adding badge icons on client wikis; Wikidata.org is responsible

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE added a comment. Hm, this is a bit trickier than I thought because `wikibase.common` is a style module loaded with `addModuleStyles()`, which has some additional restrictions (see docs

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T325084 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Jdlrobson,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

karapayneWMDE set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lydia_Pintscher triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Arian_Bozorg added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Jdlrobson, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE added a comment. Copying from what I wrote in that change: > I think we should be able to fix this fully, by splitting the required styles out of wikibase.common into some module that can also be loaded on mobile. (Not sure what it should be called yet, since

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE added a comment. Partial solution, but not sufficient in my testing: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikidata.org/+/867209 TASK DETAIL https://phabricator.wikimedia.org/T325084 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T325084: Sitelink badges invisible on mobile Wikidata

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, MediaWiki-extensions-WikibaseView, Wikidata.org, Mobile. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As a Wikidata visitor using the mobile interfaces, I want to know which