[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

ItamarWMDE changed the status of subtask T333844: RTL layout broken in latest query builder code from Invalid to Resolved. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

ItamarWMDE changed the status of subtask T333844: RTL layout broken in latest query builder code from Resolved to Invalid. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg added a comment. Thanks so much! TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Arian_Bozorg Cc: Arian_Bozorg,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Sarai-WMDE added a comment. Validation done. The Language Selector component is displaying the correct visual style and mirroring behavior depending on language directionality  Tested in Safari 15.6, Firefox and Chrome 112 on macOS Monterey. TASK DETAIL

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Sarai-WMDE attached a referenced file: F36925642: Screenshot 2023-03-24 at 15.22.42.png. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Sarai-WMDE Cc: Arian_Bozorg, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Arian_Bozorg added a comment. Just tagging @Sarai-WMDE to take a look :) TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Arian_Bozorg Cc: Arian_Bozorg, Sarai-WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

HasanAkgun_WMDE added a comment. In T329490#8776458 , @Arian_Bozorg wrote: > Thanks so much, I am not sure if I am checking the right place: > https://904092--clicky-sparqly.netlify.app/ > > But I am unable to select a language to

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Arian_Bozorg added a comment. Thanks so much, I am not sure if I am checking the right place: https://904092--clicky-sparqly.netlify.app/ But I am unable to select a language to check the RTL function TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

ItamarWMDE closed subtask T333844: RTL layout broken in latest query builder code as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, ItamarWMDE Cc: Arian_Bozorg,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Maintenance_bot Cc: Arian_Bozorg, Sarai-WMDE, Aklapper, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

gerritbot added a comment. Change 904092 **merged** by jenkins-bot: [wikidata/query-builder@master] Fix language selector alignment on RTL https://gerrit.wikimedia.org/r/904092 TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, gerritbot Cc: Arian_Bozorg, Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

gerritbot added a comment. Change 904092 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)): [wikidata/query-builder@master] Fix language selector alignment on RTL https://gerrit.wikimedia.org/r/904092 TASK DETAIL

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Sarai-WMDE added a comment. > F36925624: image.png > > Should the drop-down be aligned on the left side of the button to avoid this issue @Sarai-WMDE? Yes, exactly. The alignment should be mirrored too: F36925640: Screenshot

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Arian_Bozorg added a comment. Thanks Hasan, this is looking like it's working but the width of the drop-down menu is going off the page: F36925624: image.png Should the drop-down be aligned on the left side of the button to avoid this

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Maintenance_bot Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

gerritbot added a comment. Change 893418 **merged** by jenkins-bot: [wikidata/query-builder@master] Add RTL support to Language Selector component https://gerrit.wikimedia.org/r/893418 TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, gerritbot Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

gerritbot added a comment. Change 893418 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)): [wikidata/query-builder@master] Add RTL support to Language Selector component https://gerrit.wikimedia.org/r/893418 TASK DETAIL

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

guergana.tzatchkova added a comment. To make the LanguageSelector visible temporarily for development, the changes of this file can be re-added: https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/892394/3/src/components/QueryBuilder.vue TASK DETAIL

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, guergana.tzatchkova Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

HasanAkgun_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T329490: Query Builder: implement RTL functionality in LanguageSelector component

noarave renamed this task from "Implement RTL functionality in LanguageSelector component" to "Query Builder: implement RTL functionality in LanguageSelector component". TASK DETAIL https://phabricator.wikimedia.org/T329490 EMAIL PREFERENCES