[Wikidata-bugs] [Maniphest] T339346: Clean up retry logic in SqlIdGenerator and UpsertSqlIdGenerator

2024-02-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. The `UpsertSqlIdGenerator` retry code was removed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1003054; `SqlIdGenerator` still has some retry code left (though it has no effect since the related change

[Wikidata-bugs] [Maniphest] T339346: Clean up retry logic in SqlIdGenerator and UpsertSqlIdGenerator

2023-07-04 Thread Bugreporter
Bugreporter added a comment. In T339346#8939153 , @Umherirrender wrote: > Note: There is a same named class SqlIdGenerator in EntitySchema with the same code. which is forked from an older version of SqlIdGenerator in Wikibase -

[Wikidata-bugs] [Maniphest] T339346: Clean up retry logic in SqlIdGenerator and UpsertSqlIdGenerator

2023-06-16 Thread Umherirrender
Umherirrender added a comment. Note: There is a same named class SqlIdGenerator in EntitySchema with the same code. TASK DETAIL https://phabricator.wikimedia.org/T339346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc:

[Wikidata-bugs] [Maniphest] T339346: Clean up retry logic in SqlIdGenerator and UpsertSqlIdGenerator

2023-06-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Related change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/930268 TASK DETAIL https://phabricator.wikimedia.org/T339346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T339346: Clean up retry logic in SqlIdGenerator and UpsertSqlIdGenerator

2023-06-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wdwb-tech, Technical-Debt. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION `SqlIdGenerator` and `UpsertSqlIdGenerator` have some code that’s supposed to retry acquiring an ID if a