[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Backlog to Done on the Wikidata Dev Team (Quality Tools "Sprint") board. Arian_Bozorg added a comment. Thanks Hasan :) All good then, the rest looks good to me TASK DETAIL

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

HasanAkgun_WMDE added a comment. We have added the fix to the most recent code, but it's not on staging right now. Should we proceed anyways? @Arian_Bozorg TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Arian_Bozorg moved this task from Product Verification to Backlog on the Wikidata Dev Team (Quality Tools "Sprint") board. Arian_Bozorg added a comment. This looks good to me once the typo that Sarai pointed out is resolved :) Thanks so much! TASK DETAIL

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE added a comment. Design review done. Everything appears to follow the specs to the millimeter  Funny enough, the only thing that needs fixing is an extra period a the end of the first sentence of the message. It should just be deleted: F38097747: Screenshot 2023-10-09 at

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

noarave added a comment. @Sarai-WMDE this should be available on staging now https://mismatch-finder-staging.toolforge.org/ TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

HasanAkgun_WMDE added a comment. In T343344#9205949 , @noarave wrote: > @HasanAkgun_WMDE gladly, but you need to link the code in the task for us to be able to do that Haha so sorry! Here it is.

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

noarave added a comment. @HasanAkgun_WMDE gladly, but you need to link the code in the task for us to be able to do that TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

HasanAkgun_WMDE added a comment. In T343344#9205608 , @noarave wrote: > @HasanAkgun_WMDE I cannot peer review if I don't know what is to be reviewed :) @noarave It would be great to have a general review of the code and check if

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

noarave added a comment. @HasanAkgun_WMDE I cannot peer review if I don't know what is to be reviewed :) TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, noarave Cc:

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE added a comment. In T343344#9194407 , @HasanAkgun_WMDE wrote: > @Sarai-WMDE I have 2 questions regarding the final design: > 1 . How should it look like between breakpoints? I mean, with 550px width, should it look like

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

HasanAkgun_WMDE added a comment. I have 2 questions regarding the final design: 1 . How should it look like between breakpoints? I mean, with 550px width, should it look like tablet design or mobile design? 2. How should it look like at breakpoints? For example; at exactly 320px width

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

HasanAkgun_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE Cc: ItamarWMDE, noarave, Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

ItamarWMDE added a comment. **Task Breakdown Notes**: - We can install codex using regular npm, and include it in our project using mix. See the following docs: - Codex: https://doc.wikimedia.org/codex/main/using-codex/about.html - Larvel: https://laravel.com/docs/8.x/mix - The

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

noarave added a comment. I think it should be possible to load codex tokens using Blade's assets syntax , as codex tokens may be used as css custom properties. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

karapayneWMDE moved this task from Unified QT to Quality Tools "Sprint" on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T343344 WORKBOARD

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

karapayneWMDE updated the task description. karapayneWMDE set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Lydia_Pintscher, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE removed a project: Wikidata-UX. Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE removed Sarai-WMDE as the assignee of this task. Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Lydia_Pintscher, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Arian_Bozorg added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, Arian_Bozorg Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE added a comment. Mock-up: F37638104: Screenshot 2023-08-28 at 12.19.20.png | Link to Figma | |

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE added a comment. Heads-up that this is the non-js message displayed by Wikidata Query builder at the moment: F37546646: Screenshot 2023-08-17 at 16.41.51.png We might want to update/improve this too. TASK DETAIL

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Sarai-WMDE added a comment. Designs/copy to improve this scenario need to be defined. I'll think of options and look for any potential previous approaches and share them here, so we make a joined decision. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Lydia_Pintscher added a project: Wikidata-UX. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Lydia_Pintscher added subscribers: Sarai-WMDE, Lydia_Pintscher. Lydia_Pintscher added a comment. @Sarai-WMDE Do you have a simple copy/mockup for this? Then we could mark is as a good first task. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T343344: Mismatch Finder shows a blank page without Javascript enabled

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T343344 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Nikki, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,