[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Arian_Bozorg closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T347161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Arian_Bozorg Cc: Volker_E, guergana.tzatchkova, Arian_Bozorg, ItamarWMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Volker_E added a comment. In T347161#9516504 , @noarave wrote: > This style was overwritten when merging the replaced token chain > https://github.com/wmde/wikidata-mismatch-finder/pull/877 Comment from the side-lines: I've

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE added a comment. Thanks for the speedy fix! :) TASK DETAIL https://phabricator.wikimedia.org/T347161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: guergana.tzatchkova, Arian_Bozorg, ItamarWMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave moved this task from Product Verification to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. This style was overwritten when merging the replaced token chain https://github.com/wmde/wikidata-mismatch-finder/pull/877 TASK DETAIL

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE added a comment. Unfortunately, I just noticed that the MSMF logo still displays (or displays again?) the unwanted outline on click: F41791091: logo_outline.gif I'll move this ticket back to Product verification for now, just

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE added a comment. All fixed. Thank you! TASK DETAIL https://phabricator.wikimedia.org/T347161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: guergana.tzatchkova, Arian_Bozorg, ItamarWMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave moved this task from Product Verification to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. https://github.com/wmde/wikidata-mismatch-finder/pull/838 Taking this back to Peer Review TASK DETAIL

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE added a comment. Thanks for the latest changes! There is just a small fix left to make: As mentioned in a previous comment, the "user page" and the "log out"/"log in" links display different colors on hover. The former has the correct style: in both cases, the link text color

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE added a comment. In T347161#9468604 , @guergana.tzatchkova wrote: > Hello, @Sarai-WMDE I guess more of a question for UX: if the log in link in the AuthWidget is not supposed to have a visited state (aka purple color after

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

guergana.tzatchkova added a comment. Hello, @Sarai-WMDE I guess more of a question for UX: if the log in link in the AuthWidget is not supposed to have a visited state (aka purple color after visited)... is it supposed to have a visited state when it is part of the message component?

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave moved this task from Doing to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. https://github.com/wmde/wikidata-mismatch-finder/pull/830 TASK DETAIL https://phabricator.wikimedia.org/T347161 WORKBOARD

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE added a comment. Thanks for removing the navigation outline of the logo (1) and the :visited state in auth links (3)! The default :hover state of the links should remain, though, since this indication is needed. (I actually can still see hover states in staging. In fact, each

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. - :visited and :hover styles were removed from auth widget links - navigation outline was removed from the logo TASK DETAIL

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave moved this task from Doing to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. Some of the requested improvements are addressed here https://github.com/wmde/wikidata-mismatch-finder/pull/793 TASK DETAIL

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave moved this task from Product Verification to Doing on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. putting this back into doing since there's more work needed TASK DETAIL https://phabricator.wikimedia.org/T347161 WORKBOARD

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE added a subscriber: Arian_Bozorg. Sarai-WMDE added a comment. Hey hey. Finally reviewing this. Sorry for the delay, @noarave. Here are a couple of comments: 1. The current implementation applies the Codex link mixin styles to all elements via app.scss. Nevertheless, this

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave moved this task from Doing to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. https://github.com/wmde/wikidata-mismatch-finder/pull/772 TASK DETAIL https://phabricator.wikimedia.org/T347161 WORKBOARD

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

noarave claimed this task. noarave moved this task from Backlog to Doing on the Wikidata Dev Team (Quality Tools "Sprint") board. Restricted Application added a project: User-Noarave. TASK DETAIL https://phabricator.wikimedia.org/T347161 WORKBOARD

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

ItamarWMDE added a comment. **Task Breakdown Notes**: - We cannot import the less mixin, as we are using sass - Compose our own link from codex tokens, which can be done by copy-pasting /packages/codex/src/themes/mixins/public/link.less

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Arian_Bozorg moved this task from Unified QT Backlog to Quality Tools "Sprint" on the Wikidata Dev Team board. Arian_Bozorg edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T347161 WORKBOARD

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Arian_Bozorg set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T347161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH,

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T347161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T347161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T347161: [WtC-M2] Replace WiKit Link component by Codex's

Sarai-WMDE created this task. Sarai-WMDE added projects: Wikidata Dev Team, Wikidata Design System, Wikidata, Mismatch Finder. TASK DESCRIPTION Problem --- The Mismatch Finder's user interface was composed using a combination of Vue 2 custom components and WiKit elements, such as