[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

WMDE-leszek closed this task as "Resolved". WMDE-leszek added a comment. Thank you. TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: WMDE-Fisch, Jdforrester-WMF, WMDE-leszek,

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

thiemowmde added a project: Advanced-Search. thiemowmde added a comment. #advanced-search is the only #wmde-techwish product that contains client-side `mw.hook` hooks. These have

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

WMDE-leszek added a comment. It looks like the task, admittedly way over time, has been sorted from the Wikibase side. I'll let @thiemowmde assess whether it needs to remain open for other WMDE maintained extensions, or whether it is all sorted and can be closed by now. TASK DETAIL

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: WMDE-Fisch, Jdforrester-WMF, WMDE-leszek, ItamarWMDE, thiemowmde, Aklapper,

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

gerritbot added a comment. Change #1021788 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@REL1_42] Declare mw.wbTemplate and mw.wbTemplates as not stable https://gerrit.wikimedia.org/r/1021788 TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

gerritbot added a comment. Change #1021788 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek): [mediawiki/extensions/Wikibase@REL1_42] Declare mw.wbTemplate and mw.wbTemplates as not stable https://gerrit.wikimedia.org/r/1021788 TASK DETAIL

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23). TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: WMDE-Fisch, Jdforrester-WMF, WMDE-leszek,

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

gerritbot added a comment. Change #1019899 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Declare mw.wbTemplate and mw.wbTemplates as not stable https://gerrit.wikimedia.org/r/1019899 TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

Jdlrobson added a comment. The frontend stable policy currently doesn't cover mw.config values. We already have cases where config variables are not always available e.g. on mobile wgCategories is notably absent, so I think code should be providing fallbacks or error handling when those

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

WMDE-leszek added a comment. hello @Jdlrobson a random and likely silly question. It seems https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1019899 might do it/most of it, as wikibase puts most of its frontend stuff to own "global object" not to `mw`. Wikibase JS code does

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

gerritbot added a comment. Change #1019900 **abandoned** by WMDE-leszek: [mediawiki/extensions/Wikibase@master] Mark Wikibase hooks as not stable Reason: would have been a wrong and unwanted change https://gerrit.wikimedia.org/r/1019900 TASK DETAIL

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

gerritbot added a comment. Change #1019900 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Mark Wikibase hooks as not stable https://gerrit.wikimedia.org/r/1019900 TASK DETAIL https://phabricator.wikimedia.org/T348079

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: WMDE-Fisch, Jdforrester-WMF, WMDE-leszek, ItamarWMDE, thiemowmde, Aklapper, Jdlrobson,

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

gerritbot added a comment. Change #1019899 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Declare mw.wbTemplate and mw.wbTemplates as not stable https://gerrit.wikimedia.org/r/1019899 TASK DETAIL

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

Jdlrobson added a comment. > Does mw:Stable interface policy/Frontend even apply to extensions the same way it applies to core Yes. Anything on the mw object is subject to the deprecation policy. The reason for this is that it is not fair to expect gadget developers to understand where

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

thiemowmde added a subscriber: WMDE-Fisch. thiemowmde added a comment. I still try to understand what needs to be done here? I can see that mw:Stable interface policy/Frontend talks about hooks, and a few WMDE products happen

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

WMDE-leszek added a comment. I've clearly miscalculated remaining time. I intended to do it this week. In a matter of hours will not happen indeed, no. TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

Jdforrester-WMF added a comment. FYI, the 1.42 branch point is in a matter of hours; it doesn't appear that this will be done by then? TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

ItamarWMDE removed a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: WMDE-leszek, ItamarWMDE, thiemowmde, Aklapper, Jdlrobson, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

ItamarWMDE edited projects, added Wikidata Dev Team, Wikibase Product Platform Team WPP; removed Wikidata-Campsite. ItamarWMDE added a comment. As a side note the tag #wikidata-campsite is no longer actively maintained, please add

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

Jdlrobson added a comment. @thiemowmde could you answer my question around RevisionSlider and AdvancedSearch? @thiemowmde I've updated the title to hopefully be less confusing, per the stable policy any hooks are stable: >The function signature of the callback function for hooks

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

Jdlrobson renamed this task from "WMDE: Review code on mw object and hooks contract and mark (un)stable interfaces before 1.42.0" to "WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0". TASK DETAIL https://phabricator.wikimedia.org/T348079