[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Arian_Bozorg closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Arian_Bozorg Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE added a comment. All looking good! Thanks for the changes TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

noarave moved this task from Product Verification to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. https://github.com/wmde/wikidata-mismatch-finder/pull/839 TASK DETAIL https://phabricator.wikimedia.org/T352304 WORKBOARD

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE added a comment. Thanks for the changes! There's only one low priority fix to make in relation to this task. It introduced a bug in the MSMF Store that was already identified during code revie: there's a default outline applied via the `.button` class. We should include `outline:

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

noarave added a comment. Adding this here as we've noted the issue first on this task. Explanations and a possible workaround for the icon/text misalignment issue on codex buttons: https://github.com/wmde/wikidata-mismatch-finder/pull/837 TASK DETAIL

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE added a comment. Hey Noa! Thanks so much for rising this and confirming the following: there's an extra font style needed, UI text M. We should create and apply it to the components that don't have internal font modifiers (e.g. Dialog) to prevent them from inheriting the body M

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

noarave added a comment. For a reason still unclear to me, the font family token of the body mixin (body-M) is breaking text alignment on several places (mostly buttons and links) example 1 F41619408: image.png example 2 F41619410:

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

noarave added a comment. https://github.com/wmde/wikidata-mismatch-finder/pull/792 TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

noarave moved this task from Backlog to Doing on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave claimed this task. Restricted Application added a project: User-Noarave. TASK DETAIL https://phabricator.wikimedia.org/T352304 WORKBOARD

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

noarave set the point value for this task to "3". TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

noarave moved this task from Unified QT Backlog to Quality Tools "Sprint" on the Wikidata Dev Team board. noarave edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T352304 WORKBOARD

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE moved this task from UX Backlog to [QT] Tech Backlog on the Wikidata Dev Team board. Sarai-WMDE added a project: wmde-wikidata-tech. TASK DETAIL https://phabricator.wikimedia.org/T352304 WORKBOARD https://phabricator.wikimedia.org/project/board/6016/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

Sarai-WMDE renamed this task from "[WtC-M2] Replace WiKit tokens used in MSMF Sass files" to "[WtC-M2] Replace WiKit tokens used in MSMF's Sass files". Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T352304 EMAIL PREFERENCES