[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Jakob_WMDE closed this task as "Resolved". Jakob_WMDE added a comment. Yes, thanks! TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: Ifrahkhanyaree_WMDE, Jdforrester-WMF, daniel,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

daniel moved this task from Incoming (Needs Triage) to Done on the MW-Interfaces-Team board. daniel added a comment. I think this should be fixed now, can you confirm? TASK DETAIL https://phabricator.wikimedia.org/T359149 WORKBOARD https://phabricator.wikimedia.org/project/board/6931/

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

daniel added a project: MW-Interfaces-Team. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Ifrahkhanyaree_WMDE, Jdforrester-WMF, daniel, Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Ifrahkhanyaree_WMDE, Jdforrester-WMF, daniel, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008763 **abandoned** by Jakob: [mediawiki/extensions/Wikibase@master] Revert "REST: Temporarily skip tests involving unusual content types" Reason: All the tests here have been re-enabled or deleted in the meantime, so we don't need this

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Ifrahkhanyaree_WMDE, Jdforrester-WMF, daniel, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008763 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler): [mediawiki/extensions/Wikibase@master] Revert "REST: Temporarily skip tests involving unusual content types" https://gerrit.wikimedia.org/r/1008763 TASK DETAIL

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Ifrahkhanyaree_WMDE, Jdforrester-WMF, daniel, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008758 **abandoned** by Daniel Kinzler: [mediawiki/core@wmf/1.42.0-wmf.21] Rest: allow Handlers to disable body parsing. Reason: This can probably wait for next week's train, no need for a backport https://gerrit.wikimedia.org/r/1008758

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008419 **merged** by jenkins-bot: [mediawiki/core@master] Rest: allow Handlers to disable body parsing. https://gerrit.wikimedia.org/r/1008419 TASK DETAIL

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008758 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler): [mediawiki/core@wmf/1.42.0-wmf.21] Rest: allow Handlers to disable body parsing. https://gerrit.wikimedia.org/r/1008758 TASK DETAIL

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to "High". Lucas_Werkmeister_WMDE added a comment. Alright, tentatively lowering to High and removing parent task then. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Lucas_Werkmeister_WMDE removed a parent task: T354439: 1.42.0-wmf.21 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Ifrahkhanyaree_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Jakob_WMDE added a subscriber: Ifrahkhanyaree_WMDE. Jakob_WMDE added a comment. I don't think this needs to be a train blocker. We just agreed in a meeting with our PM (cc @Ifrahkhanyaree_WMDE) that we're fine with it being broken for a week given this is all still considered experimental.

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Jdforrester-WMF triaged this task as "Unbreak Now!" priority. Jdforrester-WMF added a comment. UBN as a (potential) train-blocker. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Jdforrester-WMF added a parent task: T354439: 1.42.0-wmf.21 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF Cc: daniel, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008419 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler): [mediawiki/core@master] Rest: allow Handlers to disable body parsing.

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: daniel, Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

daniel added a comment. Working on a fix TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12). TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008812 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] REST: Temporarily skip tests involving unusual content types

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Lucas_Werkmeister_WMDE added a comment. This hack makes the `PATCH /entities/items/{item_id}/statements/{statement_id}` test work again: diff --git a/repo/rest-api/src/RouteHandlers/PatchItemStatementRouteHandler.php

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Lucas_Werkmeister_WMDE added a comment. Note: Though the error message looks identical, this doesn’t come from Wikibase’s `ContentTypeCheckMiddleware`; with a debugger, I could instead see that it comes from `\MediaWiki\Rest\Handler::parseBodyData()`: /** * @throws

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

gerritbot added a comment. Change 1008812 had a related patch set uploaded (by Jakob; author: Jakob): [mediawiki/extensions/Wikibase@master] REST: Temporarily skip tests involving unusual content types

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Jakob_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T359149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Jakob_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, ci-test-error (WMF-deployed Build Failure), MediaWiki-REST-API. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Example build