[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

MSantos edited projects, added Content-Transform-Team-WIP, Essential-Work; removed Patch-For-Review, Content-Transform-Team. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MSantos Cc: Andyrom75,

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Jdlrobson moved this task from FY2023-24 Q3 Sprint 6 to Needs Prioritization (Tech) on the Web-Team-Backlog board. Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 6). TASK DETAIL

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Jdlrobson added a comment. Patch was reverted as a temporary measure so this will ride the train this week. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Andyrom75, cscott,

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Jdlrobson added a comment. We pinpointed this issue to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikidataPageBanner/+/972060 TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Andyrom75, cscott, SHB2000, Avsolov, Aklapper, Jdlrobson, Atsirlin, FBellamy-WMF,

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

gerritbot added a comment. Change 1010334 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian): [mediawiki/extensions/WikidataPageBanner@master] Fix inversion error in `enable-toc` test https://gerrit.wikimedia.org/r/1010334 TASK DETAIL

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Andyrom75 added a comment. @Jdlrobson unfortunately also in en:voy there's the need for some user to show/use the TOC, so it's necessary to solve the bug server-side, restoring the previous behavior. Thanks for contacting @cscott or whomever could be involved on its resolution. TASK

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Jdlrobson added a comment. > This can be achieved by adding the NOTOC keyword in the template that calls the banner. However, I am not sure if such a solution is really desirable, or something should be fixed inside the Mediawiki code instead. Regardless of whether behaviour changed

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Jdlrobson added a subscriber: cscott. Jdlrobson added a comment. @cscott I'm guessing this is fallout from the changes you were working on last week? TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Jdlrobson added a project: Content-Transform-Team. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: SHB2000, Avsolov, Aklapper, Jdlrobson, Atsirlin, FBellamy-WMF, Nishu02, ovasileva,

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

ovasileva triaged this task as "Medium" priority. ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 6); removed Web-Team-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

SHB2000 added a comment. For what it's worth, the issue seems to fix itself when "__NOTOC__" is added (see https://en.wikivoyage.org/w/index.php?title=UNESCO_World_Heritage_List=prev=4840979). F42442465: Screenshot 2024-03-07 at 23.48.15.png

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

SToyofuku-WMF added a project: Web-Team-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: SToyofuku-WMF Cc: Avsolov, Aklapper, Jdlrobson, Atsirlin, Nishu02, ovasileva, Winter,

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

Atsirlin created this task. Atsirlin added a project: Wikidata-Page-Banner. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Extension WikidataPageBanner should suppress TOC on pages with the banner. This usual behavior has changed today, and the standard column-style TOC