[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 229741 had a related patch set uploaded (by JanZerebecki): Log when we fail unserializeInfo https://gerrit.wikimedia.org/r/229741 TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread JanZerebecki
JanZerebecki added a comment. Perhaps make it LONGBLOB so that it can hold more than the entity that is stored in a MEDIUMBLOB. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread JanZerebecki
JanZerebecki added a comment. From quickly skimming the relevant code, my estimate is that we don't need to increase rc_params, because we explicitly omit also adding the content of change_info into it. So that we know which items this affected: [wikidatawiki] select change_object_id,

[Wikidata-bugs] [Maniphest] [Updated] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread hoo
hoo added a project: Wikimedia-log-errors. hoo set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Sjoerddebruin, JanZerebecki, aude, daniel, Aklapper, hoo,

[Wikidata-bugs] [Maniphest] [Triaged] T105325: edit_diff_pst variable is broken on Wikidata

2015-08-06 Thread hoo
hoo triaged this task as Normal priority. TASK DETAIL https://phabricator.wikimedia.org/T105325 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Addshore, Aklapper, Luke081515, matej_suchanek, Wikidata-bugs, aude, Se4598, Billinghurst,

[Wikidata-bugs] [Maniphest] [Created] T108232: Banners in desktop skin should have a max width

2015-08-06 Thread Jdlrobson
Jdlrobson created this task. Jdlrobson added a subscriber: Jdlrobson. Jdlrobson added a project: Wikidata-Page-Banner. Jdlrobson moved this task to July 19-August 10 on the Wikidata-Page-Banner workboard. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION

[Wikidata-bugs] [Maniphest] [Created] T108231: Work on joint presentation with Blazegraph for SmatData conf

2015-08-06 Thread Smalyshev
Smalyshev created this task. Smalyshev claimed this task. Smalyshev added a subscriber: Smalyshev. Smalyshev added projects: Wikidata-Query-Service, Discovery-Wikidata-Query-Service-Sprint, Discovery. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION Work

[Wikidata-bugs] [Maniphest] [Changed Project Column] T108231: Work on joint presentation with Blazegraph for SmatData conf

2015-08-06 Thread Smalyshev
Smalyshev moved this task to In progress on the Discovery-Wikidata-Query-Service-Sprint workboard. TASK DETAIL https://phabricator.wikimedia.org/T108231 WORKBOARD https://phabricator.wikimedia.org/project/board/1239/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Changed Project Column] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to consider for next sprint on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T108252 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Changed Project Column] T108231: Work on joint presentation with Blazegraph for SmatData conf

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to monitoring on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T108231 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev,

[Wikidata-bugs] [Maniphest] [Commented On] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread JanZerebecki
JanZerebecki added a comment. In this case it was the Q template referencing Q19859594. https://www.wikidata.org/w/index.php?title=Special:WhatLinksHere/Q16428906hidelinks=1 TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T105033: Explore mobile specific banners

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 228813 merged by jenkins-bot: WPB fake banner cropping for small screens https://gerrit.wikimedia.org/r/228813 TASK DETAIL https://phabricator.wikimedia.org/T105033 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Updated] T87524: Merge with conflicting sitelinks is not rejected

2015-08-06 Thread hoo
hoo added a comment. Can anyone come up with a recent example for this? The handling of sitelinks during merges changed heavily with https://phabricator.wikimedia.org/rEWBA59a1d67aa40439027e9834d300a8b5c6aaa7b18e so this might no longer be a problem. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Created] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread hoo
hoo created this task. hoo added subscribers: hoo, daniel, aude, JanZerebecki, Sjoerddebruin. hoo added projects: Wikidata, MediaWiki-extensions-WikibaseClient. Herald added a subscriber: Aklapper. TASK DESCRIPTION Example exception (slightly messed because logging is messed right now):

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T46117: API modules must make sure getContext()-getTitle() returns a Title object.

2015-08-06 Thread hoo
hoo added a comment. Herald added a subscriber: Aklapper. I guess this can be closed? TASK DETAIL https://phabricator.wikimedia.org/T46117 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Wikidata-bugs, thiemowmde, JanZerebecki,

[Wikidata-bugs] [Maniphest] [Commented On] T106772: WikidataPageBanner tests should run with Wikibase

2015-08-06 Thread Jdlrobson
Jdlrobson added a comment. The problem I'm seeing is there is no entry for Wikidata in integration/config.git/zuul/ext_dependencies.py and I always get confused about the differences between WikibaseClient/Lib/View I feel like it is more complicated then adding 'Wikibase':

[Wikidata-bugs] [Maniphest] [Closed] T90733: Deploy changes_subscription table

2015-08-06 Thread hoo
hoo closed this task as Resolved. hoo claimed this task. hoo added a comment. This has been done quite some time ago. TASK DETAIL https://phabricator.wikimedia.org/T90733 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, aude, daniel,

[Wikidata-bugs] [Maniphest] [Updated] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread hoo
hoo removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko

[Wikidata-bugs] [Maniphest] [Commented On] T98029: Deploy PageBanner extension on English Wikivoyage project

2015-08-06 Thread Legoktm
Legoktm added a comment. I submitted a few small patches for code quality things. I haven't tested it myself, but is image usage being tracked in the imagelinks/globalimagelinks (through GlobalUsage) table? TASK DETAIL https://phabricator.wikimedia.org/T98029 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Raised Priority] T108101: Isolate wikidata.org cookies and CORS policies

2015-08-06 Thread Smalyshev
Smalyshev raised the priority of this task from Normal to High. TASK DETAIL https://phabricator.wikimedia.org/T108101 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Matanya, Addshore, Laddo, bd808, MBlissett, Krenair, waldyrious,

[Wikidata-bugs] [Maniphest] [Commented On] T104922: Deadlock in EntityUsageTable::addUsages

2015-08-06 Thread hoo
archive/exception.log-20150805.gz:2 archive/exception.log-20150806.gz:2 TASK DETAIL https://phabricator.wikimedia.org/T104922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: daniel, Aklapper, hoo, Wikidata-bugs, aude, Krenair, greg, Malyacko

[Wikidata-bugs] [Maniphest] [Updated] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread JanZerebecki
JanZerebecki removed a blocking task: T108255: mariadb: overflow results in silent truncation. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Addshore, daniel,

[Wikidata-bugs] [Maniphest] [Updated] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined

2015-08-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp

[Wikidata-bugs] [Maniphest] [Commented On] T90115: BlazeGraph Security Review

2015-08-06 Thread Joe
Joe added a comment. @MoritzMuehlenhoff kernel upgrades should be doable relatively easily. If we want to be stricter about what the blazegraph user can do on the system, we can look into it too. I don't think network segregation is what we need here either. Alas, I don't see a general way of

[Wikidata-bugs] [Maniphest] [Commented On] T103907: Develop external hardening rules for WDQS

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 229584 merged by Giuseppe Lavagetto: https://phabricator.wikimedia.org/T103907: restrict further passed URLs https://gerrit.wikimedia.org/r/229584 TASK DETAIL https://phabricator.wikimedia.org/T103907 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Closed] T101088: Missing links on ceb: Wikipedia

2015-08-06 Thread hoo
hoo closed this task as Resolved. hoo claimed this task. hoo added a comment. I can't see any problems with cebwiki right now. This was probably some kind of temporary infrastructure problem which has been solved since. Purging the pages (`action=purge`) should also work, you don't need to edit

[Wikidata-bugs] [Maniphest] [Changed Project Column] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to consider for next sprint on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T108130 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Closed] T72728: Extract text for filters code from EntityContent and ensure test coverage for it

2015-08-06 Thread hoo
hoo closed this task as Resolved. hoo claimed this task. hoo added a comment. This has long since been extracted into an own class with tests. TASK DETAIL https://phabricator.wikimedia.org/T72728 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo

[Wikidata-bugs] [Maniphest] [Commented On] T85499: wbEntity shouldn't be served on every page load

2015-08-06 Thread hoo
hoo added a comment. All usages except for AuthorityControl can probably be easily switched without having to worry much. In case of AuthorityControl we need to be more careful: It's enabled per default, thus needs to be handled with care regarding potential performance issues. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T95685: Drop wb_entity_per_page table

2015-08-06 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 230035 had a related patch set uploaded (by Hoo man): Introduce WikiPageEntityRedirectLookup https://gerrit.wikimedia.org/r/230035 TASK DETAIL https://phabricator.wikimedia.org/T95685 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T95685: Drop wb_entity_per_page table

2015-08-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T95685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Aklapper, daniel, Wikidata-bugs, aude, Malyacko

[Wikidata-bugs] [Maniphest] [Commented On] T47839: Not all language links showing up, manual purge required

2015-08-06 Thread Bugreporter
Bugreporter added a comment. Another: https://zh.wikipedia.org/wiki/Wikipedia:%E5%82%80%E5%84%A1%E8%B4%A6%E6%88%B7%E7%9A%84%E7%89%B9%E7%82%B9 https://archive.is/5HVg6 https://www.wikidata.org/wiki/Q11056804 TASK DETAIL https://phabricator.wikimedia.org/T47839 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T87524: Merge with conflicting sitelinks is not rejected

2015-08-06 Thread matej_suchanek
matej_suchanek added a comment. @hoo See - https://www.wikidata.org/w/index.php?title=Q16434239action=history - both merges weren't completed (done by Wikidata Game) - https://www.wikidata.org/w/index.php?title=Q16432215action=history - same case TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T95685: Drop wb_entity_per_page table

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 230036 had a related patch set uploaded (by Hoo man): Remove EntityPerPageTable::getPageIdForEntityId https://gerrit.wikimedia.org/r/230036 TASK DETAIL https://phabricator.wikimedia.org/T95685 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Changed Project Column] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T108252 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Updated] T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive

2015-08-06 Thread hoo
hoo added a blocking task: T106190: {{#property:…}} parser function should enforce the parser's restricted function limit. TASK DETAIL https://phabricator.wikimedia.org/T93885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: gerritbot,

[Wikidata-bugs] [Maniphest] [Updated] T106190: {{#property:…}} parser function should enforce the parser's restricted function limit

2015-08-06 Thread hoo
hoo added a blocked task: T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive. TASK DETAIL https://phabricator.wikimedia.org/T106190 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc:

[Wikidata-bugs] [Maniphest] [Changed Project Column] T105432: Make wikibase:quantityUnit an URI

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T105432 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Changed Project Column] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to Review on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T106192 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Updated] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity

2015-08-06 Thread JanZerebecki
JanZerebecki added a project: Wikidata-Sprint-2015-06-30. JanZerebecki set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T106192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, hoo, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 229992 merged by jenkins-bot: Fail gracefully when hitting double redirects in client DataAccess https://gerrit.wikimedia.org/r/229992 TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T98029: Deploy PageBanner extension on English Wikivoyage project

2015-08-06 Thread Jdlrobson
Jdlrobson added a comment. Good question @legoktm .. unless it happens automagically I suspect not. Can you open a task with instructions on how to check / implement that? Thanks for the patches - I will take a look! TASK DETAIL https://phabricator.wikimedia.org/T98029 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Changed Project Column] T72127: Error messages for Special:GoToLinkedPage when requested target doesn't exist

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T72127 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Changed Project Column] T105824: Remove rdf:type wikibase:Value and leave only specific value class on values

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T105824 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Declined] T70377: Write migration script for schema changes to entity_per_page table

2015-08-06 Thread hoo
hoo added a subscriber: hoo. hoo closed this task as Declined. hoo claimed this task. hoo added a comment. No longer needed after https://phabricator.wikimedia.org/T95685 TASK DETAIL https://phabricator.wikimedia.org/T70377 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Unblock] T58712: Update entity_per_page table so it does not have a numeric entity id

2015-08-06 Thread hoo
hoo closed blocking task T70377: Write migration script for schema changes to entity_per_page table as Declined. Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T58712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Declined] T58712: Update entity_per_page table so it does not have a numeric entity id

2015-08-06 Thread hoo
hoo added a subscriber: hoo. hoo closed this task as Declined. hoo claimed this task. hoo added a comment. No longer needed after https://phabricator.wikimedia.org/T95685 TASK DETAIL https://phabricator.wikimedia.org/T58712 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Closed] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread JanZerebecki
JanZerebecki closed this task as Resolved. JanZerebecki added a project: Wikidata-Sprint-2015-06-30. TASK DETAIL https://phabricator.wikimedia.org/T108252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, Sjoerddebruin,

[Wikidata-bugs] [Maniphest] [Changed Project Column] T104876: wbparsevalue should use datatype to identify parser

2015-08-06 Thread JanZerebecki
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T104876 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T108252: EntityAccessor::getEntity should fail gracefully on double redirects

2015-08-06 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 229992 had a related patch set uploaded (by Hoo man): Fail gracefully when hitting double redirects in client DataAccess https://gerrit.wikimedia.org/r/229992 TASK DETAIL https://phabricator.wikimedia.org/T108252

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T96579: EPIC: Deploy Wikidata Query 0.1 Release in labs as official service

2015-08-06 Thread Liuxinyu970226
Liuxinyu970226 removed a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T96579 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Deskana, Liuxinyu970226 Cc: Daniel_Mietchen, -jem-, phuedx, JKatzWMF, Deskana, ksmith,

[Wikidata-bugs] [Maniphest] [Commented On] T77925: Wikidata PageBanner extension

2015-08-06 Thread Jdlrobson
Jdlrobson added a comment. @NiharikaKohli we're looking to get this deployed on Wikivoyage.org next week. Potentially this could be a good project to feature in your post. @sumit has done a great job, and hopefully the deploy will go well without too many hiccups and there will be a happy

[Wikidata-bugs] [Maniphest] [Commented On] T95685: Drop wb_entity_per_page table

2015-08-06 Thread hoo
hoo added a comment. I looked at this a bit today and this is quite doable, except for a few things which are really awry (eg fix `EntityPerPageTable::getEntitiesWithoutTerm` is not going to be super nice). We should start by (step by step) removing the usages of the table, announce that the

[Wikidata-bugs] [Maniphest] [Commented On] T74907: move git repositories that are dependencies of wikidata to gerrit

2015-08-06 Thread JanZerebecki
JanZerebecki added a comment. In https://phabricator.wikimedia.org/T74907#1483021, @Tpt wrote: But I believe that if we move some of these libs out of GitHub we will maybe miss contributions of external users that may use this libs for other use cases than Wikibase itself and that may be

[Wikidata-bugs] [Maniphest] [Updated] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity

2015-08-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T106192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Lydia_Pintscher, Aklapper, Wikidata-bugs, aude, Malyacko

[Wikidata-bugs] [Maniphest] [Commented On] T106192: {{#property:…}} parser function should only increase the parser's restricted function limit once per entity

2015-08-06 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 230015 had a related patch set uploaded (by Hoo man): Only increase the expensive parser function count once per entity https://gerrit.wikimedia.org/r/230015 TASK DETAIL https://phabricator.wikimedia.org/T106192

[Wikidata-bugs] [Maniphest] [Commented On] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined

2015-08-06 Thread hoo
hoo added a subscriber: hoo. hoo added a comment. Maybe we should just remove the spinner? It's a left over from back when we were basically re-building the whole DOM in JS. I don't think it serves much of a purpose now. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined

2015-08-06 Thread Jonas
Jonas added a subscriber: Lydia_Pintscher. Jonas set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Lydia_Pintscher, hoo, gerritbot, thiemowmde, Jonas, Aklapper,

[Wikidata-bugs] [Maniphest] [Closed] T72127: Error messages for Special:GoToLinkedPage when requested target doesn't exist

2015-08-06 Thread Jonas
Jonas closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T72127 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: gerritbot, Jonas, Aklapper, Legoktm, Wikidata-bugs, Bene, -jem-, JanZerebecki, Qgil, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T72127: Error messages for Special:GoToLinkedPage when requested target doesn't exist

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 228810 merged by jenkins-bot: Error message for Special:GoToLinkedPage https://gerrit.wikimedia.org/r/228810 TASK DETAIL https://phabricator.wikimedia.org/T72127 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

2015-08-06 Thread brion
brion added a comment. But yeah that code'll have to run on both. Feel free to ping me for review etc TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brion Cc: brion, gerritbot, Jdlrobson,

[Wikidata-bugs] [Maniphest] [Closed] T103907: Develop external hardening rules for WDQS

2015-08-06 Thread Smalyshev
Smalyshev closed this task as Resolved. Smalyshev claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T103907 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: gerritbot, Lydia_Pintscher, Ricordisamoa, Smalyshev, Aklapper,

[Wikidata-bugs] [Maniphest] [Unblock] T85159: [EPIC] Deploy a Wikidata Query Service into production

2015-08-06 Thread Smalyshev
Smalyshev closed blocking task T103907: Develop external hardening rules for WDQS as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T85159 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Addshore, Laddo, bd808, MBlissett,

[Wikidata-bugs] [Maniphest] [Unblock] T96579: EPIC: Deploy Wikidata Query 0.1 Release in labs as official service

2015-08-06 Thread Deskana
Deskana closed blocking task T102312: Figure out monitoring/alerting setup for labs as Declined. TASK DETAIL https://phabricator.wikimedia.org/T96579 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Deskana Cc: Daniel_Mietchen, -jem-, Liuxinyu970226,

[Wikidata-bugs] [Maniphest] [Commented On] T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive

2015-08-06 Thread daniel
daniel added a comment. With Change 225474 merged, we now report the number of entities loaded, but the limit we impose is INT_MAX. I suppose this should remain open until we have a configurable limited implemented and a good default defined. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

2015-08-06 Thread brion
brion added a comment. If http://caniuse.com/#feat=srcset is to be believed, the main problem browser on mobile is going to be Safari on iOS 8, since it supports native srcset but only for density switching, not for the size specifications. So if you use a customized polyfill, you can't rely

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

2015-08-06 Thread Jdlrobson
Jdlrobson added a comment. This is desktop AND mobile so the impact is a little greater.. :-/ TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: brion, gerritbot, Jdlrobson, Sumit,

[Wikidata-bugs] [Maniphest] [Closed] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined

2015-08-06 Thread Jonas
Jonas closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Lydia_Pintscher, hoo, gerritbot, thiemowmde, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp

[Wikidata-bugs] [Maniphest] [Commented On] T105638: RFC: Streamlining Composer usage

2015-08-06 Thread csteipp
csteipp added a comment. 1 2 are probably related, so I'll add some comment here. Happy to move to another forum if needed. The threats I've seen laid out, and my (very rough) evaluation of their risk. Happy to be corrected if it seems like I have assumptions that are wrong, or you disagree

[Wikidata-bugs] [Maniphest] [Created] T108214: Remove margin-top from .wpb-topbanner in mobile skin

2015-08-06 Thread Jdlrobson
Jdlrobson created this task. Jdlrobson added a subscriber: Jdlrobson. Jdlrobson added a project: Wikidata-Page-Banner. Jdlrobson moved this task to July 19-August 10 on the Wikidata-Page-Banner workboard. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION

[Wikidata-bugs] [Maniphest] [Commented On] T93885: Implement a limit for entities accessed via arbitrary access features and mark as expensive

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 225474 merged by jenkins-bot: Introduce a RestrictedEntityLookup for client DataAccess https://gerrit.wikimedia.org/r/225474 TASK DETAIL https://phabricator.wikimedia.org/T93885 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T96029: Special:ItemByTitle does not show an error for invalid site id

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 229129 merged by jenkins-bot: Special:ItemByTitle error messages https://gerrit.wikimedia.org/r/229129 TASK DETAIL https://phabricator.wikimedia.org/T96029 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot

[Wikidata-bugs] [Maniphest] [Changed Project Column] T102312: Figure out monitoring/alerting setup for labs

2015-08-06 Thread Smalyshev
Smalyshev moved this task to Done on the Discovery-Wikidata-Query-Service-Sprint workboard. TASK DETAIL https://phabricator.wikimedia.org/T102312 WORKBOARD https://phabricator.wikimedia.org/project/board/1239/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T108003: wb-entity-spinner: Uncaught ReferenceError: $ is not defined

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 229680 merged by jenkins-bot: Moves entity spinner to entityViewinit https://gerrit.wikimedia.org/r/229680 TASK DETAIL https://phabricator.wikimedia.org/T108003 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Declined] T102312: Figure out monitoring/alerting setup for labs

2015-08-06 Thread Deskana
Deskana closed this task as Declined. Deskana claimed this task. Deskana added a comment. I'm declining this, since we're focussing on getting the service into production instead. TASK DETAIL https://phabricator.wikimedia.org/T102312 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread hoo
hoo added a comment. I poked at this some more and iterated over all changes currently in the DB using very similar code to what we use in Wikibase and the change ids mentioned above are the only ones failing. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T50684: Wikidata's Watchlist in wikipedia are like read Watchlist

2015-08-06 Thread MGChecker
MGChecker added a subscriber: MGChecker. Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T50684 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MGChecker Cc: Aklapper, MGChecker, Wikidata-bugs, thiemowmde, Yamaha5,

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

2015-08-06 Thread Jdlrobson
Jdlrobson added a comment. Thanks @brion for the quick response! You read correctly. Right now we're using srcset attribute to serve the best sized banner depending on the user's current browser window. The plan is to point the src attribute to the lowest res image but we're keen to use a

[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread hoo
hoo added a comment. In https://phabricator.wikimedia.org/T108130#1514967, @JanZerebecki wrote: Perhaps make it LONGBLOB so that it can hold more than the entity that is stored in a MEDIUMBLOB. Mh... maybe. Also, do we need to resize the rc_params field as well? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Changed Project Column] T103907: Develop external hardening rules for WDQS

2015-08-06 Thread Smalyshev
Smalyshev moved this task to Done on the Discovery-Wikidata-Query-Service-Sprint workboard. TASK DETAIL https://phabricator.wikimedia.org/T103907 WORKBOARD https://phabricator.wikimedia.org/project/board/1239/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T108207: Allow editors to define links to topics an icon refers to

2015-08-06 Thread Sumit
Sumit created this task. Sumit added subscribers: Sumit, Jdlrobson. Sumit added a project: Wikidata-Page-Banner. Sumit moved this task to June 26-July 18 on the Wikidata-Page-Banner workboard. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION Allow defining

[Wikidata-bugs] [Maniphest] [Commented On] T108207: Allow editors to define links to topics an icon refers to

2015-08-06 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 229759 had a related patch set uploaded (by Sumit): WikidataPageBanner add link to icons https://gerrit.wikimedia.org/r/229759 TASK DETAIL https://phabricator.wikimedia.org/T108207 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T108207: Allow editors to define links to topics an icon refers to

2015-08-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108207 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Jdlrobson, Sumit, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko,

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

2015-08-06 Thread brion
brion added a comment. Well, desktop isn't as big a worry since high-res screen usually means large screen (and you'll usually max out at 2, rather than the 3 that some phones like the iPhone 6plus reach)... :) So it should be safe there to load the 1x and then polyfill-load the

[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread gerritbot
gerritbot added a comment. Change 229741 merged by jenkins-bot: Log when we fail unserializeInfo https://gerrit.wikimedia.org/r/229741 TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T72209: Create a special page to query for badges

2015-08-06 Thread Jonas
Jonas added a subscriber: Jonas. Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T72209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, Jonas Cc: Jonas, Aklapper, Kopiersperre, jayvdb, Opraco, putnik,

[Wikidata-bugs] [Maniphest] [Merged] T107776: Error on saving change of label and description, violation of constraint

2015-08-06 Thread matej_suchanek
matej_suchanek closed this task as a duplicate of T106456: Editing label and description simultaneously conflicts with existing items which have the new label and old description. TASK DETAIL https://phabricator.wikimedia.org/T107776 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T104806: hideanons=1 on Special:recentchanges hides all wikidata changes including edits done by registered users on wikidata

2015-08-06 Thread matej_suchanek
matej_suchanek added a blocked task: T90435: Wikidata watchlist integration (tracking). TASK DETAIL https://phabricator.wikimedia.org/T104806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Merl, Aklapper, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Updated] T90435: Wikidata watchlist integration (tracking)

2015-08-06 Thread matej_suchanek
matej_suchanek added a blocking task: T104806: hideanons=1 on Special:recentchanges hides all wikidata changes including edits done by registered users on wikidata. TASK DETAIL https://phabricator.wikimedia.org/T90435 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T104806: hideanons=1 on Special:recentchanges hides all wikidata changes including edits done by registered users on wikidata

2015-08-06 Thread MGChecker
MGChecker added a subscriber: MGChecker. TASK DETAIL https://phabricator.wikimedia.org/T104806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MGChecker Cc: MGChecker, Merl, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp

[Wikidata-bugs] [Maniphest] [Updated] T105456: Deal with 'anchored' labels

2015-08-06 Thread matej_suchanek
matej_suchanek added a project: Wikidata.org. TASK DETAIL https://phabricator.wikimedia.org/T105456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, matej_suchanek Cc: Ladsgroup, matej_suchanek, Aklapper, Wikidata-bugs, aude, Malyacko,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T106456: Editing label and description simultaneously conflicts with existing items which have the new label and old description

2015-08-06 Thread matej_suchanek
matej_suchanek added subscribers: Addshore, jeblad. matej_suchanek merged a task: T107776: Error on saving change of label and description, violation of constraint. TASK DETAIL https://phabricator.wikimedia.org/T106456 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T106456: Editing label and description simultaneously conflicts with existing items which have the new label and old description

2015-08-06 Thread matej_suchanek
matej_suchanek added a project: MediaWiki-extensions-WikibaseRepository. matej_suchanek set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T106456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: jeblad, Addshore,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T101950: Goal: Establish a framework to engage with data engineers and open data organizations

2015-08-06 Thread DarTar
DarTar added a subscriber: Daniel_Mietchen. TASK DETAIL https://phabricator.wikimedia.org/T101950 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil, DarTar Cc: Daniel_Mietchen, ezachte, Rogol_Domedonfors, Ilario, Ricordisamoa, Hjfocs, Jane023,

[Wikidata-bugs] [Maniphest] [Commented On] T90115: BlazeGraph Security Review

2015-08-06 Thread Smalyshev
Smalyshev added a comment. Limit memory usage of queries yes Limit maximum duration of queries yes Parsing the AST of the query to filter malicious queries No. We have a capability of doing AST filter (we actually have one already implementing label service) but we don't have any

[Wikidata-bugs] [Maniphest] [Updated] T77925: Wikidata PageBanner extension

2015-08-06 Thread NiharikaKohli
NiharikaKohli added a comment. Hello! End of GSoC is fast approaching. 17 August is Suggested pencils down deadline and 21 August is Firm pencils down deadline. It is expected that you don't dive into new features which might take longer than two weeks to complete and instead work on

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T107709: Disable Collection generation for non-wikitext content models

2015-08-06 Thread MGChecker
MGChecker added a subscriber: MGChecker. TASK DETAIL https://phabricator.wikimedia.org/T107709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MGChecker Cc: MGChecker, Addshore, cscott, hoo, Krenair, Aklapper, Matanya, Raymond, Wikidata-bugs, aude,

[Wikidata-bugs] [Maniphest] [Commented On] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread JanZerebecki
JanZerebecki added a comment. [wikidatawiki] select length(change_info) from wb_changes where change_id in (236998945, 236999268, 237059314, 237059627) ; +-+ | length(change_info) | +-+ | 65535 | | 65535 | |

[Wikidata-bugs] [Maniphest] [Updated] T108130: Warning: array_key_exists() expects parameter 2 to be array, null given in the change dispatcher

2015-08-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T108130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Addshore, daniel, JanZerebecki, Aklapper, hoo, Wikidata-bugs, aude, Malyacko,

[Wikidata-bugs] [Maniphest] [Commented On] T103070: find extensions using code directly from Wikibase and provide mechanism with a stable interface

2015-08-06 Thread JanZerebecki
JanZerebecki added a comment. What from that sentence is it that you don't understand? Do you have a question? This task is about people using code from Wikidata.git or mediawiki/vendor.git inapropriately: 1. People using a package private interface (e.g. something from Wikibase.git), then we

  1   2   >