[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment.
https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js=606565642




In T107693#3825336, @Sjoerddebruin wrote:
Great so far! Is it possible to use OOjs UI for the popup though? We are slowly transforming our current gadgets to it. The form will automatically look correct as well then.


Updated with OOjs UI :D




In T107693#3825793, @Mvolz wrote:
Also it would be nice if there was some indication that you can click on the no results found link - like making a "create new item" link and have it be underlined, so people know it's clickable.


Added :)




In T107693#3825793, @Mvolz wrote:
But I'm getting an error when trying to create an item from the pop-up

"[Wiws9wpAME0AABYAle0AAABL] 2017-12-09 18:35:51: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"


That's weird. I tested again and created entity successfully.TASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricordisamoa, matej_suchanek, Aklapper, Mvolz, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Jayprakash12345, QZanden, srishakatux, dachary, Beeyan, Pahadiahimanshu, Manrajsinghgrover, Keer25, MtDu, D3r1ck01, RexxS, Wikidata-bugs, aude, jayvdb, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T102888: [Bug] Recent changes pages doesn't have anymore the interlingual wikilinks on the sidebar on some projects

2017-12-09 Thread Izno
Izno added a comment.
This task is either a duplicate of T172461: Special:RecentChanges no longer displays interwiki links on wikis that have added them to MediaWiki:Recentchangestext or T123063: Special pages should link to all languages in a project..

I would suggest merging it in to one of those two.TASK DETAILhttps://phabricator.wikimedia.org/T102888EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: IznoCc: Izno, Trizek-WMF, Liuxinyu970226, PokestarFan, Palnatoke, Elitre, zhuyifei1999, He7d3r, MZMcBride, liangent, XXN, Bene, aude, Mbch331, hoo, Lydia_Pintscher, Ricordisamoa, Alex_brollo, Accurimbono, Candalua, Andyrom75, Aklapper, Lahi, Gq86, Lsherwinforone, GoranSMilovanovic, Jrbranaa, QZanden, Ptolusque, Sethakill, Wong128hk, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T182505: Error while editing Q2718734

2017-12-09 Thread Sjoerddebruin
Sjoerddebruin added subscribers: Legoktm, Sjoerddebruin.Sjoerddebruin added a comment.
According to @Legoktm "Lock wait timeout exceeded; try restarting transaction". mw1279 seems to have some issues.TASK DETAILhttps://phabricator.wikimedia.org/T182505EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Sjoerddebruin, Legoktm, Aklapper, Epidosis, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T182505: Error while editing Q2718734

2017-12-09 Thread Epidosis
Epidosis created this task.Epidosis added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONI unsuccessfully tried to edit https://www.wikidata.org/wiki/Q2718734. The result was: [WixEfApAIC8AAIGm95gK] 2017-12-09 20:16:12: Errore irreversibile di tipo "Wikimedia\Rdbms\DBQueryError"TASK DETAILhttps://phabricator.wikimedia.org/T182505EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EpidosisCc: Aklapper, Epidosis, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread Mvolz
Mvolz added a comment.



In T107693#3825308, @eflyjason wrote:
https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js=606396356 the popup is working too :D


Nice!

But I'm getting an error when trying to create an item from the pop-up

"[Wiws9wpAME0AABYAle0AAABL] 2017-12-09 18:35:51: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Also it would be nice if there was some indication that you can click on the no results found link - like making a "create new item" link and have it be underlined, so people know it's clickable.

I don't want feature creep on this, honestly having the pop-up at all is great (even if it isn't OOUI) - it *is* supposed to be a small task!TASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MvolzCc: eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricordisamoa, matej_suchanek, Aklapper, Mvolz, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Jayprakash12345, QZanden, srishakatux, dachary, Beeyan, Pahadiahimanshu, Manrajsinghgrover, Keer25, MtDu, D3r1ck01, RexxS, Wikidata-bugs, aude, jayvdb, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T182322: ChronologyProtector breaks if two requests write different sets of databases

2017-12-09 Thread Envlh
Envlh added a comment.
As a user, it's back to normal for me. Thanks !TASK DETAILhttps://phabricator.wikimedia.org/T182322EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, EnvlhCc: Darwinius, Aklapper, Lea_Lacroix_WMDE, Addshore, Ladsgroup, Joe, Trizek-WMF, jhsoby, Envlh, Framawiki, daniel, hoo, Simon_Villeneuve, Manu1400, MisterSynergy, Fnielsen, Jay8g, TerraCodes, aude, aaron, Krinkle, Jonas, thiemowmde, Lucas_Werkmeister_WMDE, Steinsplitter, Anvilaquarius, Anomalocaris, Sjoerddebruin, Imarlier, GerritBot, MusikAnimal, Lahi, Gq86, Baloch007, Dfil7, Lordiis, Icedevil, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Johan, Volker_E, Luke081515, Wikidata-bugs, GWicke, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread Sjoerddebruin
Sjoerddebruin added a comment.
Great so far! Is it possible to use OOjs UI for the popup though? We are slowly transforming our current gadgets to it. The form will automatically look correct as well then.TASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricordisamoa, matej_suchanek, Aklapper, Mvolz, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Jayprakash12345, QZanden, srishakatux, dachary, Beeyan, Pahadiahimanshu, Manrajsinghgrover, Keer25, MtDu, D3r1ck01, RexxS, Wikidata-bugs, aude, jayvdb, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment.
https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js=606396356 the popup is working too :DTASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricordisamoa, matej_suchanek, Aklapper, Mvolz, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Jayprakash12345, QZanden, srishakatux, dachary, Beeyan, Pahadiahimanshu, Manrajsinghgrover, Keer25, MtDu, D3r1ck01, RexxS, Wikidata-bugs, aude, jayvdb, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment.
https://www.wikidata.org/wiki/User:Eflyjason/Gadget-CreateNewItem.js

var currentFieldText = "";
$(document).on('input propertychange paste', ".ui-suggester-input", function() {
	currentFieldText = $(this).val();
	//console.log("Entering: "+currentFieldText);
});
$(document).on('DOMSubtreeModified', ".ui-entityselector-list",function(){
	var firstLi = $(this).find("li").first();
	var isNotFound = firstLi.hasClass('ui-entityselector-notfound');
	console.log('Current Text Field content: '+currentFieldText+". Not found: "+isNotFound);
	if(isNotFound){
		var innerA = firstLi.find("a").first();
		innerA.attr("href", "https://www.wikidata.org/wiki/Special:NewItem?label="+currentFieldText).attr("target", "_blank");
	}
});

The basic feature should be working right now :D (though I'm not sure if it's the best approach?)

I will optimize it and make it into a popup later :DTASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricordisamoa, matej_suchanek, Aklapper, Mvolz, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Jayprakash12345, QZanden, srishakatux, dachary, Beeyan, Pahadiahimanshu, Manrajsinghgrover, Keer25, MtDu, D3r1ck01, RexxS, Wikidata-bugs, aude, jayvdb, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread Mvolz
Mvolz added a comment.
You should be able to traverse the DOM with JS to insert it directly into
the menu. Try inspecting the element using your browser's debugger to see
where that would be.

I guess the hard part is when the script should be triggered; maybe on
typing in the box? And check every time to see if the list has no results
and then replace it?

(If nothing I'm typing is making sense please ask for clarification :))TASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MvolzCc: eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricordisamoa, matej_suchanek, Aklapper, Mvolz, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Jayprakash12345, QZanden, srishakatux, dachary, Beeyan, Pahadiahimanshu, Manrajsinghgrover, Keer25, MtDu, D3r1ck01, RexxS, Wikidata-bugs, aude, jayvdb, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment.
I guess that this gadget will have to override _initMenu function in jquery.wikibase.entityselector.js and replace the null with the open new URL function?

customItems.unshift( new $.ui.ooMenu.CustomItem(
this.options.messages.notfound,
function () {
  return self._cache.suggestions && !self._cache.suggestions.length
&& self.element.val().trim() !== '';
},
null,
'ui-entityselector-notfound'
  ) );

But I can't find how to do this with user script. Or is there any other easier method?TASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: eflyjason, Ladsgroup, Liuxinyu970226, PokestarFan, Lydia_Pintscher, ChristianKl, Sjoerddebruin, daniel, Ricordisamoa, matej_suchanek, Aklapper, Mvolz, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Jayprakash12345, QZanden, srishakatux, dachary, Beeyan, Pahadiahimanshu, Manrajsinghgrover, Keer25, MtDu, D3r1ck01, RexxS, Wikidata-bugs, aude, jayvdb, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T166216: Imagegrid should lazy load

2017-12-09 Thread D3r1ck01
D3r1ck01 removed a project: Africa-Wikimedia-Developers.D3r1ck01 added a comment.
Removing #africa-wikimedia-developers tag as task is put up for #google-code-in-2017.TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: D3r1ck01, Jan_Dittrich, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Florian, rosalieper, PokestarFan, Aklapper, Jonas, TerraCodes, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, EBjune, Zoranzoki21, merbst, Beeyan, Avner, MtDu, Gehel, JGirault, FloNight, Xmlizer, MuhammadShuaib, RexxS, SimmeD, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, jayvdb, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unassigned] T99358: [Task] Security review of Wikibase-Quality-External-Validation branch master

2017-12-09 Thread Aklapper
Aklapper removed csteipp as the assignee of this task.Aklapper lowered the priority of this task from "High" to "Low".Aklapper removed a project: Patch-For-Review.Aklapper added a comment.
Lowering priority per last comment by Lydia; resetting assignee.TASK DETAILhttps://phabricator.wikimedia.org/T99358EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: dpatrick, Lydia_Pintscher, gerritbot, soeren.oldag, JanZerebecki, Jonaskeutel, Tamslo, csteipp, Andreasburmeister, Liuxinyu970226, Aklapper, Wikibase-Quality-External-Validation, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Scott_WUaS, Luke081515, abian, Wikidata-bugs, aude, Bawolff, Mbch331, Jay8g, Krenair, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T182494: DuplicateReferences: "selectedReference is not defined"

2017-12-09 Thread matej_suchanek
matej_suchanek created this task.matej_suchanek added projects: Wikidata, Wikidata-Gadgets.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONThe fix is (said to be) available at https://www.wikidata.org/w/index.php?oldid=603354382 (diff) but needs to be reviewed.TASK DETAILhttps://phabricator.wikimedia.org/T182494EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T89552: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs

2017-12-09 Thread Multichill
Multichill closed this task as "Resolved".Multichill claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T89552EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: Swiss-National-Library, BeatEstermann, PokestarFan, Astinson, SandraF_WMF, Pyb, Spinster, Jane023, Puik, Shonagon, Jdforrester-WMF, Sumit, GAllegre, brion, Regisrob, Fae, Klokantech, Pietromarialiuzzo, Nemo_bis, Matanya, Marsupium, Husky, Jheald, Tgr, Bawolff, Gilles, dschwen, Aklapper, Multichill, Lahi, PDrouin-WMF, Gq86, E1presidente, Waytogoeducation, Ramsey-WMF, GoranSMilovanovic, QZanden, srishakatux, Acer, V4switch, Pahadiahimanshu, Manrajsinghgrover, Keer25, Susannaanas, Wong128hk, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T173346: IIIF and Structured Data on Wikimedia Commons discussion

2017-12-09 Thread Multichill
Multichill closed subtask T89552: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T173346EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SandraF_WMF, MultichillCc: Swiss-National-Library, BeatEstermann, YULdigitalpreservation, brion, Sadads, Abit, SandraF_WMF, Aklapper, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, GoranSMilovanovic, Ivana_Isadora, QZanden, Acer, Jseddon, FloNight, Trizek-WMF, Susannaanas, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan, Elitre, Qgil___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs