[Wikidata-bugs] [Maniphest] [Commented On] T126597: [Task] Move WikibaseDataModel to Gerrit

2018-01-24 Thread demon
demon added a comment.
@Addshore: thoughts, especially in light of all the work we did to clean up the build process?TASK DETAILhttps://phabricator.wikimedia.org/T126597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: demonCc: demon, Jonas, hoo, Dereckson, Lydia_Pintscher, MZMcBride, aude, JanZerebecki, JeroenDeDauw, Legoktm, GPHemsley, Tobi_WMDE_SW, adrianheine, daniel, thiemowmde, Aklapper, mmodell, chasemp, Ricordisamoa, Liuxinyu970226, Addshore, Bene, Lazowik, Tpt, Krenair, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, jayvdb, Paladox, Mbch331, Jay8g, QChris, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

2018-01-24 Thread Krinkle
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONChecking the format constraint on a SPARQL query service### Problem

Wikidata validates each newly stored statement against the constraints from the associated property. The properties themselves are user-generated and one of the possible for text values is a regex pattern.

Due to the impact of potentially malicious regexes, the MediaWiki PHP backend for Wikidata does //not// use PHP's `preg_match`. Instead, we need to isolate this in some way.

The current workaround uses the SPARQL query service, which incurs a lot of overhead (ping, TCP, HTTP, SPARQL parsing, query engine preparation), which results in bad timing of the format constraint even for benign regexes. We should investigate whether we can check regexes more locally. However, the mechanism should be tightly restricted in order to avoid denial-of-service attacks via malicious regexesWe can’t directly uses Lua’s regexes because their syntax is too different from PCRE, and implementig a PCRE-compatible engine in Lua is probably too much work. I’m not familiar enough with firejail to comment on that option.

### Solutions

* Lua (via PHP binding?)
* PHP program called as sub process within a Firejail.
* re2 (), either via a microservice, or via PHP binding.
* ...TASK DETAILhttps://phabricator.wikimedia.org/T176312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Halfak, Anomie, Smalyshev, tstarling, daniel, GWicke, Joe, Lucas_Werkmeister_WMDE, Krinkle, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, SBisson, Wikidata-bugs, aude, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178079: Implement a (conservative) usage aspect deduplicater (days: 4)

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 405896 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rearrange UsageDeduplicator implementation

https://gerrit.wikimedia.org/r/405896TASK DETAILhttps://phabricator.wikimedia.org/T178079EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Ladsgroup, eranroz, daniel, Lydia_Pintscher, aude, Aklapper, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T182394: java.lang.IllegalStateException: RDF store reports the last update time is before the minimum safe poll time.

2018-01-24 Thread Smalyshev
Smalyshev added a comment.
Ok, got it. I've added property wikibaseMaxDaysBack to set the maximum timeframe.TASK DETAILhttps://phabricator.wikimedia.org/T182394EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Smalyshev, Addshore, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, Abbe98, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T179239: Make shorter timeout for Wikibase fetches

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 405825 merged by jenkins-bot:
[wikidata/query/rdf@master] Add timeout to Wikibase requests

https://gerrit.wikimedia.org/r/405825TASK DETAILhttps://phabricator.wikimedia.org/T179239EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hoo, Aklapper, Gehel, Smalyshev, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T137810: [Task] Add monolingual language code mn-Mong

2018-01-24 Thread Badaa
Badaa added a comment.
Hi,
Thanks Gerard M.
I just read the Terms and definitions of ISO 639-3. 
There are following sentences in paragraph 4.2.2 Individual languages:

There is no one definition of “language” that is agreed upon by all and appropriate for all purposes. As a result, 
 there can be disagreement, even among speakers or linguistic experts, as to whether two varieties represent 
 dialects of a single language or two distinct languages. For this part of ISO 639, judgements regarding when 
 two  varieties  are  considered  to  be  the  same  or  different  languages  are  based  on  a  number  of  factors,  
 including  linguistic  similarity,  intelligibility,  a  common  literature,  the  views  of  speakers  concerning  the  
 relationship between language and identity, and other factors. The following basic criteria are followed.


Two related varieties are normally considered varieties of the same language if speakers of each variety have  inherent  understanding  of  the  other  variety  (that  is,  can  understand  based  on  knowledge  of  their own variety without needing to learn the other variety) at a functional level.
Where  spoken  intelligibility  between  varieties  is  marginal,  the  existence  of  a  common  literature  or  of  a common  ethnolinguistic  identity  with  a  central  variety  that  both  understand  can  be  strong  indicators  that they should nevertheless be considered varieties of the same language.
Where  there  is  enough  intelligibility  between  varieties  to  enable  communication,  the  existence  of  well- established,  distinct  ethnolinguistic  identities  can  be  a  strong  indicator  that  they  should  nevertheless  be considered to be different languages.


and under 4.2.4Dialects

The  linguistic  varieties  denoted  by  each  of  the  identifiers  in  this  part  of  ISO  639  are  assumed  to  be  distinct  languages  and  not  dialects  of  some  language,  even  though  for  some  purposes  some  users  may  consider  a  variety  listed  in  this  part  of  ISO  639  to  be  a  “dialect”  rather  than  a  “language”. In  this  standard,  the  term  dialect refers  to  any  sub-variety  of  a  language  such  as  might  be  based  on  geographic  region, age, gender, social class, time period, or the like.

From these definitions, I would conclude Mongolian is an individual language rather than macro language. After all, it is correct my first assumption in previous comment. But I tend to think, to change/fix such an aged standard is almost impossible or?
Thus, I read furthermore ISO 639-3, there are following:

The dialects of a language are included within the denotation represented by the identifier for that language. Thus,  each  language  identifier  represents  the  complete  range  of  all  the  spoken  or  written  varieties  of  that  language, including any standardized form. 
 For  applications  in  which  it  is  necessary  to  identify  dialects,  a  separate  standard  may  be  developed  that provides  identifiers  for  dialects,  or  that  combines  identifiers  from  this  or  other  parts  of  ISO  639  with  other distinguishing identificational qualifiers. See 4.7 for further discussion. 
 ...
 4.7Scriptsandregions
 Some  languages  are  written  in  different  scripts  by  different  user  communities.  A  single  language  identifier  is provided  for  a  language  in  this  part  of  ISO  639  even  though  the  language  may  be  written  in  more  than  one script.  For  applications  in  which  it  is  necessary  to  identify  distinct  writing  systems  of  a  single  language,  a  separate standard may be developed that combines identifiers from this or other parts of ISO 639 with script identifiers from ISO 15924. 
 ...

In ISO 15924, Mongolian script is defined as Mong (145) see: https://en.wikipedia.org/wiki/ISO_15924 
I also recognized that at least Firefox and Chrome (webkits) implemented the the lang attributes of "mn-Mong" for html tag. If I declare , then I see correct scrolling behavior for vertical layout.
Thus, we need to add the script code mn-Mong.
thanks,TASK DETAILhttps://phabricator.wikimedia.org/T137810EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BadaaCc: Badaa, ChristianKl, C933103, jhsoby, thiemowmde, Liuxinyu970226, Lydia_Pintscher, GerardM, Aklapper, Zppix, Popolon, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T182424: Diffs for statements, grammatical features and representations of a form (M) (days: 9)

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 403963 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move path array prepending logic to ClaimDifferenceVisualizer

https://gerrit.wikimedia.org/r/403963TASK DETAILhttps://phabricator.wikimedia.org/T182424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: thiemowmde, gerritbot, Ladsgroup, Aklapper, Lydia_Pintscher, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183373: Refactor and split up CheckConstraints::newFromGlobalState

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 406050 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Split up and test CheckConstraints::newFromGlobalState

https://gerrit.wikimedia.org/r/406050TASK DETAILhttps://phabricator.wikimedia.org/T183373EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T183373: Refactor and split up CheckConstraints::newFromGlobalState

2018-01-24 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T183373EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T175565: Check “difference within range” constraints on qualifiers and references (days: 3)

2018-01-24 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).
TASK DETAILhttps://phabricator.wikimedia.org/T175565EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, ReleaseTaggerBotCc: gerritbot, Aklapper, Lydia_Pintscher, Ivan_A_Krestinin, abian, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T145458: Editing a file annotation requires very careful mouse movement

2018-01-24 Thread cscott
cscott added a comment.
See also the UX mockup at https://phabricator.wikimedia.org/T146397#3241037TASK DETAILhttps://phabricator.wikimedia.org/T145458EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cscottCc: MarkTraceur, Prtksxna, cscott, gerritbot, Matanya, matmarex, Aklapper, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Bawolff, Ricordisamoa, brion, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T168532: Check constraints on qualifiers and references

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T175565: Check “difference within range” constraints on qualifiers and references (days: 3) as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T168532EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: abian, Ivan_A_Krestinin, gerritbot, PokestarFan, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T175565: Check “difference within range” constraints on qualifiers and references (days: 3)

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-01-17 board.
TASK DETAILhttps://phabricator.wikimedia.org/T175565WORKBOARDhttps://phabricator.wikimedia.org/project/board/3207/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lydia_Pintscher, Ivan_A_Krestinin, abian, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T175565: Check “difference within range” constraints on qualifiers and references (days: 3)

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 405293 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Check “difference within range” on qualifiers and references

https://gerrit.wikimedia.org/r/405293TASK DETAILhttps://phabricator.wikimedia.org/T175565EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Aklapper, Lydia_Pintscher, Ivan_A_Krestinin, abian, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T185313: mw.wikibase.entity:getBacklinks (lua API in wikibase client)

2018-01-24 Thread matej_suchanek
matej_suchanek added a parent task: T112073: Lua in Wikibase (tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T185313EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Uzume, Aklapper, Ghuron, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T112073: Lua in Wikibase (tracking)

2018-01-24 Thread matej_suchanek
matej_suchanek added subtasks: T185313: mw.wikibase.entity:getBacklinks (lua API in wikibase client), T185557: Create the easy function mw.wikibase.property('P21', 'Q8023', 'en').
TASK DETAILhttps://phabricator.wikimedia.org/T112073EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: PokestarFan, Liuxinyu970226, Ricordisamoa, aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185576: Improve performance of the search service

2018-01-24 Thread Hjfocs
Hjfocs added a comment.
sed -n '${OFFSET},${LIMIT}'p ${QUICKSTATEMENT_DATASET} would actually do the job when no property and/or value are given!TASK DETAILhttps://phabricator.wikimedia.org/T185576EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Aklapper, Hjfocs, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185576: Improve performance of the search service

2018-01-24 Thread Hjfocs
Hjfocs added a comment.

no parameters given = slow: GRAPH ?g { ?s ?p ?o };
with dataset = slow, e.g., 31sec, 366ms: GRAPH <$dataset> { ?s ?p ?o};
with property = fast, e.g., 455ms GRAPH ?g { ?s $property ?o };
with value = slow: GRAPH ?g { ?s ?p ?o { SELECT ?o WHERE { ?o ?x $value} };
with property and value = slow
TASK DETAILhttps://phabricator.wikimedia.org/T185576EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Aklapper, Hjfocs, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, dachary, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Tpt, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T182394: java.lang.IllegalStateException: RDF store reports the last update time is before the minimum safe poll time.

2018-01-24 Thread Addshore
Addshore added a comment.

In T182394#3920889, @Smalyshev wrote:
This in combination with the ability to configure the amount of time recent changes hangs around

Not sure what you mean here?


So you said above that the limit that the updater uses for recent changes is 30 days, however this is configurable in mediawiki, so it would be great to have it configurable in the updater too / another option you can pass in.TASK DETAILhttps://phabricator.wikimedia.org/T182394EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Smalyshev, Addshore, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, Abbe98, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T178079: Implement a (conservative) usage aspect deduplicater (days: 4)

2018-01-24 Thread WMDE-leszek
WMDE-leszek renamed this task from "Implement a (conservative) usage aspect deduplicater (days: 3)" to "Implement a (conservative) usage aspect deduplicater (days: 4)".
TASK DETAILhttps://phabricator.wikimedia.org/T178079EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: gerritbot, Ladsgroup, eranroz, daniel, Lydia_Pintscher, aude, Aklapper, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T184702: Set the edit summary when editing the representation and/or grammatical features of the form (days: 3)

2018-01-24 Thread WMDE-leszek
WMDE-leszek renamed this task from "Set the edit summary when editing the representation and/or grammatical features of the form (days: 2)" to "Set the edit summary when editing the representation and/or grammatical features of the form (days: 3)".
TASK DETAILhttps://phabricator.wikimedia.org/T184702EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, daniel, Aklapper, Jonas, Lydia_Pintscher, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)

2018-01-24 Thread WMDE-leszek
WMDE-leszek renamed this task from "Wikibase must not insert local recentchanges entries for nonexistent local users (days: 4)" to "Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)".
TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 404715 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use InMemoryEntityLookup instead of JsonFileEntityLookup

https://gerrit.wikimedia.org/r/404715TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Jonas, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178079: Implement a (conservative) usage aspect deduplicater (days: 3)

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 405895 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix smaller mistakes in UsageDeduplicator

https://gerrit.wikimedia.org/r/405895TASK DETAILhttps://phabricator.wikimedia.org/T178079EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, Ladsgroup, eranroz, daniel, Lydia_Pintscher, aude, Aklapper, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T62097: no.wikisource language issue

2018-01-24 Thread Liuxinyu970226
Liuxinyu970226 added a comment.Herald added subscribers: jeblad, Danmichaelo, jhsoby.
Now the "language code no" is corrected to single norsk, so is there any other problems?TASK DETAILhttps://phabricator.wikimedia.org/T62097EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Liuxinyu970226Cc: jhsoby, Danmichaelo, jeblad, Liuxinyu970226, jayvdb, Aklapper, Amire80, siebrand, JanZerebecki, aude, matej_suchanek, Ricordisamoa, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Bodhisattwa, Samwilson, Wikidata-bugs, Shizhao, Billinghurst, Mbch331, jayantanth, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T137810: [Task] Add monolingual language code mn-Mong

2018-01-24 Thread GerardM
GerardM added a comment.
Hoi,
The defenitions are in the standard. The standard is the ISO639-3.
Thanks,

GerardMTASK DETAILhttps://phabricator.wikimedia.org/T137810EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GerardMCc: Badaa, ChristianKl, C933103, jhsoby, thiemowmde, Liuxinyu970226, Lydia_Pintscher, GerardM, Aklapper, Zppix, Popolon, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T185637: Request for custom nginx configuration, Wikidata primary sources tool VPS project

2018-01-24 Thread Hjfocs
Hjfocs created this task.Hjfocs added projects: Cloud-Services, cloud-services-team, Wikidata, Wikidata-primary-sources.Herald added a subscriber: Aklapper.
TASK DESCRIPTION
VPS project: https://tools.wmflabs.org/openstack-browser/project/wikidata-primary-sources-tool
Instance: https://tools.wmflabs.org/openstack-browser/server/pst.wikidata-primary-sources-tool.eqiad.wmflabs


The project Web services need to keep connections alive using the nginx upstream and keepalive directives: http://nginx.org/en/docs/http/ngx_http_upstream_module.html#keepalive
I tested the following nginx configuration on a third-party server, which seems to work just fine.


File: /etc/nginx/sites-enabled/pst
sample content:


upstream ka {
server localhost:; ###localhost must be replaced with the instance IP
keepalive 32;
}

server {

listen ###public IP here###;

location /pst/curate {
proxy_redirect off;
proxy_set_header Host $host;
proxy_set_header X-Real-IP  $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_pass_header Set-Cookie;
proxy_pass http://ka/pst/curate;
proxy_http_version 1.1;
proxy_set_header Connection "";
}
}


I've been digging for specific documentation on how to achieve this on VPS projects, with no success;
I also blindly tried to use the puppet class profile::dumps::web::nginx, with no success:
the class makes /etc/nginx available;
added /etc/nginx/sites-enabled/pstwith the above configuration;
replaced localhost with 10.68.22.221 (i.e., the instance IP);
sudo nginx -s reload.



Any guidance on this is super appreciated, and I'll gladly create a documentation page on wikitech afterwards.TASK DETAILhttps://phabricator.wikimedia.org/T185637EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Aklapper, Hjfocs, 1978Gage2001, Lahi, aborrero, Gq86, GoranSMilovanovic, Kiailandi, Chicocvenancio, QZanden, Tbscho, dachary, LawExplorer, JJMC89, Luke081515, Wikidata-bugs, aude, Gryllida, Ricordisamoa, Sjoerddebruin, Tpt, scfc, Mbch331, bd808, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T137810: [Task] Add monolingual language code mn-Mong

2018-01-24 Thread Badaa
Badaa added a comment.
Hi,
I am from Mongolia.
What are the definitions of a macro language and a language? 
If a language is a (mainly spoken) system to communicate among people then Mongolian is not macro language. Because, I can communicate without any problems with mongolian people in Inner Mongolia (now in China) and the Mongolians in Buriat (now in Russia) even easier than the communication among German in Bayern, in NRW or in Berlin.
If a language is a superordinate concept of scripts then Mongolian language has some totally different scripts like traditional (vertical Mongolian), Khalkh (Cyrillic), Buriat (Cyrillic), Halimag (known also as Kalmyk, Cyrillic and Latin) etc.
In Mongolia, the official script is Cyrillic since 1947 and tried to revert to Mongolian script. Everyone in Mongolia learns at school both scripts Mongolian script and Cyrillic since 1980 until now. "Mongolian Language law" has been adopted and is effective since July 1st of 2015. In this law, Mongolian script will be introduced in stages and state and local government is to conduct their correspondence in both Cyrillic and Mongolian script. This provision is to be effective starting January 1st of 2025.
In my opinion to disjoint too much is wrong way and exaggerated. The Mongolian is not macro language and could be very well handled like German. (de - German, de-AT - Austria, de-CH Switzerland)
mn (ᠮᠣᠩᠭᠣᠯ Mongolian vertical)
mn-MN (Монгол Cyrillic)
mn-CN (ᠮᠣᠩᠭᠣᠯ Mongolian vertical)
mn-RU (Буриад Cyrillic) etc.
If scripts play in main role then Mongolian is a macro language and it should be handled as mn-Mong, mn-Cyrl etc.
But before we to discuss further, we need to clarify and isolate what is a language and what is a script.TASK DETAILhttps://phabricator.wikimedia.org/T137810EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BadaaCc: Badaa, ChristianKl, C933103, jhsoby, thiemowmde, Liuxinyu970226, Lydia_Pintscher, GerardM, Aklapper, Zppix, Popolon, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 405897 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t use NewStatement to build standalone snaks

https://gerrit.wikimedia.org/r/405897TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Jonas, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T168240: WBQC test improvements

2018-01-24 Thread gerritbot
gerritbot added a comment.
Change 405893 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Expand ReferenceContextTest::testGetSnakGroup

https://gerrit.wikimedia.org/r/405893TASK DETAILhttps://phabricator.wikimedia.org/T168240EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Jonas, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T175565: Check “difference within range” constraints on qualifiers and references (days: 3)

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "Check “difference within range” constraints on qualifiers and references (days: 2)" to "Check “difference within range” constraints on qualifiers and references (days: 3)".
TASK DETAILhttps://phabricator.wikimedia.org/T175565EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lydia_Pintscher, Ivan_A_Krestinin, abian, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T175565: Check “difference within range” constraints on qualifiers and references (days: 2)

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T175565EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lydia_Pintscher, Ivan_A_Krestinin, abian, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T184623: Don’t check constraints on historical and diff pages

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T184623EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T185211: Generate coverage report for Wikidata extensions

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [] x] [WikimediaBadges](https://doc.wikimedia.org/cover-extensions/WikimediaBadges/) (?)TASK DETAILhttps://phabricator.wikimedia.org/T185211EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, hashar, Addshore, Legoktm, greg, Aklapper, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T185211: Generate coverage report for Wikidata extensions

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [] x] [WikibaseQuality](https://doc.wikimedia.org/cover-extensions/WikibaseQuality/)
 [] PropertySuggester
 [x] x] [WikibaseQualityConstraints](https://doc.wikimedia.org/cover-extensions/WikibaseQualityConstraints/)
 [] Wikidata.org (?)...TASK DETAILhttps://phabricator.wikimedia.org/T185211EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, hashar, Addshore, Legoktm, greg, Aklapper, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T165617: Investigate “coverage: unknown” badge on WikibaseQualityConstraints

2018-01-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a subscriber: Ladsgroup.Lucas_Werkmeister_WMDE added a comment.
Resolved by @Ladsgroup with I3d8f1e448c and I3ecd957006. (Though we now also have T185211: Generate coverage report for Wikidata extensions.)TASK DETAILhttps://phabricator.wikimedia.org/T165617EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup, gerritbot, PokestarFan, Lucas_Werkmeister_WMDE, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T185629: jquery.ui.ooMenu.js should not cause warning "jQuery.fn.offset() requires an element connected to a document"

2018-01-24 Thread He7d3r
He7d3r added a parent task: T169385: jQuery 3 migration warnings.
TASK DETAILhttps://phabricator.wikimedia.org/T185629EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: He7d3rCc: He7d3r, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, LawExplorer, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T185629: jquery.ui.ooMenu.js should not cause warning "jQuery.fn.offset() requires an element connected to a document"

2018-01-24 Thread He7d3r
He7d3r created this task.He7d3r added projects: _javascript_, ValueView.Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONThe script at


https://github.com/wikimedia/data-values-value-view/blob/63a84426e2a2a0ff88b04131a510aa1bb6bc8c57/lib/jquery.ui/jquery.ui.ooMenu.js#L254


(or https://www.wikidata.org/w/extensions/Wikibase/view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.ooMenu.js?31222 )
has the line

if ( this.element.offset().left + this.element.outerWidth( true ) > $( window ).width() ) {

which causes the warning

JQMIGRATE: jQuery.fn.offset() requires an element connected to a document

in the console when visiting
https://www.wikidata.org/wiki/Special:Watchlist?debug=1TASK DETAILhttps://phabricator.wikimedia.org/T185629EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: He7d3rCc: He7d3r, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, LawExplorer, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T185628: jquery.wikibase.entityview.js should not use deprecated jQuery.expr[':']

2018-01-24 Thread He7d3r
He7d3r added a parent task: T169385: jQuery 3 migration warnings.
TASK DETAILhttps://phabricator.wikimedia.org/T185628EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: He7d3rCc: He7d3r, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, LawExplorer, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T185628: jquery.wikibase.entityview.js should not use deprecated jQuery.expr[':']

2018-01-24 Thread He7d3r
He7d3r created this task.He7d3r added projects: _javascript_, MediaWiki-extensions-WikibaseView.Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONThe script at


https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/b513dc8c088c0817fc8c5081819ab78faeb6415b/view/resources/jquery/wikibase/jquery.wikibase.entityview.js#L167


(or https://www.wikidata.org/w/extensions/Wikibase/view/resources/jquery/wikibase/jquery.wikibase.entityview.js?da0f6 )
has the line

	$.expr[ ':' ][ $.wikibase.entityview.prototype.widgetFullName ]

which causes the warning

JQMIGRATE: jQuery.expr[':'] is deprecated; use jQuery.expr.pseudos

in the console when visiting
https://www.wikidata.org/wiki/Special:Watchlist?debug=1TASK DETAILhttps://phabricator.wikimedia.org/T185628EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: He7d3rCc: He7d3r, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, enigmaeth, rohitt, LawExplorer, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs