[Wikidata-bugs] [Maniphest] [Updated] T179793: Consider dropping the "wb_items_per_site.wb_ips_site_page" index
thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from incoming to in progress on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T179793WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, thiemowmdeCc: jcrespo, Stashbot, Marostegui, Aklapper, Ladsgroup, Multichill, daniel, hoo, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Minhnv-2809, Maathavan, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T188182: Special:Nearby no longer shows descriptions on Wikidata
thiemowmde added subscribers: pmiazga, Lea_Lacroix_WMDE.thiemowmde added a comment. Looks like said MFEnableWikidataDescriptions flag was introduced via https://gerrit.wikimedia.org/r/402126 (T182362) and https://gerrit.wikimedia.org/r/408357 (T182217) some weeks ago. But since this is disabled by default and the configuration not updated, the feature was effectively disabled. Was this intentional? Why is one feature hidden behind two almost identical configuration flags now?TASK DETAILhttps://phabricator.wikimedia.org/T188182EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Lea_Lacroix_WMDE, pmiazga, Jdlrobson, thiemowmde, Lydia_Pintscher, aude, Aklapper, Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jrbranaa, QZanden, LawExplorer, Winter, Wong128hk, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T186726: Security review WikibaseLexeme extension
Bawolff moved this task from In Progress to Awaiting remediation on the Security-Reviews board.Bawolff added a comment. Review of WikidataLexeme & php-vuejs-templating (To be clear, I didn't look at vue.js in general, since that was already reviewed by Darian afaik). "FormIdFormatter.php" line 69 & "SenseIdFormatter.php" line 73 - It looks like this is not properly escaped. However, it also looks like this is just a couple hard coded examples. Kind of confused by this class tbh. "SensesView.php" line 127 - $sense->getId()->getSerialization() - should be html escaped I think. "FormsView.php" line 86 - $this->textProvider->get( 'comma-separator' ) - Please avoid using messages as raw html in new code. [This may be an issue with Wikidata in general] ClickJacking: Since this allows edit interaction directly on wikipage, it should take steps to prevent click jacking. Either _javascript_ should detect when the page is being framed, and refuse to load the editing related js code (Since the editing related code only happens if js is enabled, its safe to detect this condition in JS), or the extension can call OutputPage::preventClickjacking() (Which will totally disables frames altogether for both js and non-js users). In php-vuejs Its unclear to me if DomDocument::loadHtml processes external entities in modern PHP. https://www.mediawiki.org/wiki/XML_External_Entity_Processing implies that at least in older versions of PHP this was a problem. For the avoidance of doubt, can we wrap the call to loadHtml with libxml_disable_entity_loader just in case per https://www.mediawiki.org/wiki/XML_External_Entity_Processing . TASK DETAILhttps://phabricator.wikimedia.org/T186726WORKBOARDhttps://phabricator.wikimedia.org/project/board/944/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, EBjune, LawExplorer, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Status] T181401: wikidatawiki_p.wb_items_per_site query is slower than expected on Wiki Replicas
Dispenser changed the task status from "Invalid" to "Resolved".Dispenser added a comment. I talked with @jcrespo on IRC and with some digging (P6782) to eventually find out the index I was using wb_ips_site_page was dropped without updating the documentation (T179793#4018800). For reference, the query to search article titles for all wikis. This is useful in determining if a red link was untranslated from transwiking or if an article already exists in another language. Here's the updated version using the wb_ips_item_site_page index: SELECT 1 FROM wikidatawiki_p.wb_items_per_site WHERE ips_site_page='Harrington Place, Stellenbosch' AND ips_site_id IN ( SELECT dbname FROM meta_p.wiki WHERE dbname != 'enwiki' );TASK DETAILhttps://phabricator.wikimedia.org/T181401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DispenserCc: jcrespo, zhuyifei1999, Legoktm, Dispenser, Aklapper, Giuliamocci, 1978Gage2001, Lahi, aborrero, Gq86, Darkminds3113, GoranSMilovanovic, Chicocvenancio, Jrbranaa, QZanden, Tbscho, LawExplorer, Vali.matei, JJMC89, Volker_E, srodlund, Wong128hk, Wikidata-bugs, aude, GWicke, Gryllida, scfc, Mbch331, Jay8g, Krenair, chasemp___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T184948: limit page creation rate on Wikidata
Framawiki added a comment. Note that usually and per https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes we, devs of #wikimedia-site-requests, ask for a link to community consensus before doing config changes...TASK DETAILhttps://phabricator.wikimedia.org/T184948EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, hoo, Sjoerddebruin, Addshore, Ladsgroup, gerritbot, Aklapper, Lydia_Pintscher, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, biplabanand, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T188378: Error for some Lua modules "The time allocated for running scripts has expired"
Lydia_Pintscher added a subscriber: Ladsgroup.Lydia_Pintscher added a comment. @Ladsgroup can you think of anything that changed that would cause this?TASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Ladsgroup, happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Wikidata-bugs, aude, TheDJ, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T177802: Move (at least Wikibase) rc_params into a separate table, allow for de-duplication.
Lydia_Pintscher triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T177802EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Noella94, jcrespo, Lydia_Pintscher, daniel, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188828: Wikipedia in spanish not updating wikidata data.
MarcoAurelio added a comment. I see the data rightly in both articles linked too. Maybe a caching issue or a busy job queue at that moment that made the data not update instantaneously?TASK DETAILhttps://phabricator.wikimedia.org/T188828EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarcoAurelioCc: MarcoAurelio, Mbch331, Zeroth, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T143486: [feature request] remove sitelinks / update sitelinks on Wikidata when pages are deleted/moved on client wikis (all users)
matej_suchanek added a comment. With rMW96bd79b4a36a: Avoid DB rows with usable names but ID = 0 by introducing "interwiki" usernames (T20209), "interwiki" usernames can be used.TASK DETAILhttps://phabricator.wikimedia.org/T143486EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Lydia_Pintscher, NicoScribe, Ladsgroup, PokestarFan, ArthurPSmith, Liuxinyu970226, Izno, hoo, Aklapper, Esc3300, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
