[Wikidata-bugs] [Maniphest] [Commented On] T143706: Implement TermLookup based on Elastic

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416641 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] [WIP] Implement TermLookup with ElasticSearch

https://gerrit.wikimedia.org/r/416641TASK DETAILhttps://phabricator.wikimedia.org/T143706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, WMDE-leszek, Smalyshev, hoo, Liuxinyu970226, Aklapper, aude, JeroenDeDauw, Tobi_WMDE_SW, thiemowmde, adrianheine, Lydia_Pintscher, Ricordisamoa, daniel, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T143706: Implement TermLookup based on Elastic

2018-03-05 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T143706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, WMDE-leszek, Smalyshev, hoo, Liuxinyu970226, Aklapper, aude, JeroenDeDauw, Tobi_WMDE_SW, thiemowmde, adrianheine, Lydia_Pintscher, Ricordisamoa, daniel, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, GWicke, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188502: Implement multilingual captions in UploadWizard

2018-03-05 Thread Ramsey-WMF
Ramsey-WMF added a comment.
Does that mean we need to enforce them even if there are no technical reasons for doing so?

Yes. Caption is a short field. We'll have a multilingual "description" field as well, for the longer summaries.TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, Ramsey-WMFCc: Ramsey-WMF, PDrouin-WMF, gerritbot, matthiasmullie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, E1presidente, Cparle, Darkminds3113, Sksvdbvd, SandraF_WMF, Youssefalli1, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, Base, aude, Bawolff, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183489: MCR schema migration stage 1: Fix Legacy Archive Rows

2018-03-05 Thread Abit
Abit added a comment.
@Anomie what is this task blocked by?  Is it the code review Piotr is doing?TASK DETAILhttps://phabricator.wikimedia.org/T183489EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, AbitCc: Abit, Jdforrester-WMF, Aklapper, aude, Addshore, Anomie, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T174025: Implement MCR revision retrieval legacy version

2018-03-05 Thread Abit
Abit added a comment.
@daniel, the MCR wiki shows this task as complete, but here it is still open.  Which is correct?TASK DETAILhttps://phabricator.wikimedia.org/T174025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, AbitCc: Abit, gerritbot, Aklapper, daniel, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, Maathavan, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Anomie, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188413: wdqs-updater does not recover after an UnknownHostException

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416622 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/rdf@master] Set negative DNS cache TTL to 5s

https://gerrit.wikimedia.org/r/416622TASK DETAILhttps://phabricator.wikimedia.org/T188413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev, Gehel, Aklapper, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188413: wdqs-updater does not recover after an UnknownHostException

2018-03-05 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T188413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev, Gehel, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T143706: Implement TermLookup based on Elastic

2018-03-05 Thread Smalyshev
Smalyshev added a comment.
Another API quirk: getLabel(s) and getDescription(s) return null when the term does not exist. getPrefetchedTerm returns null when term has not been prefetched and false when it does not exist. Probably needs to be unified, otherwise it is annoying to integrate those two.TASK DETAILhttps://phabricator.wikimedia.org/T143706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: WMDE-leszek, Smalyshev, hoo, Liuxinyu970226, Aklapper, aude, JeroenDeDauw, Tobi_WMDE_SW, thiemowmde, adrianheine, Lydia_Pintscher, Ricordisamoa, daniel, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T188946: High-level discussion for the direction of structured licensing

2018-03-05 Thread Platonides
Platonides updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...2. Adopt a structured license selection process (like [[http://rightsstatements.org|rightssstatement.org]]. This allows for very effective licensing selection, presentation, and reuse, but limits potential licensing variationsTASK DETAILhttps://phabricator.wikimedia.org/T188946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Keegan, PlatonidesCc: SandraF_WMF, Abit, Ramsey-WMF, Slaporte, Aklapper, Keegan, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, GoranSMilovanovic, Ivana_Isadora, QZanden, Tramullas, Acer, LawExplorer, Jseddon, FloNight, Trizek-WMF, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Elitre, Qgil___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188045: wdqs1004 broken

2018-03-05 Thread Cmjohnson
Cmjohnson added a comment.
a ticket has been placed with Dell You have successfully submitted request SR961706803.TASK DETAILhttps://phabricator.wikimedia.org/T188045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CmjohnsonCc: Joe, RobH, Stashbot, Gehel, Cmjohnson, Papaul, gerritbot, elukey, Smalyshev, Aklapper, Dzahn, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Southparkfan, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T188946: High-level discussion for the direction of structured licensing

2018-03-05 Thread Keegan
Keegan created this task.Keegan triaged this task as "Normal" priority.Keegan added projects: Structured-Data-Commons, Epic, Wikidata, Community-Liaisons (Jan-Mar-2018).
TASK DESCRIPTIONBefore we get into the details of how we implement structured licensing, we need to see Commons and Wikimedia community opinions about some potential directions. This will influence future conversations around implementation, in upload, presentation, and reuse.

Three potential directions:


Take the status quo and model it. This allows for extensive license modification, which restricts the effectiveness of structure.



Adopt a structured license selection process (like [http://rightsstatements.org|rightssstatement.org]. This allows for very effective licensing selection, presentation, and reuse, but limits potential licensing variations.



Something else?


I'll start an opinion-gathering process.TASK DETAILhttps://phabricator.wikimedia.org/T188946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: SandraF_WMF, Abit, Ramsey-WMF, Slaporte, Aklapper, Keegan, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, GoranSMilovanovic, Ivana_Isadora, QZanden, Tramullas, Acer, LawExplorer, Jseddon, FloNight, Trizek-WMF, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Elitre, Qgil___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T188944: Multiple SPARQL queries when hovering over "data updated" element

2018-03-05 Thread Smalyshev
Smalyshev created this task.Smalyshev added a project: Wikidata Query UI.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONWhen I hover over "data updated" element on the lower left of the edit windows (green double arrows) I see repeated SPARQL queries in the network log, going out at the rate of several queries per second. While updating the data periodically is OK, I do not think this kind of rate is necessary. Should have some kind of debouncing probably.TASK DETAILhttps://phabricator.wikimedia.org/T188944EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Gq86, EBjune, merbst, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188924: Stack overflow in WikibaseRepo initialization on Wikidata Beta

2018-03-05 Thread Addshore
Addshore added a parent task: T183963: 1.31.0-wmf.24 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T188924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188924: Stack overflow in WikibaseRepo initialization on Wikidata Beta

2018-03-05 Thread Addshore
Addshore added a comment.
I see the following in the logs after hitting https://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page a few times

Fatal error: Stack overflow in /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php on line 622
[Mon Mar  5 20:05:17 2018] [hphp] [20682:7fa8713ff700:22210:01] [] \nFatal error: Stack overflow in /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php on line 622

[Mon Mar  5 20:05:02 2018] [hphp] [20682:7fa7d2fff700:22063:01] [] \nCatchable fatal error: Argument 1 passed to __invoke() must be an instance of ApiMain, undefined variable given in /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Content
Catchable fatal error: Argument 1 passed to __invoke() must be an instance of ApiMain, undefined variable given in /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Content/EntityContentFactory.php on line 204TASK DETAILhttps://phabricator.wikimedia.org/T188924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188924: Stack overflow in WikibaseRepo initialization on Wikidata Beta

2018-03-05 Thread Addshore
Addshore added a comment.
Marked as high so that we investigate this, in theory the cause would be in this weeks train.TASK DETAILhttps://phabricator.wikimedia.org/T188924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T188924: Stack overflow in WikibaseRepo initialization on Wikidata Beta

2018-03-05 Thread Addshore
Addshore triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T188924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

2018-03-05 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-03-05T20:02:00Z]  Synchronized php-1.31.0-wmf.23/extensions/Wikibase: Fix empty condition list in metadata lookup - T188313 (duration: 01m 58s)TASK DETAILhttps://phabricator.wikimedia.org/T188313EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, StashbotCc: Stashbot, gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 415319 merged by Hashar:
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.23] Fix empty condition list in metadata lookup

https://gerrit.wikimedia.org/r/415319TASK DETAILhttps://phabricator.wikimedia.org/T188313EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T172129: New constraint type for type of snak

2018-03-05 Thread matej_suchanek
matej_suchanek added a comment.
Quick example: biographical properties like date of birth are known or unknown but they always exist (everybody was born some time somewhere), so novalue doesn't make sense. This constraint could help catch this abuse, as well as somevalue × novalue confusions. I realize now this could be implemented together with T183092: Make an obvious way of blacklisting a value for a property.TASK DETAILhttps://phabricator.wikimedia.org/T172129EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Lydia_Pintscher, Nikki, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, PokestarFan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188413: wdqs-updater does not recover after an UnknownHostException

2018-03-05 Thread Gehel
Gehel added a comment.

In T188413#4024380, @Smalyshev wrote:
It probably covers both failed queries, and queries with negative response.

That's the thing - there's no case for Updater to look up URLs which would give negative response. It ever goes only to Wikidata (or whatever server is used to d/l updates) and if that fails, it's an error.


There is no nominal use case. There are error scenarios. Yes if the updater gets a negative response, it is because something outside of its control went wrong (broken DNS, broken configuration, broken network, ...). That does not mean that we should discount this scenario.

In the end, the difference between no negative cache and a small negative cache is small, so it does not matter much. The real issue is that it seems that we have an infinite negative cache and that's really wrong!TASK DETAILhttps://phabricator.wikimedia.org/T188413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Smalyshev, Gehel, Aklapper, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T138708: [Epic] Signed statements

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
Hey @AdityaJ  Great to hear you are interested in the project. I think as a first step it would be great if you install Wikibase and get it running.TASK DETAILhttps://phabricator.wikimedia.org/T138708EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: AdityaJ, Jonas, rosalieper, EddyAfful, BamLifa, MichaelSchoenitzer, psinghal20, Nikhil-nk, Liuxinyu970226, BVershbow_WMF, PDrouin-WMF, Astinson, Ramsey-WMF, Quoth, Daniel_Mietchen, Tpt, Glorian_Yapinus, Micru, Jane023, DarTar, Abbe98, I9606, YULdigitalpreservation, Tallerone, abian, Scott_WUaS, johl, jayvdb, tfmorris, Spinster, TomT0m, Denny, Eloquence, JanZerebecki, T.seppelt, Aklapper, daniel, Zppix, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, srishakatux, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Mvolz, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T172129: New constraint type for type of snak

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
Do you have some examples where we explicitly want to say that novalue and somevalue are not allowed? They should theoretically be allowed everywhere.TASK DETAILhttps://phabricator.wikimedia.org/T172129EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Nikki, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, PokestarFan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188104: Improve Explorer on Query.Wikidata.org

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T188104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: prssanna, Rammanojpotla, Akshatbhargava123, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, srishakatux, merbst, LawExplorer, D3r1ck01, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mvolz, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188046: Simple English localization gets date format from previous localization

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T188046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T187876: Improve Graph Explorer on Query.Wikidata.org

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T187876EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: prssanna, Rammanojpotla, Lucas_Werkmeister_WMDE, Akshatbhargava123, BamLifa, srishakatux, Jonas, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, D3r1ck01, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mvolz, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T184301: dist/ in WDQS GUI is out of date

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T184301EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Jonas, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186365: In Wikidata Query tool the tooltip arrow looks broken in RTL languages

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T186365EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, EBjune, merbst, LawExplorer, Srdjan_m, Jonas, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T183936: SVG download of Dimensions view looks broken

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T183936EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T183831: wikidata/query/gui CI job lacks PhantomJS / proper browsers

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T183831EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lucas_Werkmeister_WMDE, gerritbot, Aklapper, hashar, Jonas, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Xmlizer, thcipriani, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188211: Download WDQS results as a static HTML table

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T188211EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Smalyshev, Aklapper, abian, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T185549: "Limit" button is not translated

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T185549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Amire80, Aklapper, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, EBjune, merbst, LawExplorer, Srdjan_m, Jonas, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T187874: Improve Explorer Dialog on Query.Wikidata.org

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T187874EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Gopavasanth, prssanna, Rammanojpotla, BamLifa, Aklapper, Jonas, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, srishakatux, merbst, LawExplorer, D3r1ck01, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mvolz, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188110: Support multilingual query templates

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T188110EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188110: Support multilingual query templates

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata-Sprint-2018-02-28.
TASK DETAILhttps://phabricator.wikimedia.org/T188110EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T164372: Implement “Units” constraint

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
We just talked about it and it makes sense to have the default be more lenient for now. If needed we can add a parameter to be more strict later.TASK DETAILhttps://phabricator.wikimedia.org/T164372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Sjoerddebruin, PokestarFan, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188413: wdqs-updater does not recover after an UnknownHostException

2018-03-05 Thread Smalyshev
Smalyshev added a comment.
It probably covers both failed queries, and queries with negative response.

That's the thing - there's no case for Updater to look up URLs which would give negative response. It ever goes only to Wikidata (or whatever server is used to d/l updates) and if that fails, it's an error.TASK DETAILhttps://phabricator.wikimedia.org/T188413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Gehel, Aklapper, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T185712: Make Context serializable

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [update `CheckResult`](https://gerrit.wikimedia.org/r/415550)
- [ - [x] [drop `Context::storeCheckResultInArray` and `ApiV2Context`](https://gerrit.wikimedia.org/r/416425)
- [ ] add s11n classes
- refactorings and restructurings? possibly following T188728?TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T74157: [Story] Use rc_source and drop RC_TYPE

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher removed a project: Wikidata-Sprint-2018-02-28.Lydia_Pintscher moved this task from in progress to needs discussion or investigation on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T74157WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Ladsgroup, gerritbot, PokestarFan, Liuxinyu970226, Ricordisamoa, Krenair, Lydia_Pintscher, aude, Aklapper, bd808, EBernhardson, Quiddity, Spage, Mattflaschen-WMF, DannyH, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Lewizho99, Maathavan, Trizek-WMF, SBisson, Wikidata-bugs, Gryllida, jeblad, Catrope, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T164372: Implement “Units” constraint

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subscriber: Lydia_Pintscher.Lucas_Werkmeister_WMDE added a comment.
@Lydia_Pintscher:

I only want to define the base-unit for a dimension and then automatically all the other derived units are also allowed.

That’s a change in behavior from KrBot (for example, P​2660 “topographic prominence” has a constraint stating that the unit should be “metre”, and the database report lists lots of items with unit “foot” as violations). Are we sure we want this to be the default behavior?TASK DETAILhttps://phabricator.wikimedia.org/T164372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Sjoerddebruin, PokestarFan, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T177970: Expand references with constraint violations

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONConstraint check results on references are hidden because references are collapsed by default. Should we expand references with constraint violations to raise their visibility?It is easy to overlook them in this case. Since we want to encourage people to clean up the violations we should make them more visible by expanding the references that have a constraint violation.



From the developer tools console, this can be done with the following command:...TASK DETAILhttps://phabricator.wikimedia.org/T177970EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T170610: Add “no bounds” constraint

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAs a data maintainer I want to be able to find problematic values that have a explicitly defined bound but should not. I want to be able to define per property if it should take bounds or not.

We should have a new constraint type **No bounds** for quantity properties that are about non-physical quantities without uncertainty. This is in fact a substantial fraction of Wikidata quantity properties. Since use of bounds indicates uncertainty and we cannot use novalue for bounds, we need to indicate the absence of uncertainty by using no bounds at all, rather than ±0 boundsTASK DETAILhttps://phabricator.wikimedia.org/T170610EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lucas_Werkmeister_WMDE, Aklapper, MisterSynergy, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T188924: Stack overflow in WikibaseRepo initialization on Wikidata Beta

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Beta-Cluster-Infrastructure.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONThere seems to be some call cycle in the WikibaseRepo initialization on wikidata.beta.wmflabs.org. From logstash:

"0":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":927},
"1":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":773,"function":"getStore","class":"Wikibase\\Repo\\WikibaseRepo","type":"->","args":[]},
"2":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":408,"function":"getEntityLookup","class":"Wikibase\\Repo\\WikibaseRepo","type":"->","args":[]},
"3":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":380,"function":"newValidatorBuilders","class":"Wikibase\\Repo\\WikibaseRepo","type":"->","args":[]},
"4":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/WikibaseRepo.datatypes.php","line":328,"function":"getDefaultValidatorBuilders","class":"Wikibase\\Repo\\WikibaseRepo","type":"::","args":[]},
"5":{"function":"Closure$#37","args":[]},
"6":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":624,"function":"call_user_func","args":["Closure$#37;2699"]},
"7":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":615,"function":"getEntityDiffer","class":"Wikibase\\Repo\\WikibaseRepo","type":"->","args":[]},
"8":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":934,"function":"getEntityChangeFactory","class":"Wikibase\\Repo\\WikibaseRepo","type":"->","args":[]},
"9":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":773,"function":"getStore","class":"Wikibase\\Repo\\WikibaseRepo","type":"->","args":[]},
"10":{"file":"/srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php","line":408,"function":"getEntityLookup","class":"Wikibase\\Repo\\WikibaseRepo","type":"->","args":[]},

Earliest log message for this error appears to be from today (2018-03-05) 14:37 UTC. There haven’t been any recent Wikibase commits since last Wednesday except some comment or i18n updates, so I’m not sure what could have caused this.TASK DETAILhttps://phabricator.wikimedia.org/T188924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T164372: Implement “Units” constraint

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAs a data maintainer I want to be able to define which units are allowed for a given property with datatype quantity.
I only want to define the base-unit for a dimension and then automatically all the other derived units are also allowed.

See [Template:Constraint:Units](https://www.wikidata.org/wiki/Template:Constraint:Units): must use one of the listed units (or //novalue// for no units allowed)TASK DETAILhttps://phabricator.wikimedia.org/T164372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Sjoerddebruin, PokestarFan, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T143706: Implement TermLookup based on Elastic

2018-03-05 Thread thiemowmde
thiemowmde added a comment.

@Smalyshev wrote:
I don't see where term types are defined […]


That's exactly the issue I referred to. These "term types" being strings is mostly an implementation detail of how the wb_terms table is designed. The currently specified term types can be found in TermIndexEntry. Please use these constants to make it easier to find places working with these term types.


TermIndexEntry::TYPE_LABEL = "label"
TermIndexEntry::TYPE_ALIAS = "alias"
TermIndexEntry::TYPE_DESCRIPTION = "description"


but could there be more?

We played around with ideas to have other types for #lexicographical_data, but we are most probably not going to do this. So these 3 types are all that exist.

Is Elastic implementation supposed to support them […]

Please either return no result if a caller asks for an unknown term type, or throw an exception.

Also, there's an overlap of coverage - you can use getLabel or you can use getPrefetchedTerm(... 'label' ...).

This is just one of the many problems of this combination of older and newer interfaces. Please focus on the more narrow methods (everything without $termType) if possible.

code dealing with prefetching, buffering, resolving different repos […] should all this code be reimplemented for ElasticSearch implementation of prefetchTerms or can it be somehow reused? All that code relies on TermBuffer/TermIndex now.

We might need to split the existing implementations. But I believe it is easier to start over and not touch the existing implementations. For example, you can start by implementing nothing but a TermLookup. If this works, you can add a small TermBuffer implementation on top that allows for prefetching. Since TermBuffer alone is not very useful, you might need to use the PrefetchingTermLookup interface as a decorator instead:

class PrefetchingElasticTermLookup implements PrefetchingTermLookup {

	private $lookup;

	public function __construct( ElasticTermLookup $lookup ) {
		$this->lookup = $lookup;
	}

	public function prefetchTerms( array $entityIds, array $termTypes = null, array $languageCodes = null ) {
		/* TBD */
	}

	public function getPrefetchedTerm( EntityId $entityId, $termType, $languageCode ) {
		switch ( $termType ) {
			case TermIndexEntry::TYPE_LABEL:
return $this->getLabel( $entityId, $languageCode );
			case TermIndexEntry::TYPE_DESCRIPTION:
return $this->getDescription( $entityId, $languageCode );
			default:
throw new \InvalidArgumentException( "Not defined for \$termType \"$termType\"" );
		}
	}

	public function getLabel( EntityId $entityId, $languageCode ) {
		$this->lookup->getLabel( $entityId, $languageCode );
	}

	public function getLabels( EntityId $entityId, array $languageCodes ) {
		$this->lookup->getLabels( $entityId, $languageCodes );
	}

	public function getDescription( EntityId $entityId, $languageCode ) {
		$this->lookup->getDescription( $entityId, $languageCode );
	}

	public function getDescriptions( EntityId $entityId, array $languageCodes ) {
		$this->lookup->getDescriptions( $entityId, $languageCodes );
	}

}



TermLookup methods are supposed to be dealing with entities from federated repos too, and also working on the WikibaseClient side […]

This might indeed be needed. However, I suggest to not care for these for the moment. We can add such functionality later via dispatchers, decorators, and such.TASK DETAILhttps://phabricator.wikimedia.org/T143706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: WMDE-leszek, Smalyshev, hoo, Liuxinyu970226, Aklapper, aude, JeroenDeDauw, Tobi_WMDE_SW, thiemowmde, adrianheine, Lydia_Pintscher, Ricordisamoa, daniel, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, GWicke, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188502: Implement multilingual captions in UploadWizard

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416466 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Improve what details step looks like

https://gerrit.wikimedia.org/r/416466TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, gerritbotCc: Ramsey-WMF, PDrouin-WMF, gerritbot, matthiasmullie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, E1presidente, Cparle, Darkminds3113, Sksvdbvd, SandraF_WMF, Youssefalli1, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, Base, aude, Bawolff, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188661: Remove jolokia collectors for WDQS/Updater

2018-03-05 Thread Gehel
Gehel added a comment.

In T188661#4015658, @Smalyshev wrote:
Also we may want to replace https://grafana.wikimedia.org/dashboard/db/wikidata-query-service with https://grafana.wikimedia.org/dashboard/db/wikidata-query-service-prometheus


DoneTASK DETAILhttps://phabricator.wikimedia.org/T188661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Aklapper, Gehel, Smalyshev, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188413: wdqs-updater does not recover after an UnknownHostException

2018-03-05 Thread Gehel
Gehel added a comment.

In T188413#4019360, @Smalyshev wrote:
We could probably set networkaddress.cache.negative.ttl to 0 - I do not see where we would have any use for negative DNS caching at all.


I'm not exactly sure which cases are covered by networkaddress.cache.negative.ttl. It probably covers both failed queries, and queries with negative response. In case of a negative response by DNS, caching the result is the correct behaviour, to reduce load on DNS. In both cases, caching will enable immediate failure which is in general a good thing (in our case, we probably don't care). So setting it to a small value (10 seconds?) is probably better.

All that DNS caching behaviour in Java is not well documented and I don't understand it as well as I should, so I'd prefer to have a test scenario before changing the current behaviour.TASK DETAILhttps://phabricator.wikimedia.org/T188413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Smalyshev, Gehel, Aklapper, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T170610: Add “no bounds” constraint

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
Do you think some properties that are definitely physical might also need the opposite, a constraint that says the values should always have uncertainty? In that case we could perhaps merge the constraint types into one, and have a parameter that determines whether values should have bounds or not…TASK DETAILhttps://phabricator.wikimedia.org/T170610EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, MisterSynergy, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188635: [Spike] Numbers of patrol actions in Wikidata and reasons behind it

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T188635EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: kaldari, Aklapper, jcrespo, Krinkle, Bawolff, MaxSem, gerritbot, Catrope, WMDE-leszek, Nemo_bis, MZMcBride, MGChecker, ArielGlenn, Framawiki, Nikerabbit, Tgr, brion, Nirmos, daniel, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Declined] T171170: Move Wikidata entity IDs to Wikibase-production.php

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Declined".Lucas_Werkmeister_WMDE added a comment.
I’m going to decline this task with the reasoning given above: having Wikidata entity IDs in extension.json is useful to make the import of those entities nice and painless.

That said, I agree that we should create these items and properties on test and beta Wikidata as well, and then configure the extension accordingly there. But that’s for another task.TASK DETAILhttps://phabricator.wikimedia.org/T171170EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, PokestarFan, Aklapper, Bugreporter, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T188110: Support multilingual query templates

2018-03-05 Thread Jonas
Jonas moved this task from Backlog to Done on the Wikidata Query UI board.Jonas triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T188110WORKBOARDhttps://phabricator.wikimedia.org/project/board/2901/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, JonasCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186161: What to do if the WDQS does not synchronise with Wikibase?

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T186161EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Addshore, Andrawaag, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Abbe98, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188110: Support multilingual query templates

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 408850 merged by jenkins-bot:
[wikidata/query/gui@master] Support multiple languages in query templates

https://gerrit.wikimedia.org/r/408850TASK DETAILhttps://phabricator.wikimedia.org/T188110EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Gq86, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, EBjune, merbst, Lewizho99, Maathavan, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186467: Graph visualization not working in query service UI installed via wikibase-docker

2018-03-05 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T186467EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, Lucas_Werkmeister_WMDE, DarTar, Addshore, Jonas, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Abbe98, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
Note: The old task T188728: Replace claim with violation message in Special:ConstraintReport is also related.TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188502: Implement multilingual captions in UploadWizard

2018-03-05 Thread matthiasmullie
matthiasmullie added a comment.
As I understand it, Twitter currently:


has a fixed limit of 280 (most languages) or 140 (Chinese, Japanese, and Korean)
that limit is the amount of characters, not the amount of bytes (so characters requiring more bytes only count 1 towards the total allowed length)

shows a vague indicator (circular progress bar)
shows the exact amount of remaining characters when there are only 20 left


Counting bytes instead of characters makes no sense except for hard storage constraints, which is not the case here. The current length validation for descriptions (5 <= input <= 1) just tests .length, which is character length (not byte count) already.

As I understand it, we want to encourage short captions.
Does that mean we need to enforce them even if there are no technical reasons for doing so? Or do we just want to nudge people towards writing succinct descriptions, without forcing them to? (accurately describing something that has a really long name might get annoying)

Assuming we don't want to enforce that limit, I'm thinking we could add some progress bar towards some ideal length & warn users once they're over, but still allow them to submit it.
Kind of like how we warn when a user attempts to submit something without categories, but still allow them to submit it. Or maybe not even warn at all: progress bar might suffice to nudge people towards the desirable length.
I don't think we need to display an exact "x characters remaining" count if we don't really enforce it.

As for support in different languages: assuming we have no other research, we could start out with Twitter's findings of nudging people towards  in most languages, and  in Chinese, Japanese & Korean?

Thoughts?TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullieCc: Ramsey-WMF, PDrouin-WMF, gerritbot, matthiasmullie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, E1presidente, Cparle, Darkminds3113, Sksvdbvd, SandraF_WMF, Youssefalli1, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, PKM, Base, aude, Bawolff, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178047: Investigate why wikidata abstracts dumps are so large

2018-03-05 Thread hoo
hoo added a comment.

In T178047#4023267, @ArielGlenn wrote:
I'm tempted to just turn off abstracts for Wikidata altogether, since every item in there is a Qxxx with junk for the abstract.


If this is just NS0 (or content namespaces… which are all Wikibase entity namespaces), this definitely makes sense to me.


In T178047#4023267, @ArielGlenn wrote:
But your approach is better, in case similar content creeps into other projects.  @hoo, what do you think about https://gerrit.wikimedia.org/r/#/c/416409/, as opposed to somehow checking for TextContent and WikitextContent (which requires having the content to hand)?


Hm… not sure about returning "NONTEXTCONTENT", maybe either omit the  or do something like ?TASK DETAILhttps://phabricator.wikimedia.org/T178047EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, hooCc: gerritbot, hoo, ArielGlenn, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, gnosygnu, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T188802: String values with leading/trailing whitespace are (inconsistently) reported as invalid

2018-03-05 Thread thiemowmde
thiemowmde renamed this task from "Adding property field Property:P742 (pseudonym) needs to ignore leading spaces" to "String values with leading/trailing whitespace are (inconsistently) reported as invalid".
TASK DETAILhttps://phabricator.wikimedia.org/T188802EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lydia_Pintscher, Aklapper, Billinghurst, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T188802: Adding property field Property:P742 (pseudonym) needs to ignore leading spaces

2018-03-05 Thread thiemowmde
thiemowmde added projects: DataValues, MediaWiki-extensions-WikibaseRepository, Easy.thiemowmde triaged this task as "Low" priority.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde added a comment.
Labels, descriptions, aliases, as well as monolingual text values are trimmed. For monolingual text values this happens in the backend via MonolingualTextParser.

For string values this is not done. Instead a validator blocks strings with leading or trailing spaces, tabs, newlines, or any other vertical whitespace. The code for this can be seen in ValidatorBuilders::getCommonStringValidators.

We did not wanted to enforce trimming on string values because whitespace can be significant and meaningful. Think of https://www.wikidata.org/wiki/Property:P487, the string property holding a Unicode character. Shouldn't it be possible to add a statement to https://www.wikidata.org/wiki/Q380933 (the Item describing the space character) that holds the space character? Because of the validator this is currently not possible. I believe having this validator in place was a good thing. But nowadays we have plenty of alternatives, most notably constrain checks. Maybe it's time to lift the hard-coded limitation?TASK DETAILhttps://phabricator.wikimedia.org/T188802WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, Lydia_Pintscher, Aklapper, Billinghurst, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread thiemowmde
thiemowmde triaged this task as "Normal" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, thiemowmdeCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails

2018-03-05 Thread thiemowmde
thiemowmde triaged this task as "Lowest" priority.thiemowmde added a project: Need-volunteer.
TASK DETAILhttps://phabricator.wikimedia.org/T185697EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Legoktm, gerritbot, greg, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Scott_WUaS, abian, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T185609: Invalid callback WikibaseQuality\ExternalValidation\WikibaseQualityExternalValidationHooks::onCreateSchema

2018-03-05 Thread thiemowmde
thiemowmde triaged this task as "Lowest" priority.thiemowmde added a project: Need-volunteer.
TASK DETAILhttps://phabricator.wikimedia.org/T185609EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, Lucas_Werkmeister_WMDE, Umherirrender, Legoktm, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Scott_WUaS, abian, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T185609: Invalid callback WikibaseQuality\ExternalValidation\WikibaseQualityExternalValidationHooks::onCreateSchema

2018-03-05 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T185609EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Umherirrender, Legoktm, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185609: Invalid callback WikibaseQuality\ExternalValidation\WikibaseQualityExternalValidationHooks::onCreateSchema

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416433 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Add autoload instructions to MediaWiki extension registration

https://gerrit.wikimedia.org/r/416433TASK DETAILhttps://phabricator.wikimedia.org/T185609EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Umherirrender, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416433 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Add autoload instructions to MediaWiki extension registration

https://gerrit.wikimedia.org/r/416433TASK DETAILhttps://phabricator.wikimedia.org/T185697EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Legoktm, gerritbot, greg, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185712: Make Context serializable

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416425 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove Context::storeCheckResultInArray and ApiV2Context

https://gerrit.wikimedia.org/r/416425TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T185712: Make Context serializable

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [update `CheckResult`](https://gerrit.wikimedia.org/r/415550)
- [x- [ ] [drop `Context::storeCheckResultInArray` and `ApiV2Context`](https://gerrit.wikimedia.org/r/416425)...TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T185712: Make Context serializable

2018-03-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [update `CheckResult`](https://gerrit.wikimedia.org/r/415550)
- [ ] - [x] [drop `Context::storeCheckResultInArray` and `ApiV2Context` (don’t forget to adjust `@covers` tags in tests!](https://gerrit.wikimedia.org/r/416425)...TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185712: Make Context serializable

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416425 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove Context::storeCheckResultInArray and ApiV2Context

https://gerrit.wikimedia.org/r/416425TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178047: Investigate why wikidata abstracts dumps are so large

2018-03-05 Thread ArielGlenn
ArielGlenn added a comment.
I'm tempted to just turn off abstracts for Wikidata altogether, since every item in there is a Qxxx with junk for the abstract.  But your approach is better, in case similar content creeps into other projects.  WHat do you think about https://gerrit.wikimedia.org/r/#/c/416409/, as opposed to somehow checking for TextContent and WikitextContent (which requires having the content to hand)?TASK DETAILhttps://phabricator.wikimedia.org/T178047EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlennCc: gerritbot, hoo, ArielGlenn, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, gnosygnu, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416410 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Rearrange PrefetchingWPEMDA::loadLatestRevisionIds

https://gerrit.wikimedia.org/r/416410TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416406 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add missing htmlspecialchars() to SensesView

https://gerrit.wikimedia.org/r/416406TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T178047: Investigate why wikidata abstracts dumps are so large

2018-03-05 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T178047EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, gerritbotCc: gerritbot, hoo, ArielGlenn, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, gnosygnu, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T178047: Investigate why wikidata abstracts dumps are so large

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416409 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[mediawiki/extensions/ActiveAbstract@master] don't try to abstract things that aren't text or wikitext

https://gerrit.wikimedia.org/r/416409TASK DETAILhttps://phabricator.wikimedia.org/T178047EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, gerritbotCc: gerritbot, hoo, ArielGlenn, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, gnosygnu, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread thiemowmde
thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from ready to go to in progress on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T186726WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, thiemowmdeCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread thiemowmde
thiemowmde added a comment.
I uploaded fixes for two issues:


 https://gerrit.wikimedia.org/r/416406
 https://github.com/wmde/php-vuejs-templating/pull/6
 FormIdFormatter and SenseIdFormatter are dummy implementations. The escaping is fine. I created T188899: [Task] Remove hard-coded demo data from Lexeme code base to properly deal with these later.
 comma-separator is a message from core, and intentionally contains HTML (but no wiki syntax). As far as I can see we are using it correctly. Yes, we are aware messages with HTML are problematic, and we avoid it whenever possible.
 Click-jacking prevention is a general issue for all of #Wikidata and should have it's own ticket.
TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, thiemowmdeCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T188378: Error for some Lua modules "The time allocated for running scripts has expired"

2018-03-05 Thread Ladsgroup
Ladsgroup added a comment.
I took a look at this and it seems this task is a symptom and not a problem on its own. If it's going down gradually, it means we are hitting scalability issues and there are several ways to handle that. One of them includes optimizing wb_terms table which we are on it but it takes months to become fully useful but if we are returning too many errors like this suddenly, it is a regression bug. Looking at the slow-parse graph in logstash, it tells me that we had an increase around 15 of February which started to decrease around first of March and last week is the lowest in the past 30 days. This drop started exactly when I enabled reading from term_full_entity_id instead of term_entity_id. It helps because we remove an additional where clause from the query (term_entity_type = 'item', etc.).
For historical reasons:
F14407345: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread gerritbot
gerritbot added a comment.
Change 416406 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add missing htmlspecialchars() to SensesView

https://gerrit.wikimedia.org/r/416406TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, EBjune, LawExplorer, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bawolff, gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Ladsgroup, thiemowmde, Lydia_Pintscher, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, dpatrick, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T188899: [Task] Remove hard-coded demo data from Lexeme code base

2018-03-05 Thread thiemowmde
thiemowmde added a parent task: T168260: Deploy WikibaseLexeme extension on Wikimedia cluster.
TASK DETAILhttps://phabricator.wikimedia.org/T188899EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: RazShuty, Ladsgroup, Jonas, Aleksey_WMDE, WMDE-leszek, Lydia_Pintscher, thiemowmde, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T168260: Deploy WikibaseLexeme extension on Wikimedia cluster

2018-03-05 Thread thiemowmde
thiemowmde added a subtask: T188899: [Task] Remove hard-coded demo data from Lexeme code base.
TASK DETAILhttps://phabricator.wikimedia.org/T168260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, daniel, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T188899: [Task] Remove hard-coded demo data from Lexeme code base

2018-03-05 Thread thiemowmde
thiemowmde created this task.thiemowmde added projects: Wikidata, Lexicographical data, Technical-Debt.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONIn T186726: Security review WikibaseLexeme extension the #security-reviews team stumbled across hard-coded demo data in the Lexeme code base. Before T168260: Deploy WikibaseLexeme extension on Wikimedia cluster these must all be removed, and possibly replaced with proper implementations:


Everything in the directory src/DemoData:
AskOut1Populator, AskOut2Populator, AskOut3Populator, HardLexemePopulator, LeiterLexemePopulator, and usages:
Currently exclusively used in LexemeContent.

Id.php is a set of constants.
Used in above populators.
Also directly used in LexemeContent.


FormIdFormatter.php and SenseIdFormatter.php are basically nothing but dummies with hard-coded demo-data.
resources/experts/Form.js and resources/experts/Sense.js contain the same demo data.

TASK DETAILhttps://phabricator.wikimedia.org/T188899EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: RazShuty, Ladsgroup, Jonas, Aleksey_WMDE, WMDE-leszek, Lydia_Pintscher, thiemowmde, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Claimed] T165151: investigate if we can remove/minimize jumping when loading Special:NewLexeme

2018-03-05 Thread Jakob_WMDE
Jakob_WMDE claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T165151EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: gerritbot, thiemowmde, Jakob_WMDE, Aklapper, Lydia_Pintscher, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Raised Priority] T188378: Error for some Lua modules "The time allocated for running scripts has expired"

2018-03-05 Thread thiemowmde
thiemowmde raised the priority of this task from "Lowest" to "Normal".thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde added a project: Performance.thiemowmde added a comment.
What generally changed since November 2015 is:


The Items are all bigger now. Here are the diffs for two randomly picked example Items from the California maintenance list: https://www.wikidata.org/w/index.php?title=Q400522=626131991=310722154, https://www.wikidata.org/w/index.php?title=Q805375=594954459=275088526.
Way more pages use way more information from Wikidata, which means the available CPU resources need to be shared between way more processes often running at the same time.


The next step in this task should be to recreate an example use case on a local system, and profile the code involved to find bottlenecks. Maybe it's wb_terms again? Quite possible.TASK DETAILhttps://phabricator.wikimedia.org/T188378WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T74157: [Story] Use rc_source and drop RC_TYPE

2018-03-05 Thread thiemowmde
thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from needs discussion or investigation to in progress on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T74157WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, gerritbot, PokestarFan, Liuxinyu970226, Ricordisamoa, Krenair, Lydia_Pintscher, aude, Aklapper, bd808, EBernhardson, Quiddity, Spage, Mattflaschen-WMF, DannyH, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Lewizho99, Maathavan, Trizek-WMF, SBisson, Wikidata-bugs, Gryllida, jeblad, Catrope, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs