[Wikidata-bugs] [Maniphest] [Commented On] T202785: Federation request to https://ld.stadt-zuerich.ch/query fails

2018-08-27 Thread Smalyshev
Smalyshev added a comment.
From this: https://stackoverflow.com/questions/47730864/jetty-client-cant-connect-to-jetty-server-via-http-2 it sounds like there's no OOB support in Jetty for going from HTTP/1 to HTTP/2, at least not without some coding. So I am not sure how to support this now.TASK DETAILhttps://phabricator.wikimedia.org/T202785EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Gehel, Aklapper, Smalyshev, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T202785: Federation request to https://ld.stadt-zuerich.ch/query fails

2018-08-27 Thread Smalyshev
Smalyshev added a subscriber: Gehel.Smalyshev added a comment.
I suspect the problem may be in HTTP/2. Looking into communication with ld.stadt-zuerich.ch, it seems to be switching to HTTP/2. https://www.eclipse.org/jetty/documentation/current/http2.html says:

To use HTTP/2 in Jetty via a TLS connector you need to add the ALPN boot jar in the boot classpath. This is done automatically when using the Jetty distribution’s start.jar module system, but must be configured directly otherwise.

Maybe this is missing. @Gehel, I wonder if you know anything about this?TASK DETAILhttps://phabricator.wikimedia.org/T202785EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Gehel, Aklapper, Smalyshev, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-08-27 Thread Smalyshev
Smalyshev added a comment.
@Imarlier yes, I suspect it might be Wikidata recentchanges API being slow, and I wonder if there's a way to check that (i.e. whether there are a lot of slow requests there and whether there are bumps in slow requests correlated with WDQS recentchanges load fails).TASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Imarlier, Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Vali.matei, Zppix, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-08-27 Thread Imarlier
Imarlier added a comment.
Hey, @Smalyshev -- Did you tag perf team on this because you're hoping that we can help with the investigation?TASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ImarlierCc: Imarlier, Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Vali.matei, Zppix, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-08-27 Thread Gehel
Gehel added a comment.
Digging into this a bit more from the WDQS side, we see a few interesting things:


The NoHttpResponseException seems to not be a timeout client side, but an empty response (not even headers), with a state transition. It looks similar to what we would see if an intermediate proxy would cleanly terminate the TCP connection before the server had sent any data (so timeout on the proxy < timeout on the server)
We see many more occurrences of the issue on the public wdqs cluster in eqiad than on the others (so more occurrences on the cluster that has more load). See kibana.
High lag on wdqs (updates from wikidata lagging behind) are sometimes correlated with high rate of NoHttpResponseException. But that correlation is far from perfect, with high rate of NoHttpResponseException happening with no impact on wdqs lag.
The high lag times are correlated with high system load. This would indicate a correlation between load on blazegraph and timeouts on wikidata. Maybe through CPU starvation. Note that we also see wikidata timeouts when load is low.


I can come up with plenty of scenarios which explain part of the symptoms, but nothing that make sense of all of them. I'm not entirely sure that the issue is on the wikidata side. It is possible that the issue (or at least part of the issue) is related to WDQS itself.TASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Vali.matei, Zppix, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455630 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix undeletion write-both/read-old mode.

https://gerrit.wikimedia.org/r/455630TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, gerritbotCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T194015: Make PageArchive aware of MCR

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455630 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix undeletion write-both/read-old mode.

https://gerrit.wikimedia.org/r/455630TASK DETAILhttps://phabricator.wikimedia.org/T194015EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, gerritbotCc: hashar, Aklapper, gerritbot, CCicalese_WMF, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T174024: Implement MCR revision retrieval interface

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455630 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix undeletion write-both/read-old mode.

https://gerrit.wikimedia.org/r/455630TASK DETAILhttps://phabricator.wikimedia.org/T174024EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, gerritbotCc: Abit, tstarling, Addshore, gerritbot, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T174024: Implement MCR revision retrieval interface

2018-08-27 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T174024EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, gerritbotCc: Abit, tstarling, Addshore, gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T171140: Enable Wikidata support for Outreach Wiki

2018-08-27 Thread Urbanecm
Urbanecm renamed this task from "Enable support for Outreach Wiki" to "Enable Wikidata support for Outreach Wiki".
TASK DETAILhttps://phabricator.wikimedia.org/T171140EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrbanecmCc: Framawiki, Kaganer, Jane023, PokestarFan, Koavf, Lydia_Pintscher, Aklapper, Ricordisamoa, Candalua, Krenair, MZMcBride, Darkdadaah, intracer, Micru, Liuxinyu970226, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Zoranzoki21, LawExplorer, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T200563: wdq1003 is anomalous

2018-08-27 Thread Smalyshev
Smalyshev added a comment.
Another anomaly on 1003 - it gets the bulk of timeout errors from wikidata (T202764): https://logstash.wikimedia.org/goto/b9eada384c246bf953a3abf8fc362f90TASK DETAILhttps://phabricator.wikimedia.org/T200563EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Stashbot, Gehel, Aklapper, Smalyshev, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T201217: Load daily diffs to WDQS instead of weekly dumps

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 454067 merged by Gehel:
[operations/puppet@production] Enable daily category diffs on test

https://gerrit.wikimedia.org/r/454067TASK DETAILhttps://phabricator.wikimedia.org/T201217EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, gerritbotCc: gerritbot, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-08-27 Thread Ladsgroup
Ladsgroup added subscribers: WMDE-leszek, Lydia_Pintscher, Ladsgroup.Ladsgroup added a comment.
CC @Lydia_Pintscher  @WMDE-leszekTASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, WMDE-leszek, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Imarlier, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Vali.matei, Zppix, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T202912: [W4Q1iwpEEj4AAG9APN4AAAAK] /wiki/Albert_Einstein MediaWiki\Services\NoSuchServiceException from line 445 of /srv/mediawiki/php-master/includes/services/S

2018-08-27 Thread Aklapper
Aklapper edited projects, added Lexicographical data; removed wikiba.se.Restricted Application added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T202912EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T200350: Impossibility to use Ping project on projects over 50 participants

2018-08-27 Thread MMiller_WMF
MMiller_WMF added a comment.
We are considering this for Growth team maintenance work.TASK DETAILhttps://phabricator.wikimedia.org/T200350EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MMiller_WMFCc: MMiller_WMF, kaldari, Dispenser, Daniel_Mietchen, Wostr, Liuxinyu970226, Jklamo, PKM, Mahir256, Yair_rand, Quiddity, Yann, Hsarrazin, Aklapper, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Taiwania_Justo, SBisson, Luke081515, Wikidata-bugs, aude, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T202912: [W4Q1iwpEEj4AAG9APN4AAAAK] /wiki/Albert_Einstein MediaWiki\Services\NoSuchServiceException from line 445 of /srv/mediawiki/php-master/includes/services/S

2018-08-27 Thread Jdlrobson
Jdlrobson triaged this task as "Unbreak Now!" priority.Jdlrobson added a comment.Restricted Application added subscribers: Liuxinyu970226, TerraCodes.
guessing this classes as unbreak now?TASK DETAILhttps://phabricator.wikimedia.org/T202912EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T202912: [W4Q1iwpEEj4AAG9APN4AAAAK] /wiki/Albert_Einstein MediaWiki\Services\NoSuchServiceException from line 445 of /srv/mediawiki/php-master/includes/services/S

2018-08-27 Thread Jdlrobson
Jdlrobson created this task.Jdlrobson added a project: wikiba.se.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONWhen visiting https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein or https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein (mobile or desktop)

I see the following error

[W4Q1rgpEEj4AAGKXd2EA] /wiki/Albert_Einstein MediaWiki\Services\NoSuchServiceException from line 445 of /srv/mediawiki/php-master/includes/services/ServiceContainer.php: No such service: WikibaseLexemeTermLanguages

Backtrace:

#0 /srv/mediawiki/php-master/includes/services/ServiceContainer.php(408): MediaWiki\Services\ServiceContainer->createService(string)
#1 /srv/mediawiki/php-master/extensions/WikibaseLexeme/src/WikibaseLexemeServices.php(18): MediaWiki\Services\ServiceContainer->getService(string)
#2 /srv/mediawiki/php-master/extensions/WikibaseLexeme/src/WikibaseLexemeHooks.php(141): Wikibase\Lexeme\WikibaseLexemeServices::getTermLanguages()
#3 /srv/mediawiki/php-master/includes/Hooks.php(174): Wikibase\Lexeme\WikibaseLexemeHooks::onWikibaseContentLanguages(array)
#4 /srv/mediawiki/php-master/includes/Hooks.php(234): Hooks::callHook(string, array, array, NULL, string)
#5 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/WikibaseContentLanguages.php(51): Hooks::runWithoutAbort(string, array)
#6 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/WikibaseClient.php(1236): Wikibase\Lib\WikibaseContentLanguages::getDefaultInstance()
#7 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/WikibaseClient.php(1248): Wikibase\Client\WikibaseClient->getWikibaseContentLanguages()
#8 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(286): Wikibase\Client\WikibaseClient->getTermsLanguages()
#9 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(88): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->newLanguageIndependentLuaBindings()
#10 /srv/mediawiki/php-master/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(487): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->getLanguageIndependentLuaBindings()
#11 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaSandbox/Engine.php(393): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->getEntityId(string)
#12 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#13 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaSandbox/Engine.php(316): LuaSandboxFunction->call(LuaSandboxFunction)
#14 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaCommon/LuaCommon.php(295): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#15 /srv/mediawiki/php-master/extensions/Scribunto/includes/engines/LuaCommon/LuaCommon.php(967): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#16 /srv/mediawiki/php-master/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#17 /srv/mediawiki/php-master/includes/parser/Parser.php(3478): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#18 /srv/mediawiki/php-master/includes/parser/Parser.php(3185): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#19 /srv/mediawiki/php-master/includes/parser/Preprocessor_Hash.php(1114): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#20 /srv/mediawiki/php-master/includes/parser/Preprocessor_Hash.php(1546): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#21 /srv/mediawiki/php-master/includes/parser/Parser.php(3356): PPTemplateFrame_Hash->cachedExpand(string, PPNode_Hash_Tree)
#22 /srv/mediawiki/php-master/includes/parser/Preprocessor_Hash.php(1114): Parser->braceSubstitution(array, PPFrame_Hash)
#23 /srv/mediawiki/php-master/includes/parser/Parser.php(2999): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#24 /srv/mediawiki/php-master/includes/parser/Parser.php(1345): Parser->replaceVariables(string)
#25 /srv/mediawiki/php-master/includes/parser/Parser.php(474): Parser->internalParse(string)
#26 /srv/mediawiki/php-master/includes/content/WikitextContent.php(341): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#27 /srv/mediawiki/php-master/includes/content/AbstractContent.php(516): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#28 /srv/mediawiki/php-master/includes/poolcounter/PoolWorkArticleView.php(145): AbstractContent->getParserOutput(Title, integer, ParserOptions)
#29 /srv/mediawiki/php-master/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#30 /srv/mediawiki/php-master/includes/page/Article.php(604): PoolCounterWork->execute()
#31 /srv/mediawiki/php-master/includes/actions/ViewAction.php(68): Article->view()
#32 

[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread Anomie
Anomie added a comment.
We should get it fixed before 1.32 is released (or did MCR undeletion make it into 1.31? I forget). For Wikimedia sites I can just make sure everything got migrated as I'm already doing.TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, AnomieCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread daniel
daniel added a comment.
It looks like the "fake" SlotRecord created by RevisionStore::newRevisionFromArchiveRow() passes the $slot->hasRevision() check in RevisionStore::insertRevisionInternal() so it doesn't actually insert it.

That's as designed (well, partially): when undeleting, it should not be necessary to insert slot rows, since they should already be there. That's of course not the case when undeleting from an unmigrated archive row. Nasty edge case, lucky we still write the "old" info the revision table, otherwise we would have lost these revisions!

This will never happen when the database in a consistently migrated or unmigrated state, but we probably want to properly deal with this in RevisionStore. How urgent do you think this is?TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, danielCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T195440: Special:NewLexeme - improve suggestions for "Lexical category"

2018-08-27 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
See also T189744.TASK DETAILhttps://phabricator.wikimedia.org/T195440EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, Aklapper, Liuxinyu970226, abian, Lydia_Pintscher, Jan_Dittrich, daniel, Ladsgroup, VIGNERON, Micru, Jakob_WMDE, thiemowmde, eranroz, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201821: Entity selector for grammatical feature should suggest grammatical features mostly

2018-08-27 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
See also T189744.TASK DETAILhttps://phabricator.wikimedia.org/T201821EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: WMDE-leszek, Lydia_Pintscher, Ladsgroup, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread Anomie
Anomie added a comment.
Also it looks like undeletions can somehow manage to escape the script, if the undeletion happens between when the rev_id is reached in revision and when the ar_rev_id is reached in archive. Found a few on commonswiki so far, and I won't be too surprised if there are more on enwiki or other big wikis.

It looks like the "fake" SlotRecord created by RevisionStore::newRevisionFromArchiveRow() passes the $slot->hasRevision() check in RevisionStore::insertRevisionInternal() so it doesn't actually insert it.TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, AnomieCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T189744: Add hints parameter to wbsearchentities

2018-08-27 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* Specify grammatlexical category for Lexemeeme as Q-id (T195440)
* Specify grammatical features for Forms as Q-id (T201821)

For Item search:...TASK DETAILhttps://phabricator.wikimedia.org/T189744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, Lydia_PintscherCc: Jonas, EBernhardson, gerritbot, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202287: Implement new File page design using OOUI

2018-08-27 Thread Cparle
Cparle added a comment.
Note that the captions are expected to appear first on the page, see https://www.dropbox.com/s/kuv5d2gu3y7x430/Display%20caption%20on%20File%20Page.png?dl=0TASK DETAILhttps://phabricator.wikimedia.org/T202287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: gerritbot, MarkTraceur, Aklapper, Ramsey-WMF, PDrouin-WMF, Cparle, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, E1presidente, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-27 Thread daniel
daniel added a comment.
we'd have to have someplace for third-party installations to store their revision text, and whatever that mechanism is (not necessarily an external store), would be supported along with the external store. We also need to support installations that do not enable MCR. What that all looks like should be dealt with then. Until then, it's ok to continue to use the text ids as is.

Not enabling MCR is not a thing - it's not necessarily use MCR, but 1.32 will use the MCR storage schema, with content addresses instead of text ID, for all storage. The old schema will be supported  for B/C, but I'd want it to be dropped in 1.33. rev_text_id will then no longer exist (and if it exists, it will be 0). The content address is an integral part of the new storage schema as deployed, the live sites will start relying on it soon, though rev_text_id will still be written for B/C until nothing uses it anymore.

So, for the new schema, I'd highly recommend to remove any mention of a numeric text ID, in favor of an opaque content address. See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/443608/14 for the patch that makes the dump infrastructure use addresses instead of text IDs. Review would be appreciated, since that patch blocks the SDC project. (the patch currently fails CI, but that failure is inherited from the parent patch - working on it).TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlenn, danielCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189744: Add hints parameter to wbsearchentities

2018-08-27 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
@Jonas Would your current way of doing this also be possible for the language, lexical category and grammatical features on Lexeme pages as well as units for quantity values and languages for monolingual text values? I'm asking because these are not attached to a property and I'm not sure how that could be done there. Or do we need to go with the hints parameter as suggested in this ticket for those cases?TASK DETAILhttps://phabricator.wikimedia.org/T189744EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, Lydia_PintscherCc: Jonas, EBernhardson, gerritbot, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, FloNight, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-27T16:31:53Z]  Running populateContentTables.php on advisorswiki for T183488 and T202904TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, StashbotCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196085: Metrics for search success on commons

2018-08-27 Thread Cparle
Cparle added a comment.
See here for prior art on the subject https://meta.wikimedia.org/wiki/Research:Baseline_Metrics_for_Structured_Data_on_Wikimedia_Commons#File_searchTASK DETAILhttps://phabricator.wikimedia.org/T196085EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: Aklapper, Cparle, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread daniel
daniel added a comment.

In T183488#4535083, @Anomie wrote:
I'm running queries on all wikis to see if there are any revision or archive rows lacking a slots row. That found T202904 so far.


Wow, nice find!TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, danielCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T198105: Merge Lexemes via a Special Page

2018-08-27 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T198105EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Pablo-WMDE, Liuxinyu970226, KaMan, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198105: Merge Lexemes via a Special Page

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455589 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] i18n: add messages for merge summaries

https://gerrit.wikimedia.org/r/455589TASK DETAILhttps://phabricator.wikimedia.org/T198105EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Pablo-WMDE, Liuxinyu970226, KaMan, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread Anomie
Anomie added a comment.
I'm running queries on all wikis to see if there are any revision or archive rows lacking a slots row. That found T202904 so far.TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, AnomieCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196485: WDQS diskspace is low

2018-08-27 Thread ops-monitoring-bot
ops-monitoring-bot added a comment.
Completed auto-reimage of hosts:

['wdqs2003.codfw.wmnet']

and were ALL successful.TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ops-monitoring-botCc: ops-monitoring-bot, gerritbot, Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread daniel
daniel added a comment.
@Anomie What do you think of re-running the script on a few more wikis, as a spot check to verify that it finds nothing to do? If otoh the script finds stuff to migrate, something is wrong...TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, danielCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T202706: wmf.18 - "Failed to load blob from address" while merging entities

2018-08-27 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)); removed MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
TASK DETAILhttps://phabricator.wikimedia.org/T202706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, ReleaseTaggerBotCc: Stashbot, Sabas88, Liuxinyu970226, Robby, Nikki, gerritbot, daniel, Addshore, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, Agabi10, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Assigned] T198105: Merge Lexemes via a Special Page

2018-08-27 Thread Pablo-WMDE
Pablo-WMDE assigned this task to Tarrow.
TASK DETAILhttps://phabricator.wikimedia.org/T198105EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, Pablo-WMDECc: Pablo-WMDE, Liuxinyu970226, KaMan, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198105: Merge Lexemes via a Special Page

2018-08-27 Thread Pablo-WMDE
Pablo-WMDE added a comment.
I tried the integration of all our changes. I seems to work, supports the expected error handling, and makes sense overall.
The only thing I found a bit irritating on the "success page" is that the lexeme ids I just successfully merged (and mentioned in the success message) are pre-filled into the form fields again - which, of course, leads to an error (the source can not be found another time) when clicking "Merge Lexemes" another time.TASK DETAILhttps://phabricator.wikimedia.org/T198105EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, Liuxinyu970226, KaMan, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196485: WDQS diskspace is low

2018-08-27 Thread ops-monitoring-bot
ops-monitoring-bot added a comment.
Script wmf-auto-reimage was launched by gehel on neodymium.eqiad.wmnet for hosts:

['wdqs2003.codfw.wmnet']

The log can be found in /var/log/wmf-auto-reimage/201808271550_gehel_5518.log.TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ops-monitoring-botCc: ops-monitoring-bot, gerritbot, Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202706: wmf.18 - "Failed to load blob from address" while merging entities

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455112 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Pass IDBAccessObject flag to RevisionStore in WikiPageEntityRevisionLookup

https://gerrit.wikimedia.org/r/455112TASK DETAILhttps://phabricator.wikimedia.org/T202706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Stashbot, Sabas88, Liuxinyu970226, Robby, Nikki, gerritbot, daniel, Addshore, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, Agabi10, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Project Column] T201168: [Trailblaze] Create recommendation system prototype for property suggestions

2018-08-27 Thread fdans
fdans moved this task from Incoming to Radar on the Analytics board.
TASK DETAILhttps://phabricator.wikimedia.org/T201168WORKBOARDhttps://phabricator.wikimedia.org/project/board/11/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: fdansCc: JAllemandou, Addshore, Jonas, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-27T15:49:02Z]  Re-running populateContentTables.php on aawikibooks, gotwikibooks, kswikiquote, lvwikibooks, nostalgiawiki, wawikibooks and wikimania2005wiki for T183488TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, StashbotCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread Anomie
Anomie closed this task as "Resolved".Anomie added a comment.
Confirmed that no wikis have duplicate ar_rev_id values now.TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Stashbot, gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T183488: MCR schema migration stage 2: populate new fields

2018-08-27 Thread Anomie
Anomie closed subtask T202032: Duplicate ar_rev_id values in several wikis as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: tstarling, AnomieCc: jcrespo, greg, tstarling, Stashbot, Abit, gerritbot, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T183489: MCR schema migration stage 1: Fix Legacy Archive Rows

2018-08-27 Thread Anomie
Anomie closed subtask T193180: Clean up archive rows with duplicate revision IDs as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T183489EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Abit, Jdforrester-WMF, Aklapper, aude, Addshore, Anomie, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T193180: Clean up archive rows with duplicate revision IDs

2018-08-27 Thread Anomie
Anomie closed this task as "Resolved".Anomie added a comment.
See T202032 for all the action.TASK DETAILhttps://phabricator.wikimedia.org/T193180EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Aklapper, gerritbot, greg, Stashbot, CCicalese_WMF, daniel, Addshore, aude, Jdforrester-WMF, Abit, Anomie, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196485: WDQS diskspace is low

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455563 merged by Gehel:
[operations/puppet@production] configured wqds to use RAID10

https://gerrit.wikimedia.org/r/455563TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: ops-monitoring-bot, gerritbot, Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T198105: Merge Lexemes via a Special Page

2018-08-27 Thread Pablo-WMDE
Pablo-WMDE closed subtask T202626: Lexeme merge error messages as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T198105EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Liuxinyu970226, KaMan, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T202626: Lexeme merge error messages

2018-08-27 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T202626EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Lydia_Pintscher, Jakob_WMDE, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202626: Lexeme merge error messages

2018-08-27 Thread Pablo-WMDE
Pablo-WMDE added a comment.
Apparently +/- identical to what is done for item merging.
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/i18n/en.json#L248 ffTASK DETAILhttps://phabricator.wikimedia.org/T202626EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Lydia_Pintscher, Jakob_WMDE, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196485: WDQS diskspace is low

2018-08-27 Thread ops-monitoring-bot
ops-monitoring-bot added a comment.
Script wmf-auto-reimage was launched by gehel on neodymium.eqiad.wmnet for hosts:

['wdqs2003.codfw.wmnet']

The log can be found in /var/log/wmf-auto-reimage/201808271540_gehel_3833.log.TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ops-monitoring-botCc: ops-monitoring-bot, gerritbot, Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T189808: Make undo work with multiple slots.

2018-08-27 Thread Anomie
Anomie updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONWhen using the "undo" function to undo an edit (or a series of edits), changes to all slots should be undone, not just changes to the main slot.
This means that the logic for undoing edits needs to be extracted from EditPage.

At present, undo simply fails if multiple slots are involved, see {T194412}.

Note that undo presently allows manual editing of the content to be undone. This is not possible for all kinds of content (see ContentHandler::supportsDirectEditing), and EditPage also does not currently support editing multiple slots at once.

It would probably be acceptable to not offer the ability to manually edit during an undo  (check with product/UX), at least if the undo spans multiple slots. Or manual editing is only offered for the main slot - this seems ok for the SDC use case, but may be surprising when multiple slots are text based.The editable slots should be made available for additional editing, We should at least show a warning explaining thisas is currently the case for (most) single-content revisions.

Proposed implementation:
Create an UndoAction that works for multiple slots, and functions be showing a diff, and a button to confirm the edit, with no editing ability. In Action::getActionName(), if $actionName === "edit", check if the page has multiple slots (a WikiPage is constructed towards the end of that method anyway). If it has multiple slots, set $actionName = 'undo', triggering the new code. 

UndoAction may later gain editing ability, or may otherwise be consolidated with code that is being factored out of EditPage. For now, this approach allows us to implement undo logic that will work for SDC without touching the old behavior.At present, Note that undo logic will have to be factored out of EditPage anyway at some point.undo redirects to a special action that displays a diff with no editing capability when non-main slots are involved, This could act as a first stepsee {T200216}.

However: depending on how much of the logic in EditPage::internalAttemptSave needs to be replicated (especially,Implementing this will depend on the updating of the edit form itself to be able to handle multiple slots. At a high level, the edit form takes serialized Content data for each slot to populate the form. The initial loading of the page (e.g. conflict resolution and various hook points,from an edit link) generally gets this data from a saved revision. including edit filters)When the user requests a preview or diff, it may make more sense to at least have a partial refactoring of EditPage,it gets this data from the user's submission. to avoid duplicating this logicAn undo would get the data from the Content objects returned by `ContentHandler::getUndoContent()`.

Some considerations:
* Undo should not offer any free form editing ability for models for which ContentHandler::supportsDirectEditing returns false.
* Perhaps free form editing can be dropped from the undo function completely. If we keep it,Note that not all content models support direct editing of the content (see `ContentHandler::supportsDirectEditing`). we'll need {T174033}.
* A diff for each slot should be shown for confirmationThe undo content for such slots must be preserved through the process of displaying the edit form, {T194731}.
* If undo supports editingdisplaying any previews and diffs requested by the user, it needs to support preview!and finally saving the edit. If it does not support editing,The "edit" interface for such slots should probably display a diff or other indication that changes will be made to the slot. it could show a preview right away,  {T174036}.

Any previews and diffs requested by the user while editing should include the changes to the uneditable slots.TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Jdforrester-WMF, gerritbot, Tgr, CCicalese_WMF, Anomie, Aklapper, -jem-, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Reassigned] T202778: add ssds to wdqs2003

2018-08-27 Thread Papaul
Papaul reassigned this task from Papaul to Gehel.Papaul added a comment.
Disks are in placeTASK DETAILhttps://phabricator.wikimedia.org/T202778EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, PapaulCc: Stashbot, Mathew.onipe, Aklapper, mark, faidon, Addshore, Smalyshev, RobH, Papaul, Gehel, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, Wong128hk, Cmjohnson, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Southparkfan, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189808: Make undo work with multiple slots.

2018-08-27 Thread Anomie
Anomie added a comment.
The task was originally a combination of "make undo fully work, including editing of directly-editable slots" and the hack for SDC that was eventually split into T200216, plus some musing on the feasibility of fundamentally changing how undo works that I'm sure would not fly with our on-wiki editor communities.

I'm going to rewrite it to reflect only the bit that wasn't split out, and remove the aforementioned musing.TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Jdforrester-WMF, gerritbot, Tgr, CCicalese_WMF, Anomie, Aklapper, -jem-, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202778: add ssds to wdqs2003

2018-08-27 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-27T15:26:43Z]  taking wdqs2003 offline for SSD installation - T202778TASK DETAILhttps://phabricator.wikimedia.org/T202778EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Papaul, StashbotCc: Stashbot, Mathew.onipe, Aklapper, mark, faidon, Addshore, Smalyshev, RobH, Papaul, Gehel, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, Wong128hk, Cmjohnson, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Southparkfan, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2018-08-27 Thread ArielGlenn
ArielGlenn added a comment.
That was very helpful, thanks.

Okay, here's my take.  At some point in the future (unknown when), we might lose the text table; we'd have to have someplace for third-party installations to store their revision text, and whatever that mechanism is (not necessarily an external store), would be supported along with the external store. We also need to support installations that do not enable MCR. What that all looks like should be dealt with then. Until then, it's ok to continue to use the text ids as is.

Because there's some doubt about which element a given parser may grab if it expects the element to be unique (see T199121#4494050), I'd rather avoid having multiple text elements and use the safer, if less satisfying, mixed format for now, of an unwrapped text element tag formatted the same old way, and new content tags which will be unlooked for and hopefully ignored by existing tools.This also avoids duplicating revision information into the text attributes for the main slot for the sake of backwards compatibility.   I agree that when we come up to another breaking change in the future, we should revisit the mixed format.

It's true that most information we provide about the content element really will be attributes of the content in a given slot and not pieces of data somehow bundled up as part of the content, so it would more properly be represented as attributes rather an as revision child elements. We could move the attributes into the content tag thus:



for first-pass ('stub') dumps, or like this:

stuff goes here...
... 


for second-pass (revision content) dumps.
In the case that the revision has been suppressed/deleted, we could produce the following:



for either pass of the dumps. We would do this for each slot (except 'main', which would be formatted as a plain old boring text element in the way currently done), since suppression/deletion is at the revision level only, not per slot.

What do folks think about the above?TASK DETAILhttps://phabricator.wikimedia.org/T199121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ArielGlennCc: tstarling, awight, JAllemandou, hoo, pmiazga, Nemo_bis, brion, Tgr, Aklapper, Fjalapeno, ArielGlenn, daniel, kostajh, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, Lunewa, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, SBisson, gnosygnu, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, GWicke, jayvdb, Ricordisamoa, fbstj, Lydia_Pintscher, Fabrice_Florin, Raymond, santhosh, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T196485: WDQS diskspace is low

2018-08-27 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Zppix, Maathavan, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196485: WDQS diskspace is low

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455563 had a related patch set uploaded (by Mathew.onipe; owner: Mathew.onipe):
[operations/puppet@production] configured wqds to use RAID10

https://gerrit.wikimedia.org/r/455563TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T202897: Make multi-lingual captions on the File page editable using javascript

2018-08-27 Thread Cparle
Cparle created this task.Cparle added projects: Wikidata, Multimedia, Structured-Data-Commons, Multimedia-Team-Working-Board, Epic, Patch-For-Review.Restricted Application removed a project: Patch-For-Review.
TASK DESCRIPTIONMake multi-lingual captions on the File page editable using _javascript_ (and OOUI in particular)TASK DETAILhttps://phabricator.wikimedia.org/T202897EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: PDrouin-WMF, Ramsey-WMF, Aklapper, MarkTraceur, gerritbot, Cparle, Lahi, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196485: WDQS diskspace is low

2018-08-27 Thread Mathew.onipe
Mathew.onipe added a comment.
@Gehel Alright then.TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mathew.onipeCc: Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T202896: Display multi-lingual captions on File page using php

2018-08-27 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T202896EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, gerritbotCc: PDrouin-WMF, Ramsey-WMF, Aklapper, MarkTraceur, gerritbot, Cparle, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, E1presidente, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, V4switch, LawExplorer, Lewizho99, Maathavan, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202896: Display multi-lingual captions on File page using php

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455204 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Inject multi-lingual caption data into the File page content

https://gerrit.wikimedia.org/r/455204TASK DETAILhttps://phabricator.wikimedia.org/T202896EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, gerritbotCc: PDrouin-WMF, Ramsey-WMF, Aklapper, MarkTraceur, gerritbot, Cparle, Lahi, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T202896: Display multi-lingual captions on File page using php

2018-08-27 Thread Cparle
Cparle created this task.Cparle added projects: Wikidata, Multimedia, Structured-Data-Commons, Multimedia-Team-Working-Board, Epic, Patch-For-Review.Restricted Application removed a project: Patch-For-Review.
TASK DESCRIPTIONAs the first part of T202287, inject html for multi-lingual file captions into the html on the File pageTASK DETAILhttps://phabricator.wikimedia.org/T202896EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: PDrouin-WMF, Ramsey-WMF, Aklapper, MarkTraceur, gerritbot, Cparle, Lahi, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, V4switch, LawExplorer, Susannaanas, Wong128hk, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Matanya, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-27T14:43:51Z]  Running deduplicateArchiveRevId.php on gotwikibooks, kswikiquote, lvwikibooks, nostalgiawiki, wawikibooks and wikimania2005wiki for T202032TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, StashbotCc: Stashbot, gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-27T14:42:44Z]  Running deduplicateArchiveRevId.php on aawikibooks for T202032TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, StashbotCc: Stashbot, gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202676: Support non-Q and non-P items in custom Wikibase installations

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455073 abandoned by Yurik:
[WIP] Allow custom Item & Prop prefixes

Reason:
See https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /455480/ instead

https://gerrit.wikimedia.org/r/455073TASK DETAILhttps://phabricator.wikimedia.org/T202676EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Aleksey_WMDE, WMDE-leszek, Lydia_Pintscher, thiemowmde, Bugreporter, gerritbot, daniel, Aklapper, Yurik, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T198104: Merge Lexemes via the API

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455568 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Add wblmergelexemes endpoint

https://gerrit.wikimedia.org/r/455568TASK DETAILhttps://phabricator.wikimedia.org/T198104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T198104: Merge Lexemes via the API

2018-08-27 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T198104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T189101: Deploy schema change for adding numeric primary key to wbqc_constraints table

2018-08-27 Thread WMDE-leszek
WMDE-leszek set Due Date to Sun, Sep 9, 10:00 PM.Restricted Application changed the subtype of this task from "Task" to "Deadline".
TASK DETAILhttps://phabricator.wikimedia.org/T189101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: jcrespo, Marostegui, Ladsgroup, Aklapper, Jonas, hoo, aude, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Salgo60, Agabi10, Luke081515, Wikidata-bugs, Lydia_Pintscher, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Raised Priority] T189101: Deploy schema change for adding numeric primary key to wbqc_constraints table

2018-08-27 Thread WMDE-leszek
WMDE-leszek raised the priority of this task from "Normal" to "High".WMDE-leszek added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T189101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: jcrespo, Marostegui, Ladsgroup, Aklapper, Jonas, hoo, aude, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Salgo60, Agabi10, Luke081515, Wikidata-bugs, Lydia_Pintscher, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202676: Support non-Q and non-P items in custom Wikibase installations

2018-08-27 Thread Yurik
Yurik added a comment.
@thiemowmde @daniel my last patch only refactors Wikibase extension a bit, without touching the data model.  It fixes the last few places I found that used direct Item ID parsing/composition, instead using the same common interface used by other code.  Are there any concerns with that?  For example, Lua function getSiteLink() used TermIdconstructor, whereas all other code in that same file used EntityParser instance.

Merging this code should be a noop for Wikidata, and it may even simplify T114904 -- all related code may be in one place.  Or it certainly shouldn't get in the way of the db migration.

So if this patch has no impact on Wikidata, but helps us, could you merge it to help us?

I do understand your point about the UI, but sadly that's the problem -- it is not just UI issue in OSM.  The OSM ecosystem is much less centralized than Wikidata.  There is no single editor to make it consistent. There is no common validation system. There is really only one "convention" that all tools understand -- that OSM data is stored as a simple key-value string table. Tools do not assume anything else about the data, e.g. semantic meaning of the keys, etc.  So it is almost always up to the users to type in or copy/paste all values.

One of the conventions is how Wikidata Q items are entered - e.g. wikidata = Q42. Any user in any tool can instantly tell that Q42 is a Wikidata item, and some tools even make it into a link using heuristics, e.g. if the key contains the word wikidata, and the value matches Qnnn regex, it shows as a link, but other tools simply show it as text.  Most OSM users by now are fairly well versed in this.

If we introduce OSM Wikibase, it will be stored in the same way - a text string, with some key. For example, if community decides to introduce a few items in OSM Wikibase, e.g. "type of OSM feature", and possibly one more "something else", the feature key-value table would look like this:


keyvalue
feature_typeQ123
wikidataQ456
something_elseQ789



As you can see, this is very confusing. We cannot suddenly change how we store Wikidata items - that will break all of the existing tools and data consumers.  Requiring an`osm:Q123` style for osm-stored items would also lead to problems - many users will simply forget to type it in, and multiple OSM editing tools make it impossible to effectively enforce it. Having no way to visually distinguish the source of item will potentially create a chaos.

I have already extensively tested my patch, and it seems that it solves what we need - effective way to store "osm items" as having different prefix.  I'm sure I can work with other tools to adapt them to this need as well.TASK DETAILhttps://phabricator.wikimedia.org/T202676EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: YurikCc: WMDE-leszek, Lydia_Pintscher, thiemowmde, Bugreporter, gerritbot, daniel, Aklapper, Yurik, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Reassigned] T194043: Replace usages of Content::getSecondaryDataUpdates

2018-08-27 Thread CCicalese_WMF
CCicalese_WMF reassigned this task from Anomie to Tgr.CCicalese_WMF added a subscriber: Anomie.
TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, CCicalese_WMFCc: Anomie, gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).
TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, ReleaseTaggerBotCc: Stashbot, gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189101: Deploy schema change for adding numeric primary key to wbqc_constraints table

2018-08-27 Thread jcrespo
jcrespo added a comment.
Please if you could give this a lot of priority, because if we miss this "train" (switchover) we could be waiting for a full extra year. Thanks. PK changes are not easy to do normally.TASK DETAILhttps://phabricator.wikimedia.org/T189101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: jcrespo, Marostegui, Ladsgroup, Aklapper, Jonas, hoo, aude, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Luke081515, Wikidata-bugs, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T202894: Track orphan Wikidata items or entities on Grafana

2018-08-27 Thread abian
abian created this task.abian added projects: Wikidata, WMDE-Analytics-Engineering.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONIt would be great to be able to check the ratio orphan/total and its evolution on a Grafana dashboard, where orphan is the number of Wikidata items or entities with no links from other items or entities, and total is the total number of Wikidata items or entities.

Context/motivation: https://en.wikipedia.org/wiki/Wikipedia:Orphan.TASK DETAILhttps://phabricator.wikimedia.org/T202894EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: Aklapper, abian, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T201362: Grafana dashboard with the number of Wikidata entities indexed in each language

2018-08-27 Thread abian
abian added a project: WMDE-Analytics-Engineering.
TASK DETAILhttps://phabricator.wikimedia.org/T201362EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: Aklapper, abian, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189101: Deploy schema change for adding numeric primary key to wbqc_constraints table

2018-08-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.
constraint_guid should be kept. The SQL patch above re-adds the index on it, but not the UNIQUE constraint, so we’ll have to fix that. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T189101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: jcrespo, Marostegui, Ladsgroup, Aklapper, Jonas, hoo, aude, gerritbot, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Luke081515, Wikidata-bugs, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread Anomie
Anomie added a comment.
Note the above backport should wind up having almost no effect on live Wikimedia wikis at this time, since the only ones that seem affected by the MySQL bug are closed wikis where there's no ability to edit. The only effect should be two more SELECT MAX($field) FROM $table-style queries during the creation of each revision, and a few microseconds of PHP code.

The backport was mainly so I can start re-running the maintenance scripts today instead of waiting until the end of the week.TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Stashbot, gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-27T13:25:34Z]  Synchronized php-1.32.0-wmf.18/includes/Storage/RevisionStore.php: Backport for T202032 (duration: 00m 49s)TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, StashbotCc: Stashbot, gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 40 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.18] Make sure we don't try to use a deleted rev ID.

https://gerrit.wikimedia.org/r/40TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, gerritbotCc: gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T202891: Embed toolbars are hidden behind map controls

2018-08-27 Thread Jonas
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...{F25419505}

Tasks:
[ ] Fix z-index for toolbars in embed.htmlTASK DETAILhttps://phabricator.wikimedia.org/T202891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Aklapper, Jonas, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T202891: Embed toolbars are hidden behind map controls

2018-08-27 Thread Jonas
Jonas created this task.Jonas added projects: Wikidata, Wikidata Query UI, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONFrom discussion in T201908: Bug report: Missing number of hits in resultset when displaying a Map 

Toolbars should be in front of map controls when toolbar is expanded.
F25419502: image.png

F25419505: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T202891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Aklapper, Jonas, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202032: Duplicate ar_rev_id values in several wikis

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 40 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@wmf/1.32.0-wmf.18] Make sure we don't try to use a deleted rev ID.

https://gerrit.wikimedia.org/r/40TASK DETAILhttps://phabricator.wikimedia.org/T202032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, gerritbotCc: gerritbot, Aklapper, daniel, aude, Addshore, Anomie, Abit, jcrespo, tstarling, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202223: WikibaseLexeme LexemeSpecialWhatLinksHereTest tests fail on Math CI

2018-08-27 Thread Physikerwelt
Physikerwelt added a comment.
I am not sure what to do. Creating all tables is certainly a workaround. However, that would be different from the production setup and create tables that might never be used. I suspected that it could be related to the use of the  globals to access the config. However, that did not help either.TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PhysikerweltCc: hashar, gerritbot, MarcoAurelio, Pablo-WMDE, Addshore, WMDE-leszek, Aklapper, Physikerwelt, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Izno, Wikidata-bugs, aude, fredw, Pkra, Darkdadaah, scfc, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202223: WikibaseLexeme LexemeSpecialWhatLinksHereTest tests fail on Math CI

2018-08-27 Thread gerritbot
gerritbot added a comment.
Change 455482 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/extensions/Math@master] Avoid globals in MathRenderer::getValidModes

https://gerrit.wikimedia.org/r/455482TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: hashar, gerritbot, MarcoAurelio, Pablo-WMDE, Addshore, WMDE-leszek, Aklapper, Physikerwelt, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Izno, Wikidata-bugs, aude, fredw, Pkra, Darkdadaah, scfc, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T202890: Collapse icon of mini map not present in build

2018-08-27 Thread Jonas
Jonas created this task.Jonas added projects: Wikidata, Wikidata Query UI, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONFrom discussion in T201908: Bug report: Missing number of hits in resultset when displaying a Map 
Colapse icon of mini map is missing on query.wikidata.org
F25423189: image.png

Task:


 Fix gruntfile.js include collapse icon in grunt build task
TASK DETAILhttps://phabricator.wikimedia.org/T202890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Aklapper, Jonas, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Salgo60, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T77972: [Story] Always show P248 (stated in), P854 (reference URL) and P813 (date of retrieval) when adding sources

2018-08-27 Thread matej_suchanek
matej_suchanek added a project: Wikidata-Gadgets.
TASK DETAILhttps://phabricator.wikimedia.org/T77972EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Esc3300, Conny, hoo, Liuxinyu970226, Lydia_Pintscher, Mbch331, Sjoerddebruin, aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, Wikidata-bugs, Ricordisamoa___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T77972: [Story] Always show P248 (stated in), P854 (reference URL) and P813 (date of retrieval) when adding sources

2018-08-27 Thread matej_suchanek
matej_suchanek added a comment.
With T199672#4529546 merged, this should be a piece of cake.TASK DETAILhttps://phabricator.wikimedia.org/T77972EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Esc3300, Conny, hoo, Liuxinyu970226, Lydia_Pintscher, Mbch331, Sjoerddebruin, aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T153684: Autofill link for Wikidata's citoid gadget: data retrieval should be signified

2018-08-27 Thread Deskana
Deskana triaged this task as "Low" priority.Deskana removed a project: VisualEditor.
TASK DETAILhttps://phabricator.wikimedia.org/T153684EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DeskanaCc: Charlie_WMDE, aude, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Mvolz, Sjoerddebruin, Mbch331, iamjessklein, marcella, Necroarcano, Robinma, merbst, Wess, Srdjan_m, Jrf, Husun1297, Swainr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T153685: Autofill link for Wikidata's citoid gadget: wording

2018-08-27 Thread Deskana
Deskana triaged this task as "Low" priority.Deskana removed a project: VisualEditor.
TASK DETAILhttps://phabricator.wikimedia.org/T153685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DeskanaCc: Charlie_WMDE, Lydia_Pintscher, aude, Aklapper, Jan_Dittrich, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, Shangkuanlc, mobrovac, Wikidata-bugs, Ricordisamoa, Mvolz, Sjoerddebruin, Mbch331, iamjessklein, marcella, Necroarcano, Robinma, merbst, Wess, Srdjan_m, Jrf, Husun1297, Swainr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T141855: [Task] Handle publisher as part of citoid support for Wikidata

2018-08-27 Thread Deskana
Deskana removed a project: VisualEditor.
TASK DETAILhttps://phabricator.wikimedia.org/T141855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DeskanaCc: aude, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Shangkuanlc, mobrovac, Wikidata-bugs, Mvolz, Mbch331, iamjessklein, marcella, Necroarcano, Robinma, merbst, Wess, Srdjan_m, Jrf, Husun1297, Swainr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T153683: Autofill link for Wikidata's citoid gadget should be closer to autofilled area

2018-08-27 Thread Deskana
Deskana triaged this task as "Low" priority.Deskana removed a project: VisualEditor.
TASK DETAILhttps://phabricator.wikimedia.org/T153683EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DeskanaCc: Lydia_Pintscher, Aklapper, Jan_Dittrich, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, Shangkuanlc, mobrovac, Wikidata-bugs, aude, Ricordisamoa, Mvolz, Sjoerddebruin, Mbch331, iamjessklein, marcella, Necroarcano, Robinma, merbst, Wess, Srdjan_m, Jrf, Husun1297, Swainr___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T196485: WDQS diskspace is low

2018-08-27 Thread Gehel
Gehel added a comment.
Note that data import after reimage can be done by copying over data from wdqs1010, which has been reimported recently. Procedure is documented on https://wikitech.wikimedia.org/wiki/Wikidata_query_service#Data_transfer_procedure.TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T202778: add ssds to wdqs2003

2018-08-27 Thread Gehel
Gehel added a subscriber: Mathew.onipe.Gehel added a comment.
@Papaul: we'll start by reimaging wdqs2003 (wdqs200[12] to follow). We'll reimage them one by one, to ensure that we have at most 1 host down in the cluster at any time.

@Papaul: ping me when you are around, and I'll depool / shutdown wdqs2003 to let you add the disks. I'll take it over for reimaging and data import.TASK DETAILhttps://phabricator.wikimedia.org/T202778EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Papaul, GehelCc: Mathew.onipe, Aklapper, mark, faidon, Addshore, Smalyshev, RobH, Papaul, Gehel, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, Wong128hk, Cmjohnson, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Southparkfan, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T196485: WDQS diskspace is low

2018-08-27 Thread Gehel
Gehel added a subscriber: Mathew.onipe.Gehel added a comment.
To not duplicate infos on each of the child tasks, I'll add anything that is common to all on this task.

We'll take this occasion to reimage the systems, so that we can validate that we have a working partman configuration with the new disks as well. Newer wdqs servers use the raid10-gpt-srv-lvm-ext4 recipe. We should use the same. We will loose a bit of disk space, since the new disks are slightly larger than the old ones (960GB vs 800GB). We are unlikely to need those GB for a few years, and by that time, those systems will be out of warranty. So let's choose simplicity and coherence over maximization of disk space that we're probably not going to need.TASK DETAILhttps://phabricator.wikimedia.org/T196485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Mathew.onipe, Cmjohnson, RobH, Aklapper, Gehel, Smalyshev, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Avner, Zppix, Jonas, FloNight, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202706: wmf.18 - "Failed to load blob from address" while merging entities

2018-08-27 Thread Sabas88
Sabas88 added a comment.
@Addshore thank you very much, I just tried another merge and I didn't get the errorTASK DETAILhttps://phabricator.wikimedia.org/T202706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Sabas88Cc: Stashbot, Sabas88, Liuxinyu970226, Robby, Nikki, gerritbot, daniel, Addshore, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, Agabi10, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T169775: Declare Wikibase JavaScript hooks stable

2018-08-27 Thread Jonas
Jonas added a comment.
@Addshore @WMDE-leszek  if you agree I would add a section 'Stable hooks' to the https://www.wikidata.org/wiki/Wikidata:Stable_Interface_Policy stating that all hooks defined in https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/docs/hooks.txt excluding deprecated hooks are considered stable.TASK DETAILhttps://phabricator.wikimedia.org/T169775EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Jonas, WMDE-leszek, Addshore, Lea_Lacroix_WMDE, Aleksey_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202706: wmf.18 - "Failed to load blob from address" while merging entities

2018-08-27 Thread Addshore
Addshore added a comment.
Fixed in production, but the patch still needs to be reviewed and merged on master so leaving this open.

This still blocks this weeks train as the master patch should be merged before the branch.
If it is not then it should again be backported onto the newly cut branch.TASK DETAILhttps://phabricator.wikimedia.org/T202706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Stashbot, Sabas88, Liuxinyu970226, Robby, Nikki, gerritbot, daniel, Addshore, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, Agabi10, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T202706: wmf.18 - "Failed to load blob from address" while merging entities

2018-08-27 Thread Stashbot
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-08-27T11:59:58Z]  Synchronized php-1.32.0-wmf.18/extensions/Wikibase/lib/includes: [[gerrit:455542]] Pass IDBAccessObject flag to RevisionStore in WikiPageEntityRevisionLookup T202706 (duration: 00m 51s)TASK DETAILhttps://phabricator.wikimedia.org/T202706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, StashbotCc: Stashbot, Sabas88, Liuxinyu970226, Robby, Nikki, gerritbot, daniel, Addshore, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, Agabi10, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T202706: wmf.18 - "Failed to load blob from address" while merging entities

2018-08-27 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
TASK DETAILhttps://phabricator.wikimedia.org/T202706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, ReleaseTaggerBotCc: Stashbot, Sabas88, Liuxinyu970226, Robby, Nikki, gerritbot, daniel, Addshore, Aklapper, Bugreporter, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, JJMC89, Maathavan, Agabi10, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T169775: Declare Wikibase JavaScript hooks stable

2018-08-27 Thread Jonas
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [ x] [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/454012/ | Add documentation about hooks in the code (/docs/hooks.txt) ]]...TASK DETAILhttps://phabricator.wikimedia.org/T169775EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Jonas, WMDE-leszek, Addshore, Lea_Lacroix_WMDE, Aleksey_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Salgo60, Lewizho99, Maathavan, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


  1   2   >