[Wikidata-bugs] [Maniphest] [Closed] T217897: Reduce / remove the aggessive cache busting behaviour of wdqs-updater

2019-05-07 Thread Smalyshev
Smalyshev closed this task as "Resolved". Smalyshev added a comment. Update now uses revision IDs everywhere for non-lagged fetches. TASK DETAIL https://phabricator.wikimedia.org/T217897 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc

[Wikidata-bugs] [Maniphest] [Updated] T153353: Blazegraph not properly using labels from sub-queries for filtering (omitting rows), unless they're selected

2019-05-07 Thread Smalyshev
Smalyshev added a project: User-Smalyshev. TASK DETAIL https://phabricator.wikimedia.org/T153353 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Igorkim78, Aklapper, Smalyshev, hoo, darthmon_wmde, alaa_wmde, joker88john, ET4Eva, CucyNoi

[Wikidata-bugs] [Maniphest] [Commented On] T153353: Blazegraph not properly using labels from sub-queries for filtering (omitting rows), unless they're selected

2019-05-07 Thread Smalyshev
Smalyshev added a comment. I am a bit cautions about adding stuff to annotations because there's some code that scans all the annotations and unexpected annotations may confuse it. That's why btw it is not possible to add reference to query base as annotation to child node (there's `parent`

[Wikidata-bugs] [Maniphest] [Claimed] T222695: Create buttons

2019-05-07 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T222695 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE Cc: Tarrow, Jakob_WMDE, Matthias_Geisler_WMDE, Aklapper, Pablo-WMDE, Hanna_Petruschat

[Wikidata-bugs] [Maniphest] [Commented On] T222697: Implement generic overlay capability

2019-05-07 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE added a comment. Maybe a good candidate for 3rd party?: https://www.npmjs.com/package/vue-js-modal TASK DETAIL https://phabricator.wikimedia.org/T222697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE C

[Wikidata-bugs] [Maniphest] [Commented On] T222692: research links, where do the urls come from (incl `returnto` params)

2019-05-07 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE added a comment. In file MobileFrontend/src/mobile.editor.overlay/EditorOverlay.js: LN 270: The url is build by mw.util.getUrl( 'AnyIdentifier', params ) LN 253ff: The parameter are set TASK DETAIL https://phabricator.wikimedia.org/T222692 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Claimed] T222692: research links, where do the urls come from (incl `returnto` params)

2019-05-07 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T222692 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilova

[Wikidata-bugs] [Maniphest] [Unblock] T215304: "Depicts walking": Add/edit depicts statements in UploadWizard

2019-05-07 Thread Ramsey-WMF
Ramsey-WMF closed subtask T219947: Metadata/Add data step right alignment issues as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T215304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ramsey-WMF Cc: Edtadros, matthiasmullie, gerritbot,

[Wikidata-bugs] [Maniphest] [Unblock] T215304: "Depicts walking": Add/edit depicts statements in UploadWizard

2019-05-07 Thread Ramsey-WMF
Ramsey-WMF closed subtask T216298: [Alpha/Labs] Note CC0 license for all structured data on the new UploadWizard "Metadata" step as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T215304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ram

[Wikidata-bugs] [Maniphest] [Closed] T215304: "Depicts walking": Add/edit depicts statements in UploadWizard

2019-05-07 Thread Ramsey-WMF
Ramsey-WMF closed this task as "Resolved". Ramsey-WMF added a comment. Done! yay! TASK DETAIL https://phabricator.wikimedia.org/T215304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ramsey-WMF Cc: Edtadros, matthiasmullie, gerritbot, Abit, Jdfor

[Wikidata-bugs] [Maniphest] [Unblock] T199352: Deploy Structured Data on Commons with arbitrary Statements

2019-05-07 Thread Ramsey-WMF
Ramsey-WMF closed subtask T215304: "Depicts walking": Add/edit depicts statements in UploadWizard as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T199352 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ramsey-WMF Cc: Yann, Abbe98, Cparle

[Wikidata-bugs] [Maniphest] [Unblock] T215304: "Depicts walking": Add/edit depicts statements in UploadWizard

2019-05-07 Thread Ramsey-WMF
Ramsey-WMF closed subtask T219944: Upload Wizard depicts heading/label should match what's been updated for File Page as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T215304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ramsey-WMF Cc:

[Wikidata-bugs] [Maniphest] [Updated] T153353: Blazegraph not properly using labels from sub-queries for filtering (omitting rows), unless they're selected

2019-05-07 Thread Igorkim78
Igorkim78 added a comment. The EmptyLabelServiceOptimizer running optimizeJoinGroup(AST2BOpContext, StaticAnalysis, IBindingSet[], JoinGroupNode) as of current takes projection from StaticAnalisys.getQueryRoot() as parent of JoinGroupNode wrapping statement pattern of the LabelService clause

[Wikidata-bugs] [Maniphest] [Commented On] T153353: Blazegraph not properly using labels from sub-queries for filtering (omitting rows), unless they're selected

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508725 had a related patch set uploaded (by Igor Kim; owner: Igor Kim): [wikidata/query/rdf@master] Propagate Projection from SubqueryNode to where clause https://gerrit.wikimedia.org/r/508725 TASK DETAIL https://phabricator.wikimedia.org/T153353 EM

[Wikidata-bugs] [Maniphest] [Updated] T153353: Blazegraph not properly using labels from sub-queries for filtering (omitting rows), unless they're selected

2019-05-07 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T153353 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Igorkim78, Aklapper, Smalyshev, hoo, darthmon_wmde, alaa_wmde, joker88john, ET4Eva, CucyN

[Wikidata-bugs] [Maniphest] [Updated] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14). TASK DETAIL https://phabricator.wikimedia.org/T222449 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Ladsgroup, Michael, darthmon_wmde, alaa_wmde, joker8

[Wikidata-bugs] [Maniphest] [Updated] T222090: UnexpectedValueException when clearing Lexeme via wbeditentity without providing new language

2019-05-07 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T222090 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Krinkle Cc: Tarrow, Lucas_Werkmeister_WMDE, darthmon_wmde, alaa_wmde, Nandana, Mringgaard, Lahi, G

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. It still fails in beta cluster because of not being able to find the item. TASK DETAIL https://phabricator.wikimedia.org/T222449 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Michael, darthmon_

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508617 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Give elastic on beta more time to recognize created items https://gerrit.wikimedia.org/r/508617 TASK DETAIL https://phabricator.wikimedia.org/T222449 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T222159: WikibaseMediaInfo serializes empty statements as empty array [] instead of empty object {} in JSON

2019-05-07 Thread Ramsey-WMF
Ramsey-WMF added a project: Multimedia-Current-Work. TASK DETAIL https://phabricator.wikimedia.org/T222159 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ramsey-WMF Cc: Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, alaa_wmde, Edtadros, Nandana, J

[Wikidata-bugs] [Maniphest] [Edited] T222695: Create buttons

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T222695 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Tarrow, Jakob_WMDE, Matthias_Geisler_WMDE, Aklapper, Pablo-WMDE, Hanna_Petruschat_WMDE, dart

[Wikidata-bugs] [Maniphest] [Edited] T222695: Create buttons

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE added subscribers: Jakob_WMDE, Tarrow. Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T222695 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Tarrow, Jakob_WMDE, Matthias_Geisler_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T222090: UnexpectedValueException when clearing Lexeme via wbeditentity without providing new language

2019-05-07 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07). TASK DETAIL https://phabricator.wikimedia.org/T222090 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, ReleaseTaggerBot Cc: Tarrow, Lucas_Werkmeister_WMDE, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Commented On] T222707: switch eslint to require dangling comma with "always-multiline"

2019-05-07 Thread Michael
Michael added a comment. Thank you a lot! I appreciate this digging into ancient history :) I now understand better how this rule came to be, thank you 🙏 These missing commas and thus suboptimal diffs are only a very minor annoyance at most and I'm not sure they are worth the time an

[Wikidata-bugs] [Maniphest] [Commented On] T222695: Create buttons

2019-05-07 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE added a comment. Could we please extend the description...it is a bit brief and I guess hardly to understand right way on the first look what is ment and why it is in order on this position. TASK DETAIL https://phabricator.wikimedia.org/T222695 EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Created] T222751: port Wikibase Selenium misc tests from Ruby to Node.js

2019-05-07 Thread Michael
Michael created this task. Michael added projects: Wikidata, wikidata-tech-focus, Browser-Tests, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This refers to the following test files: - non_existing_item.feature - edit_tab.feature - delete_ite

[Wikidata-bugs] [Maniphest] [Created] T222749: port Wikibase Selenium tests about statements from Ruby to Node.js

2019-05-07 Thread Michael
Michael created this task. Michael added projects: Wikidata, wikidata-tech-focus, Browser-Tests, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This refers to the following test files: - statement.feature - statements_geo.feature - statements_i

[Wikidata-bugs] [Maniphest] [Created] T222748: port Wikibase Selenium tests about sitelinks from Ruby to Node.js

2019-05-07 Thread Michael
Michael created this task. Michael added projects: Wikidata, Browser-Tests, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This refers to the following two test files: - sitelinks.feature (16 scenarios) - sitelinks_badge.feature ( 5 scenarios) TA

[Wikidata-bugs] [Maniphest] [Created] T222746: port Wikibase Selenium smoke tests from Ruby to Node.js

2019-05-07 Thread Michael
Michael created this task. Michael added projects: Wikidata, Browser-Tests, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This refers to the following test files: - item_smoke.feature - property_smoke.feature TASK DETAIL https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T222090: UnexpectedValueException when clearing Lexeme via wbeditentity without providing new language

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 507261 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] WikiPageEntityStore: Don't try to save invalid content https://gerrit.wikimedia.org/r/507261 TASK DETAIL https://phabricator.wikimedia.org/T222090 EMAIL PREFERENCES https://p

[Wikidata-bugs] [Maniphest] [Commented On] T222192: Replace WikibaseSchema repository content with message pointing to EntitySchema

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. In T222192#5165175 , @WMDE-leszek wrote: > repo is read only, so behaves as expected :) > Made it active for you for the time being. Please report once changed ,so will make it read only again. Thank

[Wikidata-bugs] [Maniphest] [Created] T222745: port Wikibase Selenium tests about termbox editing from Ruby to Node.js

2019-05-07 Thread Michael
Michael created this task. Michael added projects: Wikidata, Browser-Tests, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This task includes porting the following feature browsertests from ruby to nodejs: - label.feature (6 scenarios of which 4 ar

[Wikidata-bugs] [Maniphest] [Updated] T222192: Replace WikibaseSchema repository content with message pointing to EntitySchema

2019-05-07 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T222192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, gerritbot Cc: Lydia_Pintscher, Aklapper, Lea_Lacroix_WMDE, hoo, noarave, Michael, WMDE-lesze

[Wikidata-bugs] [Maniphest] [Commented On] T222192: Replace WikibaseSchema repository content with message pointing to EntitySchema

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508633 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/WikibaseSchema@master] Remove everything https://gerrit.wikimedia.org/r/508633 TASK DETAIL https://phabricator.wikimedia.org/T222192 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T222192: Replace WikibaseSchema repository content with message pointing to EntitySchema

2019-05-07 Thread WMDE-leszek
WMDE-leszek added a comment. repo is read only, so behaves as expected :) Made it active for you for the time being. Please report once changed ,so will make it read only again. TASK DETAIL https://phabricator.wikimedia.org/T222192 EMAIL PREFERENCES https://phabricator.wikimedia.org/se

[Wikidata-bugs] [Maniphest] [Commented On] T221774: Add Wikidata query service lag to Wikidata maxlag

2019-05-07 Thread Smalyshev
Smalyshev added a comment. > Go through Prometheus or ask the instances individually or …? prometheus & icinga know what is the lag for each server, so I think it's better to ask them? I am not sure if we have good support for scheduled recurrent jobs on Wiki - if we do, we could just ma

[Wikidata-bugs] [Maniphest] [Commented On] T221774: Add Wikidata query service lag to Wikidata maxlag

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. A very minor note: WDQS depends heavily on mediawiki nodes to function, making mediawiki apps to depend on WDQS (which we already has done in WikibaseQualityConstraints) will make a cyclic dependency that bit Wikipedia a lot with ores extension and ores service. Ov

[Wikidata-bugs] [Maniphest] [Commented On] T222192: Replace WikibaseSchema repository content with message pointing to EntitySchema

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. To ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseSchema ! [remote rejected] HEAD -> refs/publish/master (project state does not permit write) error: failed to push some refs to 'ssh://ladsgr...@gerrit.wikimedia.org:29418/mediawiki/extensio

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T222707: switch eslint to require dangling comma with "always-multiline"

2019-05-07 Thread Jdforrester-WMF
Jdforrester-WMF added a subscriber: DanielFriesen. Jdforrester-WMF added a comment. In T222707#5164954 , @Michael wrote: > In T222707#5164890 , @Jdforrester-WMF wrote: > > > The codi

[Wikidata-bugs] [Maniphest] [Claimed] T222192: Replace WikibaseSchema repository content with message pointing to EntitySchema

2019-05-07 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T222192 WORKBOARD https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508617 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/WikibaseLexeme@master] Give elastic on beta more time to recognize created items https://gerrit.wikimedia.org/r/508617 TASK DETAIL https://phabri

[Wikidata-bugs] [Maniphest] [Updated] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T222449 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Ladsgroup, Michael, darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIri

[Wikidata-bugs] [Maniphest] [Commented On] T221946: rename repository for WikibaseSchema

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508614 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions@master] Rename WikibaseSchema to EntitySchema https://gerrit.wikimedia.org/r/508614 TASK DETAIL https://phabricator.wikimedia.org/T221946 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Updated] T222707: switch eslint to require dangling comma with "always-multiline"

2019-05-07 Thread Michael
Michael added a project: Front-end-Standards-Group. Michael added a comment. In T222707#5164890 , @Jdforrester-WMF wrote: > The coding standard you link is not "MediaWiki's", it's Wikimedia's, and is meant to apply to all production code

[Wikidata-bugs] [Maniphest] [Commented On] T221946: rename repository for WikibaseSchema

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. The integration patch has been merged by the old repo still exist in beta cluster instead. I'm trying to find out where config for that is stored. No luck so far. TASK DETAIL https://phabricator.wikimedia.org/T221946 EMAIL PREFERENCES https://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T222707: switch eslint to require dangling comma with "always-multiline"

2019-05-07 Thread Jdforrester-WMF
Jdforrester-WMF added a comment. The coding standard you link is not "MediaWiki's", it's Wikimedia's, and is meant to apply to all production code. I disagree with your argument (the developer community has had this conversation befo

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread Michael
Michael added a comment. In T222449#5164836 , @Ladsgroup wrote: > It might be the classic issue of elastic not being able to index the newly created item. We had this issue in Wikibase itself a lot. But then, why does everything

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. In T222449#5164843 , @Michael wrote: > In T222449#5164836 , @Ladsgroup wrote: > > > It might be the classic issue of elastic not being able to index the n

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. In T222449#5164806 , @Michael wrote: > The images show that the id that should have been created was not found. I will try to figure out what is going on. > > F28955913: image.png

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread Michael
Michael added a comment. The images show that the id that should have been created was not found. I will try to figure out what is going on. F28955913: image.png TASK DETAIL https://phabricator.wikimedia.org/T222449 EMAIL PREFERENCES htt

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread thcipriani
thcipriani added a comment. In T222621#5164600 , @alaa_wmde wrote: > @thcipriani yes it has been reverted already ah, hadn't realized, thank you! TASK DETAIL https://phabricator.wikimedia.org/T222621 EMAIL PREFERENCES https:

[Wikidata-bugs] [Maniphest] [Unassigned] T217243: Add baserevid to WikibaseLexeme API modules

2019-05-07 Thread alaa_wmde
alaa_wmde removed alaa_wmde as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T217243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: alaa_wmde, Tarrow, gerritbot, Addshore, Aklapper, darthmon_wmde, joker88john

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. After the release, I manually restarted the build and all passed except these two: https://integration.wikimedia.org/ci/view/Selenium/job/selenium-daily-beta-WikibaseLexeme/256/console 17:29:24 1) Lexeme:Header can edit the language of a Lexeme: 17:29:24

[Wikidata-bugs] [Maniphest] [Closed] T222444: Create new wdio-wikibase release

2019-05-07 Thread alaa_wmde
alaa_wmde closed this task as "Resolved". alaa_wmde added a comment. In T222444#5164674 , @Ladsgroup wrote: > Out of the three bullet points in the acceptance criteria, this is not done only: > > > there exists documentation somewher

[Wikidata-bugs] [Maniphest] [Unassigned] T194737: Improve features for wikibase vandalism detection model

2019-05-07 Thread Ladsgroup
Ladsgroup removed Ladsgroup as the assignee of this task. Ladsgroup edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T194737 EMAIL PREFERENCES https://phabricator.wikimedia.org/s

[Wikidata-bugs] [Maniphest] [Updated] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread alaa_wmde
alaa_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T222621 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: alaa_wmde, thcipriani,

[Wikidata-bugs] [Maniphest] [Unblock] T199409: [Bug] NewLexeme suggester menu appears behind special page tab

2019-05-07 Thread alaa_wmde
alaa_wmde closed subtask T222444: Create new wdio-wikibase release as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T199409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, alaa_wmde Cc: alaa_wmde, Greta_Doci_WMDE, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Unblock] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-07 Thread alaa_wmde
alaa_wmde closed subtask T222444: Create new wdio-wikibase release as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T222449 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Michael, darthmon_wmde, alaa_wmde, Nandana, Mringgaa

[Wikidata-bugs] [Maniphest] [Commented On] T222444: Create new wdio-wikibase release

2019-05-07 Thread Ladsgroup
Ladsgroup added a comment. Out of the three bullet points in the acceptance criteria, this is not done only: > there exists documentation somewhere how to do a release to npmjs I think then we can close this ticket. TASK DETAIL https://phabricator.wikimedia.org/T222444 EMAIL PREF

[Wikidata-bugs] [Maniphest] [Updated] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread alaa_wmde
alaa_wmde removed a parent task: T220729: 1.34.0-wmf.4 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T222621 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: alaa_wmde, thcipriani, Mholloway, Jdforrester-WMF, Jakob_WM

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread alaa_wmde
alaa_wmde added a comment. @thcipriani yes it has been reverted already TASK DETAIL https://phabricator.wikimedia.org/T222621 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: alaa_wmde, thcipriani, Mholloway, Jdforrester-WMF, Jakob_WM

[Wikidata-bugs] [Maniphest] [Lowered Priority] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread alaa_wmde
alaa_wmde lowered the priority of this task from "Unbreak Now!" to "High". alaa_wmde added a comment. High because this is the last piece of a solution that is ready to go apart from this case. Let's fix this case and ship the working solution. TASK DETAIL https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Changed Project Column] T221612: clear two step process in shex simple tool

2019-05-07 Thread Michael
Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Michael added a comment. As far as I can see, this was implemented in #45 and works as expected. TASK DETAIL https:/

[Wikidata-bugs] [Maniphest] [Commented On] T222681: WikidataPageBanner uses a blacklist of skin names to decide 'prebodyhtml' support instead of sane feature detection

2019-05-07 Thread Isarra
Isarra added a comment. So Jack Phoenix looked into it, and apparently the only public skins he found that support this prebodyhtml thing are Vector, Minerva, and Metrolook. Also, this may be a stupid question, but do we not register such apis in some way? Shouldn't it be possible to jus

[Wikidata-bugs] [Maniphest] [Commented On] T222621: Not possible to edit items via wbeditentity if they have same label and description

2019-05-07 Thread thcipriani
thcipriani added a comment. I notice that this is still blocking the train, but no one has addressed this yet. From the task description: > I checked this is the case by reverting just this commit. Is that a reasonable course of action we could take to remove this as a train bl

[Wikidata-bugs] [Maniphest] [Commented On] T217770: Don't show fingerprints with unidentifyable language codes in termbox

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Lydia_Pintscher @Lea_WMDE Could we please have a quick chat about this, if this is supposed to get any attention at all, to avoid people repeatedly trying to figure out what this is all about. Mind you this is affecting termbox v1 and v2 alike. TASK DETAIL htt

[Wikidata-bugs] [Maniphest] [Triaged] T200432: Labels/aliases/descriptions in Toki Pona need to be removed

2019-05-07 Thread noarave
noarave triaged this task as "Normal" priority. noarave updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T200432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Addshore, Pasleim, matej_suchanek, Mbch331, Harmoni

[Wikidata-bugs] [Maniphest] [Commented On] T222444: Create new wdio-wikibase release

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508547 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Raise minimal wdio-wikibase and wdio-mediawiki to 0.3.0 https://gerrit.wikimedia.org/r/508547 TASK DETAIL https://phabricator.wikimedia.org/T222444 EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Edited] T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one ali

2019-05-07 Thread WMDE-leszek
WMDE-leszek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Ta

[Wikidata-bugs] [Maniphest] [Edited] T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one ali

2019-05-07 Thread WMDE-leszek
WMDE-leszek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Ta

[Wikidata-bugs] [Maniphest] [Edited] T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one ali

2019-05-07 Thread WMDE-leszek
WMDE-leszek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: sarhan.alaa, Lydia_Pintscher, alaa_wmde, Lea_Lacroix_WMDE, thiemowmde, Greta_Doci_WMDE, Ta

[Wikidata-bugs] [Maniphest] [Updated] T200432: Labels/aliases/descriptions in Toki Pona need to be removed

2019-05-07 Thread WMDE-leszek
WMDE-leszek set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T200432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Addshore, Pasleim, matej_suchanek, Mbch331, Harmonia_Amanda, Aklapper, Lydia_P

[Wikidata-bugs] [Maniphest] [Created] T222712: SDC Pilot: support the development of the ISA microcontributions tool

2019-05-07 Thread SandraF_WMF
SandraF_WMF created this task. SandraF_WMF added projects: Wikidata, SDC General, GLAM. TASK DESCRIPTION #isa is a fun, multilingual, mobile-first 'microcontributions' tool, that makes it easy for (groups of inexperienced) people to add structured d

[Wikidata-bugs] [Maniphest] [Edited] T200432: Labels/aliases/descriptions in Toki Pona need to be removed

2019-05-07 Thread WMDE-leszek
WMDE-leszek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T200432 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Addshore, Pasleim, matej_suchanek, Mbch331, Harmonia_Amanda, Aklapper, Lydia_Pintscher, da

[Wikidata-bugs] [Maniphest] [Commented On] T220985: Complete support of Lexemes in QuickStatements

2019-05-07 Thread Lea_Lacroix_WMDE
Lea_Lacroix_WMDE added a comment. A new wish for a full support of Lexemes on QS was mentioned here :) TASK DETAIL https://phabricator.wikimedia.org/T220985 EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Commented On] T217770: Don't show fingerprints with unidentifyable language codes in termbox

2019-05-07 Thread Tarrow
Tarrow added a comment. I'm unable to replicate this bug in desktop "classic" termbox. Perhaps you could have a look @Pablo-WMDE ? My steps were: - add `{{#babel: fil}}` to my user page - load an item Outcome: see a correct tagalog line in the termbox. No problems adding cont

[Wikidata-bugs] [Maniphest] [Retitled] T219375: Handle languages that are no longer supported in Wikibase UI

2019-05-07 Thread WMDE-leszek
WMDE-leszek renamed this task from "Handle languages that are no longer supported" to "Handle languages that are no longer supported in Wikibase UI". TASK DETAIL https://phabricator.wikimedia.org/T219375 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] [Edited] T217770: Don't show fingerprints with unidentifyable language codes in termbox

2019-05-07 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Addshore, Lydia_Pintscher, Pablo-WMDE, gerritbot, WMDE-leszek, Lea_WMDE, Hanna_Petruschat_WM

[Wikidata-bugs] [Maniphest] [Edited] T217770: Don't show fingerprints with unidentifyable language codes in termbox

2019-05-07 Thread WMDE-leszek
WMDE-leszek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Tarrow, Addshore, Lydia_Pintscher, Pablo-WMDE, gerritbot, WMDE-leszek, Lea_WMDE, Hanna_Pet

[Wikidata-bugs] [Maniphest] [Commented On] T221645: Port WikibaseLexeme lexeme_header.feature Selenium tests from Ruby to Node.js

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508333 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Rewrite lexical category ruby test to nodejs https://gerrit.wikimedia.org/r/508333 TASK DETAIL https://phabricator.wikimedia.org/T221645 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] [Updated] T221602: [Problem] Discontinued support of a language breaks edits in Terms

2019-05-07 Thread Tarrow
Tarrow removed a subtask: T217770: Don't show fingerprints with unidentifyable language codes in termbox . TASK DETAIL https://phabricator.wikimedia.org/T221602 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Aklapper, alaa_wmde, d

[Wikidata-bugs] [Maniphest] [Updated] T217770: Don't show fingerprints with unidentifyable language codes in termbox

2019-05-07 Thread Tarrow
Tarrow removed a parent task: T221602: [Problem] Discontinued support of a language breaks edits in Terms. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Addshore, Lydia_Pintsc

[Wikidata-bugs] [Maniphest] [Edited] T217770: Don't show fingerprints with unidentifyable language codes in termbox

2019-05-07 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Addshore, Lydia_Pintscher, Pablo-WMDE, gerritbot, WMDE-leszek, Lea_WMDE, Hanna_Petruschat_WM

[Wikidata-bugs] [Maniphest] [Commented On] T217770: Don't show fingerprints with unidentifyable language codes in termbox

2019-05-07 Thread Tarrow
Tarrow added a comment. @Lea_WMDE Is the meant to have been added to the campsite? As I read it this task is only about changing the new (currently mobile) Termbox that the hike is working on. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T218054: Add UA to node -> mediawiki requests

2019-05-07 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE added a comment. Hey maybe a tiny question but with probably big consequences: As Jakob pointed out, it is good to be stick on the User-Agent policy[ 1 ] of Mediawiki. That also means we have to make smaller changes to the package.json and fill it with the author field

[Wikidata-bugs] [Maniphest] [Commented On] T221602: [Problem] Discontinued support of a language breaks edits in Terms

2019-05-07 Thread Tarrow
Tarrow added a comment. > in edit, term editing should ignore those terms with unsupported languages, allowing the user to intentionally be able to save their edits as well as remove those terms at once. I'm not clear that this is necessary. If we remove the "dead languages" at the time

[Wikidata-bugs] [Maniphest] [Commented On] T222444: Create new wdio-wikibase release

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508547 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/WikibaseLexeme@master] Raise minimal wdio-wikibase and wdio-mediawiki to 0.3.0 https://gerrit.wikimedia.org/r/508547 TASK DETAIL https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T218078: Cache WikibaseContentLanguagesRepo in SSR

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 508175 **merged** by jenkins-bot: [wikibase/termbox@master] WaitingForLanguageWikibaseContentLanguagesRepo: make it cacheable https://gerrit.wikimedia.org/r/508175 TASK DETAIL https://phabricator.wikimedia.org/T218078 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T220977: Investigate surprising rise in mobile page views for wikidata

2019-05-07 Thread GoranSMilovanovic
GoranSMilovanovic added a comment. @Lea_WMDE > If the growth is natural, would it be a valid assumption to assume that the editing behavior for mobile also increased? Inspecting this now. TASK DETAIL https://phabricator.wikimedia.org/T220977 EMAIL PREFERENCES https://phabricato

[Wikidata-bugs] [Maniphest] [Created] T222707: switch eslint to require dangling comma with "always-multiline"

2019-05-07 Thread Michael
Michael created this task. Michael added projects: Wikidata-Campsite, Code-Health, JavaScript. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Having a dangling comma in multiline javascript objects and arrays results in cl

[Wikidata-bugs] [Maniphest] [Commented On] T221645: Port WikibaseLexeme lexeme_header.feature Selenium tests from Ruby to Node.js

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 507811 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Rewrite Lexeme language ruby test to nodejs https://gerrit.wikimedia.org/r/507811 TASK DETAIL https://phabricator.wikimedia.org/T221645 EMAIL PREFERENCES https://phabri

[Wikidata-bugs] [Maniphest] [Commented On] T222444: Create new wdio-wikibase release

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 507959 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Bump wdio-wikibase version https://gerrit.wikimedia.org/r/507959 TASK DETAIL https://phabricator.wikimedia.org/T222444 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Created] T222703: Consider bumping wdio-wikibase version to 1.0.0 and treat it as stable

2019-05-07 Thread Michael
Michael created this task. Michael added a project: Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Currently, wdio-wikibase has 0 as major version which defines it as "still in initial development

[Wikidata-bugs] [Maniphest] [Commented On] T218078: Cache WikibaseContentLanguagesRepo in SSR

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 507940 **merged** by jenkins-bot: [wikibase/termbox@master] Provide a more universal way to cache repository data https://gerrit.wikimedia.org/r/507940 TASK DETAIL https://phabricator.wikimedia.org/T218078 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T218077: Cache MessageRepository in SSR

2019-05-07 Thread gerritbot
gerritbot added a comment. Change 507940 **merged** by jenkins-bot: [wikibase/termbox@master] Provide a more universal way to cache repository data https://gerrit.wikimedia.org/r/507940 TASK DETAIL https://phabricator.wikimedia.org/T218077 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Edited] T222698: Implement IP warning overlay

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T222698 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZan

[Wikidata-bugs] [Maniphest] [Updated] T221831: Add "Your are not logged in" overlay popup on termbox editing

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Termbox-Iteration-15; removed Wikidata-Termbox-Hike. TASK DETAIL https://phabricator.wikimedia.org/T221831 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Lea_WMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Edited] T221831: Add "Your are not logged in" overlay popup on termbox editing

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T221831 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, Matthias_Geisler_WMDE, Tarrow,

[Wikidata-bugs] [Maniphest] [Created] T222698: Implement IP warning overlay

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-15. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - get all the messages - do not HTML escape the message that contains markup (bold) <- discussion had: sanitize it (to restri

[Wikidata-bugs] [Maniphest] [Created] T222697: Implement generic overlay capability

2019-05-07 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-15. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - research 3rd party solutions - for this story behaves as a modal, decision needs to be taken through buttons, can not be "c

  1   2   >