[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-02 Thread gerritbot
gerritbot added a comment. Change 569394 had a related patch set uploaded (by DannyS712; owner: DannyS712): [mediawiki/extensions/TimedMediaHandler@master] Remove confusing $this->doLogin() call https://gerrit.wikimedia.org/r/569394 TASK DETAIL https://phabricator.wikimedia.org/T244

[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-02 Thread gerritbot
gerritbot added a comment. Change 569393 had a related patch set uploaded (by DannyS712; owner: DannyS712): [mediawiki/extensions/Newsletter@master] Remove use of ApiTestCase::doLogin https://gerrit.wikimedia.org/r/569393 TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL P

[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-02 Thread gerritbot
gerritbot added a comment. Change 569392 had a related patch set uploaded (by DannyS712; owner: DannyS712): [mediawiki/extensions/TitleBlacklist@master] Remove use of ApiTestCase::doLogin https://gerrit.wikimedia.org/r/569392 TASK DETAIL https://phabricator.wikimedia.org/T244039 EM

[Wikidata-bugs] [Maniphest] [Triaged] T243955: CachingPropertyInfoLookup doesn't cache lookups internally

2020-02-02 Thread Addshore
Addshore moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board. Addshore triaged this task as "High" priority. Addshore added a comment. At one point we did also cache this for ~10-20s on machines. I both added and removed that last year. It was removed in https:

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-02 Thread gerritbot
gerritbot added a comment. Change 569378 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] WIP Removed "non-entity-source" conditional logic in TermSqlIndex https://gerrit.wikimedia.org/r/569378 TASK DETAIL https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-02 Thread gerritbot
gerritbot added a comment. Change 569376 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in SqlEntityInfoBuilder https://gerrit.wikimedia.org/r/569376 TASK DETAIL https://phab

[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-02 Thread gerritbot
gerritbot added a comment. Change 569368 had a related patch set uploaded (by DannyS712; owner: DannyS712): [mediawiki/extensions/BounceHandler@master] Remove use of ApiTestCase::doLogin https://gerrit.wikimedia.org/r/569368 TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAI

[Wikidata-bugs] [Maniphest] [Updated] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-02 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, gerritbot Cc: Daimona, Aklapper, DannyS712, Un1tY, Hook696, Adidsone1, Falcopragati, Daryl-T

[Wikidata-bugs] [Maniphest] [Updated] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-02 Thread DannyS712
DannyS712 added projects: MediaWiki-extensions-Newsletter, Thanks, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-BounceHandler, MediaWiki-extensions-CodeReview, ORES, TimedMediaHandler, TitleBlacklist. DannyS712 updated the task description. Restricted Application added projects: