[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833853 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich): [design/codex@main] docs, Menu: Separate menu scroll into its own demo https://gerrit.wikimedia.org/r/833853 TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

2022-09-21 Thread Jdlrobson
Jdlrobson added a comment. I think the lack of wprov on keyboard is likely a bug. I think it's fine for these behaviours to be consistent and the conditional behaviour of onSubmit handler seems fine. Regarding the instrumentation, tracking these as a submit event instead of a click also

[Wikidata-bugs] [Maniphest] T317681: Make new Vector search navigate to item search results on Wikidata

2022-09-21 Thread EBernhardson
EBernhardson added a comment. I'm not sure why search results go back into the search engine to be redirected instead of going directly to the page. We return the full link in action=opensearch which is used in other contexts (browser go-bar, etc.). It has simply "always" been that way, at

[Wikidata-bugs] [Maniphest] T317681: Make new Vector search navigate to item search results on Wikidata

2022-09-21 Thread Jdlrobson
Jdlrobson added a project: patch-welcome. Jdlrobson added subscribers: phuedx, EBernhardson. Jdlrobson added a comment. Not sure. I looked through T249366 and T249299 and couldn't find any clues. I

[Wikidata-bugs] [Maniphest] T317702: Not all edgeLabels shown on graph in a Wikibase query service

2022-09-21 Thread Fnielsen
Fnielsen added a comment. In T317702#8251095 , @Addshore wrote: > `LIMIT 154` doesnt seem to work for me, but `LIMIT 100` does. Yes. It seems not to be 154/155 necessarily. `LIMIT 130` works for me currently. TASK DETAIL

[Wikidata-bugs] [Maniphest] T317702: Not all edgeLabels shown on graph in a Wikibase query service

2022-09-21 Thread Addshore
Addshore added a comment. `LIMIT 154` doesnt seem to work for me, but `LIMIT 100` does. So it seems the behaviour of showing / how showing the labels inconsistent And to visually aid folks. Example of labels on edges (connections/arrows) not being shown F35527369: image.png

[Wikidata-bugs] [Maniphest] T187912: Usernames with apostrophes are not well escaped in edit summaries

2022-09-21 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T187912 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Maintenance_bot Cc: aniluom, Swayamsrk, Mormegil, thiemowmde, matej_suchanek,

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833739 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTest https://gerrit.wikimedia.org/r/833739 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL

[Wikidata-bugs] [Maniphest] T317101: WikibaseQualityConstraints Phan CI broken by nullable type of Statement::getGuid()

2022-09-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: WikibaseMediaInfo. Lucas_Werkmeister_WMDE added a comment. Restricted Application added a project: Structured-Data-Backlog. WikibaseMediaInfo also seems to be affected (console

[Wikidata-bugs] [Maniphest] T297513: Wikidata does not allow search for deleted items

2022-09-21 Thread Bovlb
Bovlb added a comment. I have prototyped such a tool at https://wd-deleted.toolforge.org/ TASK DETAIL https://phabricator.wikimedia.org/T297513 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bovlb Cc: MisterSynergy, Lydia_Pintscher, SilentSpike,

[Wikidata-bugs] [Maniphest] T187912: Usernames with apostrophes are not well escaped in edit summaries

2022-09-21 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26). TASK DETAIL https://phabricator.wikimedia.org/T187912 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, ReleaseTaggerBot Cc: aniluom, Swayamsrk, Mormegil,

[Wikidata-bugs] [Maniphest] T187912: Usernames with apostrophes are not well escaped in edit summaries

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833014 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Unescape double and single qoutes while formatting auto-comments. https://gerrit.wikimedia.org/r/833014 TASK DETAIL https://phabricator.wikimedia.org/T187912 EMAIL

[Wikidata-bugs] [Maniphest] T187755: Double quotes in sitelink are displayed as HTML entity in automated edit summary

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833014 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Unescape double and single qoutes while formatting auto-comments. https://gerrit.wikimedia.org/r/833014 TASK DETAIL https://phabricator.wikimedia.org/T187755 EMAIL

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. (The third Gerrit change is just an optional cleanup, and it should probably at least be +1ed by the WBMI developers. The first two Wikibase

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833800 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Revert "Make sure wbUserSpecifiedLanguages is a plain array"

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833799 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Use UserPreferredContentLanguagesLookup for wbUserSpecifiedLanguages

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T311617 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Manuel, Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833798 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Make sure language lookups return plain arrays https://gerrit.wikimedia.org/r/833798 TASK DETAIL

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Note that WikibaseMediaInfo already uses `UserLanguageLookup::getAllUserLanguages()` instead of `::getUserSpecifiedLanguages()` (i.e. includes the language preference). TASK DETAIL https://phabricator.wikimedia.org/T311617 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T312811: 陋️ Provide initial "automated summaries" to statement edits made with Wikibase REST API

2022-09-21 Thread WMDE-leszek
WMDE-leszek added a comment. Due to @WMDE-leszek's failure the incorrect "autocomment" has been requested in the original description, leading to incorrect plural form message to be used in create/update summaries (accidentally working correctly for the removal summary), i.e. "Create

[Wikidata-bugs] [Maniphest] T312811: 陋️ Provide initial "automated summaries" to statement edits made with Wikibase REST API

2022-09-21 Thread WMDE-leszek
WMDE-leszek updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T312811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Jakob_WMDE, Silvan_WMDE, Ollie.Shotton_WMDE, Lydia_Pintscher, Aklapper, WMDE-leszek,

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Okay, I think I’ve found the two code paths that do subtly different things here. - “Server-side order” (initial rendering): - `OutputPageBeforeHTMLHookHandler::getLocallyRenderedEntityViewPlaceholderExpander()` calls

[Wikidata-bugs] [Maniphest] T313638: Coordinates in Structured Data cannot be removed from or changed

2022-09-21 Thread El_Grafo
El_Grafo added a comment. In T313638#8250458 , @Herzi.Pinki wrote: > the solution for this (allow the deletion of false coordinates) is only half way. In principle the bot copied it, the bot shall keep it in sync without user

[Wikidata-bugs] [Maniphest] T313638: Coordinates in Structured Data cannot be removed from or changed

2022-09-21 Thread El_Grafo
El_Grafo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T313638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: El_Grafo Cc: Herzi.Pinki, Fl.schmitt, El_Grafo, Sitacuisses, SJu, Aklapper, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T313638: Coordinates in Structured Data cannot be removed from or changed

2022-09-21 Thread Herzi.Pinki
Herzi.Pinki added a comment. the solution for this (allow the deletion of false coordinates) is only half way. In principle the bot copied it, the bot shall keep it in sync without user intervention. TASK DETAIL https://phabricator.wikimedia.org/T313638 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T313638: Coordinates in Structured Data cannot be removed from or changed

2022-09-21 Thread El_Grafo
El_Grafo added a project: Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T313638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: El_Grafo Cc: Fl.schmitt, El_Grafo, Sitacuisses, SJu, Aklapper, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T313638: Coordinates in Structured Data cannot be removed from or changed

2022-09-21 Thread El_Grafo
El_Grafo renamed this task from "Coordinates cannot be removed from the Structured Data" to "Coordinates in Structured Data cannot be removed from or changed ". TASK DETAIL https://phabricator.wikimedia.org/T313638 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833750 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Stop using prophecy in SidebarLinkBadgeDisplayTest https://gerrit.wikimedia.org/r/833750 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T311617: MUL - Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-09-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T311617 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833749 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Stop using prophecy in WikibaseValueFormatterBuildersTest https://gerrit.wikimedia.org/r/833749 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833748 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTest https://gerrit.wikimedia.org/r/833748 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833744 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTest https://gerrit.wikimedia.org/r/833744 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833737 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Stop using prophecy in WikiPageEntityStoreTest https://gerrit.wikimedia.org/r/833737 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833750 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Stop using prophecy in SidebarLinkBadgeDisplayTest https://gerrit.wikimedia.org/r/833750 TASK DETAIL

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833749 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Stop using prophecy in WikibaseValueFormatterBuildersTest https://gerrit.wikimedia.org/r/833749 TASK

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833748 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryDbTest https://gerrit.wikimedia.org/r/833748

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833744 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Stop using prophecy in EntityIdLocalPartPageTableEntityQueryUnitTest

[Wikidata-bugs] [Maniphest] T318219: Timeline view: vertical and horizontal controls

2022-09-21 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T318219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, VladimirAlexiev, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T318219: Timeline view: vertical and horizontal controls

2022-09-21 Thread VladimirAlexiev
VladimirAlexiev updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T318219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: VladimirAlexiev Cc: Aklapper, VladimirAlexiev, AWesterinen, MPhamWMF, CBogen, Namenlos314, Gq86,

[Wikidata-bugs] [Maniphest] T318219: Timeline view: vertical and horizontal controls

2022-09-21 Thread VladimirAlexiev
VladimirAlexiev created this task. VladimirAlexiev added a project: Wikidata Query UI. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION See this query https://w.wiki/5j55. It has controls on top to tweak the view: F35527011: image.png

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.3; 2022-09-26); removed MW-1.40-notes (1.40.0-wmf.2; 2022-09-19). TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833739 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Stop using prophecy in TypeDispatchingWikiPageEntityMetaDataAccessorTest

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 832496 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove instances of prophecy library in Wikibase https://gerrit.wikimedia.org/r/832496 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833737 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Stop using prophecy in WikiPageEntityStoreTest https://gerrit.wikimedia.org/r/833737 TASK DETAIL

[Wikidata-bugs] [Maniphest] T315966: Handle dependency on phpspec/prophecy

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 832275 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Stop using prophecy in tests https://gerrit.wikimedia.org/r/832275 TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T318137: MUL - Fix mobile termbox styles for present/missing labels/descriptions

2022-09-21 Thread guergana.tzatchkova
guergana.tzatchkova claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T318137 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T312811: 陋️ Provide initial "automated summaries" to statement edits made with Wikibase REST API

2022-09-21 Thread gerritbot
gerritbot added a comment. Change 833728 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek): [mediawiki/extensions/Wikibase@master] REST DNM exploration change for T312811 https://gerrit.wikimedia.org/r/833728 TASK DETAIL

[Wikidata-bugs] [Maniphest] T312811: 陋️ Provide initial "automated summaries" to statement edits made with Wikibase REST API

2022-09-21 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T312811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Jakob_WMDE, Silvan_WMDE, Ollie.Shotton_WMDE, Lydia_Pintscher, Aklapper, WMDE-leszek,