[Wikidata-bugs] [Maniphest] [Updated] T204070: [Spike, 8hrs] Where should Schema property 'sameAs' live?

2018-09-12 Thread Jdlrobson
Jdlrobson set the point value for this task to "0".Jdlrobson added a comment. (to mark we've talked about this in today's estimation meeting)TASK DETAILhttps://phabricator.wikimedia.org/T204070EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: J

[Wikidata-bugs] [Maniphest] [Edited] T204070: [Spike, ?hrs] Where should Schema property 'sameAs' live?

2018-09-12 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...** If so does it need security review? == Outcome * Evaluate all the options and cast a judgement on the best * Send a wikitech-l email (including wikimedia DE) for discussion * Draw a conclusion TASK

[Wikidata-bugs] [Maniphest] [Edited] T204070: [Spike, ?hrs] Where should Schema property 'sameAs' live?

2018-09-12 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* Should this live in [[ https://www.mediawiki.org/wiki/Extension:GoogleRichCards | the Google Rich Cards extension ]] ? * Should it be a gadget? * Should it live in a Wikibase extension?...TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Updated] T204070: [Spike, ?hrs] Where should Schema property 'sameAs' live?

2018-09-11 Thread Jdlrobson
Jdlrobson added a project: Spike. TASK DETAILhttps://phabricator.wikimedia.org/T204070EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Deskana, Aklapper, Krenair, cscott, Imarlier, dr0ptp4kt, phuedx, Niedzielski, CKoerner_WMF, Elitre, Tbayer

[Wikidata-bugs] [Maniphest] [Created] T204070: [Spike, ?hrs] Where should Schema property 'sameAs' live?

2018-09-11 Thread Jdlrobson
Jdlrobson created this task.Jdlrobson triaged this task as "High" priority.Jdlrobson added projects: SEO, MediaWiki-extensions-WikibaseClient, Wikidata, Readers-Web-Backlog. TASK DESCRIPTIONIn T198946 we identified a change we'd like to make to add a tag to the top of pages. While

[Wikidata-bugs] [Maniphest] [Commented On] T198946: Add Schema property 'sameAs' pointing to Wikidata entries

2018-09-05 Thread Jdlrobson
Jdlrobson added a comment. AIUI this is Wikipedia-specific functionality (improving I see this as MediaWiki functionality that is dependent on Wikibase being present, thus Wikibase seems ideal. We'd want to improve SEO for all our wikis, right? Relatedly, how would you feel about reaching out

[Wikidata-bugs] [Maniphest] [Commented On] T198946: Add Schema property 'sameAs' pointing to Wikidata entries

2018-09-04 Thread Jdlrobson
Jdlrobson added a comment. To me, rather than creating a new extension this feels like something that should live in one of the Wikibase extensions. Can we reach out to Wikimedia DE to see where would be appropriate? I don't like the gadget approach as I think we should be building for all search

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T202912: [W4Q1iwpEEj4AAG9APN4AAAAK] /wiki/Albert_Einstein MediaWiki\Services\NoSuchServiceException from line 445 of /srv/mediawiki/php-master/include

2018-08-28 Thread Jdlrobson
Jdlrobson added a subscriber: nray.Jdlrobson added a comment. Thanks all for fixing and thanks @nray for finding the bug!TASK DETAILhttps://phabricator.wikimedia.org/T202912EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, JdlrobsonCc: nray, gerritbot

[Wikidata-bugs] [Maniphest] [Triaged] T202912: [W4Q1iwpEEj4AAG9APN4AAAAK] /wiki/Albert_Einstein MediaWiki\Services\NoSuchServiceException from line 445 of /srv/mediawiki/php-master/includes/services/S

2018-08-27 Thread Jdlrobson
Jdlrobson triaged this task as "Unbreak Now!" priority.Jdlrobson added a comment.Restricted Application added subscribers: Liuxinyu970226, TerraCodes. guessing this classes as unbreak now?TASK DETAILhttps://phabricator.wikimedia.org/T202912EMAIL PREFERENCEShttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Created] T202912: [W4Q1iwpEEj4AAG9APN4AAAAK] /wiki/Albert_Einstein MediaWiki\Services\NoSuchServiceException from line 445 of /srv/mediawiki/php-master/includes/services/S

2018-08-27 Thread Jdlrobson
Jdlrobson created this task.Jdlrobson added a project: wikiba.se.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONWhen visiting https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein or https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein (mobile or desktop) I see

[Wikidata-bugs] [Maniphest] [Commented On] T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found

2018-08-22 Thread Jdlrobson
Jdlrobson added a comment. I also just hit this issue and it broke our staging environment. I've applied the local json fix for the time being from @Smalyshev to restore it.TASK DETAILhttps://phabricator.wikimedia.org/T201615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Closed] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-08-17 Thread Jdlrobson
Jdlrobson closed this task as "Resolved".Jdlrobson added a project: Readers-Web-Kanbanana-Board.Jdlrobson claimed this task.Jdlrobson added a comment. Thanks all for looking into this. Looking at last 90 days, I'm seeing a smooth line from the 10th (before that the lines were extre

[Wikidata-bugs] [Maniphest] [Changed Project Column] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-16 Thread Jdlrobson
Jdlrobson moved this task from Needs Analysis to Tracking on the Readers-Web-Backlog board.Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T199855WORKBOARDhttps://phabricator.wikimedia.org/project/board/67

[Wikidata-bugs] [Maniphest] [Changed Project Column] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-10 Thread Jdlrobson
Jdlrobson moved this task from Inbox to Blocked on the User-Jdlrobson board.Jdlrobson added a comment. ^ takes care of it, but as I'm the only maintainer I'm not sure if it will ever get reviewed :)TASK DETAILhttps://phabricator.wikimedia.org/T199855WORKBOARDhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-08-09 Thread Jdlrobson
Jdlrobson added a comment. I can't seem to replicate the issue anymore on the beta cluster. Hopefully graphs will stabilise from a week tomorrow (16th)! Yay! Thanks all!TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T157014: CONSULTATION/PLAN: Managing Complex State and GUI on MediaWiki (e.g. for Wikidata/Wikibase UI)

2018-07-30 Thread Jdlrobson
Jdlrobson added a comment. My team (reading web) as part of T195473 is planning to use webpack which I'd strongly advise as a precursor to using Vue.js with a complicated UI. We still plan to ship CSS and i18n via ResourceLoader, but are likely to eventually move away from RL for client side

[Wikidata-bugs] [Maniphest] [Commented On] T200639: Positioning of Extension:GeoCrumbs and Extension:WikidataPageBanner

2018-07-30 Thread Jdlrobson
Jdlrobson added a comment. Hey @Atsirlin I think en.wikivoyage uses Page status indicators. I've not used them myself but if that doesn't help I'm hoping one of the subscribers here might be able to guide you.. This seems to be the template they use to add those: https://en.wikivoyage.org/w

[Wikidata-bugs] [Maniphest] [Updated] T200639: Positioning of Extension:GeoCrumbs and Extension:WikidataPageBanner

2018-07-29 Thread Jdlrobson
Jdlrobson added projects: Readers-Web-Backlog (Tracking), User-Jdlrobson.Jdlrobson added subscribers: Zerabat, zhuyifei1999, Sjoerddebruin, Stryn, Glaisher.Jdlrobson added a comment. Hey there! Firstly to workaround this problem, might I suggest the following CSS: .mw-parser-output > *:fi

[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

2018-07-29 Thread Jdlrobson
Jdlrobson added a comment. I see 2 options here Only do the subtitle fix when a banner exists (e.g. add `&& banner``` to https://gerrit.wikimedia.org/g/mediawiki/extensions/WikidataPageBanner/+/7d39c374cc589d9ecd714976d5508ca5f6b133c9/includes/WikidataPageBanner.hooks.php#62) We

[Wikidata-bugs] [Maniphest] [Updated] T200075: Wikidata mobile website: Make coordinates clickable

2018-07-23 Thread Jdlrobson
Jdlrobson removed a project: MobileFrontend.Jdlrobson added a comment. MobileFrontend doesn't touch this content so untagging. Let me know if I can help in any way.TASK DETAILhttps://phabricator.wikimedia.org/T200075EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Triaged] T199855: WikidataPageBanner breaks Vector page subtitle

2018-07-22 Thread Jdlrobson
Jdlrobson added a project: User-Jdlrobson.Jdlrobson triaged this task as "Low" priority.Jdlrobson added a comment. This feels like an incorrectly configured WikidataPageBanner setup. Will look at setup on test wiki shortly.TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Closed] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-12 Thread Jdlrobson
Jdlrobson closed this task as "Resolved".Jdlrobson claimed this task.Jdlrobson added a comment. Thanks for confirming! This will be deployed in 1.32.wmf.13 currently planned for July 17th (https://wikitech.wikimedia.org/wiki/Deployments)TASK DETAILhttps://phabricator.wikimedia.org/T1

[Wikidata-bugs] [Maniphest] [Commented On] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-11 Thread Jdlrobson
Jdlrobson added a comment. @Baloch007 could you please confirm this is working as expected on our test server?: https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=en https://en.m.wikivoyage.beta.wmflabs.org/wiki/Test_RTL?uselang=psTASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Edited] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-11 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...https://ps.wikivoyage.org/wiki/%D9%82%D8%A8%D8%B1%D8%B3?uselang=en should show the same banner as https://ps.wikivoyage.org/wiki/%D9%82%D8%A8%D8%B1%D8%B3?uselang=ps = Developer notes The positioning assumes a LTR

[Wikidata-bugs] [Maniphest] [Updated] T198818: Pagebanner positioning doesn't work on RTL wikis

2018-07-11 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog, Wikidata-Page-Banner; removed Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog (Tracking).Herald added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T198818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata

2018-07-02 Thread Jdlrobson
Jdlrobson added a comment. Happy to chat through this. No rush. Please let me know if you would like me to attend any services sync relating to this. It feels like we have a few things to work out with the accept-language header before this patch is ready anyway.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Updated] T198468: Integration of Lexeme page with 'popups' extension

2018-07-02 Thread Jdlrobson
Jdlrobson added a comment. @Pablo-WMDE hey, I see what you mean. Since the link element has an href it tries to parse it even though it points to the same page. I've opened up T198652 to fix that generic case. Thanks for pointing that out. Regardless, I'd definitely recommend avoiding href's

[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata

2018-07-02 Thread Jdlrobson
Jdlrobson added a comment. @bearND I've clarified in the commit that this is seen as iterative and the goal for https://gerrit.wikimedia.org/r/434193 is to be compatible with the standard endpoint. Doing this would allow us to begin experimentation on the beta cluster I've written a POC

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-07-02 Thread Jdlrobson
Jdlrobson added a comment. Thanks @Physikerwelt! From my understanding the problem is not wikidata but wikibase If this is the case i suspect we can disable the config flag on wikipedia's: https://gerrit.wikimedia.org/r/442738 I'll check in with you Wednesday if there is any issues with swatting

[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson added a comment. Long term we'll probably want to add a 'type' 'wikidata' to https://www.mediawiki.org/wiki/Page_Previews/API_Specification rather than lean on the 'standard' type The first iteration of the patch implements yhe I am happy to drop sitelinks and claims on the short term

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-29 Thread Jdlrobson
Jdlrobson added a comment. And also, Math itself: MathHooks.php#mathTagHook. This is why I think https://gerrit.wikimedia.org/r/#/c/442725/is the right solution here. Please please please review? :)TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Edited] T111231: Page previews for Wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[] Update the summary endpoint to construct the Wikidata specific summary (https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mobileapps/+/434193) [] Previews on wikidata must contain the following:... * Page

[Wikidata-bugs] [Maniphest] [Edited] T111231: Page previews for Wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[] Logged-in users may turn off descriptions within their user preferences Note: Further tweaks may be needed by the client/endpoint to deal with Wikidata specific edge cases (E.g. articles with no descriptions

[Wikidata-bugs] [Maniphest] [Edited] T111231: Page previews for Wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Allow page previews to appear on wikidata containing the description of each item = Mocks {F8453797} {F8453796} {F8453795} =Acceptance Criteria...TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T111231: Page previews for Wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson added a project: Mobile-Content-Service.Jdlrobson added a comment.Herald added a project: Reading-Infrastructure-Team-Backlog. https://gerrit.wikimedia.org/r/434193 is ready for review and if merged should allow us to get this up and running on https://wikidata.beta.wmflabs.org

[Wikidata-bugs] [Maniphest] [Commented On] T167787: [Spike 2hr] Investigate ability for page previews to appear in wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson added a comment. Can we include the following in Wikidata previews (currently accessible via API calls): the total number of statements; the total number of labels; the total number of external identifiers; and the total number of site links? Yes. The API will return this information

[Wikidata-bugs] [Maniphest] [Edited] T111231: Page previews for Wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[] Update the summary endpoint to behave differently forconstruct the Wikidata domain. API response format remains same but data is returned from Wikidata api.specific summary (https://gerrit.wikimedia.org/r/#/c

[Wikidata-bugs] [Maniphest] [Commented On] T198468: Integration of Lexeme page with 'popups' extension

2018-06-29 Thread Jdlrobson
Jdlrobson added a comment. (With regards to the add Sense / addForm links I'd recommend converting those to buttons and/or removing the title attribute since they are _javascript_ only and that will confuse page previews into thinking they are links)TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T198468: Integration of Lexeme page with 'popups' extension

2018-06-29 Thread Jdlrobson
Jdlrobson added a comment. Popups is currently not compatible with Wikidata. We disabled it in production, but I suspect forgot to turn it off in labs. :/ I'm actually going to be doing some work on T111231 and T167787 today, following up from some work in the hackathon, as I think it would

[Wikidata-bugs] [Maniphest] [Updated] T111231: Page previews for Wikidata

2018-06-29 Thread Jdlrobson
Jdlrobson added subscribers: Pablo-WMDE, Jakob_WMDE, Trizek-WMF, Bdjwiki, gerritbot, pizzzacat, Quiddity, Raymond, SamB, Se4598, JanZerebecki, Wikidata-bugs, Jdforrester-WMF, Vibhabamba, hoo.Jdlrobson merged tasks: T198468: Integration of Lexeme page with 'popups' extension, T69434: [Task] Make

[Wikidata-bugs] [Maniphest] [Merged] T198468: Integration of Lexeme page with 'popups' extension

2018-06-29 Thread Jdlrobson
Jdlrobson closed this task as a duplicate of T111231: Page previews for Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T198468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Jakob_WMDE, Lydia_Pintscher, Pablo-WMDE, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Merged] T69434: [Task] Make Hovercards work on Wikidata item links

2018-06-29 Thread Jdlrobson
Jdlrobson closed this task as a duplicate of T111231: Page previews for Wikidata.Herald removed a subscriber: Liuxinyu970226. TASK DETAILhttps://phabricator.wikimedia.org/T69434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Bene, JdlrobsonCc: ovasileva

[Wikidata-bugs] [Maniphest] [Updated] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-26 Thread Jdlrobson
Jdlrobson edited projects, added User-Jdlrobson, Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.Jdlrobson added a comment. I have a patch up. With a few minor adjustments this should get fixed.TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-25 Thread Jdlrobson
Jdlrobson added a comment. So from what i understand https://github.com/wikimedia/mediawiki-extensions-Math/blob/master/src/MathHooks.php#L202 uses the parser hook but there are other ways to add math to a page? If that's understood I think I've got this.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-24 Thread Jdlrobson
Jdlrobson added a comment. @Physikerwelt can you explain to me why https://en.wikipedia.beta.wmflabs.org/wiki/Module:T173949 causes the loading of unnecessary Math styles/scripts on desktop/mobileeven though they are not needed to render the page? The fact desktop and mobile parser output

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-21 Thread Jdlrobson
Jdlrobson added a comment. ^ @Physikerwelt can you take a look at this patch? This should remedy the problem with Math styles showing up where they shouldn't be. It looks like this impacts any page using the scribunto formatPropertyValues function. I'm pretty sure we can also remove

[Wikidata-bugs] [Maniphest] [Edited] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-21 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...``` Looking into this some more - this hook does seem to run on mobile AND desktop and styles are only added on the first run, however only sometimes does it get cached. Experimenting with several pages, adding

[Wikidata-bugs] [Maniphest] [Edited] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-21 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Next step would be to replicate this on an environment where I can see exactly what's going on. == Thur 1st June 2018 I set it up on http://en-reading-web-staging.wmflabs.org/w/index.php?title=T173949 so I could

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-20 Thread Jdlrobson
Jdlrobson added a comment. @Physikerwelt any idea why a call to formatPropertyValues in a Lua template would load the Maths modules as a side effect?TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Edited] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-20 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...I connected https://wikidata.beta.wmflabs.org/wiki/Q361812 to https://en.wikipedia.beta.wmflabs.org/wiki/T173949 and re-ran the experiment but it failed. I updated the module, still no luck, however when I added

[Wikidata-bugs] [Maniphest] [Closed] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-19 Thread Jdlrobson
Jdlrobson closed this task as "Resolved".Jdlrobson added a comment. Can you still reproduce a problem locally when RelatedArticles is without the above patch? If so, could you try to make a more minimal test case that ends up with e.g. putting a certain piece of code in module X that mak

[Wikidata-bugs] [Maniphest] [Updated] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-18 Thread Jdlrobson
Jdlrobson added a project: MediaWiki-Cache. TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson

[Wikidata-bugs] [Maniphest] [Updated] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-18 Thread Jdlrobson
Jdlrobson added a project: wikiba.se.Jdlrobson added a comment. Apologies for all the notes/spam, but after a few hours looking at this I've managed to narrow this down to an[[ https://en.m.wikipedia.beta.wmflabs.org/wiki/Module:Internet_Archive | Internet Archive Lua module ]] which is hitting

[Wikidata-bugs] [Maniphest] [Edited] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-18 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* Ensure https://www.wikidataata.beta.wmflabs.org/wiki/Q4115189361812 has a site link to https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson/T173949T173949 and has an inception field. IF not add one pointing

[Wikidata-bugs] [Maniphest] [Retitled] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-18 Thread Jdlrobson
Jdlrobson renamed this task from "ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?" to "Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded".Jdlrob

[Wikidata-bugs] [Maniphest] [Updated] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-15 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog; removed Readers-Web-Backlog (Tracking). TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Physikerwelt, Krinkle, brion, Niedzielski, greg

[Wikidata-bugs] [Maniphest] [Commented On] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-15 Thread Jdlrobson
Jdlrobson added a comment. @Physikerwelt it's how the hooks work that confuse me. The Barack Obama article on enwiki uses neither the chem or the math parser functions but the ext.math.styles appear to be leaking into the page some how. How that's happening, I have no idea. Do you have any

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-15 Thread Jdlrobson
Jdlrobson added subscribers: brion, Krinkle.Jdlrobson added a comment. I feel that it is a serious problem in production as it might be a symptom of a much larger problem but it's not clear who should look into this. I'd appreciate someone who understands the parser to check if there's anything

[Wikidata-bugs] [Maniphest] [Raised Priority] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-14 Thread Jdlrobson
Jdlrobson raised the priority of this task from "High" to "Unbreak Now!".Jdlrobson added a comment.Herald added subscribers: Liuxinyu970226, TerraCodes. This is still happening leading to unnecessary render blocking styles. I've added a few tags and raised priority to

[Wikidata-bugs] [Maniphest] [Edited] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-14 Thread Jdlrobson
Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThe "[[ https://grafana.wikimedia.org/dashboard/db/mobile-2g?orgId=1=1501082591633=1503501791637 | CSS Size (Barack Obama - en.m) ]]" graph shows that the CSS size for this page has been fluctuatin

[Wikidata-bugs] [Maniphest] [Retitled] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-14 Thread Jdlrobson
Jdlrobson renamed this task from "ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate" to "ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?".Jdlrobson add

[Wikidata-bugs] [Maniphest] [Updated] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-06-13 Thread Jdlrobson
Jdlrobson edited projects, added User-Jdlrobson, Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.Jdlrobson added a comment. This change will go live on 20th June, at which point the local wiki hacks can be removed. I've left a message on the talk page to communicate this change! https

[Wikidata-bugs] [Maniphest] [Closed] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-06-13 Thread Jdlrobson
Jdlrobson closed this task as "Resolved".Jdlrobson claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T113642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: gerritbot, TheDJ, Sjoerddebruin, Zerabat, Legoktm, Trijnstel, J

[Wikidata-bugs] [Maniphest] [Created] T197038: Wikibase phpunit failure blocking WikidataPageBanner patches

2018-06-12 Thread Jdlrobson
Jdlrobson created this task.Jdlrobson added projects: Wikibase-Quality, Wikidata-Page-Banner, Readers-Web-Backlog (Tracking).Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONSeen on https://gerrit.wikimedia.org/r/440003 19:46:47 There was 1 error: 19:46:47 19

[Wikidata-bugs] [Maniphest] [Updated] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog, RelatedArticles, Patch-For-Review.Jdlrobson added a comment. That should probably get rid of the remaining errors. Just need some thoughts from @Krinkle about whether there is any way we can future proof

[Wikidata-bugs] [Maniphest] [Updated] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog; removed Readers-Web-Backlog (Tracking). TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Krinkle, gerritbot, JGirault, Massimo_Telo

[Wikidata-bugs] [Maniphest] [Reopened] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Jdlrobson
Jdlrobson reopened this task as "Open".Jdlrobson added a project: RelatedArticles.Jdlrobson added a subscriber: Krinkle.Jdlrobson added a comment. Spoke too soon. I found a page - https://fr.wikivoyage.org/wiki/Trouville-sur-Mer at resolution 2048x1536 Again, it is caused by a _javascr

[Wikidata-bugs] [Maniphest] [Closed] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog (Tracking), Wikidata-Page-Banner; removed Readers-Web-Backlog.Jdlrobson closed this task as "Resolved".Jdlrobson claimed this task.Jdlrobson added a comment. I can't seem to replicate this on Italian or French Wikipedia any more.

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-06-06 Thread Jdlrobson
Jdlrobson added a comment. Maybe something else is hitting the API? Is there anyway, we could update QUnit to report outgoing API requests? e.g. if mw.ajax is called log a warning message that shows up in the node report detailing the URL and the test/extension making it? This would help a lot

[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata

2018-05-20 Thread Jdlrobson
Jdlrobson added a comment. I worked on this during the hackathon. This seems relatively straightforward. It needs a new endpoint (POC=https://gerrit.wikimedia.org/r/434193 WIP: Add a wikidata summary endpoint) and configuration like so ($wgPopupsRestGatewayEndpoint = 'http://0.0.0.0:6927

[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata

2018-05-20 Thread Jdlrobson
Jdlrobson added a comment. http://jdlrobson.com/DEMO2.movTASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T193360: Cantonese Wikipedia mobile app interface cannot edit yue descriptions from Wikidata

2018-05-09 Thread Jdlrobson
Jdlrobson added subscribers: Charlotte, bearND, Tgr.Jdlrobson added a comment. @Liuxinyu970226 not completely sure right now, TBH it sounds like an issue inside either the Android web client or inside the API that it uses. @Charlotte and @bearND / @Tgr should hopefully be better equipped

[Wikidata-bugs] [Maniphest] [Commented On] T161596: [EPIC] Address vandalism issues with showing Wikidata descriptions on mobile

2018-05-04 Thread Jdlrobson
Jdlrobson added a comment. Is this still stalled Olga now they can be overridden? Does this mean we can add them back on English?TASK DETAILhttps://phabricator.wikimedia.org/T161596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ovasileva, JdlrobsonCc: Elitre

[Wikidata-bugs] [Maniphest] [Updated] T193360: Cantonese Wikipedia mobile app interface cannot edit yue descriptions from Wikidata

2018-05-04 Thread Jdlrobson
Jdlrobson edited projects, added Mobile-Content-Service; removed Readers-Web-Backlog (Tracking), MobileFrontend.Jdlrobson added a comment.Herald added a project: Reading-Infrastructure-Team-Backlog. Looks like this is a bug in the app. Not the mobile web experience. Adding mobile content service

[Wikidata-bugs] [Maniphest] [Commented On] T193360: Cantonese Wikipedia mobile web and mobile app interfaces should pull and push yue descriptions from Wikidata

2018-05-03 Thread Jdlrobson
Jdlrobson added a comment. @deryckchan I'm a little confused https://zh-yue.m.wikipedia.org/wiki/%E5%A4%A7%E9%95%B7%E4%BB%8A_(%E5%8A%87%E9%9B%86) shows the wikidata description as 韓國劇集 which is Cantonese if I'm not mistaken (https://www.wikidata.org/wiki/Q133898) F17622944: Screen Shot 2018-05-03

[Wikidata-bugs] [Maniphest] [Updated] T193360: Cantonese Wikipedia mobile web and mobile app interfaces should pull and push yue descriptions from Wikidata

2018-05-03 Thread Jdlrobson
Jdlrobson added projects: wikiba.se, MobileFrontend, Readers-Web-Backlog (Tracking), Wikipedia-Android-App-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T193360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Liuxinyu970226, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-03 Thread Jdlrobson
Jdlrobson added a comment. @Krinkle the ajax requests in MobileFrontend were causing the complaint in "ext.wikiEditor.toolbar" https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/19909/console and I suspect before that the complaints against jquery.wikibase.si

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-03 Thread Jdlrobson
Jdlrobson added a comment. I think this is the issue: https://gerrit.wikimedia.org/r/430633 Don't trigger API requests during Qunit execution @Krinkle it's unfortunate the unit tests didn't complain in this browser test. Anyway we can get these more isolated? I think once that patch is merged

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-03 Thread Jdlrobson
Jdlrobson added a comment. Investigating this some more and given the new failures I think there is not a fault in Wikibase here but an extensions who's tests are alphabetically run earlier. I'm looking into that now and if I can I will revert the above patchset.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-03 Thread Jdlrobson
Jdlrobson added a comment. Similar issues now showing up in ext.wikiEditor.toolbar https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/19909/console It seems like there are some ajax requests being made during the unit tests.TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-02 Thread Jdlrobson
Jdlrobson added a comment. This is blocking the merge of core change https://gerrit.wikimedia.org/r/#/c/424165/ and probably lots of other changes in core. Unbreak now..?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-04-24 Thread Jdlrobson
Jdlrobson set the point value for this task to "5". TASK DETAILhttps://phabricator.wikimedia.org/T113642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: TheDJ, Sjoerddebruin, Zerabat, Legoktm, Trijnstel, Jdforrester-WMF, Shanmuga

[Wikidata-bugs] [Maniphest] [Raised Priority] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-04-24 Thread Jdlrobson
Jdlrobson raised the priority of this task from "High" to "Needs Triage".Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...We could make it possible to configure the extension so that breadcrumbs can be displayed above the heading with a

[Wikidata-bugs] [Maniphest] [Updated] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-04-24 Thread Jdlrobson
Jdlrobson added a subscriber: TheDJ.Jdlrobson merged a task: T192643: Wikidata pagebanner causes page reflow. TASK DETAILhttps://phabricator.wikimedia.org/T113642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: TheDJ, Sjoerddebruin, Zerabat

[Wikidata-bugs] [Maniphest] [Merged] T192643: Wikidata pagebanner causes page reflow

2018-04-24 Thread Jdlrobson
Jdlrobson closed this task as a duplicate of T113642: Should be possible to print breadcrumbs above the heading. TASK DETAILhttps://phabricator.wikimedia.org/T192643EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Jdlrobson, TheDJ, Aklapper, Lahi

[Wikidata-bugs] [Maniphest] [Updated] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-04-24 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog; removed Readers-Web-Backlog (Tracking). TASK DETAILhttps://phabricator.wikimedia.org/T113642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Sjoerddebruin, Zerabat, Legoktm, Trijnstel

[Wikidata-bugs] [Maniphest] [Retitled] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-04-24 Thread Jdlrobson
Jdlrobson renamed this task from "Should be possible to print breadcrumbs above the heading" to "Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage". TASK DETAILhttps://phabricator.wikimedia.org/T113642EMAIL PREFERENCEShttps://phabr

[Wikidata-bugs] [Maniphest] [Updated] T192643: Wikidata pagebanner causes page reflow

2018-04-24 Thread Jdlrobson
Jdlrobson added a comment. This is actually a user script https://en.wikivoyage.org/wiki/MediaWiki:Common.js working around T113642TASK DETAILhttps://phabricator.wikimedia.org/T192643EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Jdlrobson

[Wikidata-bugs] [Maniphest] [Changed Status] T111231: Page previews for Wikidata

2018-04-20 Thread Jdlrobson
Jdlrobson changed the task status from "Stalled" to "Open". TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Mholloway, Sjoerddebruin, Pchelolo, bmansurov, pmiazga,

[Wikidata-bugs] [Maniphest] [Commented On] T191689: PAGEBANNER "origin" parameter calculation is not working at all.

2018-04-10 Thread Jdlrobson
Jdlrobson added a comment. "it's not working at all" is not accurate. It's doing something, but it's rules are not clear at all. Playing with it an image of Albert Einstein I do see an impact on https://eu.m.wikipedia.org/wiki/Lankide:Jdlrobson/Draft With origin |origin=0.125,-0.5

[Wikidata-bugs] [Maniphest] [Updated] T191689: PAGEBANNER "origin" parameter calculation is misleading/confusing

2018-04-10 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.Jdlrobson added a comment. This looks like it's working as it's currently implemented - I've documented it to the best of my ability here: https://www.mediawiki.org/wiki/Extension:WikidataPageBanner

[Wikidata-bugs] [Maniphest] [Retitled] T191689: PAGEBANNER "origin" parameter calculation is misleading/confusing

2018-04-10 Thread Jdlrobson
Jdlrobson renamed this task from "PAGEBANNER is not calculating "origin" parameter in euwiki" to "PAGEBANNER "origin" parameter calculation is misleading/confusing". TASK DETAILhttps://phabricator.wikimedia.org/T191689EMAIL PREFERENCEShttps://

[Wikidata-bugs] [Maniphest] [Commented On] T191689: PAGEBANNER is not calculating "origin" parameter in euwiki

2018-04-09 Thread Jdlrobson
Jdlrobson added a comment. @Theklan can you provide some more information? The origin only sets a central focal point so it completely depends on the image resolution and the device you are using whether the result is the same. Can you point us to an example?TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description

2018-03-28 Thread Jdlrobson
Jdlrobson added a comment. @DannyH see follow ups - I think we need to update all clients now. @Tgr do you plan to do one for mobile web or do you need me to organise that?TASK DETAILhttps://phabricator.wikimedia.org/T184000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description

2018-03-21 Thread Jdlrobson
Jdlrobson added a comment. Note that given MobileFrontend doesn't always use the API it may need updating post this change.TASK DETAILhttps://phabricator.wikimedia.org/T184000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, JdlrobsonCc: Jdlrobson

[Wikidata-bugs] [Maniphest] [Created] T189798: jquery.wikibase.edittoolbar regularly causing QUnit failures

2018-03-15 Thread Jdlrobson
Jdlrobson created this task.Jdlrobson added projects: Wikidata, wikiba.se.Herald added a subscriber: Aklapper. TASK DESCRIPTIONSeen frequently on MobileFrontend e.g. https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/56808/console afterEach failed on Create & des

[Wikidata-bugs] [Maniphest] [Reassigned] T188182: Regression: Wikidata descriptions are not showing on various wikis

2018-03-07 Thread Jdlrobson
Jdlrobson reassigned this task from Jdlrobson to ovasileva.Jdlrobson added a comment. Yup. Wikidata descriptions show up in search results, nearby and watchlist on Russian and English but not under the title. You cannot enable this via beta. On all other projects they show up in all places. Does

[Wikidata-bugs] [Maniphest] [Updated] T188182: Regression: Wikidata descriptions are not showing on various wikis

2018-03-06 Thread Jdlrobson
Jdlrobson added a subscriber: ovasileva.Jdlrobson added a comment. This is fixed now, and I discovered a bug while working on this (T189066) @ovasileva one of the side effects of this fix, is now that wikidata descriptions under the title cannot be enabled in the beta mode on English Wikipedia

[Wikidata-bugs] [Maniphest] [Retitled] T188182: Regression: Wikidata descriptions are not showing on various wikis

2018-03-06 Thread Jdlrobson
Jdlrobson renamed this task from "Special:Nearby no longer shows descriptions on Wikidata " to "Regression: Wikidata descriptions are not showing on various wikis".Jdlrobson updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONWikidata: most of these ite

[Wikidata-bugs] [Maniphest] [Claimed] T188182: Special:Nearby no longer shows descriptions on Wikidata

2018-03-06 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Kanbanana-Board; removed Readers-Web-Backlog (Tracking).Jdlrobson claimed this task.Jdlrobson raised the priority of this task from "Low" to "High".Herald added a project: Readers-Web-Backlog. TASK DETAILhttps://phabricator.wikime

<    4   5   6   7   8   9   10   11   12   13   >