JeroenDeDauw changed the title from Support new Entity types to Support new
types of Entities in Wikibase Repository.
JeroenDeDauw set Security to none.
TASK DETAIL
https://phabricator.wikimedia.org/T75496
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
JeroenDeDauw added a project: MediaWiki-extensions-WikidataClient.
TASK DETAIL
https://phabricator.wikimedia.org/T76019
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
To: JeroenDeDauw
Cc: wikidata-bugs, JeroenDeDauw
JeroenDeDauw created this task.
JeroenDeDauw added subscribers: wikidata-bugs, thiemowmde, hoo,
Lydia_Pintscher, daniel, GPHemsley, aude, JeroenDeDauw, Wikidata-bugs.
JeroenDeDauw added a project: MediaWiki-extensions-WikidataRepo.
JeroenDeDauw changed Security from none to none.
TASK
JeroenDeDauw added a comment.
We could just bolt the whole pile of extension points on top of the
WikibaseRepo class. Then extensions to Wikibase Repository could do something
like
$wikibaseRepo-registerEntityIdParser( $myNewEntityIdParser );
This will add a lot of state to WikibaseRepo
JeroenDeDauw added a comment.
We could just bolt the whole pile of extension points on top of the
WikibaseRepo class. Then extensions to Wikibase Repository could do something
like
$wikibaseRepo-registerEntityIdParser( $myNewEntityIdParser );
This will add a lot of state to WikibaseRepo
JeroenDeDauw created this task.
JeroenDeDauw added subscribers: wikidata-bugs, thiemowmde, hoo,
Lydia_Pintscher, daniel, GPHemsley, aude, JeroenDeDauw, Wikidata-bugs.
JeroenDeDauw added a project: MediaWiki-extensions-WikidataRepo.
JeroenDeDauw changed Security from none to none.
TASK
Gerrit Code Review ger...@wikimedia.org committed rEWDAb2b7de41b491: Updated
mediawiki/extensions/Wikidata Project: mediawiki/extensions/DataValues…
(authored by JeroenDeDauw).
JeroenDeDauw added a project: Wikidata.
Updated mediawiki/extensions/Wikidata Project: mediawiki/extensions/DataValues
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
http://c2.com/cgi/wiki?DontNameClassesObjectManagerHandlerOrData
TASK DETAIL
https://phabricator.wikimedia.org/T77992
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
JeroenDeDauw closed this task as Resolved.
JeroenDeDauw claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T78662
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
I already resolved this. Relevant commits are linked on GitHub.
TASK DETAIL
https://phabricator.wikimedia.org/T78662
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
JeroenDeDauw added a subscriber: JeroenDeDauw.
TASK DETAIL
https://phabricator.wikimedia.org/T85181
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
JeroenDeDauw added a comment.
Has any thought been put into how to combine this with the plans the Wikidata
team has for queries?
TASK DETAIL
https://phabricator.wikimedia.org/T85181
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Calling this fingerprint is confusing, since we already use that word for a
different concept. (Do point out how evil this is.)
I like the general idea proposed here.
TASK DETAIL
https://phabricator.wikimedia.org
JeroenDeDauw added a comment.
Thanks all for outlining your thoughts on the subject.
I have to take issue with the basic approach taken here. It's the classical
- I need some code that solves this use case nice
- There already is code that deals with the relevant subject, so I can use
JeroenDeDauw added a comment.
While I have no issue with something along the lines of the proposed
EntityTerms and associated interface being introduced, I'm concerned about the
name.
Consider this:
- There is no guarantee all types of entities have terms
- Different types of entities can
JeroenDeDauw changed the task status from Declined to Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T1293
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
JeroenDeDauw added a comment.
Note sure if this has been considered: the existing terms table cannot deal
with non numeric entity ids. Any new solution we create should not have the
same problem.
TASK DETAIL
https://phabricator.wikimedia.org/T86530
REPLY HANDLER ACTIONS
Reply to comment
JeroenDeDauw added a comment.
This generally seems fine to me. Definitely better than the current terms table.
Lookup by label/alias should be implemented based on Cirrus/Elastic
This is the only thing I'm really *frown* at. Should it say search instead of
lookup? If it's just lookup, I'd
JeroenDeDauw added a subscriber: JeroenDeDauw.
TASK DETAIL
https://phabricator.wikimedia.org/T87237
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
JeroenDeDauw closed this task as Resolved.
JeroenDeDauw claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T78293
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
PR: https://github.com/wmde/WikibaseDataModel/pull/348
TASK DETAIL
https://phabricator.wikimedia.org/T78284
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
JeroenDeDauw added a project: § Wikidata-Sprint-2015-01-21.
TASK DETAIL
https://phabricator.wikimedia.org/T78284
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
JeroenDeDauw moved this task to Review on the § Wikidata-Sprint-2015-01-21
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T78284
WORKBOARD
https://phabricator.wikimedia.org/project/board/1011/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
JeroenDeDauw created this task.
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a project: Wikibase-DataModel.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Merge Remove Claim into the 3.0.x-dev branch.
Pull request: https://github.com/wmde
JeroenDeDauw added a comment.
@GWicke: Indeed. I would however not extend this to every solution that is a
good fit for the WMF use case will also be a good fit for those that are on the
Wikidata teams roadmap. Keep in mind that the Wikidata team also wants to have
complex queries. As far as I
JeroenDeDauw closed this task as Declined.
JeroenDeDauw claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T78287
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw closed this task as Declined.
JeroenDeDauw claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T78292
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added a subscriber: JeroenDeDauw.
TASK DETAIL
https://phabricator.wikimedia.org/T78650
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
JeroenDeDauw added a subscriber: JeroenDeDauw.
TASK DETAIL
https://phabricator.wikimedia.org/T78653
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
JeroenDeDauw added a subscriber: JeroenDeDauw.
TASK DETAIL
https://phabricator.wikimedia.org/T78651
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
JeroenDeDauw closed this task as Resolved.
JeroenDeDauw claimed this task.
JeroenDeDauw added a comment.
Done with https://github.com/wmde/WikibaseInternalSerialization/pull/41
TASK DETAIL
https://phabricator.wikimedia.org/T78272
REPLY HANDLER ACTIONS
Reply to comment or attach files
JeroenDeDauw closed this task as Resolved.
JeroenDeDauw claimed this task.
JeroenDeDauw added a comment.
Fixed now https://travis-ci.org/wmde/Diff/jobs/45878081
TASK DETAIL
https://phabricator.wikimedia.org/T71524
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
JeroenDeDauw closed blocking task T71524: [HHVM] Tests on Travis are failing
(due to PHPUnit version used) as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T66415
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Wikibase now ignores empty references, solving the problem this investigation
is about. That does not answer how they got into the system in the first place,
though likely does make answering that less of a priority
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Looking at the DataValues components, I'm not seeing any big issues with how
they are split. Some of them contain crappy code, and others have boundary
problems. The general organization seems fine though
JeroenDeDauw created this task.
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a project: MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
`Wikibase\Validators\EntityValidator` uses part of the `ValueValidators
JeroenDeDauw created this task.
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
## Problem
There is existing and new code we currently have no good place for. Examples
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Pull request up for review: https://github.com/wmde/WikibaseDataModel/pull/419
TASK DETAIL
https://phabricator.wikimedia.org/T78285
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Testing against both would be awesome. Switching to just MySQL has the
disadvantage that devs running MySQL might not notice them breaking SQLite
compat.
TASK DETAIL
https://phabricator.wikimedia.org/T94208
REPLY
JeroenDeDauw changed the title from Create extension mechanism for Wikibase
Repository for new entity types to Create extension mechanism for Wikibase
Repository.
JeroenDeDauw edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T76021
REPLY HANDLER ACTIONS
Reply
JeroenDeDauw closed this task as Invalid.
JeroenDeDauw claimed this task.
JeroenDeDauw added a comment.
This is a duplicate of https://phabricator.wikimedia.org/T76021
There is no duplicate status? Setting to invalid, please change if there is
something more appropriate
TASK DETAIL
https
JeroenDeDauw closed blocking task T77985: Add mechanism for registering new
entity types, to work with things like EntityViewFactory as Invalid.
TASK DETAIL
https://phabricator.wikimedia.org/T75496
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
JeroenDeDauw added a comment.
Duplicate: https://phabricator.wikimedia.org/T77985
TASK DETAIL
https://phabricator.wikimedia.org/T76021
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
JeroenDeDauw added a comment.
Not done yet - Claim is still there
TASK DETAIL
https://phabricator.wikimedia.org/T87388
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added a comment.
Thank you Dereckson for writing down your concerns and observations, I share
many of them. I do not expect constructive discussion to happen here, and just
get one-sided repeats of arguments already covered in the past. If we want to
improve things, then IMO we
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
This is purely about configuration in the repo right? And not yet another self
maintained coverage infrastructure that breaks every month and then stops
working altogether?
TASK DETAIL
https
JeroenDeDauw added a comment.
What I'd really like to have is such a simple conceptual overview together with
some pointers on where to find code dealing with each part of it.
TASK DETAIL
https://phabricator.wikimedia.org/T75604
REPLY HANDLER ACTIONS
Reply to comment or attach files
JeroenDeDauw added a comment.
Having such a diagram would be nice.
Something along the lines of what is on these slides as well:
http://jeroendedauw.github.io/slides/smwcon/2014fall/wikibase/#/3/1 Since this
is conceptual, maintenance for that should be very low
TASK DETAIL
https
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
I'd like to see what has been done for components Diff and
DataModelSerialization also done for our other code. High level documentation,
release notes, clear interfaces and a clear distinction between what is package
JeroenDeDauw added a comment.
The blocker Use datamodel serialization in
Wikibase\Client\Scribunto\EntityAccessor
https://phabricator.wikimedia.org/T89234 is more like a subtask than a
separate task that blocks this one.
TASK DETAIL
https://phabricator.wikimedia.org/T64188
REPLY HANDLER
JeroenDeDauw changed the title from Uncaught exception from line 586 in
Diff\Patcher\PatcherException to Uncaught exception from line 586 in
content/EntityContent.php.
JeroenDeDauw set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T97146
REPLY HANDLER ACTIONS
Reply
JeroenDeDauw added a subscriber: Addshore.
TASK DETAIL
https://phabricator.wikimedia.org/T96458
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
JeroenDeDauw edited projects, added MediaWiki-extensions-WikibaseRepository;
removed Wikibase-DataModel.
JeroenDeDauw set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T95685
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
JeroenDeDauw added a comment.
Deprecated configuration setting strict used
TASK DETAIL
https://phabricator.wikimedia.org/T74318
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
JeroenDeDauw added a blocking task: T97706: Remove EntityDeserializer.
TASK DETAIL
https://phabricator.wikimedia.org/T75496
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw removed blocking tasks: T76019: Support new types of Entities in
Wikibase Client, T75496: Support new types of Entities in Wikibase Repository.
TASK DETAIL
https://phabricator.wikimedia.org/T97706
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
JeroenDeDauw added a blocked task: T97706: Remove EntityDeserializer.
TASK DETAIL
https://phabricator.wikimedia.org/T76019
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added a blocked task: T97706: Remove EntityDeserializer.
TASK DETAIL
https://phabricator.wikimedia.org/T75496
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added blocking tasks: T75496: Support new types of Entities in
Wikibase Repository, T76019: Support new types of Entities in Wikibase Client.
TASK DETAIL
https://phabricator.wikimedia.org/T97706
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
JeroenDeDauw removed a blocked task: T97706: Remove EntityDeserializer.
TASK DETAIL
https://phabricator.wikimedia.org/T75496
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw removed a blocked task: T97706: Remove EntityDeserializer.
TASK DETAIL
https://phabricator.wikimedia.org/T76019
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added a blocked task: T75496: Support new types of Entities in
Wikibase Repository.
TASK DETAIL
https://phabricator.wikimedia.org/T97706
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
You are right about there being OCP violations that need fixing.
Currently there is this EntityDeserializer, with ItemDeserializer and
PropertyDeserializer derivatives. That is very similar to what we had in
DataModel
JeroenDeDauw added a comment.
You are correct - since we have DispatchableSerializer, we do not need to have
an EntityDeserializer class to be able to have an entity deserializer.
TASK DETAIL
https://phabricator.wikimedia.org/T97706
REPLY HANDLER ACTIONS
Reply to comment or attach files
JeroenDeDauw added a comment.
Thanks for looking into this.
-2 as per https://github.com/wmde/WikibaseDataModel/pull/477
TASK DETAIL
https://phabricator.wikimedia.org/T98343
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc
JeroenDeDauw added a comment.
remove the notion of Fingerprint from the model. Instead, represent sets of
labels, descriptions, and aliases separately, to accommodate future types of
entities.
What is meant by this? Re-introducing LabelList and AliasList classes? Adding
getLabelsList
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Yay for agile documentation!
One concern I do have is that if we bundle a diagram with the code, then it
needs to be updated when the code is updated. Not for every commit clearly, but
for every release that includes
JeroenDeDauw added a comment.
I talked to @Snaterlicious the day after his last comment yet forgot to write
anything down here. We talked about the unsuitability of using Fingerprint in
certain cases, and how that simply means that one should not use it in these
cases rather than incentive
JeroenDeDauw added a comment.
This would indeed be useful for the Wikidata project, especially when we start
getting extensions on top of Wikibase Repostory, which will be soon. We'll be
able to drop our Wikidata specific build step, have things end up in extensions
as expected, and also avoid
JeroenDeDauw added a comment.
Can we please not create an issue per PR and in doing so duplicate the
discussions? We are also not creating an issue per commit on Gerrit.
Most discussion happened here:
https://github.com/wmde/WikibaseDataModel/pull/476
TASK DETAIL
https
JeroenDeDauw added a comment.
I'm not entirely sure where issues are being experienced. I can't remember the
last time I logged into packagist and triggered a refresh there, since I've not
found the need to do so for a very long time. If some commits where made even
after the tag and it still
JeroenDeDauw created this task.
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Right now Wikibase Repository and Wikibase Cleint do not separate unit and
integration tests, like most
JeroenDeDauw edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T96458
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
JeroenDeDauw added a subscriber: thiemowmde.
JeroenDeDauw set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T96458
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
JeroenDeDauw added subscribers: hoo, aude.
TASK DETAIL
https://phabricator.wikimedia.org/T96458
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
JeroenDeDauw closed this task as Resolved.
JeroenDeDauw claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T78285
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw closed this task as Resolved.
JeroenDeDauw claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T78288
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
JeroenDeDauw added a comment.
Do you agree that packagist.org is less reliable than 99%?
I don't know. Could be.
Do you agree that currently nobody, besides you has access to the account in
question?
No
TASK DETAIL
https://phabricator.wikimedia.org/T96659
EMAIL PREFERENCES
https
JeroenDeDauw added a comment.
https://github.com/wikimedia/composer-merge-plugin/pull/29
TASK DETAIL
https://phabricator.wikimedia.org/T97560
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Addshore, hoo, aude, daniel, JeroenDeDauw
JeroenDeDauw added a comment.
You get the same reaction for Snak. Especially if you via tone of voice,
formulation of sentence, body language, or some other mechanism, already
indicate you think the name is stupid. Also, this issue says redesign, not
rename. There are separate things.
TASK
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Yeah, we fixed the issue by simply ignoring empty references in
https://github.com/wmde/WikibaseDataModel/blob/master/RELEASE-NOTES.md#version-260-2015-03-08
TASK DETAIL
https://phabricator.wikimedia.org/T89094
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
I do not agree with the motivations outlined here as outlined in my comment on
the pull request: https://github.com/wmde/WikibaseInternalSerialization/pull/69
TASK DETAIL
https://phabricator.wikimedia.org/T98124
JeroenDeDauw added a comment.
This is something that's come up a few times over the last years as something
that we will probably need at some point. What are the concrete usecases we
have for this now? Without those it is rather hard to say anything about what
kind of approach is best taken
JeroenDeDauw added subscribers: JeroenDeDauw, mkroetzsch.
TASK DETAIL
https://phabricator.wikimedia.org/T101752
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: mkroetzsch, JeroenDeDauw, Aklapper, daniel, Wikidata-bugs, aude
JeroenDeDauw added a comment.
3rd party wikis using Wikidata items as unit identifiers.
Can you be more specific? I'm guessing you are talking about third party wikis
running a Wikibase Repository, and have items in there with entityid datavalues
pointing to Wikidata?
I see no breaking
JeroenDeDauw added a comment.
Other than that, I can't think of any issues. EntityId is completely opaque.
While EntityId might not be explicitly providing certain guarantees, many users
of it can still make assumptions that would be violated when introducing this
new derivative. If the URL
JeroenDeDauw added a comment.
I'm fine with moving that to Gerrit. If that is indeed helpful... I did not
know Python very well two years ago.
Why not use the existing WikibaseDataModel name? Just wikibase is to broad. I
think it's fine to initially put the datavalues stuff at the same place
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.
Heh... https://phabricator.wikimedia.org/T45326
TASK DETAIL
https://phabricator.wikimedia.org/T78298
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc
JeroenDeDauw added a subscriber: JeroenDeDauw.
TASK DETAIL
https://phabricator.wikimedia.org/T99243
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: JeroenDeDauw, Ricordisamoa, daniel, thiemowmde, Bene, Aklapper,
Lydia_Pintscher
JeroenDeDauw added a comment.
A separate directory is not possible, as this is not just about things in
Wikibase.git. I find it quite annoying to keep repeating myself, and would much
appreciate people reading the description before asking questions it already
answers.
TASK DETAIL
https
JeroenDeDauw added a comment.
I find it odd we had a ticket for this. We never had that before, and are not
doing it for other components either AFAIK. After all, what needed doing was
one small commit that took perhaps 30 minutes to create, was not widely
disruptive and did not need a very
JeroenDeDauw added a comment.
Presumably unsurprisingly I support the creation of such libraries :) My
position has not changed much since the linked mail from 2013: I am still
willing to help but will not pull it on my own.
TASK DETAIL
https://phabricator.wikimedia.org/T102741
EMAIL
JeroenDeDauw added a comment.
I strongly dislike moving all repositories used by Wikidata to Gerrit. The same
goes for any such general policy, such as forcing people to use a particular OS
or IDE. If the people that contribute to a repository most want to have it at a
given location, than let
JeroenDeDauw added a subscriber: Tobi_WMDE_SW.
TASK DETAIL
https://phabricator.wikimedia.org/T100947
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Tobi_WMDE_SW, Bene, thiemowmde, Tobias, Lydia_Pintscher, JeroenDeDauw,
Aklapper
JeroenDeDauw added subscribers: Lydia_Pintscher, Tobias, thiemowmde, Bene.
TASK DETAIL
https://phabricator.wikimedia.org/T100947
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JeroenDeDauw
Cc: Bene, thiemowmde, Tobias, Lydia_Pintscher, JeroenDeDauw
JeroenDeDauw created this task.
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a project: Wikibase-DataModel.
JeroenDeDauw moved this task to Backlog on the Wikibase-DataModel workboard.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project
JeroenDeDauw added a comment.
Related: would be nice if people could rage on this PR for it to be merged:
https://github.com/phpmd/phpmd/pull/273
TASK DETAIL
https://phabricator.wikimedia.org/T86538
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
JeroenDeDauw added a comment.
And of course we ought to get to having one extension per repo like all other
extensions at some point...
TASK DETAIL
https://phabricator.wikimedia.org/T100813
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
JeroenDeDauw added a comment.
For a second I wondered if dataTypeId: string should be dataType: DataType,
but the string is fine.
If I'm not mistaken we originally had it like that in the PHP DataModel, but
then moved away from it due to binding that did not provide sufficient value.
TASK
JeroenDeDauw added a comment.
@daniel: I do not see how we need to be adding a second, rather complex, data
model on top of the core data model. For the example provided, having a
serialization of a property value snak with added data type, all you need is a
simple typed snak object. One
1 - 100 of 367 matches
Mail list logo
