[Wikidata-bugs] [Maniphest] [Changed Project Column] T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki

2018-09-18 Thread Krinkle
Krinkle moved this task from Production Impact to Regressed <= 1.32-wmf.19 on the Wikimedia-production-error board.Krinkle added a comment. Still an issue?TASK DETAILhttps://phabricator.wikimedia.org/T122520WORKBOARDhttps://phabricator.wikimedia.org/project/board/1055/EMAIL PREFERENCESht

[Wikidata-bugs] [Maniphest] [Closed] T146069: "TypeError: undefined is not an object (evaluating 'mw.util.addPortletLink')" while opening item in new tab (on background) in Safari

2018-09-17 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment. mw.util.addPortletLink is a method of the mw.util singleton, which needs to be ensured by any code that uses it by declaring a deepndency on mediawiki.util. When that is done, the system automatic

[Wikidata-bugs] [Maniphest] [Commented On] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-09-16 Thread Krinkle
Krinkle added a comment. @Marostegui So to confirm, recentchanges db hosts are the same within and between eqiad/codfw. But the api db hosts are different, right? Only api dbhosts in codfw have the two extra indexes. Is that right? Also, are there differences between recentchanges db hosts

[Wikidata-bugs] [Maniphest] [Updated] T203805: codesniffer detects unparenthesized ternary in mediawiki/core Article.php

2018-09-16 Thread Krinkle
Krinkle added subscribers: Tgr, Krinkle.Krinkle added a project: Structured-Data-Commons.Krinkle added a comment.Restricted Application added a project: Wikidata. (Follows-up T174035)TASK DETAILhttps://phabricator.wikimedia.org/T203805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-09-14 Thread Krinkle
Krinkle added a comment. Earlier when I was investigating with Stas, performing the slow recentchanges api request with X-Wikimedia-Debug: log shows the following in Logstash: [DEBUG] [DBConnection] Wikimedia\Rdbms\LoadBalancer::getReaderIndex: using server db2080 for group 'api' Which indeed

[Wikidata-bugs] [Maniphest] [Unassigned] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-09-14 Thread Krinkle
Krinkle removed Krinkle as the assignee of this task.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T202764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: gerritbot

[Wikidata-bugs] [Maniphest] [Edited] T147981: Deadlock in SiteLinkTable::insertLinks on Item merges

2018-09-13 Thread Krinkle
Krinkle updated the task description. (Show Details)Krinkle set Risk Rating to N/A. CHANGES TO TASK DESCRIPTIONWarning: [data-update-failed]: A data update callback triggered an exception (A database query error has occurred. Did you forget to run your application's database schema updater after

[Wikidata-bugs] [Maniphest] [Updated] T147981: Deadlock in SiteLinkTable::insertLinks on Item merges

2018-09-13 Thread Krinkle
Krinkle added a parent task: T30599: Deadlock tracking bug (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T147981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, daniel, hoo, Aklapper, Matanya, Base, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Updated] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2018-09-13 Thread Krinkle
Krinkle added a parent task: T30599: Deadlock tracking bug (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T151789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, hoo, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Changed Project Column] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2018-09-13 Thread Krinkle
Krinkle moved this task from Production Impact to Production 1.32-wmf.20+ on the Wikimedia-production-error board.Krinkle added a comment. Still seen: exception.message: Wikimedia\Rdbms\DBTransactionStateError Cannot execute query from Wikibase\Repo\Content\DataUpdateAdapter::doUpdate while

[Wikidata-bugs] [Maniphest] [Changed Status] T179195: Replace use of .eslintignore with ignore in Gruntfile.js in all repos, for consistency

2018-09-13 Thread Krinkle
Krinkle changed the task status from "Open" to "Stalled".Krinkle added a comment. I think moving to Gruntfile is a viable option, but it there are other options. If we really want to defocus on tooling integration, we should move eslintrc to Gruntfile as well. Or, keep the

[Wikidata-bugs] [Maniphest] [Edited] T204159: Fatal "Call getPrefixedText on a non-object" from WikibaseClient on ApiEchoNotifications

2018-09-12 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...```name=stacktrace,lines=10 #0 [internal function]: Wikibase\Client\Notifications\PageConnectionPresentationModel->callbackForBundleCount(EchoEvent)...TASK DETAILhttps://phabricator.wikimedia.org/T204159EM

[Wikidata-bugs] [Maniphest] [Created] T204159: Fatal "Call getPrefixedText on a non-object" from WikibaseClient on ApiEchoNotifications

2018-09-12 Thread Krinkle
Krinkle created this task.Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseClient, Notifications.Restricted Application added a subscriber: Aklapper.Restricted Application added projects: Growth-Team, Wikidata. TASK DESCRIPTIONError Request ID

[Wikidata-bugs] [Maniphest] [Updated] T88258: Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration

2018-09-12 Thread Krinkle
Krinkle added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration. TASK DETAILhttps://phabricator.wikimedia.org/T88258EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, WMDE-leszek, Addshore

[Wikidata-bugs] [Maniphest] [Edited] T174047: Hide deprecated/unused fields on toolforge replica [MCR]

2018-09-11 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONFields that will become unused with MCR schema migration should be hidden in the toolforge replica of the wiki databases, to avoid tools from reading incomplete/inconsistent data. These fields will eventually

[Wikidata-bugs] [Maniphest] [Updated] T88258: Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration

2018-09-11 Thread Krinkle
Krinkle edited parent tasks, added: T140852: Load all Wikimedia-deployed extensions and skins via extension registration; removed: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration. TASK DETAILhttps://phabricator.wikimedia.org/T88258EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T97368: Investigate more efficient memcached solution for CacheAwarePropertyInfoStore

2018-09-11 Thread Krinkle
Krinkle added a project: Wikimedia-Incident. TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Joe, mark, Addshore, jijiki, akosiaris, Krinkle, JanZerebecki, thiemowmde, aude, daniel, Aklapper, hoo

[Wikidata-bugs] [Maniphest] [Updated] T97368: Investigate more efficient memcached solution for CacheAwarePropertyInfoStore

2018-09-11 Thread Krinkle
Krinkle edited projects, added Performance-Team, wikidata-tech-focus, Operations; removed Performance. TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Joe, mark, Addshore, jijiki, akosiaris

[Wikidata-bugs] [Maniphest] [Retitled] T97368: Investigate more efficient memcached solution for CacheAwarePropertyInfoStore

2018-09-11 Thread Krinkle
Krinkle renamed this task from "[Task] Investigate about more efficient PropertyInfoStore implementations" to "Investigate more efficient memcached solution for CacheAwarePropertyInfoStore ". TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps://phabr

[Wikidata-bugs] [Maniphest] [Updated] T97368: [Task] Investigate about more efficient PropertyInfoStore implementations

2018-09-11 Thread Krinkle
Krinkle added a subscriber: akosiaris.Krinkle added a comment. At T204083, @akosiaris wrote: SRE team noticed that a specific host (mc1023) is close to saturating the uplink network connection [1]. More investigation into the grafana graphs for the entire cluster [2] showed

[Wikidata-bugs] [Maniphest] [Merged] T204083: wikibase_shared/-wikidatawiki-hhvm:CacheAwarePropertyInfoStore memcached key not well distributed, causing excessive traffic

2018-09-11 Thread Krinkle
Krinkle closed this task as a duplicate of T97368: [Task] Investigate about more efficient PropertyInfoStore implementations. TASK DETAILhttps://phabricator.wikimedia.org/T204083EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: jijiki, Addshore

[Wikidata-bugs] [Maniphest] [Updated] T97368: [Task] Investigate about more efficient PropertyInfoStore implementations

2018-09-11 Thread Krinkle
Krinkle added subscribers: jijiki, Addshore, mark, Joe.Krinkle merged a task: T204083: wikibase_shared/-wikidatawiki-hhvm:CacheAwarePropertyInfoStore memcached key not well distributed, causing excessive traffic. TASK DETAILhttps://phabricator.wikimedia.org/T97368EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Raised Priority] T97368: [Task] Investigate about more efficient PropertyInfoStore implementations

2018-09-11 Thread Krinkle
Krinkle raised the priority of this task from "Normal" to "High".Krinkle added a comment. Raising priority as the use of this memcached key brings the network link for the Memcached server it maps to dangerously close to not being able to handle it. Whichever Memcached serv

[Wikidata-bugs] [Maniphest] [Claimed] T202764: Wikidata produces a lot of failed requests for recentchanges API

2018-09-10 Thread Krinkle
Krinkle moved this task from Inbox to Doing on the Performance-Team board.Krinkle claimed this task.Krinkle added a comment. I'll investigate a bit to try to determine whether MediaWiki recentchanges may have regressed more generally or whether this might be specific to the Wikidata setup.TASK

[Wikidata-bugs] [Maniphest] [Changed Project Column] T203696: Drastically reduce the number of ResourceLoader modules that Wikibase creates

2018-09-10 Thread Krinkle
Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T203696WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Declined] T130561: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"

2018-09-05 Thread Krinkle
Krinkle closed this task as "Declined".Krinkle moved this task from Production 1.32-wmf.19+ to Production Impact on the Wikimedia-production-error board.Krinkle added a comment. Mistook it for another one. This one hasn't been seen for at least 30 days. Closing for now.TASK D

[Wikidata-bugs] [Maniphest] [Commented On] T130561: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"

2018-09-05 Thread Krinkle
Krinkle added a comment. Assuming the write isn't a no-op, it should indeed use an earlier hook to inform the value to be written instead of changing it immediately afterwards. It's still curious that it would deadlock, though, and even curiouser that it isn't deterministic.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Retitled] T130561: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"

2018-09-05 Thread Krinkle
Krinkle renamed this task from "FlaggedRevsHooks::autoMarkPatrolled shouldn't need to update the RC entry that has just been saved" to "FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded"".Krinkle remo

[Wikidata-bugs] [Maniphest] [Updated] T130561: FlaggedRevsHooks::autoMarkPatrolled shouldn't need to update the RC entry that has just been saved

2018-09-05 Thread Krinkle
Krinkle added a parent task: T30499: 1205: Lock wait timeout exceeded; try restarting transaction (tracking).Restricted Application added a project: Growth-Team. TASK DETAILhttps://phabricator.wikimedia.org/T130561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T191282: Wikimedia\Rdbms\LoadBalancer::{closure}: found writes pending

2018-09-04 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment. There are indeed a few hits still, but this has become an tracking task for a category of issues, which doesn't seem useful. The found writes pending error is a symptom of an underlying problem. Th

[Wikidata-bugs] [Maniphest] [Closed] T199855: WikidataPageBanner breaks Vector page subtitle

2018-08-31 Thread Krinkle
Krinkle removed a project: Patch-For-Review.Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment. Backported and verified on mwdebug and in prod.TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Updated] T196349: wbgetentities API call for a Form ID results in Serializers\\Exceptions\\UnsupportedObjectException

2018-08-29 Thread Krinkle
Krinkle moved this task from Backlog to Production Impact on the Wikimedia-log-errors board.Krinkle added a project: Wikidata-Campsite.Krinkle added a comment. (Triaging from backlog by ensuring a team tag or equivalent is present; Please confirm whether this error still exists case. Feel free

[Wikidata-bugs] [Maniphest] [Updated] T194374: Special:EntitiesWithout* allows selecting Lexeme, however it just throws an exception

2018-08-29 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAILhttps://phabricator.wikimedia.org/T194374EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Lydia_Pintscher, daniel, Addshore, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Declined] T189841: Bad value for parameter $pageTitle: must be a string

2018-08-23 Thread Krinkle
Krinkle closed this task as "Declined".Krinkle added a comment. No exceptions or errors for SiteLinkTable in last 7 days,TASK DETAILhttps://phabricator.wikimedia.org/T189841EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklap

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-20 Thread Krinkle
Krinkle added a comment. In T110022#4508947, @Legoktm wrote: In T110022#4502131, @Krinkle wrote: I think this can also work backwards, like if upstream doesn't add support for newer PHP versions, then we're stuck. I agree that's a general concern to be aware of when comparing vendors

[Wikidata-bugs] [Maniphest] [Edited] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

2018-08-16 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONTo generaWhen generating the startup response for a wiki, ResourceLoader needs to compute the content and/or version of the `mediawiki.jqueryMsg` module,. ResourceLoader This currently indirectlyvolves invoking

[Wikidata-bugs] [Maniphest] [Commented On] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

2018-08-16 Thread Krinkle
Krinkle added a comment. I'd recommend considering Message::text() instead of Message::parse(). This would disallow templates and parser functions, which aren't currently used in those messages. https://codesearch.wmflabs.org/search/?q=wikibase-repo-name.%2B%5B%5C%5B%5C%5D%7B%7D%27%3C%3E%5D

[Wikidata-bugs] [Maniphest] [Created] T202097: Avoid invoking Parser in WikibaseClient ResourceLoaderJqueryMsgModuleMagicWords hook

2018-08-16 Thread Krinkle
Krinkle created this task.Krinkle added projects: Performance-Team, MediaWiki-extensions-WikibaseClient.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata. TASK DESCRIPTIONTo generate the content and/or version of the mediawiki.jqueryMsg module

[Wikidata-bugs] [Maniphest] [Closed] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

2018-08-16 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T201453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Al

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-14 Thread Krinkle
Krinkle added a comment. I agree that non-static state and active maintenance are desirable traits. I haven't recently checked either library for those aspects, but I trust @BPirkle and @Tgr that Guzzle is better in that regard. I'd like to instead provide feedback on another aspect: Stability

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-14 Thread Krinkle
Krinkle added a comment. In T110022#4479395, @Tgr wrote: In T110022#4478166, @Krinkle wrote: We'd basically map the exception class to a localisation message somewhere [..] [..] Mapping by class is not really useful. Mapping by message would involve regex parsing messages - possible but a bit

[Wikidata-bugs] [Maniphest] [Changed Project Column] T172443: Wikibase: Unresolved redirect in WikiPageEntityRevisionLookup.php:103

2018-08-13 Thread Krinkle
Krinkle moved this task from Backlog to Production Impact on the Wikimedia-log-errors board.Krinkle added a comment. Still seen several times per day in the last 7 days on wikidata.org with the current branch (1.32.0-wmf.16). Recent sample: Unresolved redirect to Q52155568 exception_id

[Wikidata-bugs] [Maniphest] [Created] T201453: Flaky test case in SimpleCacheWithBagOStuffTest

2018-08-07 Thread Krinkle
Krinkle created this task.Krinkle added projects: MediaWiki-extensions-WikibaseClient, Wikidata, Wikimedia-log-errors (Shared Build Failure).Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONWikibase\Lib\Tests\SimpleCacheWithBagOStuffTest::testSetMultipleTtl Failed asserting

[Wikidata-bugs] [Maniphest] [Commented On] T200009: Archive mediawiki/extensions/Wikidata (Wikidata build)

2018-08-07 Thread Krinkle
Krinkle added a comment. In T29#4483270, @mmodell wrote: What is the benefit to emptying the repository? [..] no need to obscure it from history. In the context of #cleanup, "emptying the repo" means adding a new commit to the master branch that removes all files except

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-03 Thread Krinkle
Krinkle added a comment. A wrapper would be straight-forward indeed, but another idea to consider could be to handle localisation at a higher layer that catches the exception, and responsible for printing it in some way. That approach might be easier to scale to other libraries we use, including

[Wikidata-bugs] [Maniphest] [Updated] T135461: Exploratory: Making Wikidata content accessible on foundation.wikimedia.org

2018-07-31 Thread Krinkle
Krinkle added a project: WMF-Communications. TASK DETAILhttps://phabricator.wikimedia.org/T135461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, PokestarFan, Liuxinyu970226, Lydia_Pintscher, aude, Heather, JAnstee_WMF, Aklapper, Varnent

[Wikidata-bugs] [Maniphest] [Commented On] T135461: Exploratory: Making Wikidata content accessible on foundation.wikimedia.org

2018-07-31 Thread Krinkle
Krinkle added a comment. @Varnent Is this still sought-after? I assume not, but just checking :)TASK DETAILhttps://phabricator.wikimedia.org/T135461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, PokestarFan, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Retitled] T135461: Exploratory: Making Wikidata content accessible on foundation.wikimedia.org

2018-07-31 Thread Krinkle
Krinkle renamed this task from "Exploratory: Making Wikidata content accessible on wikimediafoundation.org" to "Exploratory: Making Wikidata content accessible on foundation.wikimedia.org".Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIO

[Wikidata-bugs] [Maniphest] [Commented On] T197616: Create a production test wiki in group0 to parallel Wikimedia Commons

2018-07-30 Thread Krinkle
Krinkle added a comment. In T197616#4461712, @daniel wrote: Do you believe that the test wikis on the live cluster should be removed [..] Yes and no. Yes, I'd prefer we not see test-wikis as ways to catch regressions during normal deployments, because almost none of our procedures (apart from

[Wikidata-bugs] [Maniphest] [Updated] T162562: Choose a field length for entity id columns and stick to it

2018-07-28 Thread Krinkle
Krinkle removed a project: MediaWiki-Database. TASK DETAILhttps://phabricator.wikimedia.org/T162562EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Marostegui, aude, Ladsgroup, daniel, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Commented On] T197616: Create a production test wiki in group0 to parallel Wikimedia Commons

2018-07-27 Thread Krinkle
Krinkle added a comment. In T197616#4429492, @Krinkle wrote: In T197616#4297600, @daniel wrote: The beta setup is probably not going to cover all the angles for e.g. wikibase change propagation. @Krinkle Can you clarify what angles you think aren't going to covered

[Wikidata-bugs] [Maniphest] [Commented On] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

2018-07-25 Thread Krinkle
Krinkle added a comment. Hi, just wanted to mention that TechCom has been reading along here. Let us know if you need our input and/or would like an IRC meeting for finding more options, or narrowing down options, or approving a specific option.TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

2018-07-25 Thread Krinkle
Krinkle removed a parent task: T191060: 1.32.0-wmf.14 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes

[Wikidata-bugs] [Maniphest] [Updated] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

2018-07-25 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

2018-07-25 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors. TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin

[Wikidata-bugs] [Maniphest] [Edited] T200340: Wikibase\DataModel\Entity\EntityIdParsingException $serialization must not be an empty string

2018-07-25 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[{exception_id}] {exception_url} Wikibase\DataModel\Entity\EntityIdParsingException from line 49 of /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php

[Wikidata-bugs] [Maniphest] [Retitled] T200072: MCR broke Undelete action (and made Cognate tests fail) "The given Title does not belong to page ID"

2018-07-24 Thread Krinkle
Krinkle renamed this task from "MCR causes Cognate integration test fails: The given Title does not belong to page ID 2 but actually belongs to 4" to "MCR broke Undelete action (and made Cognate tests fail) "The given Title does not belong to page ID"".Krinkle edited

[Wikidata-bugs] [Maniphest] [Edited] T199855: WikidataPageBanner breaks Vector page subtitle

2018-07-17 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...| {F23876255}| {F23875640} | {F23876682} | {F23875941}...TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper

[Wikidata-bugs] [Maniphest] [Created] T199855: WikidataPageBanner breaks Vector page subtitle

2018-07-17 Thread Krinkle
Krinkle created this task.Krinkle added a project: Wikidata-Page-Banner.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONI've noticed this on test2.wikipedia.org where the extension was enabled. F23876255: capture3.pngF23875640: capture.pngF23875941: capture2

[Wikidata-bugs] [Maniphest] [Updated] T199855: WikidataPageBanner breaks Vector page subtitle

2018-07-17 Thread Krinkle
Krinkle added projects: Regression, Readers-Web-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T199855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jrbranaa, QZanden, LawExplorer, Winter

[Wikidata-bugs] [Maniphest] [Commented On] T197616: Create a production test wiki in group0 to parallel Wikimedia Commons

2018-07-16 Thread Krinkle
Krinkle added a comment. In T197616#4297600, @daniel wrote: The beta setup is probably not going to cover all the angles for e.g. wikibase change propagation. Can we fix that in Beta Cluster? I do not think it is unreasonable to require new projects to work properly in Beta Cluster from day -1

[Wikidata-bugs] [Maniphest] [Closed] T196351: Fatal error: Call to undefined method Wikibase\\Lexeme\\DataModel\\Lexeme::getRepresentations()

2018-07-13 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment. Not seen in production in the last 30 days (php-1.32.0-wmf.8, php-1.32.0-wmf.10, php-1.32.0-wmf.12). Must've been fixed or rendered unreachable in wmf.7.TASK DETAILhttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Updated] T162555: Stop using MockTermIndex

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation). TASK DETAILhttps://phabricator.wikimedia.org/T162555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345

[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation). TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Ladsgroup, Ricordisamoa, Jonas, adrianheine

[Wikidata-bugs] [Maniphest] [Updated] T143038: Remove use of jquery.tipsy in Wikibase

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation). TASK DETAILhttps://phabricator.wikimedia.org/T143038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: MZMcBride, Addshore, thiemowmde, Jonas, Aklapper, Jdforrester

[Wikidata-bugs] [Maniphest] [Updated] T143038: Remove use of jquery.tipsy in Wikibase

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T143038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: MZMcBride, Addshore, thiemowmde, Jonas, Aklapper, Jdforrester

[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Ladsgroup, Ricordisamoa, Jonas, adrianheine

[Wikidata-bugs] [Maniphest] [Updated] T162555: Stop using MockTermIndex

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T162555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345

[Wikidata-bugs] [Maniphest] [Updated] T98033: [Task] Drop API-Style wrapper from JSON output of Special:EntityData

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T98033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Addshore, Aklapper, daniel, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T98035: [Task] Drop support for php-serialized output from Special:EntityData

2018-07-13 Thread Krinkle
Krinkle edited projects, added Technical-Debt (Deprecation); removed Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T98035EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, PokestarFan, Jonas, thiemowmde, gerritbot, daniel

[Wikidata-bugs] [Maniphest] [Updated] T191282: Wikimedia\Rdbms\LoadBalancer::{closure}: found writes pending

2018-07-10 Thread Krinkle
Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Analytics.Herald added a project: Analytics. TASK DETAILhttps://phabricator.wikimedia.org/T191282EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Declined] T178810: Wikibase: Increase batch size for HTMLCacheUpdateJobs triggered by repo changes.

2018-07-10 Thread Krinkle
Krinkle closed this task as "Declined".Krinkle added a comment. Closing out as this seems specific to the old Redis-based JobQueue and JobRunner that are no longer as of last week. Please re-open if it still applies.TASK DETAILhttps://phabricator.wikimedia.org/T178810EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Unblock] T173710: Job queue is increasing non-stop

2018-07-10 Thread Krinkle
Krinkle closed subtask T178810: Wikibase: Increase batch size for HTMLCacheUpdateJobs triggered by repo changes. as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Krinkle

[Wikidata-bugs] [Maniphest] [Closed] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

2018-07-09 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle assigned this task to aaron.Krinkle moved this task from External to Ours done on the Performance-Team (Radar) board.Krinkle added a comment. Marking as resolved for now given the new JobQueue based on EventBus. If the rate remain

[Wikidata-bugs] [Maniphest] [Commented On] T198816: WikibaseRepo "dataRightsUrl " setting should not bypass MediaWiki's configuration logic

2018-07-04 Thread Krinkle
Krinkle added a comment. By the way, while it's fine for this setting to exist in Wikibase, it's worth checking whether it still has a use case. A simpler solution is always to remove code :)TASK DETAILhttps://phabricator.wikimedia.org/T198816EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Created] T198816: WikibaseRepo "dataRightsUrl " setting should not bypass MediaWiki's configuration logic

2018-07-04 Thread Krinkle
Krinkle created this task.Krinkle added projects: MediaWiki-extensions-WikibaseRepository, Technical-Debt.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONCurrently Wikibase has its own dataRightsUrl setting that defaults to core's setting of wgRightsUrl

[Wikidata-bugs] [Maniphest] [Updated] T73461: [hhvm] MemcachedPeclBagOStuff.php: Error at offset 0 of 6 bytes

2018-07-02 Thread Krinkle
Krinkle closed this task as a duplicate of T184854: hhvm memcached and php7 memcached extensions do not play well together.Herald added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T73461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T193858: Make monolingual text datatype indexable in wikibase

2018-07-02 Thread Krinkle
Krinkle removed projects: Hashtags, Gamepress, Tamil-Sites. TASK DETAILhttps://phabricator.wikimedia.org/T193858EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, KrinkleCc: Aklapper, GerritBot, Cparle, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci

[Wikidata-bugs] [Maniphest] [Commented On] T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded

2018-06-28 Thread Krinkle
Krinkle added a comment. In T173949#4312026, @Physikerwelt wrote: I think a good solution is that the Math extension follows the standard procedure for all tag extensions that require custom CSS and js for their content. Is there a good example of such an extension? Yes. SyntaxHighlighter

[Wikidata-bugs] [Maniphest] [Unblock] T195520: Multiple projects reporting Cannot access the database: No working replica DB server

2018-06-23 Thread Krinkle
Krinkle closed subtask T195525: MWExceptionRenderer.php doesn't always declare the encoding used. as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T195520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Jdfor

[Wikidata-bugs] [Maniphest] [Updated] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-15 Thread Krinkle
Krinkle removed a project: Performance. TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E

[Wikidata-bugs] [Maniphest] [Commented On] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-15 Thread Krinkle
Krinkle added a comment. @Jdlrobson It does indeed appear to be a bug somewhere relating to cache pollution, in particular it seems a cache key somewhere is being shared between mobile and desktop that shouldn't be. I can reproduce the following in Incognito mode (with disabled cache): (Desktop

[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase

2018-06-15 Thread Krinkle
Krinkle added subscribers: gerritbot, Krinkle.Krinkle added a comment. In T123218#3916627, @gerritbot wrote: [mediawiki/extensions/Wikibase@master] Remove some of IE8 hacks (wikibase/templates.js) https://gerrit.wikimedia.org/r/392663 TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches

2018-06-14 Thread Krinkle
Krinkle removed a project: Wikimedia-log-errors (Shared Build Failure). TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jdforrester-WMF, TerraCodes, Liuxinyu970226, Stashbot, Legoktm

[Wikidata-bugs] [Maniphest] [Commented On] T189538: Reduce complexity of Wikibase JS module registration

2018-06-08 Thread Krinkle
Krinkle added a comment. The remaining work here is to apply "Reduce indirection in resources files" to the rest of Wikibase. The above commit (https://gerrit.wikimedia.org/r/419334) was merely an example for one of the modules (view/wikibase-data-model).TASK D

[Wikidata-bugs] [Maniphest] [Updated] T189538: Reduce complexity of Wikibase JS module registration

2018-06-08 Thread Krinkle
Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review.Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* [x] / {e9b71a058b24} * [ * [x

[Wikidata-bugs] [Maniphest] [Updated] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson, KrinkleCc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75

[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Krinkle
Krinkle added a comment. @Jdlrobson Yes, there is some form of sandboxing at the level of module loading. Which means that if you define module "a" and "b" as a.js and b.js, and load them separately but in the same request with "a" before "b", the

[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches

2018-05-29 Thread Krinkle
Krinkle added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Liuxinyu970226, Stashbot, Legoktm, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Closed] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-29 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch

[Wikidata-bugs] [Maniphest] [Updated] T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'

2018-05-29 Thread Krinkle
Krinkle added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T195868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Stashbot, thcipriani, Legoktm, Liuxinyu970226, TerraCodes, Krinkle, Jdforrester-WMF, Aleksey_WMDE, daniel

[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q

2018-05-18 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* **Where**: Sala de projectes (QC/0011) * Next session: {T194275} What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How can you

[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q

2018-05-18 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION* **When**: Friday 18 May, 16:00 - 17:00 * **Where**: Sala de projectes (QC/0011) What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-03 Thread Krinkle
Krinkle added a comment. it's unfortunate the unit tests didn't complain in this browser test. Anyway we can get these more isolated? I'm not sure I understand. What exactly didn't complain where?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-02 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Smalyshev, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189329: jquery.wikibasea qunit tests are flaky (Pending Ajax requests)

2018-05-02 Thread Krinkle
Krinkle moved this task from Resolved to Backlog on the Wikimedia-log-errors (Jenkins Failure) board.Krinkle added a comment. Still happening for jquery.wikibase.sitelinkview ✖ Create and destroy afterEach failed on Create and destroy: Pending AJAX requests: 0 (active: 3)TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Retitled] T189329: jquery.wikibasea qunit tests are flaky (Pending Ajax requests)

2018-05-02 Thread Krinkle
Krinkle renamed this task from "jquery.wikibase.edittoolbar and other qunit tests are flaky" to "jquery.wikibasea qunit tests are flaky (Pending Ajax requests)".Krinkle removed a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)). TASK DETAILhttps://phabr

[Wikidata-bugs] [Maniphest] [Updated] T120847: Use BCP 47 conform language codes for the HTML attribute lang

2018-04-20 Thread Krinkle
Krinkle removed a parent task: T2209: HTML validity (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T120847EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, Aklapper, Fomafix, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Closed] T173850: Possible PHP7 compatibility issues in WMF-deployed extensions

2018-04-18 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Smalyshev, Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie

[Wikidata-bugs] [Maniphest] [Updated] T189762: selenium test for Wikibase is unstable

2018-04-18 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T189762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: mmodell, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Tgr, Jonas, WMDE-leszek, gerritbot, hoo, greg

<    3   4   5   6   7   8   9   10   11   12   >