[Wikidata-bugs] [Maniphest] [Updated] T169638: Option to Show and Hide Wikidata edits on RecentChanges is not working according to user or wiki preferences

2017-07-06 Thread Krinkle
Krinkle added a project: Edit-Review-Improvements-RC-Page.Herald added a project: Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T169638EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Trizek-WMF, Aklapper, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis

2017-07-28 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui

[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis

2017-08-07 Thread Krinkle
Krinkle added commits: rEWBA0df49eeaf49d: Use multi-page RefreshLinksJobs in WikiPageUpdater, rEWBA4d8e2b80d700: Use HTMLCacheUpdateJob instead of invalidateCache, rEWBA172b739396bd: Remove overengineered page update code from ChangeHandler, rEWBA2987fe5bcf62: Move injection of RC records

[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis

2017-08-07 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: Jrbranaa, PokestarFan, Agabi10, gerritbot, Krinkle, aaron

[Wikidata-bugs] [Maniphest] [Updated] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

2017-08-07 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Herald added a subscriber: PokestarFan. TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Gilles

[Wikidata-bugs] [Maniphest] [Updated] T70567: Make EntityView UI aware of redirects

2017-07-31 Thread Krinkle
Krinkle removed a project: MediaWiki-Redirects.Herald added a subscriber: PokestarFan. TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious

[Wikidata-bugs] [Maniphest] [Updated] T54564: Allow sitelinks to redirect pages to fix the 'Bonnie and Clyde problem'

2017-07-31 Thread Krinkle
Krinkle removed a project: MediaWiki-Redirects. TASK DETAILhttps://phabricator.wikimedia.org/T54564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Eugene, PokestarFan, ArthurPSmith, Pasleim, StudiesWorld, daniel, Metamorforme42, JEumerus

[Wikidata-bugs] [Maniphest] [Closed] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"

2017-08-22 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle added a comment. Fixed. The hit rate dropped to 0 for this warning in Logstash as of August 17. (Presumably due to all wikis to 1.30.0-wmf.14)TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Unblock] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis

2017-08-22 Thread Krinkle
Krinkle closed subtask T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope" as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpr

[Wikidata-bugs] [Maniphest] [Updated] T154596: SpecialModifyEntity master queries on page views

2017-05-03 Thread Krinkle
Krinkle edited projects, added Availability (Multiple-active-datacenters); removed Multiple-active-datacenters. TASK DETAILhttps://phabricator.wikimedia.org/T154596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, KrinkleCc: Catrope, Joe, Krenair

[Wikidata-bugs] [Maniphest] [Updated] T154596: SpecialModifyEntity master queries on page views

2017-05-03 Thread Krinkle
Krinkle edited projects, added Multiple-active-datacenters; removed Wikimedia-Multiple-active-datacenters, Availability. TASK DETAILhttps://phabricator.wikimedia.org/T154596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, KrinkleCc: Catrope, Joe

[Wikidata-bugs] [Maniphest] [Retitled] T117272: Wikidata: Possibility to add comments with more than 255 bytes, potential db issue

2017-05-03 Thread Krinkle
Krinkle changed the title from "Wikidata: Possibilty to add comments with more than 255 bytes, potenzial db issue" to "Wikidata: Possibility to add comments with more than 255 bytes, potential db issue".Krinkle edited projects, added DBA; removed MediaWiki-Databa

[Wikidata-bugs] [Maniphest] [Commented On] T162594: Introduce MessageLocalizer interface to remove the need to depend on IContextSource for creating Message objects

2017-06-12 Thread Krinkle
Krinkle added a comment. To avoid reliance on global state, and dragging in the kitchen sink that is IContextSource, a narrow interface called MessageLocalizer should be introduced [..] Calling code that only needs the msg() method can then start using MessageLocalizer instead of IContextSource

[Wikidata-bugs] [Maniphest] [Updated] T140879: 503 error raises again while trying to load a Wikidata page

2017-06-22 Thread Krinkle
Krinkle edited projects, added Wikidata; removed MediaWiki-General-or-Unknown. TASK DETAILhttps://phabricator.wikimedia.org/T140879EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: jcrespo, Aklapper, abian, Zppix, GoranSMilovanovic, Th3d3v1ls, Hfbn0

[Wikidata-bugs] [Maniphest] [Created] T168696: Add test for Wikibase parser tag hooks

2017-06-22 Thread Krinkle
Krinkle created this task.Krinkle added projects: Wikimedia-Incident, Wikidata, MediaWiki-extensions-WikibaseClient.Herald added a subscriber: Aklapper. TASK DESCRIPTIONFollows-up on: T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/inclu

[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage

2017-05-23 Thread Krinkle
Krinkle added a comment. In T126361#3287295, @Jdlrobson wrote: Im somewhat hopeful T130632 will fix this. In T126361#3287353, @gerritbot wrote: Change 355274 had a related patch set uploaded (by Krinkle; owner: Krinkle): [mediawiki/extensions/WikidataPageBanner@master] Use ParserOutput

[Wikidata-bugs] [Maniphest] [Closed] T114577: [Task] Move PopulateInterwiki into MediaWiki (core)

2017-05-25 Thread Krinkle
Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review.Krinkle closed this task as "Resolved".Krinkle assigned this task to aude. TASK DETAILhttps://phabricator.wikimedia.org/T1

[Wikidata-bugs] [Maniphest] [Commented On] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

2017-05-25 Thread Krinkle
Krinkle added a comment. In T124418#3276610, @BBlack wrote: Not resolved, as the purge graphs can attest! Which graphs? This issue is about a "massive increase" observed between December 2015 and January 2016, however our graphs don't go back far enough. It seems data prior to Jun

[Wikidata-bugs] [Maniphest] [Updated] T155043: "Don't initialize MWServices super early" causes test failure on .7

2017-05-25 Thread Krinkle
Krinkle removed a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)). TASK DETAILhttps://phabricator.wikimedia.org/T155043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Reedy, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T126077: html continues to say "Editing..." after I saved an edit using VisualEditor (and interwiki links are gone)

2017-05-25 Thread Krinkle
Krinkle removed a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)). TASK DETAILhttps://phabricator.wikimedia.org/T126077EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Mrjohncummings, APerson, jeblad, Dvorapa, Izno, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Updated] T160140: Wikidata accepts invalid geo coordinates, causing indexing failures

2017-05-25 Thread Krinkle
Krinkle edited projects, added MW-1.29-release-notes; removed MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc

[Wikidata-bugs] [Maniphest] [Commented On] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

2017-05-30 Thread Krinkle
Krinkle added a comment. In T124418#3302573, @BBlack wrote: In T124418#1985526, @BBlack wrote: Continuing with some stuff I was saying in IRC the other day. At the "new normal", we're seeing something in the approximate ballpark of 400/s articles purged (which is then multiplie

[Wikidata-bugs] [Maniphest] [Updated] T147798: Wikibase repo UI is sometimes not properly starting up (on Firefox)

2017-06-07 Thread Krinkle
Krinkle removed a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T147798EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Gilles, ori, Aklapper, Krinkle, aude, thiemowmde, Jonas, Lydia_Pintscher, Tobi_WMDE_SW, hoo

[Wikidata-bugs] [Maniphest] [Retitled] T167360: "Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter

2017-06-07 Thread Krinkle
Krinkle renamed this task from "Warning: in_array() expects parameter 2 to be an array or collection" to ""Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter". TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Created] T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php)

2017-06-06 Thread Krinkle
Krinkle created this task.Krinkle added projects: Wikidata, Wikimedia-log-errors.Herald added subscribers: Jay8g, TerraCodes. TASK DESCRIPTIONhttps://test2.wikipedia.org/wiki/Main_Page? [WTc6bApAEKkAADjb1VEF] /wiki/Main_Page MWException from line 3382 of /srv/mediawiki/php-1.30.0-wmf.4

[Wikidata-bugs] [Maniphest] [Edited] T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php)

2017-06-06 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION<https://test2.wikipedia.org/wiki/Main_Page?> ```...TASK DETAILhttps://phabricator.wikimedia.org/T167238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Terr

[Wikidata-bugs] [Maniphest] [Commented On] T162594: Introduce MessageLocalizer interface to remove the need to depend on IContextSource for creating Message objects

2017-06-14 Thread Krinkle
Krinkle added a comment. In T162594#3347436, @daniel wrote: In T162594#3341141, @Krinkle wrote: I doubt anyone would extend ContextSource for a class just to get a msg() method. That seems rather unnecessary. I would not consider that acceptable for code in MediaWiki core. Well, using

[Wikidata-bugs] [Maniphest] [Commented On] T126361: When editing via VisualEditor Wrong style of Table of Contents displays when saving a page at Wikivoyage

2017-05-25 Thread Krinkle
Krinkle added a comment. The fix for this was the same as for mediawiki.toc loading in MobileFrontend and depends on a 5-patch stack in MediaWiki core - which was merged after the branch cut this week, so it'll roll out next week. Can you reproduce it in beta?TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Edited] T169023: Wikibase ontology url: wikiba.se or wikidata.org?

2017-06-27 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Looking further it seems that most references to this concept in XML files actually use http://wikiba.se/ontology not wikidata.org, although there are a few references to http://www.wikidata.org/ontology on the web

[Wikidata-bugs] [Maniphest] [Updated] T169023: Wikibase ontology url: wikiba.se or wikidata.org?

2017-06-27 Thread Krinkle
Krinkle edited projects, added Wikibase-DataModel; removed Wikibase-Internal-Serialization. TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0

[Wikidata-bugs] [Maniphest] [Edited] T169023: Wikibase ontology url: wikiba.se or wikidata.org?

2017-06-27 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* {T166299} * {T112127}TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Updated] T169023: Wikibase ontology url: wikiba.se or wikidata.org?

2017-06-27 Thread Krinkle
Krinkle added a comment. Based on T93207: Decide which domain to use for the wikibase ontology URI, I've changed this task to instead be a clean up task to remove the broken wikidata.org alias. It already doesn't work.TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

2017-09-14 Thread Krinkle
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017). TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Gilles, GWicke, ArielGlenn, Krinkle, Peter

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-09-14 Thread Krinkle
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017). TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe

[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Krinkle
Krinkle added a comment. When editing a page in VisualEditor, I sometimes notice that the description (from Wikidata's pageterms API) is duplicated. I results in the following rendering: F9586347: Screen Shot 2017-09-16 at 20.51.29.png The joining by a single comma also looks odd

[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Krinkle
Krinkle added a comment. In T163551#3612317, @Lydia_Pintscher wrote: That's definitely not how it should be. There should only ever be one description for a given item and language. Is this also caused by the duplicate rows? I'm not sure. I was gonna file a new task, but found this existing

[Wikidata-bugs] [Maniphest] [Commented On] T174922: Decide what to do with Wikibase JS-only libraries regarding the build/deployment of Wikidata code

2017-09-19 Thread Krinkle
Krinkle added a comment. In T174922#3583384, @WMDE-leszek wrote: One concern with the Option 5 I could imagine is that the separation between those libs and the "core" Wikibase is drawn less strict than e.g. when those libs are only pulled in when "building" Wikibase &

[Wikidata-bugs] [Maniphest] [Updated] T176312: Don’t check format constraint via SPARQL

2017-09-20 Thread Krinkle
Krinkle added a project: TechCom-RfC. TASK DETAILhttps://phabricator.wikimedia.org/T176312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lucas_Werkmeister_WMDE, Krinkle, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-04 Thread Krinkle
Krinkle added a comment. The above flame graph is from HHVM profiling samples over 24 hours from production traffic. While useful to see the overall impact on average, it does not provide timings (due to being sampled). Here two profiles from XHGui for an individual request (including flamegraph

[Wikidata-bugs] [Maniphest] [Commented On] T177414: Maintenance scripts exit with 0 when an (uncaught) exception is encountered

2017-10-06 Thread Krinkle
Krinkle added a comment. This explains why postgres was seemingly passing on Travis CI when in fact it was broken (again). BeforeAfter https://travis-ci.org/wikimedia/mediawiki/jobs/283426437https://travis-ci.org/wikimedia/mediawiki/jobs/283543802 F10039102: Screen Shot 2017-10-06 at 20.33.54

[Wikidata-bugs] [Maniphest] [Updated] T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes

2017-10-06 Thread Krinkle
Krinkle removed a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...**Change log statistics** || | ID | Timestamp |--|--|-- | Oldest | 373786394 | 19:45, 12 September 2016...| | Site | Position

[Wikidata-bugs] [Maniphest] [Created] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-03 Thread Krinkle
Krinkle created this task.Krinkle added projects: Performance-Team, MediaWiki-extensions-WikibaseClient, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTION/includes/WebStart.php EchoHooks::initEchoExtension (3.05%) Wikibase\Client\Hooks\EchoNotificationsHandlers

[Wikidata-bugs] [Maniphest] [Edited] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-10 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/383363...TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot

[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-05 Thread Krinkle
Krinkle added a comment. @aude A week is fine. This isn't a regression from current week's branch.TASK DETAILhttps://phabricator.wikimedia.org/T177311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, KrinkleCc: Lydia_Pintscher, gerritbot, hoo, aude

[Wikidata-bugs] [Maniphest] [Triaged] T173710: Job queue is increasing non-stop

2017-08-30 Thread Krinkle
Krinkle triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Danie

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-08-30 Thread Krinkle
Krinkle removed projects: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review.Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThis doesn't sound good: | August 21 |-- | {F9141847 height=150} Current: Mitigation: * 6898d06f8f Disable

[Wikidata-bugs] [Maniphest] [Edited] T173710: Job queue is increasing non-stop

2017-08-30 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Current: ### Mitigation: * 6898d06f8f Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob. @aaron, https://gerrit.wikimedia.org/r/373705... **→** Fixing this significantly decreased job queue growth

[Wikidata-bugs] [Maniphest] [Commented On] T174422: Make dbBatchSize in WikiPageUpdater configurable

2017-08-30 Thread Krinkle
Krinkle added a comment. @Ladsgroup @aaron Would $wgUpdateRowsPerQuery be appropiate here, too? Or is it important for this particular query to use a different batch size?TASK DETAILhttps://phabricator.wikimedia.org/T174422EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T173696: Cache constraint check results

2017-09-06 Thread Krinkle
Krinkle added a comment. In T173696#3569491, @Ladsgroup wrote: Pinging @aaron and @Krinkle as they are the experts on this. I left a few minor points at https://gerrit.wikimedia.org/r/373918. I don't know much about the use of regular expressions in the particular context of Sparql

[Wikidata-bugs] [Maniphest] [Updated] T173696: Cache constraint check results

2017-09-06 Thread Krinkle
Krinkle added a comment. In T173696#3584607, @Krinkle wrote: [..] why do we need to query an external service to execute a regular _expression_? In T173696#3584821, @Lucas_Werkmeister_WMDE wrote: Because checking arbitrary regexes on arbitrary input opens us up to DoS attacks via malicious

[Wikidata-bugs] [Maniphest] [Commented On] T173710: Job queue is increasing non-stop

2017-09-06 Thread Krinkle
Krinkle added a comment. In T173710#3583445, @Joe wrote: As a side comment: this is one of the cases where I would've loved to have an elastic environment to run MediaWiki-related applications: I could've spun up 10 instances of jobrunner dedicated to refreshlinks (or, ideally, the system could

[Wikidata-bugs] [Maniphest] [Commented On] T175109: beta: Wikidata dispatchChanges.php causes a lot of "Wikimedia\Rdbms\DatabaseMysqlBase::unlock failed to release lock"

2017-09-27 Thread Krinkle
Krinkle added a comment. Still happening. 750,000+ log entries in the last 30 days on Beta Cluster. Most are like: mediawiki WARNING wikidatawiki deployment-tin Wikimedia\Rdbms\DatabaseMysqlBase::unlock failed to release lock '' or mediawiki WARNING wikidatawiki deployment-tin Wikimedia\Rdbms

[Wikidata-bugs] [Maniphest] [Unblock] T145535: language code disparity (Wikidata tracking)

2017-08-23 Thread Krinkle
Krinkle closed subtask T21986: Wikis waiting to be renamed (tracking) as "Resolved".Herald added a subscriber: Danmichaelo. TASK DETAILhttps://phabricator.wikimedia.org/T145535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Danmichaelo, P

[Wikidata-bugs] [Maniphest] [Closed] T18976: Wikis waiting for creation (tracking)

2017-08-23 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle added a comment. Per T102509, closed in favour of #Wiki-Setup (Create).TASK DETAILhttps://phabricator.wikimedia.org/T18976EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, P

[Wikidata-bugs] [Maniphest] [Updated] T102026: Create Wikipedia Northern Luri

2017-08-23 Thread Krinkle
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T102026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Krenair, KrinkleCc: Matanya, greg, Nikerabbit, Glaisher, Dzahn, Ebe123

[Wikidata-bugs] [Maniphest] [Updated] T54034: Create Wikivoyage Vietnamese

2017-08-23 Thread Krinkle
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T54034EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Reedy, KrinkleCc: Wikidata-bugs, Abraham, SPQRobin, mxn, Petrb, Snowolf

[Wikidata-bugs] [Maniphest] [Updated] T18976: Wikis waiting for creation (tracking)

2017-08-23 Thread Krinkle
Krinkle removed subtasks: T173643: Create Wiktionary Fiji Hindi, T173471: Re-open Wikibooks Bashkir, T173013: Create Wikivoyage Hindi, T168782: Create fishbowl wiki for Maithili Wikimedians User Group, T168765: Create Wikiversity Hindi, T168764: Reopen Wikinews Dutch, T168518: Create Dinka

[Wikidata-bugs] [Maniphest] [Updated] T73382: Create Wikivoyage Persian

2017-08-23 Thread Krinkle
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T73382EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Glaisher, KrinkleCc: Wikidata-bugs, Ebe123, Petrb, Steinsplitter, revi

[Wikidata-bugs] [Maniphest] [Updated] T134017: Create Wikipedia Jamaican

2017-08-23 Thread Krinkle
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T134017EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Krenair, KrinkleCc: Jdforrester-WMF, RobH, Lydia_Pintscher, StevenJ81, hoo

[Wikidata-bugs] [Maniphest] [Updated] T168765: Create Wikiversity Hindi

2017-08-23 Thread Krinkle
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T168765EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Reedy, KrinkleCc: Anooprao, Stashbot, Reedy, Trizek-WMF, YmKavishwar

[Wikidata-bugs] [Maniphest] [Updated] T160868: Create Wikipedia Kabiye

2017-08-23 Thread Krinkle
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T160868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dereckson, KrinkleCc: Urbanecm, PokestarFan, aude, Dcljr, QZanden, hoo

[Wikidata-bugs] [Maniphest] [Commented On] T174922: Decide what to do with Wikibase JS-only libraries regarding the build/deployment of Wikidata code

2017-09-04 Thread Krinkle
Krinkle added a comment. Move all those libraries to Wikibase git repository pro: dependency problem goes away con: code provided by those libs is no longer versioned as now - all only work with current Wikibase master con: even more code in Wikibase.git con: no way for those libs to by used

[Wikidata-bugs] [Maniphest] [Updated] T174422: Make dbBatchSize in WikiPageUpdater configurable

2017-09-04 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T174422EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Aklapper, fgiunchedi, aaron, Krinkle, Jdforrester-WMF, WMDE-leszek, jcrespo, EBernhardson

[Wikidata-bugs] [Maniphest] [Edited] T173710: Job queue is increasing non-stop

2017-08-30 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... **→** Fixing this significantly decreased job queue growth. | Dashboard: Job Queue Helath |-- | {F9232210 height=150} {F9232209 height=200} | Job queue size down from 10M to a steady ~2M. Before the regression

[Wikidata-bugs] [Maniphest] [Commented On] T173710: Job queue is increasing non-stop

2017-08-30 Thread Krinkle
Krinkle added a comment. Added a mitigation section to the task description. Also a summary of the impact of the mitigations so far (based on input from @aaron). Dashboard: Job Queue Helath F9232210: Screen Shot 2017-08-31 at 00.00.31.png F9232209: Screen Shot 2017-08-31 at 00.00.18.png Job

[Wikidata-bugs] [Maniphest] [Edited] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-09 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/383117TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot

[Wikidata-bugs] [Maniphest] [Edited] T177087: Make Wikibase-related JS libraries npm packages and include them as git submodules in Wikibase.git instead of installing as PHP libs using Composer

2017-10-09 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION//This task executes the decision made at {T174922}// Libraries to consider:...TASK DETAILhttps://phabricator.wikimedia.org/T177087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Edited] T173225: [Task] Tag releases of smaller Wikibase libraries significantly lagging behind

2017-10-09 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[] https://github.com/wmde/WikibaseSerializationJavaScript/pull/43 See also: * {T172916} * {T174922} * {T173818} * {T177087}TASK DETAILhttps://phabricator.wikimedia.org/T173225EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T173850: Possible WMF deployed extension PHP 7 issues

2017-10-09 Thread Krinkle
Krinkle removed a project: HHVM. TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Updated] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-09 Thread Krinkle
Krinkle removed projects: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Commented On] T177485: lost cursor focus in fields when adding property items

2017-10-05 Thread Krinkle
Krinkle added a comment. In T177485#3661914, @Sjoerddebruin wrote: Can this be some side-effect of T124742? The _javascript_ console is full of deprecated notices (pointing to the statement view as well). There were no official breaking changes in jQuery 3 that aren't covered by jQuery Migrate

[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-05 Thread Krinkle
Krinkle added a comment. In T177311#3659950, @gerritbot wrote: Change 382383 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Split Echo hook handlers based on services needed https://gerrit.wikimedia.org/r/382383 @aude Thanks for the quick patch! public static function

[Wikidata-bugs] [Maniphest] [Declined] T105638: RFC: Streamlining Composer usage

2017-10-11 Thread Krinkle
Krinkle closed this task as "Declined".Krinkle triaged this task as "Normal" priority.Krinkle added a comment. In T105638#3670708, @Addshore wrote: Personally I think out composer usage is rather streamlined right now Indeed. Our conventions around how Composer should

[Wikidata-bugs] [Maniphest] [Commented On] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-11 Thread Krinkle
Krinkle added a comment. @thiemowmde The tests still fail with QUnit 2 at https://gerrit.wikimedia.org/r/#/c/367838/13. Failures come from data-values/value-view. In T177764#3674594, @gerritbot wrote: Change 383383 merged by jenkins-bot: [data-values/value-view@master] Remove QUnit.Parameterize

[Wikidata-bugs] [Maniphest] [Edited] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes

2017-10-23 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...We could reduce the number of HTMLCacheUpdateJobs posted by collecting pages to be notified over an entire batch of changes, such as the batch contained in a ChangeNotificationJob. This should be done in a way

[Wikidata-bugs] [Maniphest] [Edited] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes

2017-10-23 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONCurrently, we optimize for the case of a change triggering updates to many pages: we chop the set of pages into badgesbatches and push one HTMLCacheUpdateJob for each batchTASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Updated] T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes

2017-11-14 Thread Krinkle
Krinkle added a parent task: T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7). TASK DETAILhttps://phabricator.wikimedia.org/T145819EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thcipriani, Anomie, aaron

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-12-14 Thread Krinkle
Krinkle added a subscriber: Jeff_G.Krinkle merged a task: T178840: Commons category updates are very slow. Commons job queue very large.. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jeff_G

[Wikidata-bugs] [Maniphest] [Updated] T183101: Items missing from Wikidata index

2017-12-18 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T183101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aaron, Aklapper, EBernhardson, dcausse, Smalyshev, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Updated] T178997: AddUsagesForPageJob doesn't really report execution status

2017-11-17 Thread Krinkle
Krinkle edited projects, added EventBus; removed MediaWiki-JobQueue.Herald added a project: Analytics. TASK DETAILhttps://phabricator.wikimedia.org/T178997EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, KrinkleCc: thiemowmde, gerritbot, daniel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T180727: WikibaseClient resources are broken in WMF

2017-11-16 Thread Krinkle
Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T180727WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-11-08 Thread Krinkle
Krinkle added a commit: rMW8f829de5f040: Add action/user tracking to link refresh jobs. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt

[Wikidata-bugs] [Maniphest] [Edited] T173710: Job queue is increasing non-stop

2017-11-08 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/386636...TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-11-08 Thread Krinkle
Krinkle added a commit: rEWBA081c1cd78f9d: Add cause action/agent tracking to link refresh jobs. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88, Jack_who_built_the_house

[Wikidata-bugs] [Maniphest] [Changed Project Column] T89733: Allow ContentHandler to expose structured data to the search engine.

2017-11-03 Thread Krinkle
Krinkle moved this task from Backlog to Implemented on the TechCom-RfC (ArchCom-Approved) board.Krinkle removed projects: MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)), MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), Patch

[Wikidata-bugs] [Maniphest] [Updated] T592: RfC: ChangesList formatting

2017-11-03 Thread Krinkle
Krinkle added projects: Wikidata, Edit-Review-Improvements-RC-Page.Herald added a project: Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T592EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, aude, daniel, Qgil

[Wikidata-bugs] [Maniphest] [Updated] T182322: ChronologyProtector breaks if two requests write different sets of databases

2017-12-11 Thread Krinkle
Krinkle edited projects, added MediaWiki-Database; removed MediaWiki-General-or-Unknown, Performance, Performance-Team-notice, Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T182322EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore

[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q

2018-05-18 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION* **When**: Friday 18 May, 16:00 - 17:00 * **Where**: Sala de projectes (QC/0011) What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How

[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q

2018-05-18 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* **Where**: Sala de projectes (QC/0011) * Next session: {T194275} What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How can you

[Wikidata-bugs] [Maniphest] [Commented On] T189538: Reduce complexity of Wikibase JS module registration

2018-06-08 Thread Krinkle
Krinkle added a comment. The remaining work here is to apply "Reduce indirection in resources files" to the rest of Wikibase. The above commit (https://gerrit.wikimedia.org/r/419334) was merely an example for one of the modules (view/wikibase-data-model).TASK D

[Wikidata-bugs] [Maniphest] [Updated] T189538: Reduce complexity of Wikibase JS module registration

2018-06-08 Thread Krinkle
Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review.Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* [x] / {e9b71a058b24} * [ * [x

[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase

2018-06-15 Thread Krinkle
Krinkle added subscribers: gerritbot, Krinkle.Krinkle added a comment. In T123218#3916627, @gerritbot wrote: [mediawiki/extensions/Wikibase@master] Remove some of IE8 hacks (wikibase/templates.js) https://gerrit.wikimedia.org/r/392663 TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches

2018-06-14 Thread Krinkle
Krinkle removed a project: Wikimedia-log-errors (Shared Build Failure). TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jdforrester-WMF, TerraCodes, Liuxinyu970226, Stashbot, Legoktm

[Wikidata-bugs] [Maniphest] [Commented On] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-15 Thread Krinkle
Krinkle added a comment. @Jdlrobson It does indeed appear to be a bug somewhere relating to cache pollution, in particular it seems a cache key somewhere is being shared between mobile and desktop that shouldn't be. I can reproduce the following in Incognito mode (with disabled cache): (Desktop

[Wikidata-bugs] [Maniphest] [Updated] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?

2018-06-15 Thread Krinkle
Krinkle removed a project: Performance. TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E

[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches

2018-05-29 Thread Krinkle
Krinkle added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Liuxinyu970226, Stashbot, Legoktm, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'

2018-05-29 Thread Krinkle
Krinkle added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T195868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Stashbot, thcipriani, Legoktm, Liuxinyu970226, TerraCodes, Krinkle, Jdforrester-WMF, Aleksey_WMDE, daniel

[Wikidata-bugs] [Maniphest] [Closed] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)

2018-05-29 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch

[Wikidata-bugs] [Maniphest] [Updated] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson, KrinkleCc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75

[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-06 Thread Krinkle
Krinkle added a comment. @Jdlrobson Yes, there is some form of sandboxing at the level of module loading. Which means that if you define module "a" and "b" as a.js and b.js, and load them separately but in the same request with "a" before "b", the

<    1   2   3   4   5   6   7   8   9   10   >