[Wikidata-bugs] [Maniphest] [Updated] T215616: Improve interlingual links across wikis through Wikidata IDs

2019-06-27 Thread Krinkle
Krinkle added a project: MediaWiki-General-or-Unknown. Krinkle added a comment. (Does this appear to be an issue with the wikimedia-rdbms PHP library, and not a bug or specific feature request for the MediaWiki core schema.) TASK DETAIL https://phabricator.wikimedia.org/T215616 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T215616: Improve interlingual links across wikis through Wikidata IDs

2019-06-27 Thread Krinkle
Krinkle removed a project: MediaWiki-Database. TASK DETAIL https://phabricator.wikimedia.org/T215616 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: mforns, Marostegui, Isaac, Tbayer, jcrespo, EBernhardson, Halfak, Nuria, JAllemandou

[Wikidata-bugs] [Maniphest] [Updated] T227815: Message wikibase-sitelinks-wikipedia missing from wikidata.org

2019-07-11 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed MediaWiki-ResourceLoader, Performance-Team. Krinkle added a comment. The messages don't work via the normal MediaWiki interface urls, such as https://www.wikidata.org/wiki/MediaWiki:Wikibase-sitelinks-wikipedia and https

[Wikidata-bugs] [Maniphest] [Updated] T227815: Message wikibase-sitelinks-wikipedia missing from wikidata.org

2019-07-11 Thread Krinkle
Krinkle removed a parent task: T220738: 1.34.0-wmf.13 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T227815 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Mormegil, Jdforrester-WMF, Aklapper, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T227814: [Regression wmf.13] Wikidata localisation is broken

2019-07-11 Thread Krinkle
Krinkle added a parent task: T220738: 1.34.0-wmf.13 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T227814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: thcipriani, Krinkle, Jdforrester-WMF, Aklapper, Mormegil

[Wikidata-bugs] [Maniphest] [Updated] T227815: Message wikibase-sitelinks-wikipedia missing from wikidata.org

2019-07-11 Thread Krinkle
Krinkle added a parent task: T220738: 1.34.0-wmf.13 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T227815 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Mormegil, Jdforrester-WMF, Aklapper, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Commented On] T183993: Investigate & Fix "According to a SiteLinkLookup Q47013093 is linked to frwiki while it is not or it does not exist" in logs

2019-07-11 Thread Krinkle
Krinkle added a comment. In T183993#4001382 <https://phabricator.wikimedia.org/T183993#4001382>, @daniel wrote: > This can happen every now and then due to replag. We should not worry unless this happens a LOT. If this isn't a problem with the code that needs an obvious/

[Wikidata-bugs] [Maniphest] [Reopened] T183993: Investigate & Fix "According to a SiteLinkLookup Q47013093 is linked to frwiki while it is not or it does not exist" in logs

2019-07-11 Thread Krinkle
Krinkle reopened this task as "Open". Krinkle added a comment. Seen again in prod today: - Request ID: `XSeYmwpAAD0AAFX9ZwwAAADG` - Request URL: GET en.wikipedia.org `/wiki/ (some page title)` name=message PHP Warning: According to a SiteLinkLookup Q--- is linked

[Wikidata-bugs] [Maniphest] [Updated] T227699: Creating a Commons gallery page incorrectly states "This entity does not exist."

2019-07-10 Thread Krinkle
Krinkle added projects: Multimedia, StructuredDataOnCommons, MediaWiki-extensions-WikibaseRepository. Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T227699 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T189333: Changing Kibana filters is ridiculously slow

2019-07-02 Thread Krinkle
Krinkle added a subscriber: ema. Krinkle added a comment. per @ema, the `request-{}` and `response-{}` lines is due to T224994 <https://phabricator.wikimedia.org/T224994>, which was recently enabled. TASK DETAIL https://phabricator.wikimedia.org/T189333 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Retitled] T224030: Fatal when saving "Undo" edit on merged Wikidata item

2019-07-01 Thread Krinkle
Krinkle renamed this task from "Exception in Production when trying to undo a change on a merged item" to "Fatal when saving "Undo" edit on merged Wikidata item". TASK DETAIL https://phabricator.wikimedia.org/T224030 EMAIL PREFERENCES https://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T224030: Fatal when saving "Undo" edit on merged Wikidata item

2019-07-01 Thread Krinkle
Krinkle added a comment. Still seen on 1.34-wmf.11: - Request URL: `/w/index.php?title= Q… =edit= … = … ` - Request ID: `XReOdQpAAEIAAEDJ-ZkF` name=message Diff\Patcher\PatcherException: EntityContent must not contain Entity data as well as a redirect after applying

[Wikidata-bugs] [Maniphest] [Commented On] T216956: deploy WikibaseSchema to test

2019-04-23 Thread Krinkle
Krinkle added a comment. I don't know where to leave this feedback, but I'll place it here for now: - This extension registers a generically called namespace named "Schema", this overlaps with at least one other extension already (EventLogging). I recommend choosing a more spe

[Wikidata-bugs] [Maniphest] [Commented On] T219584: Flaky wdio test "RecentChanges shows lemmas in title links"

2019-04-10 Thread Krinkle
Krinkle added a comment. Please disable the test and figure it out later :) TASK DETAIL https://phabricator.wikimedia.org/T219584 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jakob_WMDE, Aklapper, TerraCodes, hashar, Nikerabbit

[Wikidata-bugs] [Maniphest] [Updated] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-08-02 Thread Krinkle
Krinkle added a project: Performance-Team-publish. TASK DETAIL https://phabricator.wikimedia.org/T203696 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: WMDE-leszek, alaa_wmde, Jakob_WMDE, Ladsgroup, gerritbot, Addshore

[Wikidata-bugs] [Maniphest] [Commented On] T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers

2019-08-02 Thread Krinkle
Krinkle added a comment. From Grafana: WebPageReplay dashboard <https://grafana.wikimedia.org/d/00572/webpagereplay-drilldown?orgId=1=156449880=156475080=enwiki=desktop=chrome=100=Sweden> F29939577: capture.png <https://phabricator.wikimedia.org/F29939577>

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-08-26 Thread Krinkle
Krinkle added a subscriber: Ladsgroup. Krinkle added a comment. I vaguely recall you doing some work on this, but I'm not sure if it was this class or something else with a similar name. Can you check if this has been improved since? TASK DETAIL https://phabricator.wikimedia.org/T229153

[Wikidata-bugs] [Maniphest] [Retitled] T231198: Wikibase and WikibaseLexeme tests now take more than 1 hour

2019-08-26 Thread Krinkle
Krinkle renamed this task from "Wikibase and WikibaseLexeme tests now take more than 1 hour in php7.2" to "Wikibase and WikibaseLexeme tests now take more than 1 hour". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231198 EMAIL

[Wikidata-bugs] [Maniphest] [Triaged] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-03 Thread Krinkle
Krinkle triaged this task as "Unbreak Now!" priority. Krinkle added a comment. Restricted Application added a subscriber: Liuxinyu970226. Users are consistently unable to view this file description page on Commons: https://commons.wikimedia.org/wiki/File:Rockstar_San_Diego_Lo

[Wikidata-bugs] [Maniphest] [Updated] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-03 Thread Krinkle
Krinkle merged a task: T231795: RevisionBasedEntityLookup.php: Call to a member function getTargetId() on a non-object (null). Krinkle added a subscriber: Pablo-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Merged] T231795: RevisionBasedEntityLookup.php: Call to a member function getTargetId() on a non-object (null)

2019-09-03 Thread Krinkle
Krinkle closed this task as a duplicate of T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null). TASK DETAIL https://phabricator.wikimedia.org/T231795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Merged] T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle closed this task as a duplicate of T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle removed a parent task: T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle removed a subtask: T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle

[Wikidata-bugs] [Maniphest] [Updated] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Krinkle
Krinkle merged a task: T231456: RevisionBasedEntityLookup.php: Revision 363605807 belongs to M77688146 instead of expected M81625979. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Reassigned] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-09-02 Thread Krinkle
Krinkle reassigned this task from Addshore to Ladsgroup. Krinkle added a subscriber: Addshore. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Reassigned] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-08-28 Thread Krinkle
Krinkle reassigned this task from Krinkle to Addshore. Krinkle removed a project: Performance. Restricted Application added a project: User-Addshore. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-08-28 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_Pintscher, Ladsgroup, Krinkle, Aklappe

[Wikidata-bugs] [Maniphest] [Updated] T226976: Convert linkitem module to use OOUI, instead of jQuery UI

2019-08-28 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T226976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: stjn, Pablo-WMDE, WMDE-leszek, Lydia_Pintscher, Aklapper, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Updated] T231089: WikibaseClient.php: PHP Notice: Undefined index:

2019-09-05 Thread Krinkle
Krinkle added a comment. Smells like T229433 <https://phabricator.wikimedia.org/T229433>. Which is also about `''` array index, and PHP 7.2. It's obviously a bug in PHP 7.2, but I've not been able to find evidence that it is due to opcache/T224491 <https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Updated] T225195: EventBus jobs failing heavily because of CentralNotice and WikibaseRepo

2019-09-07 Thread Krinkle
Krinkle removed a project: MediaWiki-extensions-CentralAuth. TASK DETAIL https://phabricator.wikimedia.org/T225195 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, Umherirrender, Legoktm, Ottomata, AndyRussG, awight

[Wikidata-bugs] [Maniphest] [Commented On] T213426: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle

2019-09-09 Thread Krinkle
Krinkle added a comment. I've often found it a sign of technical debt and think it's worth taking this one slow (could even undo the deprecation warning for now). From a quick scan it looks like nothing should need it on regular page views before interaction, in which case mw.util would

[Wikidata-bugs] [Maniphest] [Merged] T216877: PHP timeout when opening Special:EditWatchlist with 14k pages on the Watchlist on Wikidata

2019-09-08 Thread Krinkle
Krinkle closed this task as a duplicate of T41510: Editing large watchlists via Special:EditWatchlist fails due to a server timeout. TASK DETAIL https://phabricator.wikimedia.org/T216877 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Closed] T225098: Exception shutdown "transaction round 'Wikibase\Client\Changes\InjectRCRecordsJob::run' still running"

2019-09-12 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle added a comment. Not seen in WMF Logstash for 30 days. TASK DETAIL https://phabricator.wikimedia.org/T225098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jony, Aklappe

[Wikidata-bugs] [Maniphest] [Updated] T229221: Reduce usages of wikibase.entityPage.entityLoaded hook in frontend code

2019-07-31 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed Performance. TASK DETAIL https://phabricator.wikimedia.org/T229221 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lea_Lacroix_WMDE, Lucas_Werkmeister_WMDE, alaa_wmde

[Wikidata-bugs] [Maniphest] [Created] T229450: EntityIdSearchHelper.php: PHP Notice: Uninitialized string offset: 0

2019-07-31 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request ID: `XUHMHQpAIDMAAC-xEd0AAABA` Request URL: w

[Wikidata-bugs] [Maniphest] [Updated] T229153: Reconsider caching in Wikibase\SitesModule::getScript

2019-07-27 Thread Krinkle
Krinkle removed a project: MediaWiki-ResourceLoader. TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Catrope, Liuxinyu970226, darthmon_wmde, DannyS712, Nandana

[Wikidata-bugs] [Maniphest] [Updated] T229634: Flaky selenium tests block merging to Wikibase

2019-08-05 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T229634 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Smalyshev, darthmon_wmde, DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Updated] T229634: Flaky selenium tests block merging to Wikibase

2019-08-05 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T229634 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Smalyshev, darthmon_wmde, DannyS712, Nandana, Mringgaard

[Wikidata-bugs] [Maniphest] [Updated] T228739: Jenkins runs Scribunto tests in Wikibase patches

2019-08-05 Thread Krinkle
Krinkle edited projects, added Wikidata, Continuous-Integration-Config; removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T228739 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope

2019-08-05 Thread Krinkle
Krinkle added a comment. Higher level issue of re-trying LinksUpdate now tracked at T206283 <https://phabricator.wikimedia.org/T206283>. TASK DETAIL https://phabricator.wikimedia.org/T221577 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T229634: Flaky selenium tests block merging to Wikibase

2019-08-05 Thread Krinkle
Krinkle added a comment. Does not seem to affect other repositories, thus untagging from cross-repo tag for shared build failures. TASK DETAIL https://phabricator.wikimedia.org/T229634 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Raised Priority] T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin

2019-08-06 Thread Krinkle
Krinkle moved this task from Resolved to Untriaged on the Wikimedia-production-error (Shared Build Failure) board. Krinkle raised the priority of this task from "High" to "Unbreak Now!". Krinkle added a comment. Restricted Application added a subscriber: Liuxinyu97

[Wikidata-bugs] [Maniphest] [Updated] T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin

2019-08-06 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T227121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Liuxinyu970226, Krinkle, Michael, noarave, Pablo-WMDE, Aklapper, Jdlrobson, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Created] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2019-07-17 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request URL: api.php Request ID: `uApAICoAAJLcp3kX` name=message

[Wikidata-bugs] [Maniphest] [Updated] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2019-07-17 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T228293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Updated] T85499: wbEntity shouldn't be served on every page load

2019-07-23 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed Performance. TASK DETAIL https://phabricator.wikimedia.org/T85499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: Lea_Lacroix_WMDE, Addshore

[Wikidata-bugs] [Maniphest] [Updated] T221433: Category filled with pages which should not be there

2019-07-15 Thread Krinkle
Krinkle removed a project: MediaWiki-Cache. TASK DETAIL https://phabricator.wikimedia.org/T221433 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jack_who_built_the_house, SerDIDG, Aklapper, darthmon_wmde, Nandana, OlegCinema, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T207926: Label freshness (cache delay)

2019-07-15 Thread Krinkle
Krinkle removed a project: MediaWiki-Cache. TASK DETAIL https://phabricator.wikimedia.org/T207926 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Liuxinyu970226, Aklapper, VladimirAlexiev, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-30 Thread Krinkle
Krinkle set Request URL to https://commons.wikimedia.org/w/index.php?title=File:Buddha_with_Naga_(snake).jpg=no. Krinkle removed a project: Structured-Data-Team-Current-Work. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-30 Thread Krinkle
Krinkle added a comment. Still reproducible at the example URL as well. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T213426: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle

2019-10-01 Thread Krinkle
Krinkle added a comment. @Jdlrobson I can elaborate N weeks from now, but T213426#5477587 <https://phabricator.wikimedia.org/T213426#5477587> might help get you on the way. TASK DETAIL https://phabricator.wikimedia.org/T213426 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Updated] T226818: Diff when updating wbc_entity_usage

2019-07-09 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T226818 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: alaa_wmde, Krinkle, Aklapper, Marostegui, Addshore, hoo, jcrespo

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

2019-07-09 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T225814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, WMDE

[Wikidata-bugs] [Maniphest] [Edited] T236150: Write an RFC describing in detail possible solutions for checking user-provided regexes in constraints

2019-11-05 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T236150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Lucas_Werkmeister_WMDE, Joe, GWicke, daniel, tstarling, Smalyshev, Anomie, Nikerabbit

[Wikidata-bugs] [Maniphest] [Updated] T236993: Sub-optimal transaction on DB(s) [10.64.48.172 (wikidatawiki) (TRX#7105a1)]: 0

2019-11-07 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. Krinkle added a comment. (not an application error) TASK DETAIL https://phabricator.wikimedia.org/T236993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, alaa_wmde

[Wikidata-bugs] [Maniphest] [Merged] T237173: InvalidArgumentException breaking Commons "undo" functionality

2019-11-07 Thread Krinkle
Krinkle closed this task as a duplicate of T236320: Internal error while undoing file captions: Unsaved revision passed. TASK DETAIL https://phabricator.wikimedia.org/T237173 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krenair

[Wikidata-bugs] [Maniphest] [Retitled] T237667: PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue)

2019-11-07 Thread Krinkle
Krinkle renamed this task from "PHP Warning: preg_match(): Unknown modifier 'p'" to "PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue)". Krinkle changed Request URL from /w/api.php?action=wbparsevalue=json=time=%1F1964=%7B%

[Wikidata-bugs] [Maniphest] [Updated] T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue

2019-11-07 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite; removed GeoData, Discovery-Search. TASK DETAIL https://phabricator.wikimedia.org/T237067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Commented On] T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue

2019-11-07 Thread Krinkle
Krinkle added a comment. Re-classifying from mediawiki-extensions-GeoData to mediawiki-extensions-WikibaseRepo. While it contains "Geo"-something, this specific error comes from the Wikibase code. TASK DETAIL https://phabricator.wikimedia.org/T237067 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Commented On] T237667: PHP Warning: preg_match(): Unknown modifier 'p'

2019-11-07 Thread Krinkle
Krinkle added a comment. Fixed to restore full paths and url (was the fix for that in Phatality not yet deployed?). TASK DETAIL https://phabricator.wikimedia.org/T237667 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle

[Wikidata-bugs] [Maniphest] [Edited] T237667: PHP Warning: preg_match(): Unknown modifier 'p'

2019-11-07 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T237667 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, mmodell, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes

2019-10-31 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T178806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, hoo, Ladsgroup, Joe, elukey, Aklapper, daniel, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Commented On] T239594: Unexpected general module "jquery.ui.core.styles" in styles queue.

2019-12-04 Thread Krinkle
Krinkle added a comment. Deployments happen once a week through the train. This is expected to roll out later this week, unless backported sooner which I proposed with the above cherry pick, but not sure it'll happen. Is this a volume risk currently? In terms of MW functionality the message

[Wikidata-bugs] [Maniphest] [Updated] T239594: Unexpected general module "jquery.ui.core.styles" in styles queue.

2019-12-03 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T239594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, jijiki, darthmon_wmde, DannyS712, Nandana, Imarlier, Lahi, Gq86, Pablo

[Wikidata-bugs] [Maniphest] [Closed] T239594: Unexpected general module "jquery.ui.core.styles" in styles queue.

2019-12-03 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error; removed Wikimedia-General-or-Unknown, MediaWiki-General, JavaScript. Krinkle claimed this task. Krinkle added a comment. In T2196

[Wikidata-bugs] [Maniphest] [Updated] T238154: Clean removed wikibase config variables from production

2019-12-15 Thread Krinkle
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process). TASK DETAIL https://phabricator.wikimedia.org/T238154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, darthmon_wmde, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Commented On] T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue [Story Points 5]

2019-12-17 Thread Krinkle
Krinkle added a comment. In case there is confusion - the error reported in this case is logged by the PHP engine, not by our code. It comes from the following statement: Source: DmsCoordinateParser.php:L184 <https://github.com/DataValues/Geo/blob/4.2.0/src/Pars

[Wikidata-bugs] [Maniphest] [Commented On] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2019-12-17 Thread Krinkle
Krinkle added a comment. Seen 3,500 times (evenly spread out throughout the month). Logstash: https://logstash.wikimedia.org/goto/f12480d76fe5fa011e52110a94927d3e. @Ladsgroup I don't know if is the same issue or not. It does have the same stack trace from DataUpdateAdapter

[Wikidata-bugs] [Maniphest] [Commented On] T229982: SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'

2019-12-17 Thread Krinkle
Krinkle added a comment. Still reproducible. Adds noise to fatal error log. TASK DETAIL https://phabricator.wikimedia.org/T229982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Triaged] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

2019-12-17 Thread Krinkle
Krinkle moved this task from Untriaged to Dec 2019 / 1.35.wmf.10+ on the Wikimedia-production-error board. Krinkle triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T240083 WORKBOARD https://phabricator.wikimedia.org/project/board/1055/ EMAIL P

[Wikidata-bugs] [Maniphest] [Retitled] T240694: "OutOfRangeException: Latitude needs to be between -360 and 360" from action=wbparsevalue API

2019-12-17 Thread Krinkle
Krinkle renamed this task from "Exception when Latitude outside -360 and 360 is given to wbparsevalue" to ""OutOfRangeException: Latitude needs to be between -360 and 360" from action=wbparsevalue API". Krinkle updated the task description. TASK DETAIL htt

[Wikidata-bugs] [Maniphest] [Updated] T384: RfC: Dependency Injection for MediaWiki core

2019-12-03 Thread Krinkle
Krinkle edited projects, added TechCom-RFC (TechCom-Approved); removed TechCom-RFC. TASK DETAIL https://phabricator.wikimedia.org/T384 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Krinkle Cc: MGChecker, Osnard, He7d3r, ArielGlenn

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS)

2019-12-07 Thread Krinkle
Krinkle added subscribers: Nikerabbit, Addshore. Krinkle added a comment. @Nikerabbit @Addshore When your respective teams are investigating this and if you need help with how the constraint works and how it is typically dealt with, you'll probably want to tag #core-platform-team <ht

[Wikidata-bugs] [Maniphest] [Created] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS)

2019-12-07 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, UniversalLanguageSelector, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION

[Wikidata-bugs] [Maniphest] [Updated] T239192: WMFTimeoutException in Wikidata recentchanges

2019-12-03 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T239192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender, DannyS712, Aklapper, darthmon_wmde, Nandana, kostajh, Jony, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Edited] T239192: WMFTimeoutException in Wikidata recentchanges

2019-12-03 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T239192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender, DannyS712, Aklapper, darthmon_wmde, Nandana, kostajh

[Wikidata-bugs] [Maniphest] [Updated] T238014: Viewing history version of double redirect results in UnresolvedEntityRedirectException

2019-12-03 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T238014 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Bugreporter, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T238014: Viewing history version of double redirect results in UnresolvedEntityRedirectException

2019-12-03 Thread Krinkle
Krinkle added a comment. Likely related to T228293: [4h invstigation] RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) <https://phabricator.wikimedia.org/T228293>. `RevisionedUnresolvedRedirectException` is a su

[Wikidata-bugs] [Maniphest] [Unblock] T106523: Issues with srcset with browsers that do not properly support it

2019-10-14 Thread Krinkle
Krinkle closed subtask T111542: Update jquery.hidpi.js to support width/height specs as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: brion, gerritbot, Jdlrobson, Sumit

[Wikidata-bugs] [Maniphest] [Changed Project Column] T231264: Lexeme tests produce errors on merge

2019-10-24 Thread Krinkle
Krinkle moved this task from Untriaged to Resolved on the Wikimedia-production-error (Shared Build Failure) board. Krinkle added a comment. Is this still an issue? TASK DETAIL https://phabricator.wikimedia.org/T231264 WORKBOARD https://phabricator.wikimedia.org/project/board/3298

[Wikidata-bugs] [Maniphest] [Updated] T231264: Lexeme tests produce errors on merge

2019-10-24 Thread Krinkle
Krinkle changed the subtype of this task from "Production Error" to "Task". TASK DETAIL https://phabricator.wikimedia.org/T231264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Smalyshev, darthmon_wmde, DannyS712,

[Wikidata-bugs] [Maniphest] [Created] T236424: "Error: Call to a member function getTargetId() on null" from WikiPageEntityRevisionLookup.php

2019-10-24 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.3

[Wikidata-bugs] [Maniphest] [Updated] T236424: "Error: Call to a member function getTargetId() on null" from WikiPageEntityRevisionLookup.php

2019-10-24 Thread Krinkle
Krinkle changed Request URL from /w/api.php to https://commons.wikimedia.org/w/api.php. TASK DETAIL https://phabricator.wikimedia.org/T236424 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Closed] T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/WikibaseRepo.p

2019-10-24 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T236372 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: hashar, WMDE-leszek, matthiasmullie, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Closed] T236370: Call to undefined method Wikibase\Lib\EntityTypeDefinitions::getPrefetchingTermLookupCallbacks()

2019-10-24 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T236370 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: WMDE-leszek, matthiasmullie, Liuxinyu970226, Aklapper, Lar

[Wikidata-bugs] [Maniphest] [Created] T235724: Remove old pcache metric compat from ParserCache.php

2019-10-16 Thread Krinkle
Krinkle created this task. Krinkle added projects: Technical-Debt, Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Follow-up from https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/486323/9/includes/parser/ParserCache.php. Transferring from

[Wikidata-bugs] [Maniphest] [Edited] T235724: Remove old pcache metric compat from ParserCache.php

2019-10-16 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T235724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: alaa_wmde, Ladsgroup, Krinkle, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T231799: LuaWikibaseEntityLibraryTest: CI failing en masse

2019-10-18 Thread Krinkle
Krinkle added a project: Wikimedia-production-error (Shared Build Failure). Krinkle added a comment. As I understand it, the problematic core commit has been reverted and Wikibase is unblocked. The commit in question (https://gerrit.wikimedia.org/r/533729), while nice, does not appear

[Wikidata-bugs] [Maniphest] [Closed] T224030: Fatal when saving "Undo" edit on merged Wikidata item

2019-10-19 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle added a comment. In WMF Logstash the last 30 days contain no exception messages for `PatcherException`. I also checked the original user scenario from the task description. While it does still fail, it now fails with a user-faci

[Wikidata-bugs] [Maniphest] [Updated] T229982: SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'

2019-10-17 Thread Krinkle
Krinkle edited projects, added Wikidata-Campsite; removed MediaWiki-REST-API. TASK DETAIL https://phabricator.wikimedia.org/T229982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, brennen, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Changed Project Column] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-16 Thread Krinkle
Krinkle moved this task from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Krinkle added a comment. 10 days have passed. TASK DETAIL https://phabricator.wikimedia.org/T229280 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL

[Wikidata-bugs] [Maniphest] [Retitled] T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted

2019-11-23 Thread Krinkle
Krinkle renamed this task from "PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master. This should never happen, except for an edge

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread Krinkle
Krinkle added a comment. @mmodell Can you restore the file paths in the future? This makes it very hard to tell which branch the error happened on, especially around deployments. Ignoring the version for hashing purposes seems fine, but the raw data sent here should be unmodified (except

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread Krinkle
Krinkle added a comment. I would prefer the stacktrace be unmodified from the original. I don't think an extra field is needed because the "error" as reported concept does not have a version. The stack trace is a sample from any of the 100s of instances there are in Logstash, i

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

2019-10-07 Thread Krinkle
Krinkle added a comment. @Ladsgroup Can you find out which version of sqlite it uses? https://packages.ubuntu.com/bionic/sqlite3 says it comes with 3.22.0, but not sure if it actually uses that plainly on Travis. @Aaron Can you check if this is using the old or new code? If using

[Wikidata-bugs] [Maniphest] [Updated] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

2019-10-07 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T234795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Anomie, Krinkle, aaron, Ladsgroup, Aklapper, WMDE-leszek, Iflorez, darthmon_wmde, alaa_wmde

[Wikidata-bugs] [Maniphest] [Updated] T228343: Huge delay for RecentChanges in test.wikidata

2019-10-07 Thread Krinkle
Krinkle removed a project: HHVM. TASK DETAIL https://phabricator.wikimedia.org/T228343 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Joe, Pchelolo, Addshore, Bugreporter, Aklapper, Smalyshev, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Created] T234847: Performance review for Wikidata Bridge

2019-10-07 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikidata-Bridge, Wikidata, Performance-Team. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION I'm not exactly sure that this is yet or what the deployment roadmap is. Creating this as placeholder task for its performance

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T234847: Performance review for Wikidata Bridge

2019-10-07 Thread Krinkle
Krinkle added a subscriber: Lydia_Pintscher. Krinkle added a comment. @Lydia_Pintscher We're pretty limited in capacity so the earlier it is scheduled, the earlier it might happen. Let us know when it is in a state that it is ready for perf review. At that time, it would also be good to have

<    3   4   5   6   7   8   9   10   11   12   >